npm-pkg-lint 5.1.10 → 5.1.11

package/dist/index.js

@@ -10950,6 +10950,20 @@ function jsonLocation(ast, pick, ...datapath) {
   }
 }
 
+// src/utils/normalize-dependency.ts
+function normalizeDependency(key, value) {
+  if (value.startsWith("npm:")) {
+    const spec = value.slice("npm:".length);
+    const [name, version2 = ""] = spec.split(/(?<=.)@/, 2);
+    return { key, name, version: version2 };
+  }
+  return {
+    key,
+    name: key,
+    version: value
+  };
+}
+
 // node_modules/nano-spawn/source/context.js
 import process3 from "node:process";
 import { stripVTControlCharacters } from "node:util";
@@ -11320,19 +11334,19 @@ function createEntry(key, version2, source) {
   if (version2.startsWith("file:")) {
     return null;
   }
-  if (version2.startsWith("npm:")) {
-    const [newKey, newVersion] = version2.slice("npm:".length).split("@", 2);
-    key = newKey;
-    version2 = newVersion;
+  const { name, version: normalizedVersion } = normalizeDependency(key, version2);
+  if (normalizedVersion === "") {
+    return null;
   }
-  if (key === "@types/node") {
+  if (name === "@types/node") {
     return null;
   }
-  const minVersion = import_semver.default.minVersion(version2);
+  const minVersion = import_semver.default.minVersion(normalizedVersion);
   return {
-    name: key,
-    version: version2,
-    spec: `${key}@${minVersion ? minVersion.version : version2}`,
+    key,
+    name,
+    version: normalizedVersion,
+    spec: `${name}@${minVersion ? minVersion.version : normalizedVersion}`,
     source
   };
 }
@@ -11369,7 +11383,7 @@ async function deprecatedDependency(pkg, pkgAst, options) {
       if (!deprecated) {
         continue;
       }
-      const { line, column } = jsonLocation(pkgAst, "member", dependency.source, dependency.name);
+      const { line, column } = jsonLocation(pkgAst, "member", dependency.source, dependency.key);
       messages.push({
         ruleId: ruleId3,
         severity: 2,
@@ -11382,7 +11396,7 @@ async function deprecatedDependency(pkg, pkgAst, options) {
         if (dependency.source === "devDependencies") {
           continue;
         }
-        const { line, column } = jsonLocation(pkgAst, "member", dependency.source, dependency.name);
+        const { line, column } = jsonLocation(pkgAst, "member", dependency.source, dependency.key);
         messages.push({
           ruleId: ruleId3,
           severity: 1,
@@ -11884,10 +11898,59 @@ function* shadowedTypes(pkg, pkgAst) {
   }
 }
 
-// src/rules/types-node-matching-engine.ts
+// src/rules/tsconfig-base-matching-engine.ts
 var import_semver3 = __toESM(require_semver2(), 1);
-var ruleId12 = "types-node-matching-engine";
+var ruleId12 = "tsconfig-base-matching-engine";
 var severity10 = Severity.ERROR;
+var matchDependency = /^@tsconfig\/node(\d+)$/;
+function* tsconfigBaseMatchingEngine(pkg, pkgAst) {
+  if (!pkg.engines?.node) {
+    return;
+  }
+  const nodeVersion = import_semver3.default.validRange(pkg.engines.node) ? import_semver3.default.minVersion(pkg.engines.node, {}) : null;
+  if (!nodeVersion) {
+    return;
+  }
+  for (const source of ["dependencies", "devDependencies", "peerDependencies"]) {
+    const dependencies = pkg[source] ?? {};
+    const tsconfig = Object.keys(dependencies).filter((it2) => matchDependency.test(it2));
+    if (tsconfig.length === 0) {
+      continue;
+    }
+    const [first, ...duplicates] = tsconfig;
+    if (duplicates.length > 0) {
+      for (const dup of duplicates) {
+        const { line, column } = jsonLocation(pkgAst, "member", source, dup);
+        yield {
+          ruleId: ruleId12,
+          severity: severity10,
+          message: `${dup} and ${first} cannot be used at the same time`,
+          line,
+          column
+        };
+      }
+      continue;
+    }
+    const match2 = matchDependency.exec(first);
+    const baseVersion = Number(match2[1]);
+    if (baseVersion !== nodeVersion.major) {
+      const { line, column } = jsonLocation(pkgAst, "member", source, first);
+      const expectedVersion = `v${String(nodeVersion.major)}`;
+      yield {
+        ruleId: ruleId12,
+        severity: severity10,
+        message: `${first} does not match engines.node ${expectedVersion}`,
+        line,
+        column
+      };
+    }
+  }
+}
+
+// src/rules/types-node-matching-engine.ts
+var import_semver4 = __toESM(require_semver2(), 1);
+var ruleId13 = "types-node-matching-engine";
+var severity11 = Severity.ERROR;
 function* typesNodeMatchingEngine(pkg, pkgAst) {
   if (!pkg.engines?.node) {
     return;
@@ -11901,8 +11964,8 @@ function* typesNodeMatchingEngine(pkg, pkgAst) {
     if (declaredVersion === "latest") {
       continue;
     }
-    const nodeVersion = import_semver3.default.minVersion(pkg.engines.node);
-    const typesVersion = import_semver3.default.minVersion(declaredVersion);
+    const nodeVersion = import_semver4.default.minVersion(pkg.engines.node);
+    const typesVersion = import_semver4.default.minVersion(declaredVersion);
     if (!nodeVersion || !typesVersion) {
       continue;
     }
@@ -11911,8 +11974,8 @@ function* typesNodeMatchingEngine(pkg, pkgAst) {
       const actualVersion = `v${String(typesVersion.major)}`;
       const expectedVersion = `v${String(nodeVersion.major)}`;
       yield {
-        ruleId: ruleId12,
-        severity: severity10,
+        ruleId: ruleId13,
+        severity: severity11,
         message: `@types/node ${actualVersion} does not equal engines.node ${expectedVersion}`,
         line,
         column
@@ -11922,8 +11985,8 @@ function* typesNodeMatchingEngine(pkg, pkgAst) {
 }
 
 // src/rules/verify-engine-constraint.ts
-var import_semver4 = __toESM(require_semver2(), 1);
-var ruleId13 = "invalid-engine-constraint";
+var import_semver5 = __toESM(require_semver2(), 1);
+var ruleId14 = "invalid-engine-constraint";
 async function* getDeepDependencies(pkg, visited, dependency) {
   if (dependency) {
     if (visited.has(dependency)) {
@@ -11937,15 +12000,16 @@ async function* getDeepDependencies(pkg, visited, dependency) {
   }
   const { dependencies = {} } = pkgData;
   for (let [key, version2] of Object.entries(dependencies)) {
-    if (version2.startsWith("npm:")) {
-      const [newKey, newVersion] = version2.slice("npm:".length).split("@", 2);
-      key = newKey;
-      version2 = newVersion;
+    const normalized = normalizeDependency(key, version2);
+    key = normalized.name;
+    version2 = normalized.version;
+    if (version2 === "") {
+      continue;
     }
     if (key === "@types/node") {
       continue;
     }
-    const minVersion = import_semver4.default.minVersion(version2);
+    const minVersion = import_semver5.default.minVersion(version2);
     const deep = `${key}@${minVersion ? minVersion.version : version2}`;
     yield deep;
     yield* getDeepDependencies(pkg, visited, deep);
@@ -11960,9 +12024,9 @@ async function verifyDependency(dependency, minDeclared, declaredConstraint) {
   if (!constraint) {
     return null;
   }
-  if (!import_semver4.default.satisfies(minDeclared, constraint)) {
+  if (!import_semver5.default.satisfies(minDeclared, constraint)) {
     return {
-      ruleId: ruleId13,
+      ruleId: ruleId14,
       severity: 2,
       message: `the transitive dependency "${dependency}" (node ${constraint}) does not satisfy the declared node engine "${declaredConstraint}"`,
       line: 1,
@@ -11976,7 +12040,7 @@ async function verifyEngineConstraint(pkg) {
   if (!declaredConstraint) {
     return [];
   }
-  const minDeclared = import_semver4.default.minVersion(declaredConstraint);
+  const minDeclared = import_semver5.default.minVersion(declaredConstraint);
   if (!minDeclared) {
     throw new Error(`Failed to parse engine constraint "${declaredConstraint}"`);
   }
@@ -11991,7 +12055,7 @@ async function verifyEngineConstraint(pkg) {
     } catch (err) {
       if (isNpmInfoError(err) && err.code === "E404") {
         messages.push({
-          ruleId: ruleId13,
+          ruleId: ruleId14,
           severity: 1,
           message: `the transitive dependency "${dependency}" is not published to the NPM registry`,
           line: 1,
@@ -12194,11 +12258,7 @@ function verifyFields(pkg, pkgAst, options) {
   return messages;
 }
 function getActualDependency(key, version2) {
-  if (version2.startsWith("npm:")) {
-    const [name] = version2.slice("npm:".length).split("@", 2);
-    return name;
-  }
-  return key;
+  return normalizeDependency(key, version2).name;
 }
 function verifyDependencies(pkg, pkgAst, options) {
   const messages = [];
@@ -12223,27 +12283,29 @@ function verifyDependencies(pkg, pkgAst, options) {
       });
     }
   }
-  function verifyObsolete(dependency, source) {
+  function verifyObsolete(key, version2, source) {
+    const { name: dependency } = normalizeDependency(key, version2);
     const obsolete2 = isObsoleteDependency(dependency);
     if (obsolete2) {
-      const { line, column } = jsonLocation(pkgAst, "member", source, dependency);
+      const { line, column } = jsonLocation(pkgAst, "member", source, key);
+      const name = key === dependency ? `"${dependency}"` : `"${key}" ("npm:${dependency}")`;
       messages.push({
         ruleId: "obsolete-dependency",
         severity: 2,
-        message: `"${dependency}" is obsolete and should no longer be used: ${obsolete2.message}`,
+        message: `${name} is obsolete and should no longer be used: ${obsolete2.message}`,
         line,
         column
       });
     }
   }
-  for (const dependency of Object.keys(dependencies)) {
-    verifyObsolete(dependency, "dependencies");
+  for (const [key, version2] of Object.entries(dependencies)) {
+    verifyObsolete(key, version2, "dependencies");
   }
-  for (const dependency of Object.keys(devDependencies)) {
-    verifyObsolete(dependency, "devDependencies");
+  for (const [key, version2] of Object.entries(devDependencies)) {
+    verifyObsolete(key, version2, "devDependencies");
   }
-  for (const dependency of Object.keys(peerDependencies)) {
-    verifyObsolete(dependency, "peerDependencies");
+  for (const [key, version2] of Object.entries(peerDependencies)) {
+    verifyObsolete(key, version2, "peerDependencies");
   }
   return messages;
 }
@@ -12263,6 +12325,7 @@ async function verifyPackageJson(pkg, pkgAst, filePath, options = { allowedDepen
     ...outdatedEngines(pkg, pkgAst, ignoreNodeVersion),
     ...preferTypes(pkg, pkgAst),
     ...shadowedTypes(pkg, pkgAst),
+    ...tsconfigBaseMatchingEngine(pkg, pkgAst),
     ...typesNodeMatchingEngine(pkg, pkgAst)
   ];
   if (messages.length === 0) {