npm-packlist 1.4.4 → 1.4.8

package/index.js

@@ -17,6 +17,8 @@ const rootBuiltinRules = Symbol('root-builtin-rules')
 const packageNecessaryRules = Symbol('package-necessary-rules')
 const path = require('path')
 
+const normalizePackageBin = require('npm-normalize-package-bin')
+
 const defaultRules = [
   '.npmignore',
   '.gitignore',
@@ -51,6 +53,9 @@ const defaultRules = [
   'core.+([0-9])',
 ]
 
+// There may be others, but :?|<> are handled by node-tar
+const nameIsBadForWindows = file => /\*/.test(file)
+
 // a decorator that applies our custom rules to an ignore walker
 const npmWalker = Class => class Walker extends Class {
   constructor (opt) {
@@ -170,14 +175,14 @@ const npmWalker = Class => class Walker extends Class {
       pkg.browser ? '!' + pkg.browser : '',
       pkg.main ? '!' + pkg.main : '',
       '!package.json',
+      '!npm-shrinkwrap.json',
       '!@(readme|copying|license|licence|notice|changes|changelog|history){,.*[^~$]}'
     ]
-    if (pkg.bin)
-      if (typeof pkg.bin === "object")
-        for (const key in pkg.bin)
-          rules.push('!' + pkg.bin[key])
-      else
-        rules.push('!' + pkg.bin)
+    if (pkg.bin) {
+      // always an object, because normalized already
+      for (const key in pkg.bin)
+        rules.push('!' + pkg.bin[key])
+    }
 
     const data = rules.filter(f => f).join('\n') + '\n'
     super.onReadIgnoreFile(packageNecessaryRules, data, _=>_)
@@ -190,6 +195,16 @@ const npmWalker = Class => class Walker extends Class {
       then()
   }
 
+  // override parent stat function to completely skip any filenames
+  // that will break windows entirely.
+  // XXX(isaacs) Next major version should make this an error instead.
+  stat (entry, file, dir, then) {
+    if (nameIsBadForWindows(entry))
+      then()
+    else
+      super.stat(entry, file, dir, then)
+  }
+
   // override parent onstat function to nix all symlinks
   onstat (st, entry, file, dir, then) {
     if (st.isSymbolicLink())
@@ -202,7 +217,7 @@ const npmWalker = Class => class Walker extends Class {
     if (file === 'package.json')
       try {
         const ig = path.resolve(this.path, file)
-        this.onPackageJson(ig, JSON.parse(data), then)
+        this.onPackageJson(ig, normalizePackageBin(JSON.parse(data)), then)
       } catch (er) {
         // ignore package.json files that are not json
         then()

package/package.json

@@ -1,6 +1,9 @@
 {
   "name": "npm-packlist",
-  "version": "1.4.4",
+  "version": "1.4.8",
+  "publishConfig": {
+    "tag": "legacy-v1"
+  },
   "description": "Get a list of the files to add from a folder into an npm package",
   "directories": {
     "test": "test"
@@ -8,7 +11,8 @@
   "main": "index.js",
   "dependencies": {
     "ignore-walk": "^3.0.1",
-    "npm-bundled": "^1.0.1"
+    "npm-bundled": "^1.0.1",
+    "npm-normalize-package-bin": "^1.0.1"
   },
   "author": "Isaac Z. Schlueter <i@izs.me> (http://blog.izs.me/)",
   "license": "ISC",
@@ -18,7 +22,7 @@
   "devDependencies": {
     "mkdirp": "^0.5.1",
     "rimraf": "^2.6.1",
-    "tap": "^14.2.1"
+    "tap": "^14.6.9"
   },
   "scripts": {
     "test": "tap",
@@ -34,5 +38,8 @@
   "bugs": {
     "url": "https://github.com/npm/npm-packlist/issues"
   },
-  "homepage": "https://www.npmjs.com/package/npm-packlist"
+  "homepage": "https://www.npmjs.com/package/npm-packlist",
+  "tap": {
+    "jobs": 1
+  }
 }