npm-groovy-lint 9.3.0 → 9.3.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +4 -0
- package/lib/.groovylintrc-all.json +394 -394
- package/lib/codenarc-factory.js +10 -9
- package/lib/example/file with spaces.groovy +56 -0
- package/package.json +1 -1
package/CHANGELOG.md
CHANGED
|
@@ -2,6 +2,10 @@
|
|
|
2
2
|
|
|
3
3
|
## UNRELEASED
|
|
4
4
|
|
|
5
|
+
## [9.3.1] 2022-01-06
|
|
6
|
+
|
|
7
|
+
- Fix issue when used as module and with file containing spaces ([VsCodeGroovyLint #137](https://github.com/nvuillam/vscode-groovy-lint/issues/137))
|
|
8
|
+
|
|
5
9
|
## [9.3.0] 2021-12-29
|
|
6
10
|
|
|
7
11
|
- Upgrade log4j dependencies because of [security issue](https://nvd.nist.gov/vuln/detail/CVE-2021-44832).
|
|
@@ -1,395 +1,395 @@
|
|
|
1
1
|
{
|
|
2
|
-
|
|
3
|
-
|
|
4
|
-
|
|
5
|
-
|
|
6
|
-
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
44
|
-
|
|
45
|
-
|
|
46
|
-
|
|
47
|
-
|
|
48
|
-
|
|
49
|
-
|
|
50
|
-
|
|
51
|
-
|
|
52
|
-
|
|
53
|
-
|
|
54
|
-
|
|
55
|
-
|
|
56
|
-
|
|
57
|
-
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
|
|
62
|
-
|
|
63
|
-
|
|
64
|
-
|
|
65
|
-
|
|
66
|
-
|
|
67
|
-
|
|
68
|
-
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
|
|
83
|
-
|
|
84
|
-
|
|
85
|
-
|
|
86
|
-
|
|
87
|
-
|
|
88
|
-
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
|
|
105
|
-
|
|
106
|
-
|
|
107
|
-
|
|
108
|
-
|
|
109
|
-
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
115
|
-
|
|
116
|
-
|
|
117
|
-
|
|
118
|
-
|
|
119
|
-
|
|
120
|
-
|
|
121
|
-
|
|
122
|
-
|
|
123
|
-
|
|
124
|
-
|
|
125
|
-
|
|
126
|
-
|
|
127
|
-
|
|
128
|
-
|
|
129
|
-
|
|
130
|
-
|
|
131
|
-
|
|
132
|
-
|
|
133
|
-
|
|
134
|
-
|
|
135
|
-
|
|
136
|
-
|
|
137
|
-
|
|
138
|
-
|
|
139
|
-
|
|
140
|
-
|
|
141
|
-
|
|
142
|
-
|
|
143
|
-
|
|
144
|
-
|
|
145
|
-
|
|
146
|
-
|
|
147
|
-
|
|
148
|
-
|
|
149
|
-
|
|
150
|
-
|
|
151
|
-
|
|
152
|
-
|
|
153
|
-
|
|
154
|
-
|
|
155
|
-
|
|
156
|
-
|
|
157
|
-
|
|
158
|
-
|
|
159
|
-
|
|
160
|
-
|
|
161
|
-
|
|
162
|
-
|
|
163
|
-
|
|
164
|
-
|
|
165
|
-
|
|
166
|
-
|
|
167
|
-
|
|
168
|
-
|
|
169
|
-
|
|
170
|
-
|
|
171
|
-
|
|
172
|
-
|
|
173
|
-
|
|
174
|
-
|
|
175
|
-
|
|
176
|
-
|
|
177
|
-
|
|
178
|
-
|
|
179
|
-
|
|
180
|
-
|
|
181
|
-
|
|
182
|
-
|
|
183
|
-
|
|
184
|
-
|
|
185
|
-
|
|
186
|
-
|
|
187
|
-
|
|
188
|
-
|
|
189
|
-
|
|
190
|
-
|
|
191
|
-
|
|
192
|
-
|
|
193
|
-
|
|
194
|
-
|
|
195
|
-
|
|
196
|
-
|
|
197
|
-
|
|
198
|
-
|
|
199
|
-
|
|
200
|
-
|
|
201
|
-
|
|
202
|
-
|
|
203
|
-
|
|
204
|
-
|
|
205
|
-
|
|
206
|
-
|
|
207
|
-
|
|
208
|
-
|
|
209
|
-
|
|
210
|
-
|
|
211
|
-
|
|
212
|
-
|
|
213
|
-
|
|
214
|
-
|
|
215
|
-
|
|
216
|
-
|
|
217
|
-
|
|
218
|
-
|
|
219
|
-
|
|
220
|
-
|
|
221
|
-
|
|
222
|
-
|
|
223
|
-
|
|
224
|
-
|
|
225
|
-
|
|
226
|
-
|
|
227
|
-
|
|
228
|
-
|
|
229
|
-
|
|
230
|
-
|
|
231
|
-
|
|
232
|
-
|
|
233
|
-
|
|
234
|
-
|
|
235
|
-
|
|
236
|
-
|
|
237
|
-
|
|
238
|
-
|
|
239
|
-
|
|
240
|
-
|
|
241
|
-
|
|
242
|
-
|
|
243
|
-
|
|
244
|
-
|
|
245
|
-
|
|
246
|
-
|
|
247
|
-
|
|
248
|
-
|
|
249
|
-
|
|
250
|
-
|
|
251
|
-
|
|
252
|
-
|
|
253
|
-
|
|
254
|
-
|
|
255
|
-
|
|
256
|
-
|
|
257
|
-
|
|
258
|
-
|
|
259
|
-
|
|
260
|
-
|
|
261
|
-
|
|
262
|
-
|
|
263
|
-
|
|
264
|
-
|
|
265
|
-
|
|
266
|
-
|
|
267
|
-
|
|
268
|
-
|
|
269
|
-
|
|
270
|
-
|
|
271
|
-
|
|
272
|
-
|
|
273
|
-
|
|
274
|
-
|
|
275
|
-
|
|
276
|
-
|
|
277
|
-
|
|
278
|
-
|
|
279
|
-
|
|
280
|
-
|
|
281
|
-
|
|
282
|
-
|
|
283
|
-
|
|
284
|
-
|
|
285
|
-
|
|
286
|
-
|
|
287
|
-
|
|
288
|
-
|
|
289
|
-
|
|
290
|
-
|
|
291
|
-
|
|
292
|
-
|
|
293
|
-
|
|
294
|
-
|
|
295
|
-
|
|
296
|
-
|
|
297
|
-
|
|
298
|
-
|
|
299
|
-
|
|
300
|
-
|
|
301
|
-
|
|
302
|
-
|
|
303
|
-
|
|
304
|
-
|
|
305
|
-
|
|
306
|
-
|
|
307
|
-
|
|
308
|
-
|
|
309
|
-
|
|
310
|
-
|
|
311
|
-
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
315
|
-
|
|
316
|
-
|
|
317
|
-
|
|
318
|
-
|
|
319
|
-
|
|
320
|
-
|
|
321
|
-
|
|
322
|
-
|
|
323
|
-
|
|
324
|
-
|
|
325
|
-
|
|
326
|
-
|
|
327
|
-
|
|
328
|
-
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
|
|
332
|
-
|
|
333
|
-
|
|
334
|
-
|
|
335
|
-
|
|
336
|
-
|
|
337
|
-
|
|
338
|
-
|
|
339
|
-
|
|
340
|
-
|
|
341
|
-
|
|
342
|
-
|
|
343
|
-
|
|
344
|
-
|
|
345
|
-
|
|
346
|
-
|
|
347
|
-
|
|
348
|
-
|
|
349
|
-
|
|
350
|
-
|
|
351
|
-
|
|
352
|
-
|
|
353
|
-
|
|
354
|
-
|
|
355
|
-
|
|
356
|
-
|
|
357
|
-
|
|
358
|
-
|
|
359
|
-
|
|
360
|
-
|
|
361
|
-
|
|
362
|
-
|
|
363
|
-
|
|
364
|
-
|
|
365
|
-
|
|
366
|
-
|
|
367
|
-
|
|
368
|
-
|
|
369
|
-
|
|
370
|
-
|
|
371
|
-
|
|
372
|
-
|
|
373
|
-
|
|
374
|
-
|
|
375
|
-
|
|
376
|
-
|
|
377
|
-
|
|
378
|
-
|
|
379
|
-
|
|
380
|
-
|
|
381
|
-
|
|
382
|
-
|
|
383
|
-
|
|
384
|
-
|
|
385
|
-
|
|
386
|
-
|
|
387
|
-
|
|
388
|
-
|
|
389
|
-
|
|
390
|
-
|
|
391
|
-
|
|
392
|
-
|
|
393
|
-
|
|
394
|
-
|
|
395
|
-
}
|
|
2
|
+
"rules": {
|
|
3
|
+
"basic.AssertWithinFinallyBlock": {},
|
|
4
|
+
"basic.AssignmentInConditional": {},
|
|
5
|
+
"basic.BigDecimalInstantiation": {},
|
|
6
|
+
"basic.BitwiseOperatorInConditional": {},
|
|
7
|
+
"basic.BooleanGetBoolean": {},
|
|
8
|
+
"basic.BrokenNullCheck": {},
|
|
9
|
+
"basic.BrokenOddnessCheck": {},
|
|
10
|
+
"basic.ClassForName": {},
|
|
11
|
+
"basic.ComparisonOfTwoConstants": {},
|
|
12
|
+
"basic.ComparisonWithSelf": {},
|
|
13
|
+
"basic.ConstantAssertExpression": {},
|
|
14
|
+
"basic.ConstantIfExpression": {},
|
|
15
|
+
"basic.ConstantTernaryExpression": {},
|
|
16
|
+
"basic.DeadCode": {},
|
|
17
|
+
"basic.DoubleNegative": {},
|
|
18
|
+
"basic.DuplicateCaseStatement": {},
|
|
19
|
+
"basic.DuplicateMapKey": {},
|
|
20
|
+
"basic.DuplicateSetValue": {},
|
|
21
|
+
"basic.EmptyCatchBlock": {},
|
|
22
|
+
"basic.EmptyClass": {},
|
|
23
|
+
"basic.EmptyElseBlock": {},
|
|
24
|
+
"basic.EmptyFinallyBlock": {},
|
|
25
|
+
"basic.EmptyForStatement": {},
|
|
26
|
+
"basic.EmptyIfStatement": {},
|
|
27
|
+
"basic.EmptyInstanceInitializer": {},
|
|
28
|
+
"basic.EmptyMethod": {},
|
|
29
|
+
"basic.EmptyStaticInitializer": {},
|
|
30
|
+
"basic.EmptySwitchStatement": {},
|
|
31
|
+
"basic.EmptySynchronizedStatement": {},
|
|
32
|
+
"basic.EmptyTryBlock": {},
|
|
33
|
+
"basic.EmptyWhileStatement": {},
|
|
34
|
+
"basic.EqualsAndHashCode": {},
|
|
35
|
+
"basic.EqualsOverloaded": {},
|
|
36
|
+
"basic.ExplicitGarbageCollection": {},
|
|
37
|
+
"basic.ForLoopShouldBeWhileLoop": {},
|
|
38
|
+
"basic.HardCodedWindowsFileSeparator": {},
|
|
39
|
+
"basic.HardCodedWindowsRootDirectory": {},
|
|
40
|
+
"basic.IntegerGetInteger": {},
|
|
41
|
+
"basic.MultipleUnaryOperators": {},
|
|
42
|
+
"basic.ParameterAssignmentInFilterClosure": {},
|
|
43
|
+
"basic.RandomDoubleCoercedToZero": {},
|
|
44
|
+
"basic.RemoveAllOnSelf": {},
|
|
45
|
+
"basic.ReturnFromFinallyBlock": {},
|
|
46
|
+
"basic.ThrowExceptionFromFinallyBlock": {},
|
|
47
|
+
"braces.ElseBlockBraces": {},
|
|
48
|
+
"braces.ForStatementBraces": {},
|
|
49
|
+
"braces.IfStatementBraces": {},
|
|
50
|
+
"braces.WhileStatementBraces": {},
|
|
51
|
+
"comments.ClassJavadoc": {},
|
|
52
|
+
"comments.JavadocConsecutiveEmptyLines": {},
|
|
53
|
+
"comments.JavadocEmptyAuthorTag": {},
|
|
54
|
+
"comments.JavadocEmptyExceptionTag": {},
|
|
55
|
+
"comments.JavadocEmptyFirstLine": {},
|
|
56
|
+
"comments.JavadocEmptyLastLine": {},
|
|
57
|
+
"comments.JavadocEmptyParamTag": {},
|
|
58
|
+
"comments.JavadocEmptyReturnTag": {},
|
|
59
|
+
"comments.JavadocEmptySeeTag": {},
|
|
60
|
+
"comments.JavadocEmptySinceTag": {},
|
|
61
|
+
"comments.JavadocEmptyThrowsTag": {},
|
|
62
|
+
"comments.JavadocEmptyVersionTag": {},
|
|
63
|
+
"comments.JavadocMissingExceptionDescription": {},
|
|
64
|
+
"comments.JavadocMissingParamDescription": {},
|
|
65
|
+
"comments.JavadocMissingThrowsDescription": {},
|
|
66
|
+
"concurrency.BusyWait": {},
|
|
67
|
+
"concurrency.DoubleCheckedLocking": {},
|
|
68
|
+
"concurrency.InconsistentPropertyLocking": {},
|
|
69
|
+
"concurrency.InconsistentPropertySynchronization": {},
|
|
70
|
+
"concurrency.NestedSynchronization": {},
|
|
71
|
+
"concurrency.StaticCalendarField": {},
|
|
72
|
+
"concurrency.StaticConnection": {},
|
|
73
|
+
"concurrency.StaticDateFormatField": {},
|
|
74
|
+
"concurrency.StaticMatcherField": {},
|
|
75
|
+
"concurrency.StaticSimpleDateFormatField": {},
|
|
76
|
+
"concurrency.SynchronizedMethod": {},
|
|
77
|
+
"concurrency.SynchronizedOnBoxedPrimitive": {},
|
|
78
|
+
"concurrency.SynchronizedOnGetClass": {},
|
|
79
|
+
"concurrency.SynchronizedOnReentrantLock": {},
|
|
80
|
+
"concurrency.SynchronizedOnString": {},
|
|
81
|
+
"concurrency.SynchronizedOnThis": {},
|
|
82
|
+
"concurrency.SynchronizedReadObjectMethod": {},
|
|
83
|
+
"concurrency.SystemRunFinalizersOnExit": {},
|
|
84
|
+
"concurrency.ThisReferenceEscapesConstructor": {},
|
|
85
|
+
"concurrency.ThreadGroup": {},
|
|
86
|
+
"concurrency.ThreadLocalNotStaticFinal": {},
|
|
87
|
+
"concurrency.ThreadYield": {},
|
|
88
|
+
"concurrency.UseOfNotifyMethod": {},
|
|
89
|
+
"concurrency.VolatileArrayField": {},
|
|
90
|
+
"concurrency.VolatileLongOrDoubleField": {},
|
|
91
|
+
"concurrency.WaitOutsideOfWhileLoop": {},
|
|
92
|
+
"convention.CompileStatic": {},
|
|
93
|
+
"convention.ConfusingTernary": {},
|
|
94
|
+
"convention.CouldBeElvis": {},
|
|
95
|
+
"convention.CouldBeSwitchStatement": {},
|
|
96
|
+
"convention.FieldTypeRequired": {},
|
|
97
|
+
"convention.HashtableIsObsolete": {},
|
|
98
|
+
"convention.IfStatementCouldBeTernary": {},
|
|
99
|
+
"convention.ImplicitClosureParameter": {},
|
|
100
|
+
"convention.ImplicitReturnStatement": {},
|
|
101
|
+
"convention.InvertedCondition": {},
|
|
102
|
+
"convention.InvertedIfElse": {},
|
|
103
|
+
"convention.LongLiteralWithLowerCaseL": {},
|
|
104
|
+
"convention.MethodParameterTypeRequired": {},
|
|
105
|
+
"convention.MethodReturnTypeRequired": {},
|
|
106
|
+
"convention.NoDef": {},
|
|
107
|
+
"convention.NoDouble": {},
|
|
108
|
+
"convention.NoFloat": {},
|
|
109
|
+
"convention.NoJavaUtilDate": {},
|
|
110
|
+
"convention.NoTabCharacter": {},
|
|
111
|
+
"convention.ParameterReassignment": {},
|
|
112
|
+
"convention.PublicMethodsBeforeNonPublicMethods": {},
|
|
113
|
+
"convention.StaticFieldsBeforeInstanceFields": {},
|
|
114
|
+
"convention.StaticMethodsBeforeInstanceMethods": {},
|
|
115
|
+
"convention.TernaryCouldBeElvis": {},
|
|
116
|
+
"convention.TrailingComma": {},
|
|
117
|
+
"convention.VariableTypeRequired": {},
|
|
118
|
+
"convention.VectorIsObsolete": {},
|
|
119
|
+
"design.AbstractClassWithPublicConstructor": {},
|
|
120
|
+
"design.AbstractClassWithoutAbstractMethod": {},
|
|
121
|
+
"design.AssignmentToStaticFieldFromInstanceMethod": {},
|
|
122
|
+
"design.BooleanMethodReturnsNull": {},
|
|
123
|
+
"design.BuilderMethodWithSideEffects": {},
|
|
124
|
+
"design.CloneableWithoutClone": {},
|
|
125
|
+
"design.CloseWithoutCloseable": {},
|
|
126
|
+
"design.CompareToWithoutComparable": {},
|
|
127
|
+
"design.ConstantsOnlyInterface": {},
|
|
128
|
+
"design.EmptyMethodInAbstractClass": {},
|
|
129
|
+
"design.FinalClassWithProtectedMember": {},
|
|
130
|
+
"design.ImplementationAsType": {},
|
|
131
|
+
"design.Instanceof": {},
|
|
132
|
+
"design.LocaleSetDefault": {},
|
|
133
|
+
"design.NestedForLoop": {},
|
|
134
|
+
"design.OptionalCollectionReturnType": {},
|
|
135
|
+
"design.OptionalField": {},
|
|
136
|
+
"design.OptionalMethodParameter": {},
|
|
137
|
+
"design.PrivateFieldCouldBeFinal": {},
|
|
138
|
+
"design.PublicInstanceField": {},
|
|
139
|
+
"design.ReturnsNullInsteadOfEmptyArray": {},
|
|
140
|
+
"design.ReturnsNullInsteadOfEmptyCollection": {},
|
|
141
|
+
"design.SimpleDateFormatMissingLocale": {},
|
|
142
|
+
"design.StatelessSingleton": {},
|
|
143
|
+
"design.ToStringReturnsNull": {},
|
|
144
|
+
"dry.DuplicateListLiteral": {},
|
|
145
|
+
"dry.DuplicateMapLiteral": {},
|
|
146
|
+
"dry.DuplicateNumberLiteral": {},
|
|
147
|
+
"dry.DuplicateStringLiteral": {},
|
|
148
|
+
"enhanced.CloneWithoutCloneable": {},
|
|
149
|
+
"enhanced.JUnitAssertEqualsConstantActualValue": {},
|
|
150
|
+
"enhanced.MissingOverrideAnnotation": {},
|
|
151
|
+
"enhanced.UnsafeImplementationAsMap": {},
|
|
152
|
+
"exceptions.CatchArrayIndexOutOfBoundsException": {},
|
|
153
|
+
"exceptions.CatchError": {},
|
|
154
|
+
"exceptions.CatchException": {},
|
|
155
|
+
"exceptions.CatchIllegalMonitorStateException": {},
|
|
156
|
+
"exceptions.CatchIndexOutOfBoundsException": {},
|
|
157
|
+
"exceptions.CatchNullPointerException": {},
|
|
158
|
+
"exceptions.CatchRuntimeException": {},
|
|
159
|
+
"exceptions.CatchThrowable": {},
|
|
160
|
+
"exceptions.ConfusingClassNamedException": {},
|
|
161
|
+
"exceptions.ExceptionExtendsError": {},
|
|
162
|
+
"exceptions.ExceptionExtendsThrowable": {},
|
|
163
|
+
"exceptions.ExceptionNotThrown": {},
|
|
164
|
+
"exceptions.MissingNewInThrowStatement": {},
|
|
165
|
+
"exceptions.ReturnNullFromCatchBlock": {},
|
|
166
|
+
"exceptions.SwallowThreadDeath": {},
|
|
167
|
+
"exceptions.ThrowError": {},
|
|
168
|
+
"exceptions.ThrowException": {},
|
|
169
|
+
"exceptions.ThrowNullPointerException": {},
|
|
170
|
+
"exceptions.ThrowRuntimeException": {},
|
|
171
|
+
"exceptions.ThrowThrowable": {},
|
|
172
|
+
"formatting.BlankLineBeforePackage": {},
|
|
173
|
+
"formatting.BlockEndsWithBlankLine": {},
|
|
174
|
+
"formatting.BlockStartsWithBlankLine": {},
|
|
175
|
+
"formatting.BracesForClass": {},
|
|
176
|
+
"formatting.BracesForForLoop": {},
|
|
177
|
+
"formatting.BracesForIfElse": {},
|
|
178
|
+
"formatting.BracesForMethod": {},
|
|
179
|
+
"formatting.BracesForTryCatchFinally": {},
|
|
180
|
+
"formatting.ClassEndsWithBlankLine": {},
|
|
181
|
+
"formatting.ClassStartsWithBlankLine": {},
|
|
182
|
+
"formatting.ClosureStatementOnOpeningLineOfMultipleLineClosure": {},
|
|
183
|
+
"formatting.ConsecutiveBlankLines": {},
|
|
184
|
+
"formatting.FileEndsWithoutNewline": {},
|
|
185
|
+
"formatting.Indentation": {},
|
|
186
|
+
"formatting.LineLength": {},
|
|
187
|
+
"formatting.MissingBlankLineAfterImports": {},
|
|
188
|
+
"formatting.MissingBlankLineAfterPackage": {},
|
|
189
|
+
"formatting.MissingBlankLineBeforeAnnotatedField": {},
|
|
190
|
+
"formatting.SpaceAfterCatch": {},
|
|
191
|
+
"formatting.SpaceAfterClosingBrace": {},
|
|
192
|
+
"formatting.SpaceAfterComma": {},
|
|
193
|
+
"formatting.SpaceAfterFor": {},
|
|
194
|
+
"formatting.SpaceAfterIf": {},
|
|
195
|
+
"formatting.SpaceAfterMethodCallName": {},
|
|
196
|
+
"formatting.SpaceAfterMethodDeclarationName": {},
|
|
197
|
+
"formatting.SpaceAfterNotOperator": {},
|
|
198
|
+
"formatting.SpaceAfterOpeningBrace": {},
|
|
199
|
+
"formatting.SpaceAfterSemicolon": {},
|
|
200
|
+
"formatting.SpaceAfterSwitch": {},
|
|
201
|
+
"formatting.SpaceAfterWhile": {},
|
|
202
|
+
"formatting.SpaceAroundClosureArrow": {},
|
|
203
|
+
"formatting.SpaceAroundMapEntryColon": {},
|
|
204
|
+
"formatting.SpaceAroundOperator": {},
|
|
205
|
+
"formatting.SpaceBeforeClosingBrace": {},
|
|
206
|
+
"formatting.SpaceBeforeOpeningBrace": {},
|
|
207
|
+
"formatting.SpaceInsideParentheses": {},
|
|
208
|
+
"formatting.TrailingWhitespace": {},
|
|
209
|
+
"generic.IllegalClassMember": {},
|
|
210
|
+
"generic.IllegalClassReference": {},
|
|
211
|
+
"generic.IllegalPackageReference": {},
|
|
212
|
+
"generic.IllegalRegex": {},
|
|
213
|
+
"generic.IllegalString": {},
|
|
214
|
+
"generic.IllegalSubclass": {},
|
|
215
|
+
"generic.RequiredRegex": {},
|
|
216
|
+
"generic.RequiredString": {},
|
|
217
|
+
"generic.StatelessClass": {},
|
|
218
|
+
"grails.GrailsDomainGormMethods": {},
|
|
219
|
+
"grails.GrailsDomainHasEquals": {},
|
|
220
|
+
"grails.GrailsDomainHasToString": {},
|
|
221
|
+
"grails.GrailsDomainReservedSqlKeywordName": {},
|
|
222
|
+
"grails.GrailsDomainStringPropertyMaxSize": {},
|
|
223
|
+
"grails.GrailsDomainWithServiceReference": {},
|
|
224
|
+
"grails.GrailsDuplicateConstraint": {},
|
|
225
|
+
"grails.GrailsDuplicateMapping": {},
|
|
226
|
+
"grails.GrailsMassAssignment": {},
|
|
227
|
+
"grails.GrailsPublicControllerMethod": {},
|
|
228
|
+
"grails.GrailsServletContextReference": {},
|
|
229
|
+
"grails.GrailsStatelessService": {},
|
|
230
|
+
"groovyism.AssignCollectionSort": {},
|
|
231
|
+
"groovyism.AssignCollectionUnique": {},
|
|
232
|
+
"groovyism.ClosureAsLastMethodParameter": {},
|
|
233
|
+
"groovyism.CollectAllIsDeprecated": {},
|
|
234
|
+
"groovyism.ConfusingMultipleReturns": {},
|
|
235
|
+
"groovyism.ExplicitArrayListInstantiation": {},
|
|
236
|
+
"groovyism.ExplicitCallToAndMethod": {},
|
|
237
|
+
"groovyism.ExplicitCallToCompareToMethod": {},
|
|
238
|
+
"groovyism.ExplicitCallToDivMethod": {},
|
|
239
|
+
"groovyism.ExplicitCallToEqualsMethod": {},
|
|
240
|
+
"groovyism.ExplicitCallToGetAtMethod": {},
|
|
241
|
+
"groovyism.ExplicitCallToLeftShiftMethod": {},
|
|
242
|
+
"groovyism.ExplicitCallToMinusMethod": {},
|
|
243
|
+
"groovyism.ExplicitCallToModMethod": {},
|
|
244
|
+
"groovyism.ExplicitCallToMultiplyMethod": {},
|
|
245
|
+
"groovyism.ExplicitCallToOrMethod": {},
|
|
246
|
+
"groovyism.ExplicitCallToPlusMethod": {},
|
|
247
|
+
"groovyism.ExplicitCallToPowerMethod": {},
|
|
248
|
+
"groovyism.ExplicitCallToPutAtMethod": {},
|
|
249
|
+
"groovyism.ExplicitCallToRightShiftMethod": {},
|
|
250
|
+
"groovyism.ExplicitCallToXorMethod": {},
|
|
251
|
+
"groovyism.ExplicitHashMapInstantiation": {},
|
|
252
|
+
"groovyism.ExplicitHashSetInstantiation": {},
|
|
253
|
+
"groovyism.ExplicitLinkedHashMapInstantiation": {},
|
|
254
|
+
"groovyism.ExplicitLinkedListInstantiation": {},
|
|
255
|
+
"groovyism.ExplicitStackInstantiation": {},
|
|
256
|
+
"groovyism.ExplicitTreeSetInstantiation": {},
|
|
257
|
+
"groovyism.GStringAsMapKey": {},
|
|
258
|
+
"groovyism.GStringExpressionWithinString": {},
|
|
259
|
+
"groovyism.GetterMethodCouldBeProperty": {},
|
|
260
|
+
"groovyism.GroovyLangImmutable": {},
|
|
261
|
+
"groovyism.UseCollectMany": {},
|
|
262
|
+
"groovyism.UseCollectNested": {},
|
|
263
|
+
"imports.DuplicateImport": {},
|
|
264
|
+
"imports.ImportFromSamePackage": {},
|
|
265
|
+
"imports.ImportFromSunPackages": {},
|
|
266
|
+
"imports.MisorderedStaticImports": {},
|
|
267
|
+
"imports.NoWildcardImports": {},
|
|
268
|
+
"imports.UnnecessaryGroovyImport": {},
|
|
269
|
+
"imports.UnusedImport": {},
|
|
270
|
+
"jdbc.DirectConnectionManagement": {},
|
|
271
|
+
"jdbc.JdbcConnectionReference": {},
|
|
272
|
+
"jdbc.JdbcResultSetReference": {},
|
|
273
|
+
"jdbc.JdbcStatementReference": {},
|
|
274
|
+
"junit.ChainedTest": {},
|
|
275
|
+
"junit.CoupledTestCase": {},
|
|
276
|
+
"junit.JUnitAssertAlwaysFails": {},
|
|
277
|
+
"junit.JUnitAssertAlwaysSucceeds": {},
|
|
278
|
+
"junit.JUnitFailWithoutMessage": {},
|
|
279
|
+
"junit.JUnitLostTest": {},
|
|
280
|
+
"junit.JUnitPublicField": {},
|
|
281
|
+
"junit.JUnitPublicNonTestMethod": {},
|
|
282
|
+
"junit.JUnitPublicProperty": {},
|
|
283
|
+
"junit.JUnitSetUpCallsSuper": {},
|
|
284
|
+
"junit.JUnitStyleAssertions": {},
|
|
285
|
+
"junit.JUnitTearDownCallsSuper": {},
|
|
286
|
+
"junit.JUnitTestMethodWithoutAssert": {},
|
|
287
|
+
"junit.JUnitUnnecessarySetUp": {},
|
|
288
|
+
"junit.JUnitUnnecessaryTearDown": {},
|
|
289
|
+
"junit.JUnitUnnecessaryThrowsException": {},
|
|
290
|
+
"junit.SpockIgnoreRestUsed": {},
|
|
291
|
+
"junit.UnnecessaryFail": {},
|
|
292
|
+
"junit.UseAssertEqualsInsteadOfAssertTrue": {},
|
|
293
|
+
"junit.UseAssertFalseInsteadOfNegation": {},
|
|
294
|
+
"junit.UseAssertNullInsteadOfAssertEquals": {},
|
|
295
|
+
"junit.UseAssertSameInsteadOfAssertTrue": {},
|
|
296
|
+
"junit.UseAssertTrueInsteadOfAssertEquals": {},
|
|
297
|
+
"junit.UseAssertTrueInsteadOfNegation": {},
|
|
298
|
+
"logging.LoggerForDifferentClass": {},
|
|
299
|
+
"logging.LoggerWithWrongModifiers": {},
|
|
300
|
+
"logging.LoggingSwallowsStacktrace": {},
|
|
301
|
+
"logging.MultipleLoggers": {},
|
|
302
|
+
"logging.PrintStackTrace": {},
|
|
303
|
+
"logging.Println": {},
|
|
304
|
+
"logging.SystemErrPrint": {},
|
|
305
|
+
"logging.SystemOutPrint": {},
|
|
306
|
+
"naming.AbstractClassName": {},
|
|
307
|
+
"naming.ClassName": {},
|
|
308
|
+
"naming.ClassNameSameAsFilename": {},
|
|
309
|
+
"naming.ClassNameSameAsSuperclass": {},
|
|
310
|
+
"naming.ConfusingMethodName": {},
|
|
311
|
+
"naming.FactoryMethodName": {},
|
|
312
|
+
"naming.FieldName": {},
|
|
313
|
+
"naming.InterfaceName": {},
|
|
314
|
+
"naming.InterfaceNameSameAsSuperInterface": {},
|
|
315
|
+
"naming.MethodName": {},
|
|
316
|
+
"naming.ObjectOverrideMisspelledMethodName": {},
|
|
317
|
+
"naming.PackageName": {},
|
|
318
|
+
"naming.PackageNameMatchesFilePath": {},
|
|
319
|
+
"naming.ParameterName": {},
|
|
320
|
+
"naming.PropertyName": {},
|
|
321
|
+
"naming.VariableName": {},
|
|
322
|
+
"security.FileCreateTempFile": {},
|
|
323
|
+
"security.InsecureRandom": {},
|
|
324
|
+
"security.JavaIoPackageAccess": {},
|
|
325
|
+
"security.NonFinalPublicField": {},
|
|
326
|
+
"security.NonFinalSubclassOfSensitiveInterface": {},
|
|
327
|
+
"security.ObjectFinalize": {},
|
|
328
|
+
"security.PublicFinalizeMethod": {},
|
|
329
|
+
"security.SystemExit": {},
|
|
330
|
+
"security.UnsafeArrayDeclaration": {},
|
|
331
|
+
"serialization.EnumCustomSerializationIgnored": {},
|
|
332
|
+
"serialization.SerialPersistentFields": {},
|
|
333
|
+
"serialization.SerialVersionUID": {},
|
|
334
|
+
"serialization.SerializableClassMustDefineSerialVersionUID": {},
|
|
335
|
+
"size.ClassSize": {},
|
|
336
|
+
"size.MethodCount": {},
|
|
337
|
+
"size.MethodSize": {},
|
|
338
|
+
"size.NestedBlockDepth": {},
|
|
339
|
+
"size.ParameterCount": {},
|
|
340
|
+
"unnecessary.AddEmptyString": {},
|
|
341
|
+
"unnecessary.ConsecutiveLiteralAppends": {},
|
|
342
|
+
"unnecessary.ConsecutiveStringConcatenation": {},
|
|
343
|
+
"unnecessary.UnnecessaryBigDecimalInstantiation": {},
|
|
344
|
+
"unnecessary.UnnecessaryBigIntegerInstantiation": {},
|
|
345
|
+
"unnecessary.UnnecessaryBooleanExpression": {},
|
|
346
|
+
"unnecessary.UnnecessaryBooleanInstantiation": {},
|
|
347
|
+
"unnecessary.UnnecessaryCallForLastElement": {},
|
|
348
|
+
"unnecessary.UnnecessaryCallToSubstring": {},
|
|
349
|
+
"unnecessary.UnnecessaryCast": {},
|
|
350
|
+
"unnecessary.UnnecessaryCatchBlock": {},
|
|
351
|
+
"unnecessary.UnnecessaryCollectCall": {},
|
|
352
|
+
"unnecessary.UnnecessaryCollectionCall": {},
|
|
353
|
+
"unnecessary.UnnecessaryConstructor": {},
|
|
354
|
+
"unnecessary.UnnecessaryDefInFieldDeclaration": {},
|
|
355
|
+
"unnecessary.UnnecessaryDefInMethodDeclaration": {},
|
|
356
|
+
"unnecessary.UnnecessaryDefInVariableDeclaration": {},
|
|
357
|
+
"unnecessary.UnnecessaryDotClass": {},
|
|
358
|
+
"unnecessary.UnnecessaryDoubleInstantiation": {},
|
|
359
|
+
"unnecessary.UnnecessaryElseStatement": {},
|
|
360
|
+
"unnecessary.UnnecessaryFinalOnPrivateMethod": {},
|
|
361
|
+
"unnecessary.UnnecessaryFloatInstantiation": {},
|
|
362
|
+
"unnecessary.UnnecessaryGString": {},
|
|
363
|
+
"unnecessary.UnnecessaryGetter": {},
|
|
364
|
+
"unnecessary.UnnecessaryIfStatement": {},
|
|
365
|
+
"unnecessary.UnnecessaryInstanceOfCheck": {},
|
|
366
|
+
"unnecessary.UnnecessaryInstantiationToGetClass": {},
|
|
367
|
+
"unnecessary.UnnecessaryIntegerInstantiation": {},
|
|
368
|
+
"unnecessary.UnnecessaryLongInstantiation": {},
|
|
369
|
+
"unnecessary.UnnecessaryModOne": {},
|
|
370
|
+
"unnecessary.UnnecessaryNullCheck": {},
|
|
371
|
+
"unnecessary.UnnecessaryNullCheckBeforeInstanceOf": {},
|
|
372
|
+
"unnecessary.UnnecessaryObjectReferences": {},
|
|
373
|
+
"unnecessary.UnnecessaryOverridingMethod": {},
|
|
374
|
+
"unnecessary.UnnecessaryPackageReference": {},
|
|
375
|
+
"unnecessary.UnnecessaryParenthesesForMethodCallWithClosure": {},
|
|
376
|
+
"unnecessary.UnnecessaryPublicModifier": {},
|
|
377
|
+
"unnecessary.UnnecessaryReturnKeyword": {},
|
|
378
|
+
"unnecessary.UnnecessarySafeNavigationOperator": {},
|
|
379
|
+
"unnecessary.UnnecessarySelfAssignment": {},
|
|
380
|
+
"unnecessary.UnnecessarySemicolon": {},
|
|
381
|
+
"unnecessary.UnnecessarySetter": {},
|
|
382
|
+
"unnecessary.UnnecessaryStringInstantiation": {},
|
|
383
|
+
"unnecessary.UnnecessarySubstring": {},
|
|
384
|
+
"unnecessary.UnnecessaryTernaryExpression": {},
|
|
385
|
+
"unnecessary.UnnecessaryToString": {},
|
|
386
|
+
"unnecessary.UnnecessaryTransientModifier": {},
|
|
387
|
+
"unused.UnusedArray": {},
|
|
388
|
+
"unused.UnusedMethodParameter": {},
|
|
389
|
+
"unused.UnusedObject": {},
|
|
390
|
+
"unused.UnusedPrivateField": {},
|
|
391
|
+
"unused.UnusedPrivateMethod": {},
|
|
392
|
+
"unused.UnusedPrivateMethodParameter": {},
|
|
393
|
+
"unused.UnusedVariable": {}
|
|
394
|
+
}
|
|
395
|
+
}
|
package/lib/codenarc-factory.js
CHANGED
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
"use strict";
|
|
3
3
|
|
|
4
4
|
const debug = require("debug")("npm-groovy-lint");
|
|
5
|
-
const
|
|
5
|
+
const fs = require("fs-extra");
|
|
6
6
|
const os = require("os");
|
|
7
7
|
const path = require("path");
|
|
8
8
|
const { getConfigFileName } = require("./config.js");
|
|
@@ -29,14 +29,15 @@ async function prepareCodeNarcCall(options) {
|
|
|
29
29
|
// If source option, create a temporary Groovy file
|
|
30
30
|
if (options.source) {
|
|
31
31
|
cnPath = path.resolve(os.tmpdir() + "/npm-groovy-lint");
|
|
32
|
-
await
|
|
32
|
+
await fs.ensureDir(cnPath, { mode: "0777" });
|
|
33
33
|
// File path is sent (recommended): use it to create temp file name
|
|
34
34
|
if (options.sourcefilepath) {
|
|
35
35
|
const pathParse = path.parse(options.sourcefilepath);
|
|
36
36
|
cnPath = cnPath + "/codeNarcTmpDir_" + Math.random();
|
|
37
|
-
await
|
|
38
|
-
|
|
39
|
-
|
|
37
|
+
await fs.ensureDir(cnPath, { mode: "0777" });
|
|
38
|
+
const pathBase = pathParse.base.replace(/ /g, '_');
|
|
39
|
+
result.tmpGroovyFileName = path.resolve(cnPath + "/" + pathBase);
|
|
40
|
+
cnFiles = "**/" + pathBase;
|
|
40
41
|
}
|
|
41
42
|
// Use default random file name
|
|
42
43
|
else {
|
|
@@ -45,7 +46,7 @@ async function prepareCodeNarcCall(options) {
|
|
|
45
46
|
cnFiles = "**/" + tmpFileNm;
|
|
46
47
|
}
|
|
47
48
|
|
|
48
|
-
await
|
|
49
|
+
await fs.writeFile(result.tmpGroovyFileName, normalizeNewLines(options.source));
|
|
49
50
|
debug(`CREATE GROOVY temp file ${result.tmpGroovyFileName} with input source, as CodeNarc requires physical files`);
|
|
50
51
|
}
|
|
51
52
|
|
|
@@ -267,7 +268,7 @@ async function parseCodeNarcResult(options, codeNarcBaseDir, codeNarcJsonResult,
|
|
|
267
268
|
// Parse error definitions & build url if not already done and not noreturnrules option
|
|
268
269
|
if (result.rules == null && options.returnrules === true) {
|
|
269
270
|
const configAllFileName = await getConfigFileName(__dirname, null, [".groovylintrc-all.json"]);
|
|
270
|
-
const grooylintrcAllRules = Object.keys(JSON.parse(
|
|
271
|
+
const grooylintrcAllRules = Object.keys(JSON.parse(fs.readFileSync(configAllFileName, "utf8").toString()).rules);
|
|
271
272
|
const rules = {};
|
|
272
273
|
for (const ruleDef of codeNarcJsonResult.rules) {
|
|
273
274
|
const ruleName = ruleDef.name;
|
|
@@ -295,7 +296,7 @@ async function buildRuleSets(options) {
|
|
|
295
296
|
const normalizedRulesets = rulesetSplits.map(rulesetFile => {
|
|
296
297
|
const fullFile = path.resolve(rulesetFile);
|
|
297
298
|
// Encode file name so CodeNarc understands it
|
|
298
|
-
if (
|
|
299
|
+
if (fs.existsSync(fullFile)) {
|
|
299
300
|
return "file:" + encodeURIComponent(fullFile);
|
|
300
301
|
}
|
|
301
302
|
// File name has already been encoded: let it as it is (will make CodeNarc fail if file not existing)
|
|
@@ -415,7 +416,7 @@ function getCodeNarcPriorityCode(ruleFromConfig) {
|
|
|
415
416
|
async function manageDeleteTmpFiles(tmpGroovyFileName) {
|
|
416
417
|
// Remove temporary groovy file created for source argument if provided
|
|
417
418
|
if (tmpGroovyFileName) {
|
|
418
|
-
await
|
|
419
|
+
await fs.remove(tmpGroovyFileName);
|
|
419
420
|
debug(`Removed temp file ${tmpGroovyFileName} as it is not longer used`);
|
|
420
421
|
tmpGroovyFileName = null;
|
|
421
422
|
}
|
|
@@ -0,0 +1,56 @@
|
|
|
1
|
+
import groovy.io.FileType
|
|
2
|
+
import groovy.json.*
|
|
3
|
+
import groovy.time.TimeCategory
|
|
4
|
+
import static groovyx.gpars.GParsPool.withPool
|
|
5
|
+
|
|
6
|
+
def script = new GroovyScriptEngine( "." ).with{
|
|
7
|
+
loadScriptByName( 'Utils.groovy' ) ;
|
|
8
|
+
}
|
|
9
|
+
this.metaClass.mixin script
|
|
10
|
+
|
|
11
|
+
def returnCode = 0
|
|
12
|
+
Exception eThrow = null ;
|
|
13
|
+
try {
|
|
14
|
+
initialize(args) ;
|
|
15
|
+
} catch (Exception e){
|
|
16
|
+
eThrow = e ;
|
|
17
|
+
returnCode = 1
|
|
18
|
+
}
|
|
19
|
+
if (eThrow == null){
|
|
20
|
+
return 0 ;
|
|
21
|
+
}
|
|
22
|
+
else {
|
|
23
|
+
throw eThrow ;
|
|
24
|
+
return 1 ;
|
|
25
|
+
}
|
|
26
|
+
|
|
27
|
+
//////////////////////////////////////////////////////////////////////////////////////////////////////////
|
|
28
|
+
///////////////////////////////////////////////// SCRIPT /////////////////////////////////////////////////
|
|
29
|
+
//////////////////////////////////////////////////////////////////////////////////////////////////////////
|
|
30
|
+
def initialize(args3) { //
|
|
31
|
+
def executor = new TestExecutor(args3)
|
|
32
|
+
return executor
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
class TestExecutor {
|
|
36
|
+
|
|
37
|
+
public TestExecutor( args2) {
|
|
38
|
+
this.testExternalGlobalProps()
|
|
39
|
+
}
|
|
40
|
+
|
|
41
|
+
public testExternalGlobalProps() {
|
|
42
|
+
Utils.printlnLog( '########## testExternalGlobalProps')
|
|
43
|
+
def globalKeyName = new Random().with { (1..9).collect { (('a'..'z')).join()[ nextInt((('a'..'z')).join().length())]}.join()}
|
|
44
|
+
Utils.printlnLog( "Generated random key: ${globalKeyName}")
|
|
45
|
+
Utils.setExternalValue(globalKeyName , 'lelama' , 'nul')
|
|
46
|
+
def storedValue = Utils.getExternalValue(globalKeyName , 'lelama')
|
|
47
|
+
assert storedValue == 'nul' , 'Error in global prop key storage/ retrieval (1)'
|
|
48
|
+
Utils.setExternalValue(globalKeyName , 'lelama2' , 'nul2')
|
|
49
|
+
def storedValue2 = Utils.getExternalValue(globalKeyName , 'lelama2')
|
|
50
|
+
assert storedValue2 == 'nul2' , 'Error in global prop key storage/ retrieval (2)'
|
|
51
|
+
def storedValueBack = Utils.getExternalValue(globalKeyName , 'lelama')
|
|
52
|
+
assert storedValueBack == 'nul' , 'Error in global prop key storage/ retrieval (3)'
|
|
53
|
+
Utils.printlnLog( Utils.getExternalValue(globalKeyName))
|
|
54
|
+
}
|
|
55
|
+
|
|
56
|
+
}
|