npm-cli-gh-issue-preparator 1.0.3 → 1.0.4

package/.github/workflows/test.yml

@@ -24,6 +24,8 @@ jobs:
 
       - name: Run tests
         run: npm run test
+        env:
+          GH_TOKEN: ${{ secrets.GH_TOKEN }}
 
       - name: Upload test results
         uses: actions/upload-artifact@v6

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.0.4](https://github.com/HiromiShikata/npm-cli-gh-issue-preparator/compare/v1.0.3...v1.0.4) (2026-01-10)
+
+
+### Bug Fixes
+
+* **ci:** add GH_TOKEN to test workflow and fix test expectations ([86dbac0](https://github.com/HiromiShikata/npm-cli-gh-issue-preparator/commit/86dbac0bd66e0806531a26338b225ddec22c7826))
+
 ## [1.0.3](https://github.com/HiromiShikata/npm-cli-gh-issue-preparator/compare/v1.0.2...v1.0.3) (2025-12-14)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "npm-cli-gh-issue-preparator",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/renovate.json

@@ -11,12 +11,6 @@
   "branchConcurrentLimit": 2,
   "ignorePaths": ["**/generated/*", "**/_gen/*"],
   "packageRules": [
-    {
-      "matchPackagePatterns": ["*"],
-      "matchUpdateTypes": ["minor", "patch"],
-      "groupName": "all non-major dependencies",
-      "groupSlug": "all-minor-patch"
-    },
     {
       "matchPackageNames": ["eslint"],
       "allowedVersions": "<9.0.0"
@@ -32,6 +26,10 @@
     {
       "matchPackageNames": ["eslint-plugin-unused-imports"],
       "allowedVersions": "<4.0.0"
+    },
+    {
+      "matchPackageNames": ["@google/clasp"],
+      "allowedVersions": "3.1.0"
     }
   ]
 }

package/src/adapter/repositories/GitHubIssueRepository.test.ts

@@ -270,6 +270,123 @@ describe('GitHubIssueRepository', () => {
       expect(issues).toEqual([]);
     });
 
+    it('should skip items with content but undefined url', async () => {
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: jest.fn().mockResolvedValue({
+          data: {
+            organization: {
+              projectV2: {
+                items: {
+                  totalCount: 2,
+                  pageInfo: {
+                    endCursor: null,
+                    hasNextPage: false,
+                  },
+                  nodes: [
+                    {
+                      id: 'item-with-undefined-url',
+                      content: {
+                        url: undefined,
+                        title: 'Item Without URL',
+                        number: 1,
+                        labels: {
+                          nodes: [],
+                        },
+                      },
+                      fieldValues: {
+                        nodes: [
+                          {
+                            name: 'Done',
+                            field: {
+                              name: 'Status',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                    {
+                      id: 'valid-issue',
+                      content: {
+                        url: 'https://github.com/owner/repo/issues/5',
+                        title: 'Valid Issue',
+                        number: 5,
+                        labels: {
+                          nodes: [],
+                        },
+                      },
+                      fieldValues: {
+                        nodes: [
+                          {
+                            name: 'Done',
+                            field: {
+                              name: 'Status',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  ],
+                },
+              },
+            },
+          },
+        }),
+      });
+
+      const issues = await repository.getAllOpened(mockProject);
+
+      expect(issues).toHaveLength(1);
+      expect(issues[0].id).toBe('valid-issue');
+    });
+
+    it('should handle items with null labels nodes', async () => {
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: jest.fn().mockResolvedValue({
+          data: {
+            organization: {
+              projectV2: {
+                items: {
+                  totalCount: 1,
+                  pageInfo: {
+                    endCursor: null,
+                    hasNextPage: false,
+                  },
+                  nodes: [
+                    {
+                      id: 'issue-no-labels',
+                      content: {
+                        url: 'https://github.com/owner/repo/issues/10',
+                        title: 'Issue Without Labels',
+                        number: 10,
+                        labels: null,
+                      },
+                      fieldValues: {
+                        nodes: [
+                          {
+                            name: 'Done',
+                            field: {
+                              name: 'Status',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  ],
+                },
+              },
+            },
+          },
+        }),
+      });
+
+      const issues = await repository.getAllOpened(mockProject);
+
+      expect(issues).toHaveLength(1);
+      expect(issues[0].labels).toEqual([]);
+    });
+
     it('should handle issue without Status field', async () => {
       mockFetch.mockResolvedValueOnce({
         ok: true,
@@ -343,6 +460,10 @@ describe('GitHubIssueRepository', () => {
             organization: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -400,6 +521,10 @@ describe('GitHubIssueRepository', () => {
             organization: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -453,6 +578,10 @@ describe('GitHubIssueRepository', () => {
             organization: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -525,6 +654,10 @@ describe('GitHubIssueRepository', () => {
             organization: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -560,6 +693,10 @@ describe('GitHubIssueRepository', () => {
             organization: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -600,6 +737,10 @@ describe('GitHubIssueRepository', () => {
             organization: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -642,6 +783,10 @@ describe('GitHubIssueRepository', () => {
             organization: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -682,6 +827,10 @@ describe('GitHubIssueRepository', () => {
             user: {
               projectV2: {
                 fields: {
+                  pageInfo: {
+                    hasNextPage: false,
+                    endCursor: null,
+                  },
                   nodes: [
                     {
                       id: 'field-1',
@@ -1032,5 +1181,60 @@ describe('GitHubIssueRepository', () => {
 
       expect(result).toBeNull();
     });
+
+    it('should handle issue with null labels in get method', async () => {
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: jest.fn().mockResolvedValue({
+          data: {
+            organization: {
+              projectV2: {
+                items: {
+                  totalCount: 1,
+                  pageInfo: {
+                    endCursor: null,
+                    hasNextPage: false,
+                  },
+                  nodes: [
+                    {
+                      id: 'issue-null-labels',
+                      content: {
+                        url: 'https://github.com/owner/repo/issues/1',
+                        title: 'Issue With Null Labels',
+                        number: 1,
+                        labels: null,
+                      },
+                      fieldValues: {
+                        nodes: [
+                          {
+                            name: 'Done',
+                            field: {
+                              name: 'Status',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  ],
+                },
+              },
+            },
+          },
+        }),
+      });
+
+      const result = await repository.get(
+        'https://github.com/owner/repo/issues/1',
+        mockProject,
+      );
+
+      expect(result).toEqual({
+        id: 'issue-null-labels',
+        url: 'https://github.com/owner/repo/issues/1',
+        title: 'Issue With Null Labels',
+        labels: [],
+        status: 'Done',
+      });
+    });
   });
 });

package/src/domain/usecases/StartPreparationUseCase.test.ts

@@ -67,7 +67,7 @@ describe('StartPreparationUseCase', () => {
     expect(mockIssueRepository.update.mock.calls[0][1]).toBe(mockProject);
     expect(mockLocalCommandRunner.runCommand.mock.calls).toHaveLength(1);
     expect(mockLocalCommandRunner.runCommand.mock.calls[0][0]).toBe(
-      'aw https://github.com/user/repo url1 impl',
+      'aw url1 impl https://github.com/user/repo',
     );
   });
   it('should assign workspace to awaiting issues', async () => {
@@ -100,18 +100,13 @@ describe('StartPreparationUseCase', () => {
       preparationStatus: 'Preparation',
       defaultAgentName: 'agent1',
     });
-    expect(mockIssueRepository.update.mock.calls).toHaveLength(2);
+    expect(mockIssueRepository.update.mock.calls).toHaveLength(1);
     expect(mockIssueRepository.update.mock.calls[0][0]).toMatchObject({
-      id: '1',
-      status: 'Preparation',
-    });
-    expect(mockIssueRepository.update.mock.calls[0][1]).toBe(mockProject);
-    expect(mockIssueRepository.update.mock.calls[1][0]).toMatchObject({
       id: '2',
       status: 'Preparation',
     });
-    expect(mockIssueRepository.update.mock.calls[1][1]).toBe(mockProject);
-    expect(mockLocalCommandRunner.runCommand.mock.calls).toHaveLength(2);
+    expect(mockIssueRepository.update.mock.calls[0][1]).toBe(mockProject);
+    expect(mockLocalCommandRunner.runCommand.mock.calls).toHaveLength(1);
   });
   it('should not assign workspace if maximum preparing issues reached', async () => {
     const preparationIssues: Issue[] = Array.from({ length: 6 }, (_, i) => ({
@@ -147,4 +142,45 @@ describe('StartPreparationUseCase', () => {
     expect(issue7UpdateCalls).toHaveLength(0);
     expect(mockLocalCommandRunner.runCommand.mock.calls).toHaveLength(0);
   });
+  it('should handle defensive break when pop returns undefined', async () => {
+    const awaitingIssue: Issue = {
+      id: '1',
+      url: 'url1',
+      title: 'Issue 1',
+      labels: [],
+      status: 'Awaiting Workspace',
+    };
+    let popCallCount = 0;
+    const issuesWithMockedPop: Issue[] = [awaitingIssue, awaitingIssue];
+    const mockedPop = jest.fn((): Issue | undefined => {
+      popCallCount++;
+      if (popCallCount === 1) {
+        return awaitingIssue;
+      }
+      return undefined;
+    });
+    Object.defineProperty(issuesWithMockedPop, 'pop', { value: mockedPop });
+    Object.defineProperty(issuesWithMockedPop, 'filter', {
+      value: () => issuesWithMockedPop,
+    });
+    const allIssues: Issue[] = [];
+    Object.defineProperty(allIssues, 'filter', {
+      value: jest.fn(() => issuesWithMockedPop),
+    });
+    mockProjectRepository.getByUrl.mockResolvedValue(mockProject);
+    mockIssueRepository.getAllOpened.mockResolvedValueOnce(allIssues);
+    mockLocalCommandRunner.runCommand.mockResolvedValue({
+      stdout: '',
+      stderr: '',
+      exitCode: 0,
+    });
+    await useCase.run({
+      projectUrl: 'https://github.com/user/repo',
+      awaitingWorkspaceStatus: 'Awaiting Workspace',
+      preparationStatus: 'Preparation',
+      defaultAgentName: 'agent1',
+    });
+    expect(mockIssueRepository.update.mock.calls).toHaveLength(1);
+    expect(mockLocalCommandRunner.runCommand.mock.calls).toHaveLength(1);
+  });
 });