npm-check-updates 9.2.1 → 9.2.4

package/lib/package-managers/gitTags.js

@@ -8,8 +8,8 @@ const { print } = require('../logging')
 
 /** Return the highest numbered tag on a remote Git URL. */
 const greatest = async (name, version, options) => {
-  const { protocol, host, path } = parseGithubUrl(version)
-  const url = `${protocol ? protocol.replace('git+', '') : 'https:'}//${host}/${path}`
+  const { auth, protocol, host, path } = parseGithubUrl(version)
+  const url = `${protocol ? protocol.replace('git+', '') : 'https:'}//${auth ? auth + '@' : ''}${host}/${path}`
   let tagMap = new Map()
 
   // fetch remote tags
@@ -25,7 +25,9 @@ const greatest = async (name, version, options) => {
   // eslint-disable-next-line fp/no-mutating-methods
   const tags = [...tagMap.keys()]
     .map(tag => versionUtil.isSimpleVersion(tag) ? tag + '.0.0' : tag)
-    .filter(semver.valid)
+    // do not pass semver.valid reference directly since the mapping index will be interpreted as the loose option
+    // https://github.com/npm/node-semver#functions
+    .filter(tag => semver.valid(tag))
     .sort(versionUtil.compareVersions)
   const latestVersion = tags[tags.length - 1]
   return latestVersion

package/lib/versionmanager.js

@@ -181,7 +181,7 @@ function upgradeDependencies(currentDependencies, latestVersions, options = {})
 const isSatisfied = semver.satisfies
 
 /**
- * Satisfy the latest, and it is not beyond the latest).
+ * Check if a version satisfies the latest, and is not beyond the latest). Ignores `v` prefix.
  *
  * @param current
  * @param latest
@@ -200,15 +200,19 @@ function isUpgradeable(current, latest) {
   if (!range) {
     throw new Error(`"${current}" could not be parsed by semver-utils. This is probably a bug. Please file an issue at https://github.com/raineorshine/npm-check-updates.`)
   }
+
   const version = versionUtil.stringify(range)
+  const latestNormalized = versionUtil.isSimpleVersion(latest)
+    ? latest.replace('v', '') + '.0.0'
+    : latest
 
   // make sure it is a valid range
   // not upgradeable if the latest version satisfies the current range
   // not upgradeable if the specified version is newer than the latest (indicating a prerelease version)
   // NOTE: When "<" is specified with a single digit version, e.g. "<7", and has the same major version as the latest, e.g. "7", isSatisfied(latest, version) will return true since it ignores the "<". In this case, test the original range (current) rather than the versionUtil output (version).
   return Boolean(semver.validRange(version)) &&
-        !isSatisfied(latest, range.operator === '<' ? current : version) &&
-        !semver.ltr(latest, version)
+        !isSatisfied(latestNormalized, range.operator === '<' ? current : version) &&
+        !semver.ltr(latestNormalized, version)
 }
 
 /**
@@ -469,33 +473,31 @@ async function queryVersions(packageMap, options = {}) {
     const npmAlias = versionUtil.parseNpmAlias(packageMap[dep])
     const [name, version] = npmAlias || [dep, packageMap[dep]]
 
+    let versionNew = null
+
     // use gitTags package manager for git urls
     if (versionUtil.isGithubUrl(packageMap[dep])) {
-      return await packageManagers.gitTags.greatest(name, version, options)
-    }
-
-    let versionNew
-
-    try {
-      versionNew = await getPackageVersion(name, version, {
-        ...options,
-        // upgrade prereleases to newer prereleases by default
-        pre: options.pre != null ? options.pre : versionUtil.isPre(version)
-      })
+      versionNew = await packageManagers.gitTags.greatest(name, version, options)
     }
-    catch (err) {
-      const errorMessage = err ? (err.message || err).toString() : ''
-      if (errorMessage.match(/E404|ENOTFOUND|404 Not Found/i)) {
-        return null
+    else {
+      try {
+        versionNew = await getPackageVersion(name, version, {
+          ...options,
+          // upgrade prereleases to newer prereleases by default
+          pre: options.pre != null ? options.pre : versionUtil.isPre(version)
+        })
+        versionNew = npmAlias ? versionUtil.createNpmAlias(name, versionNew) : versionNew
       }
-      else {
-
-        // print a hint about the --timeout option for network timeout errors
-        if (!process.env.NCU_TESTS && /(Response|network) timeout/i.test(errorMessage)) {
-          console.error('\n\n' + chalk.red('FetchError: Request Timeout. npm-registry-fetch defaults to 30000 (30 seconds). Try setting the --timeout option (in milliseconds) to override this.') + '\n')
+      catch (err) {
+        const errorMessage = err ? (err.message || err).toString() : ''
+        if (!errorMessage.match(/E404|ENOTFOUND|404 Not Found/i)) {
+          // print a hint about the --timeout option for network timeout errors
+          if (!process.env.NCU_TESTS && /(Response|network) timeout/i.test(errorMessage)) {
+            console.error('\n\n' + chalk.red('FetchError: Request Timeout. npm-registry-fetch defaults to 30000 (30 seconds). Try setting the --timeout option (in milliseconds) to override this.') + '\n')
+          }
+
+          throw err
         }
-
-        throw err
       }
     }
 
@@ -503,7 +505,7 @@ async function queryVersions(packageMap, options = {}) {
       bar.tick()
     }
 
-    return npmAlias ? versionUtil.createNpmAlias(name, versionNew) : versionNew
+    return versionNew
   }
 
   /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "npm-check-updates",
-  "version": "9.2.1",
+  "version": "9.2.4",
   "author": "Tomas Junnonen <tomas1@gmail.com>",
   "license": "Apache-2.0",
   "contributors": [
@@ -51,7 +51,7 @@
     "chalk": "^4.1.0",
     "cint": "^8.2.1",
     "cli-table": "^0.3.1",
-    "commander": "^6.1.0",
+    "commander": "^6.2.0",
     "find-up": "5.0.0",
     "get-stdin": "^8.0.0",
     "json-parse-helpfulerror": "^1.0.3",
@@ -62,7 +62,7 @@
     "pacote": "^11.1.11",
     "parse-github-url": "^1.0.2",
     "progress": "^2.0.3",
-    "prompts": "^2.3.2",
+    "prompts": "^2.4.0",
     "rc-config-loader": "^3.0.0",
     "remote-git-tags": "^3.0.0",
     "rimraf": "^3.0.2",
@@ -76,15 +76,15 @@
     "chai-as-promised": "^7.1.1",
     "chai-string": "^1.5.0",
     "chokidar-cli": "^2.1.0",
-    "eslint": "^7.10.0",
+    "eslint": "^7.12.1",
     "eslint-config-standard": "^14.1.1",
     "eslint-plugin-fp": "^2.3.0",
     "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jsdoc": "^30.6.2",
+    "eslint-plugin-jsdoc": "^30.7.5",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^4.2.1",
     "eslint-plugin-standard": "^4.0.1",
-    "mocha": "^8.1.3",
+    "mocha": "^8.2.0",
     "nyc": "^15.1.0",
     "should": "^13.2.3",
     "tmp": "0.2.1"