novel-writer-cli 0.0.3 → 0.2.0

package/dist/__tests__/advance-refine-invalidates-eval.test.js

@@ -0,0 +1,37 @@
+import assert from "node:assert/strict";
+import { mkdtemp, mkdir, stat, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import test from "node:test";
+import { advanceCheckpointForStep } from "../advance.js";
+async function exists(absPath) {
+    try {
+        await stat(absPath);
+        return true;
+    }
+    catch {
+        return false;
+    }
+}
+test("advanceCheckpointForStep(chapter:refine) invalidates eval and counts polish revisions after judge", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-advance-refine-"));
+    await writeFile(join(rootDir, ".checkpoint.json"), `${JSON.stringify({
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "WRITING",
+        pipeline_stage: "judged",
+        inflight_chapter: 1,
+        revision_count: 0
+    }, null, 2)}\n`, "utf8");
+    await mkdir(join(rootDir, "staging/chapters"), { recursive: true });
+    await writeFile(join(rootDir, "staging/chapters/chapter-001.md"), "draft text\n", "utf8");
+    await mkdir(join(rootDir, "staging/evaluations"), { recursive: true });
+    await writeFile(join(rootDir, "staging/evaluations/chapter-001-eval.json"), `{"chapter":1,"overall":3.6,"recommendation":"polish"}\n`, "utf8");
+    assert.equal(await exists(join(rootDir, "staging/evaluations/chapter-001-eval.json")), true);
+    const updated = await advanceCheckpointForStep({ rootDir, step: { kind: "chapter", chapter: 1, stage: "refine" } });
+    assert.equal(updated.pipeline_stage, "refined");
+    assert.equal(updated.inflight_chapter, 1);
+    assert.equal(updated.revision_count, 1);
+    assert.equal(updated.orchestrator_state, "CHAPTER_REWRITE");
+    assert.equal(await exists(join(rootDir, "staging/evaluations/chapter-001-eval.json")), false);
+});

package/dist/__tests__/character-voice.test.js

@@ -407,7 +407,7 @@ test("buildInstructionPacket injects character voice drift directives into draft
         ]
     });
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), `# 第1章\n\n（占位）\n`);
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const draftOut = (await buildInstructionPacket({
         rootDir,
         checkpoint,

package/dist/__tests__/checkpoint-quickstart-phase.test.js

@@ -0,0 +1,49 @@
+import assert from "node:assert/strict";
+import { mkdir, mkdtemp, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { dirname, join } from "node:path";
+import test from "node:test";
+import { readCheckpoint } from "../checkpoint.js";
+async function writeText(absPath, contents) {
+    await mkdir(dirname(absPath), { recursive: true });
+    await writeFile(absPath, contents, "utf8");
+}
+async function writeJson(absPath, payload) {
+    await writeText(absPath, `${JSON.stringify(payload, null, 2)}\n`);
+}
+test("readCheckpoint rejects invalid quickstart_phase string", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-checkpoint-quickstart-phase-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null,
+        quickstart_phase: "banana"
+    });
+    await assert.rejects(() => readCheckpoint(rootDir), /quickstart_phase must be one of:/);
+});
+test("readCheckpoint rejects non-string quickstart_phase", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-checkpoint-quickstart-phase-non-string-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null,
+        quickstart_phase: 42
+    });
+    await assert.rejects(() => readCheckpoint(rootDir), /quickstart_phase must be a string/);
+});
+test("readCheckpoint accepts legacy checkpoint without quickstart_phase", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-checkpoint-quickstart-phase-legacy-missing-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null
+    });
+    const checkpoint = await readCheckpoint(rootDir);
+    assert.equal(checkpoint.quickstart_phase ?? null, null);
+});

package/dist/__tests__/cli-instructions-novel-ask-gate.test.js

@@ -0,0 +1,83 @@
+import assert from "node:assert/strict";
+import { mkdir, mkdtemp, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { dirname, join } from "node:path";
+import test from "node:test";
+import { main } from "../cli.js";
+async function writeText(absPath, contents) {
+    await mkdir(dirname(absPath), { recursive: true });
+    await writeFile(absPath, contents, "utf8");
+}
+async function writeJson(absPath, payload) {
+    await writeText(absPath, `${JSON.stringify(payload, null, 2)}\n`);
+}
+async function runCli(argv) {
+    let stdout = "";
+    let stderr = "";
+    const origOut = process.stdout.write;
+    const origErr = process.stderr.write;
+    process.stdout.write = (chunk) => {
+        stdout += typeof chunk === "string" ? chunk : Buffer.from(chunk).toString("utf8");
+        return true;
+    };
+    process.stderr.write = (chunk) => {
+        stderr += typeof chunk === "string" ? chunk : Buffer.from(chunk).toString("utf8");
+        return true;
+    };
+    const prevExitCode = process.exitCode;
+    try {
+        const code = await main(argv);
+        return { code, stdout, stderr };
+    }
+    finally {
+        process.exitCode = prevExitCode;
+        process.stdout.write = origOut;
+        process.stderr.write = origErr;
+    }
+}
+test("novel instructions rejects --novel-ask-file without --answer-path (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-novel-ask-missing-answer-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "INIT",
+        pipeline_stage: null,
+        inflight_chapter: null
+    });
+    const res = await runCli([
+        "--json",
+        "--project",
+        rootDir,
+        "instructions",
+        "quickstart:world",
+        "--novel-ask-file",
+        "staging/novel-ask/question.json"
+    ]);
+    assert.equal(res.code, 2);
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, false);
+    assert.match(payload.error.message, /provide both --novel-ask-file and --answer-path/);
+});
+test("novel instructions rejects --answer-path without --novel-ask-file (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-novel-ask-missing-ask-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "INIT",
+        pipeline_stage: null,
+        inflight_chapter: null
+    });
+    const res = await runCli([
+        "--json",
+        "--project",
+        rootDir,
+        "instructions",
+        "quickstart:world",
+        "--answer-path",
+        "staging/novel-ask/answer.json"
+    ]);
+    assert.equal(res.code, 2);
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, false);
+    assert.match(payload.error.message, /provide both --novel-ask-file and --answer-path/);
+});

package/dist/__tests__/cli-repair-reset-quickstart.test.js

@@ -0,0 +1,194 @@
+import assert from "node:assert/strict";
+import { mkdir, mkdtemp, readFile, stat, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { dirname, join } from "node:path";
+import test from "node:test";
+import { main } from "../cli.js";
+import { readCheckpoint } from "../checkpoint.js";
+async function writeText(absPath, contents) {
+    await mkdir(dirname(absPath), { recursive: true });
+    await writeFile(absPath, contents, "utf8");
+}
+async function writeJson(absPath, payload) {
+    await writeText(absPath, `${JSON.stringify(payload, null, 2)}\n`);
+}
+async function runCli(argv) {
+    let stdout = "";
+    let stderr = "";
+    const origOut = process.stdout.write;
+    const origErr = process.stderr.write;
+    process.stdout.write = (chunk) => {
+        stdout += typeof chunk === "string" ? chunk : Buffer.from(chunk).toString("utf8");
+        return true;
+    };
+    process.stderr.write = (chunk) => {
+        stderr += typeof chunk === "string" ? chunk : Buffer.from(chunk).toString("utf8");
+        return true;
+    };
+    const prevExitCode = process.exitCode;
+    try {
+        process.exitCode = undefined;
+        const code = await main(argv);
+        return { code, stdout, stderr };
+    }
+    finally {
+        process.exitCode = prevExitCode;
+        process.stdout.write = origOut;
+        process.stderr.write = origErr;
+    }
+}
+test("novel repair previews reset-quickstart without --force (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-quickstart-preview-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null,
+        quickstart_phase: "characters"
+    });
+    const res = await runCli(["--json", "--project", rootDir, "repair", "--reset-quickstart"]);
+    assert.equal(res.code, 0);
+    assert.equal(res.stderr, "");
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, true);
+    assert.equal(payload.command, "repair");
+    assert.equal(payload.data.rootDir, rootDir);
+    assert.deepEqual(payload.data.actions, ["reset_quickstart"]);
+    assert.equal(payload.data.applied, false);
+    assert.equal(payload.data.before_present, true);
+    assert.equal(payload.data.after_present, true);
+    assert.equal(payload.data.changed, false);
+    assert.equal(payload.data.would_change, true);
+    assert.equal(payload.data.before, "characters");
+    assert.equal(payload.data.after, "characters");
+    assert.equal(payload.data.target_after, null);
+    const checkpoint = await readCheckpoint(rootDir);
+    assert.equal(checkpoint.quickstart_phase, "characters");
+});
+test("novel repair --reset-quickstart --force sets quickstart_phase=null (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-quickstart-force-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null,
+        quickstart_phase: "characters"
+    });
+    const res = await runCli(["--json", "--project", rootDir, "repair", "--reset-quickstart", "--force"]);
+    assert.equal(res.code, 0);
+    assert.equal(res.stderr, "");
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, true);
+    assert.equal(payload.command, "repair");
+    assert.equal(payload.data.rootDir, rootDir);
+    assert.deepEqual(payload.data.actions, ["reset_quickstart"]);
+    assert.equal(payload.data.applied, true);
+    assert.equal(payload.data.before_present, true);
+    assert.equal(payload.data.after_present, true);
+    assert.equal(payload.data.changed, true);
+    assert.equal(payload.data.would_change, true);
+    assert.equal(payload.data.before, "characters");
+    assert.equal(payload.data.after, null);
+    assert.equal(payload.data.target_after, null);
+    const checkpoint = await readCheckpoint(rootDir);
+    assert.equal(checkpoint.quickstart_phase, null);
+    const raw = await readFile(join(rootDir, ".checkpoint.json"), "utf8");
+    assert.match(raw, /\"quickstart_phase\": null/);
+    await assert.rejects(() => stat(join(rootDir, ".novel.lock")), /ENOENT/);
+});
+test("novel repair --reset-quickstart --force normalizes missing quickstart_phase to null (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-quickstart-missing-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null
+    });
+    const res = await runCli(["--json", "--project", rootDir, "repair", "--reset-quickstart", "--force"]);
+    assert.equal(res.code, 0);
+    assert.equal(res.stderr, "");
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, true);
+    assert.equal(payload.command, "repair");
+    assert.equal(payload.data.applied, true);
+    assert.equal(payload.data.before_present, false);
+    assert.equal(payload.data.after_present, true);
+    assert.equal(payload.data.changed, true);
+    assert.equal(payload.data.would_change, true);
+    assert.equal(payload.data.before, null);
+    assert.equal(payload.data.after, null);
+    const checkpoint = await readCheckpoint(rootDir);
+    assert.equal(checkpoint.quickstart_phase, null);
+});
+test("novel repair --reset-quickstart --force is idempotent when already null (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-quickstart-noop-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null,
+        quickstart_phase: null
+    });
+    const res = await runCli(["--json", "--project", rootDir, "repair", "--reset-quickstart", "--force"]);
+    assert.equal(res.code, 0);
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, true);
+    assert.equal(payload.data.applied, true);
+    assert.equal(payload.data.changed, false);
+    assert.equal(payload.data.would_change, false);
+    assert.equal(payload.data.before, null);
+    assert.equal(payload.data.after, null);
+});
+test("novel repair --reset-quickstart fails gracefully when checkpoint missing (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-quickstart-no-checkpoint-"));
+    const res = await runCli(["--json", "--project", rootDir, "repair", "--reset-quickstart", "--force"]);
+    assert.equal(res.code, 2);
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, false);
+    assert.equal(payload.command, "repair");
+});
+test("novel repair --reset-quickstart fails gracefully when checkpoint is corrupt JSON (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-quickstart-corrupt-"));
+    await writeText(join(rootDir, ".checkpoint.json"), "{ broken json !!!}");
+    const res = await runCli(["--json", "--project", rootDir, "repair", "--reset-quickstart", "--force"]);
+    assert.ok(res.code !== 0, `expected non-zero exit code, got ${res.code}`);
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, false);
+    assert.equal(payload.command, "repair");
+});
+test("novel repair preview reports after_present=true even when field is missing (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-quickstart-preview-missing-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "QUICK_START",
+        pipeline_stage: null,
+        inflight_chapter: null
+    });
+    const res = await runCli(["--json", "--project", rootDir, "repair", "--reset-quickstart"]);
+    assert.equal(res.code, 0);
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.data.before_present, false);
+    assert.equal(payload.data.after_present, true);
+    assert.equal(payload.data.would_change, true);
+});
+test("novel repair rejects missing actions (json mode)", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-cli-repair-missing-action-"));
+    await writeJson(join(rootDir, ".checkpoint.json"), {
+        last_completed_chapter: 0,
+        current_volume: 1,
+        orchestrator_state: "INIT",
+        pipeline_stage: null,
+        inflight_chapter: null
+    });
+    const res = await runCli(["--json", "--project", rootDir, "repair"]);
+    assert.equal(res.code, 2);
+    const payload = JSON.parse(res.stdout.trim());
+    assert.equal(payload.ok, false);
+    assert.equal(payload.command, "repair");
+    assert.match(payload.error.message, /no actions specified/i);
+});

package/dist/__tests__/gate-decision.test.js

@@ -0,0 +1,66 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+import { computeGateDecision, detectHighConfidenceViolation } from "../gate-decision.js";
+test("computeGateDecision maps score bands to decisions (no violations)", () => {
+    assert.equal(computeGateDecision({ overall_final: 4.0, revision_count: 0, has_high_confidence_violation: false }), "pass");
+    assert.equal(computeGateDecision({ overall_final: 3.9, revision_count: 0, has_high_confidence_violation: false }), "polish");
+    assert.equal(computeGateDecision({ overall_final: 3.5, revision_count: 0, has_high_confidence_violation: false }), "polish");
+    assert.equal(computeGateDecision({ overall_final: 3.4, revision_count: 0, has_high_confidence_violation: false }), "revise");
+    assert.equal(computeGateDecision({ overall_final: 3.0, revision_count: 0, has_high_confidence_violation: false }), "revise");
+    assert.equal(computeGateDecision({ overall_final: 2.9, revision_count: 0, has_high_confidence_violation: false }), "pause_for_user");
+    assert.equal(computeGateDecision({ overall_final: 2.0, revision_count: 0, has_high_confidence_violation: false }), "pause_for_user");
+    assert.equal(computeGateDecision({ overall_final: 1.99, revision_count: 0, has_high_confidence_violation: false }), "pause_for_user_force_rewrite");
+});
+test("computeGateDecision forces revise on high-confidence violations", () => {
+    assert.equal(computeGateDecision({ overall_final: 4.8, revision_count: 0, has_high_confidence_violation: true }), "revise");
+});
+test("computeGateDecision pauses for user when high-confidence violations persist beyond max_revisions", () => {
+    assert.equal(computeGateDecision({ overall_final: 4.8, revision_count: 2, has_high_confidence_violation: true }), "pause_for_user");
+});
+test("computeGateDecision allows force_passed when revisions exhausted and score >= 3.0", () => {
+    assert.equal(computeGateDecision({ overall_final: 3.2, revision_count: 2, has_high_confidence_violation: false }), "force_passed");
+});
+test("computeGateDecision force-passes polish band when revisions exhausted", () => {
+    assert.equal(computeGateDecision({ overall_final: 3.6, revision_count: 2, has_high_confidence_violation: false }), "force_passed");
+});
+test("computeGateDecision respects max_revisions override", () => {
+    assert.equal(computeGateDecision({ overall_final: 3.6, revision_count: 1, has_high_confidence_violation: false, max_revisions: 1 }), "force_passed");
+});
+test("computeGateDecision supports manual force_pass override", () => {
+    assert.equal(computeGateDecision({ overall_final: 1.0, revision_count: 0, has_high_confidence_violation: true, force_pass: true }), "force_passed");
+});
+test("detectHighConfidenceViolation returns false when contract_verification is missing", () => {
+    assert.deepEqual(detectHighConfidenceViolation({ overall: 4.0, recommendation: "pass" }), {
+        has_high_confidence_violation: false,
+        high_confidence_violations: []
+    });
+});
+test("detectHighConfidenceViolation detects l1/l2/l3 high-confidence violations", () => {
+    const res = detectHighConfidenceViolation({
+        contract_verification: {
+            l1_checks: [{ status: "violation", confidence: "high", rule: "L1-001" }],
+            l2_checks: [],
+            l3_checks: []
+        }
+    });
+    assert.equal(res.has_high_confidence_violation, true);
+    assert.equal(res.high_confidence_violations.length, 1);
+});
+test("detectHighConfidenceViolation ignores ls_checks soft violations", () => {
+    const res = detectHighConfidenceViolation({
+        contract_verification: {
+            ls_checks: [{ status: "violation", confidence: "high", constraint_type: "soft" }]
+        }
+    });
+    assert.equal(res.has_high_confidence_violation, false);
+});
+test("detectHighConfidenceViolation marks inferred constraint_type for ls_checks when missing", () => {
+    const res = detectHighConfidenceViolation({
+        contract_verification: {
+            ls_checks: [{ status: "violation", confidence: "high" }]
+        }
+    });
+    assert.equal(res.has_high_confidence_violation, true);
+    assert.equal(res.high_confidence_violations.length, 1);
+    assert.equal(res.high_confidence_violations[0].constraint_type_inferred, true);
+});

package/dist/__tests__/init.test.js

@@ -58,23 +58,28 @@ test("initProject creates a runnable skeleton with all checkpoint fields", async
         assert.equal(result.rootDir, rootDir);
         // Exact created set (non-minimal = checkpoint + 4 templates)
         assert.deepEqual(result.created.sort(), [".checkpoint.json", "ai-blacklist.json", "brief.md", "style-profile.json", "web-novel-cliche-lint.json"].sort());
-        // All 7 staging dirs ensured
-        assert.equal(result.ensuredDirs.length, 7);
+        // All staging dirs ensured
+        assert.equal(result.ensuredDirs.length, 10);
         assert.ok(result.ensuredDirs.includes("staging/chapters"));
         assert.ok(result.ensuredDirs.includes("staging/manifests"));
+        assert.ok(result.ensuredDirs.includes("staging/volumes"));
+        assert.ok(result.ensuredDirs.includes("staging/foreshadowing"));
+        assert.ok(result.ensuredDirs.includes("staging/quickstart"));
         // Verify ALL checkpoint fields
         const checkpoint = await readCheckpoint(rootDir);
         assert.equal(checkpoint.last_completed_chapter, 0);
         assert.equal(checkpoint.current_volume, 1);
-        assert.equal(checkpoint.pipeline_stage, "committed");
+        assert.equal(checkpoint.orchestrator_state, "INIT");
+        assert.equal(checkpoint.pipeline_stage, null);
+        assert.equal(checkpoint.volume_pipeline_stage, null);
         assert.equal(checkpoint.inflight_chapter, null);
         assert.equal(checkpoint.revision_count, 0);
         assert.equal(checkpoint.hook_fix_count, 0);
         assert.equal(checkpoint.title_fix_count, 0);
         assert.ok(typeof checkpoint.last_checkpoint_time === "string" && checkpoint.last_checkpoint_time.length > 0);
-        // Integration: next step should be chapter:001:draft
+        // Integration: next step should be quickstart:world
         const next = await computeNextStep(rootDir, checkpoint);
-        assert.equal(next.step, "chapter:001:draft");
+        assert.equal(next.step, "quickstart:world");
         // All staging dirs exist
         for (const relDir of [
             "staging/chapters",
@@ -83,7 +88,10 @@ test("initProject creates a runnable skeleton with all checkpoint fields", async
             "staging/evaluations",
             "staging/logs",
             "staging/storylines",
-            "staging/manifests"
+            "staging/volumes",
+            "staging/foreshadowing",
+            "staging/manifests",
+            "staging/quickstart"
         ]) {
             await assertDir(join(rootDir, relDir));
         }

package/dist/__tests__/instructions-review-novel-ask-gate.test.js

@@ -0,0 +1,31 @@
+import assert from "node:assert/strict";
+import { mkdtemp } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import test from "node:test";
+import { buildInstructionPacket } from "../instructions.js";
+test("buildInstructionPacket rejects NOVEL_ASK gate for review steps", async () => {
+    const rootDir = await mkdtemp(join(tmpdir(), "novel-review-novel-ask-"));
+    const questionSpec = {
+        version: 1,
+        topic: "review_gate",
+        questions: [
+            {
+                id: "ok_to_continue",
+                header: "Continue?",
+                question: "Continue the review pipeline?",
+                kind: "single_choice",
+                required: true,
+                options: [{ label: "yes", description: "Proceed" }]
+            }
+        ]
+    };
+    await assert.rejects(async () => buildInstructionPacket({
+        rootDir,
+        checkpoint: { last_completed_chapter: 0, current_volume: 1, orchestrator_state: "VOL_REVIEW" },
+        step: { kind: "review", phase: "collect" },
+        embedMode: null,
+        writeManifest: false,
+        novelAskGate: { novel_ask: questionSpec, answer_path: "staging/novel-ask/review.json" }
+    }), /NOVEL_ASK gate is not supported for review steps/);
+});

package/dist/__tests__/narrative-health-injection.test.js

@@ -74,7 +74,7 @@ test("buildInstructionPacket injects compact narrative health summaries into dra
         has_blocking_issues: false
     });
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), `# 第1章\n\n（占位）\n`);
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const draftOut = (await buildInstructionPacket({
         rootDir,
         checkpoint,
@@ -126,7 +126,7 @@ test("buildInstructionPacket marks degraded when latest reports exist but are in
         has_blocking_issues: false
     });
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), `# 第1章\n\n（占位）\n`);
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const out = (await buildInstructionPacket({
         rootDir,
         checkpoint,
@@ -143,7 +143,7 @@ test("buildInstructionPacket marks degraded when latest reports exist but are in
 test("buildInstructionPacket does not inject narrative health when logs are missing (no summary, no degraded)", async () => {
     const rootDir = await mkdtemp(join(tmpdir(), "novel-narrative-health-no-logs-"));
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), `# 第1章\n\n（占位）\n`);
-    const checkpoint = { last_completed_chapter: 0, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 0, current_volume: 1, orchestrator_state: "WRITING" };
     const out = (await buildInstructionPacket({
         rootDir,
         checkpoint,
@@ -193,7 +193,7 @@ test("buildInstructionPacket does not inject narrative health summaries for stag
         has_blocking_issues: false
     });
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), `# 第1章\n\n（占位）\n`);
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const summarizeOut = (await buildInstructionPacket({
         rootDir,
         checkpoint,
@@ -239,7 +239,7 @@ test("buildInstructionPacket marks degraded on schema_version mismatch when late
         has_blocking_issues: false
     });
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), `# 第1章\n\n（占位）\n`);
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const out = (await buildInstructionPacket({
         rootDir,
         checkpoint,
@@ -279,7 +279,7 @@ test("buildInstructionPacket marks promise ledger degraded on schema_version mis
         issues: []
     });
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), `# 第1章\n\n（占位）\n`);
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const out = (await buildInstructionPacket({
         rootDir,
         checkpoint,
@@ -298,7 +298,7 @@ test("buildInstructionPacket marks both degraded when both latest files are inva
     await writeText(join(rootDir, "logs/engagement/latest.json"), "not-json");
     await writeText(join(rootDir, "logs/promises/latest.json"), "not-json");
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), "# 第1章\n\n（占位）\n");
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const out = (await buildInstructionPacket({
         rootDir,
         checkpoint,
@@ -341,7 +341,7 @@ test("buildInstructionPacket treats oversized latest.json as degraded", async ()
         has_blocking_issues: false
     });
     await writeText(join(rootDir, "staging/chapters/chapter-001.md"), "# 第1章\n\n（占位）\n");
-    const checkpoint = { last_completed_chapter: 10, current_volume: 1 };
+    const checkpoint = { last_completed_chapter: 10, current_volume: 1, orchestrator_state: "WRITING" };
     const out = (await buildInstructionPacket({
         rootDir,
         checkpoint,