novaui-cli 1.1.2 → 1.1.3

package/src/__tests__/preflight.test.js

@@ -0,0 +1,379 @@
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
+import fs from 'node:fs'
+import path from 'node:path'
+import os from 'node:os'
+
+import {
+  checkPackageJson,
+  checkReactNativeProject,
+  checkBabelConfig,
+  checkNativeWindInBabel,
+  checkReactNativeVersion,
+  checkNativeWindVersion,
+  runInitPreflightChecks,
+  runAddPreflightChecks,
+} from '../utils/preflight.js'
+
+// Test helpers
+function makeTmpDir() {
+  return fs.mkdtempSync(path.join(os.tmpdir(), 'novaui-preflight-test-'))
+}
+
+function cleanTmpDir(dir) {
+  fs.rmSync(dir, { recursive: true, force: true })
+}
+
+describe('checkPackageJson', () => {
+  let tmp
+
+  beforeEach(() => {
+    tmp = makeTmpDir()
+  })
+
+  afterEach(() => {
+    cleanTmpDir(tmp)
+  })
+
+  it('throws when package.json does not exist', () => {
+    expect(() => checkPackageJson(tmp)).toThrow(/package.json not found/)
+  })
+
+  it('returns parsed package.json when valid', () => {
+    const pkg = { name: 'test-app', version: '1.0.0' }
+    fs.writeFileSync(path.join(tmp, 'package.json'), JSON.stringify(pkg))
+
+    const result = checkPackageJson(tmp)
+    expect(result).toEqual(pkg)
+  })
+
+  it('throws when package.json is invalid JSON', () => {
+    fs.writeFileSync(path.join(tmp, 'package.json'), 'not valid json')
+
+    expect(() => checkPackageJson(tmp)).toThrow(/invalid or cannot be parsed/)
+  })
+})
+
+describe('checkReactNativeProject', () => {
+  let consoleLogSpy
+
+  beforeEach(() => {
+    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+  })
+
+  afterEach(() => {
+    consoleLogSpy.mockRestore()
+  })
+
+  it('warns when react-native is not in dependencies', () => {
+    const pkg = { dependencies: {} }
+    checkReactNativeProject(pkg)
+
+    expect(consoleLogSpy).toHaveBeenCalledWith(
+      expect.stringContaining('react-native or expo not found')
+    )
+  })
+
+  it('does not warn when react-native is present', () => {
+    const pkg = { dependencies: { 'react-native': '0.80.0' } }
+    checkReactNativeProject(pkg)
+
+    expect(consoleLogSpy).not.toHaveBeenCalledWith(
+      expect.stringContaining('react-native or expo not found')
+    )
+  })
+
+  it('does not warn when expo is present', () => {
+    const pkg = { dependencies: { expo: '~54.0.0' } }
+    checkReactNativeProject(pkg)
+
+    expect(consoleLogSpy).not.toHaveBeenCalledWith(
+      expect.stringContaining('react-native or expo not found')
+    )
+  })
+
+  it('checks devDependencies too', () => {
+    const pkg = { devDependencies: { 'react-native': '0.80.0' } }
+    checkReactNativeProject(pkg)
+
+    expect(consoleLogSpy).not.toHaveBeenCalledWith(
+      expect.stringContaining('react-native or expo not found')
+    )
+  })
+})
+
+describe('checkBabelConfig', () => {
+  let tmp
+
+  beforeEach(() => {
+    tmp = makeTmpDir()
+  })
+
+  afterEach(() => {
+    cleanTmpDir(tmp)
+  })
+
+  it('returns path to babel.config.js when it exists', () => {
+    const babelPath = path.join(tmp, 'babel.config.js')
+    fs.writeFileSync(babelPath, 'module.exports = {}')
+
+    const result = checkBabelConfig(tmp)
+    expect(result).toBe(babelPath)
+  })
+
+  it('returns path to .babelrc when it exists', () => {
+    const babelPath = path.join(tmp, '.babelrc')
+    fs.writeFileSync(babelPath, '{}')
+
+    const result = checkBabelConfig(tmp)
+    expect(result).toBe(babelPath)
+  })
+
+  it('returns null when no babel config exists', () => {
+    const result = checkBabelConfig(tmp)
+    expect(result).toBeNull()
+  })
+
+  it('prefers babel.config.js over .babelrc', () => {
+    const jsPath = path.join(tmp, 'babel.config.js')
+    const rcPath = path.join(tmp, '.babelrc')
+    fs.writeFileSync(jsPath, 'module.exports = {}')
+    fs.writeFileSync(rcPath, '{}')
+
+    const result = checkBabelConfig(tmp)
+    expect(result).toBe(jsPath)
+  })
+})
+
+describe('checkNativeWindInBabel', () => {
+  let tmp
+  let consoleLogSpy
+
+  beforeEach(() => {
+    tmp = makeTmpDir()
+    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+  })
+
+  afterEach(() => {
+    cleanTmpDir(tmp)
+    consoleLogSpy.mockRestore()
+  })
+
+  it('returns false and warns when babel config not found', () => {
+    const result = checkNativeWindInBabel(tmp)
+
+    expect(result).toBe(false)
+    expect(consoleLogSpy).toHaveBeenCalledWith(
+      expect.stringContaining('babel.config.js not found')
+    )
+  })
+
+  it('returns true when nativewind/babel is found', () => {
+    const babelPath = path.join(tmp, 'babel.config.js')
+    fs.writeFileSync(
+      babelPath,
+      'module.exports = { plugins: ["nativewind/babel"] }'
+    )
+
+    const result = checkNativeWindInBabel(tmp)
+    expect(result).toBe(true)
+  })
+
+  it('returns false and warns when nativewind/babel is not found', () => {
+    const babelPath = path.join(tmp, 'babel.config.js')
+    fs.writeFileSync(babelPath, 'module.exports = { plugins: [] }')
+
+    const result = checkNativeWindInBabel(tmp)
+
+    expect(result).toBe(false)
+    expect(consoleLogSpy).toHaveBeenCalledWith(
+      expect.stringContaining('NativeWind not detected in Babel config')
+    )
+  })
+
+  it('handles babel config read errors gracefully', () => {
+    const babelPath = path.join(tmp, 'babel.config.js')
+    fs.writeFileSync(babelPath, 'module.exports = {}')
+    fs.chmodSync(babelPath, 0o000) // Make unreadable
+
+    const result = checkNativeWindInBabel(tmp)
+
+    expect(result).toBe(false)
+
+    // Cleanup
+    fs.chmodSync(babelPath, 0o644)
+  })
+})
+
+describe('checkReactNativeVersion', () => {
+  let consoleLogSpy
+
+  beforeEach(() => {
+    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+  })
+
+  afterEach(() => {
+    consoleLogSpy.mockRestore()
+  })
+
+  it('returns true for React Native 0.72+', () => {
+    const pkg = { dependencies: { 'react-native': '0.72.0' } }
+    const result = checkReactNativeVersion(pkg)
+
+    expect(result).toBe(true)
+    expect(consoleLogSpy).not.toHaveBeenCalledWith(
+      expect.stringContaining('React Native version is below 0.72')
+    )
+  })
+
+  it('returns true for React Native 0.80+', () => {
+    const pkg = { dependencies: { 'react-native': '0.80.5' } }
+    const result = checkReactNativeVersion(pkg)
+
+    expect(result).toBe(true)
+  })
+
+  it('warns for React Native < 0.72', () => {
+    const pkg = { dependencies: { 'react-native': '0.71.0' } }
+    const result = checkReactNativeVersion(pkg)
+
+    expect(result).toBe(false)
+    expect(consoleLogSpy).toHaveBeenCalledWith(
+      expect.stringContaining('React Native version is below 0.72')
+    )
+  })
+
+  it('returns true when react-native not in dependencies', () => {
+    const pkg = { dependencies: {} }
+    const result = checkReactNativeVersion(pkg)
+
+    expect(result).toBe(true)
+  })
+
+  it('handles version with caret (^)', () => {
+    const pkg = { dependencies: { 'react-native': '^0.72.0' } }
+    const result = checkReactNativeVersion(pkg)
+
+    expect(result).toBe(true)
+  })
+
+  it('handles version with tilde (~)', () => {
+    const pkg = { dependencies: { 'react-native': '~0.80.0' } }
+    const result = checkReactNativeVersion(pkg)
+
+    expect(result).toBe(true)
+  })
+})
+
+describe('checkNativeWindVersion', () => {
+  let consoleLogSpy
+
+  beforeEach(() => {
+    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+  })
+
+  afterEach(() => {
+    consoleLogSpy.mockRestore()
+  })
+
+  it('returns false and warns when nativewind not found', () => {
+    const pkg = { dependencies: {} }
+    const result = checkNativeWindVersion(pkg)
+
+    expect(result).toBe(false)
+    expect(consoleLogSpy).toHaveBeenCalledWith(
+      expect.stringContaining('NativeWind not found in package.json')
+    )
+  })
+
+  it('returns true for NativeWind 4.x', () => {
+    const pkg = { dependencies: { nativewind: '^4.0.0' } }
+    const result = checkNativeWindVersion(pkg)
+
+    expect(result).toBe(true)
+  })
+
+  it('returns true for NativeWind 5.x', () => {
+    const pkg = { dependencies: { nativewind: '^5.0.0' } }
+    const result = checkNativeWindVersion(pkg)
+
+    expect(result).toBe(true)
+  })
+
+  it('warns for NativeWind < 4', () => {
+    const pkg = { dependencies: { nativewind: '^3.0.0' } }
+    const result = checkNativeWindVersion(pkg)
+
+    expect(result).toBe(false)
+    expect(consoleLogSpy).toHaveBeenCalledWith(
+      expect.stringContaining('NativeWind version is below 4.0')
+    )
+  })
+
+  it('checks devDependencies', () => {
+    const pkg = { devDependencies: { nativewind: '^4.0.0' } }
+    const result = checkNativeWindVersion(pkg)
+
+    expect(result).toBe(true)
+  })
+})
+
+describe('runInitPreflightChecks', () => {
+  let tmp
+  let consoleLogSpy
+
+  beforeEach(() => {
+    tmp = makeTmpDir()
+    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {})
+  })
+
+  afterEach(() => {
+    cleanTmpDir(tmp)
+    consoleLogSpy.mockRestore()
+  })
+
+  it('runs all checks successfully for valid setup', () => {
+    fs.writeFileSync(
+      path.join(tmp, 'package.json'),
+      JSON.stringify({
+        dependencies: {
+          'react-native': '0.80.0',
+          nativewind: '^4.0.0',
+        },
+      })
+    )
+    fs.writeFileSync(
+      path.join(tmp, 'babel.config.js'),
+      'module.exports = { plugins: ["nativewind/babel"] }'
+    )
+
+    expect(() => runInitPreflightChecks(tmp)).not.toThrow()
+  })
+
+  it('throws when package.json is missing', () => {
+    expect(() => runInitPreflightChecks(tmp)).toThrow(/package.json not found/)
+  })
+})
+
+describe('runAddPreflightChecks', () => {
+  let tmp
+
+  beforeEach(() => {
+    tmp = makeTmpDir()
+  })
+
+  afterEach(() => {
+    cleanTmpDir(tmp)
+  })
+
+  it('returns package json on success', () => {
+    const pkg = { name: 'test', version: '1.0.0' }
+    fs.writeFileSync(path.join(tmp, 'package.json'), JSON.stringify(pkg))
+
+    const result = runAddPreflightChecks(tmp)
+    expect(result).toEqual(pkg)
+  })
+
+  it('throws when package.json is missing', () => {
+    expect(() => runAddPreflightChecks(tmp)).toThrow(/package.json not found/)
+  })
+})

package/src/__tests__/version-check.test.js

@@ -0,0 +1,58 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
+import { getVersionInfo } from '../utils/version-check.js'
+import { getCliVersion } from '../utils/version.js'
+
+describe('getVersionInfo', () => {
+  it('returns cli and node versions', () => {
+    const info = getVersionInfo()
+    
+    expect(info).toHaveProperty('cli')
+    expect(info).toHaveProperty('node')
+    expect(typeof info.cli).toBe('string')
+    expect(typeof info.node).toBe('string')
+  })
+
+  it('includes valid node version format', () => {
+    const info = getVersionInfo()
+    expect(info.node).toMatch(/^v\d+\.\d+\.\d+/)
+  })
+
+  it('includes valid cli version or unknown', () => {
+    const info = getVersionInfo()
+    expect(info.cli).toMatch(/^\d+\.\d+\.\d+|unknown/)
+  })
+
+  it('matches current node version', () => {
+    const info = getVersionInfo()
+    expect(info.node).toBe(process.version)
+  })
+
+  it('matches getCliVersion output', () => {
+    const info = getVersionInfo()
+    const cliVersion = getCliVersion()
+    expect(info.cli).toBe(cliVersion)
+  })
+})
+
+// Note: Testing checkForUpdates is complex due to async nature and external dependencies
+// These tests would require mocking fs, fetch, and time-based caching
+// For production, integration tests would be more appropriate
+describe('version checking (unit tests)', () => {
+  it('version comparison logic works correctly', () => {
+    // This tests the internal compareVersions logic indirectly
+    // by ensuring version info is structured correctly
+    const info = getVersionInfo()
+    
+    expect(info.cli).toBeDefined()
+    expect(info.node).toBeDefined()
+    
+    // Versions should be parseable
+    if (info.cli !== 'unknown') {
+      const parts = info.cli.split('.')
+      expect(parts.length).toBeGreaterThanOrEqual(3)
+      parts.forEach(part => {
+        expect(parseInt(part, 10)).not.toBeNaN()
+      })
+    }
+  })
+})

package/src/bin.js

@@ -1,27 +1,29 @@
 #!/usr/bin/env node
 
-import fs from 'node:fs'
-import { fileURLToPath } from 'node:url'
-import { Command } from 'commander'
-import pc from 'picocolors'
+import { Command } from 'commander';
+import fs from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import pc from 'picocolors';
 
 // ─── Module imports ──────────────────────────────────────────────────────────
 
-import { DEFAULT_CONFIG, UTILS_CONTENT, CONFIG_FILENAME } from './constants.js'
-import { ensureDir, writeIfNotExists } from './utils/fs-helpers.js'
-import { loadConfig, writeConfig } from './utils/config.js'
-import { detectPackageManager, installPackages, getInstallHint, getMissingDeps } from './utils/deps.js'
-import { fetchWithTimeout, formatError } from './utils/fetch.js'
-import { getCliVersion } from './utils/version.js'
-import { getTailwindConfigContent } from './utils/tailwind.js'
-import { assertValidComponentConfig } from './utils/validate.js'
-import { init, askTheme, ASCII_BANNER } from './commands/init.js'
-import { add, pickComponentsInteractively } from './commands/add.js'
-import { getThemeCssContent } from './themes/index.js'
+import { getThemeCssContent } from './themes/index.js';
+import { add, pickComponentsInteractively } from './commands/add.js';
+import { ASCII_BANNER, askTheme, init } from './commands/init.js';
+import { CONFIG_FILENAME, DEFAULT_CONFIG, DEFAULT_THEME_CSS, UTILS_CONTENT } from './constants.js';
+import { loadConfig, writeConfig } from './utils/config.js';
+import { detectPackageManager, getInstallHint, getMissingDeps } from './utils/deps.js';
+import { fetchWithTimeout, formatError } from './utils/fetch.js';
+import { ensureDir, writeIfNotExists } from './utils/fs-helpers.js';
+import { getTailwindConfigContent } from './utils/tailwind.js';
+import { assertValidComponentConfig } from './utils/validate.js';
+import { getCliVersion } from './utils/version.js';
+import { checkForUpdates } from './utils/version-check.js';
 
 // ─── Derived constants ───────────────────────────────────────────────────────
 
-export const GLOBAL_CSS_CONTENT = getThemeCssContent(DEFAULT_CONFIG.theme)
+// Export default theme CSS for backward compatibility (tests)
+export const GLOBAL_CSS_CONTENT = DEFAULT_THEME_CSS;
 
 // ─── Re-exports (backward compatibility for tests) ───────────────────────────
 
@@ -37,35 +39,38 @@ export {
   formatError,
   getCliVersion,
   getInstallHint,
-  getThemeCssContent,
   getMissingDeps,
   getTailwindConfigContent,
+  getThemeCssContent,
   init,
   loadConfig,
   UTILS_CONTENT,
   writeConfig,
   writeIfNotExists,
-}
+};
 
 // ─── CLI entry point ─────────────────────────────────────────────────────────
 
 const isDirectRun = (() => {
-  if (!process.argv[1]) return false
+  if (!process.argv[1]) return false;
   try {
-    return fs.realpathSync(process.argv[1]) === fileURLToPath(import.meta.url)
+    return fs.realpathSync(process.argv[1]) === fileURLToPath(import.meta.url);
   } catch {
-    return process.argv[1].endsWith('/bin.js')
+    return process.argv[1].endsWith('/bin.js');
   }
-})()
+})();
 
 if (isDirectRun) {
-  const program = new Command()
+  const program = new Command();
 
   program
     .name('novaui')
     .description('NovaUI – React Native + NativeWind UI component library')
     .version(getCliVersion(), '-v, --version', 'Show CLI version')
     .addHelpText('beforeAll', ASCII_BANNER)
+    .hook('preAction', async () => {
+      await checkForUpdates().catch(() => {});
+    });
 
   // ─── init ─────────────────────────────────────────────────────────────────
 
@@ -73,15 +78,15 @@ if (isDirectRun) {
     .command('init')
     .description('Set up NovaUI (config, Tailwind, global.css, utils)')
     .option('-y, --yes', 'Skip prompts and use default configuration')
-    .action(async options => {
+    .action(async (options) => {
       try {
-        await init({ yes: options.yes })
+        await init({ yes: options.yes });
       } catch (error) {
-        console.error('')
-        console.error(pc.red(`  ✗  Error: ${formatError(error)}`))
-        process.exit(1)
+        console.error('');
+        console.error(pc.red(`  ✗  Error: ${formatError(error)}`));
+        process.exit(1);
       }
-    })
+    });
 
   // ─── add ──────────────────────────────────────────────────────────────────
 
@@ -90,39 +95,39 @@ if (isDirectRun) {
     .description('Add one or more components (e.g. button card input)')
     .option('--force', 'Overwrite existing component files')
     .action(async (components, options) => {
-      const force = options.force || false
+      const force = options.force || false;
       try {
         if (components.length === 0) {
           if (process.stdin.isTTY !== true) {
-            throw new Error('Missing component name. Usage: novaui add <component-name>')
+            throw new Error('Missing component name. Usage: novaui add <component-name>');
           }
           // Interactive multi-select when no component names given
-          const selected = await pickComponentsInteractively()
+          const selected = await pickComponentsInteractively();
           for (const name of selected) {
-            await add(name, { force })
+            await add(name, { force });
           }
         } else {
           // Support batch: novaui add button card input
           for (const name of components) {
-            await add(name, { force })
+            await add(name, { force });
           }
         }
       } catch (error) {
-        console.error('')
-        console.error(pc.red(`  ✗  Error: ${formatError(error)}`))
-        process.exit(1)
+        console.error('');
+        console.error(pc.red(`  ✗  Error: ${formatError(error)}`));
+        process.exit(1);
       }
-    })
+    });
 
   // ─── Default: show help when no command given ─────────────────────────────
 
   program.action(() => {
-    program.help()
-  })
-
-  program.parseAsync(process.argv).catch(error => {
-    console.error('')
-    console.error(pc.red(`  ✗  Error: ${formatError(error)}`))
-    process.exit(1)
-  })
+    program.help();
+  });
+
+  program.parseAsync(process.argv).catch((error) => {
+    console.error('');
+    console.error(pc.red(`  ✗  Error: ${formatError(error)}`));
+    process.exit(1);
+  });
 }