novahiz 0.3.4 → 0.3.5

package/adapters/opencode/novahiz.ts

@@ -409,9 +409,13 @@ const GATE_TOOLS = new Set(
 type RunResult = { status: number; stdout: string; stderr: string; spawnError?: string };
 
 // C1: timeout prevents a hung CLI from freezing the whole OpenCode process.
+// Raised 10 s -> 30 s (audit 2026-09-25, MEDIUM): gate/CLI runs legitimately
+// exceeded 10 s on 23-24/09 and the cap turned them into 14 spurious
+// fail-closed refusals. Still bounded, so a truly hung CLI cannot freeze
+// OpenCode for more than 30 s.
 // C2: maxBuffer caps output; oversized output is treated as a gate failure,
 // never as truncated-then-allowed.
-const RUN_TIMEOUT_MS = 10_000;
+const RUN_TIMEOUT_MS = 30_000;
 const RUN_MAX_BUFFER = 1_048_576;
 
 function run(args: string[], input?: string): RunResult {

package/dist/memory.js

@@ -390,6 +390,7 @@ export function listSlots(root) {
     return ensureMemoryRoot(dir);
 }
 export function getSlot(id, root) {
+    assertSlotId(id);
     const dir = root && root.length > 0 ? root : memoryRoot();
     const index = ensureMemoryRoot(dir);
     const meta = index.slots.find((slot) => slot.id === id);
@@ -423,6 +424,21 @@ export function rebuildIndex(root) {
     slots.sort((a, b) => a.id.localeCompare(b.id));
     return writeIndex(root, { version: 1, updated: nowIso(), slots });
 }
+const SLOT_ID_MAX_LEN = 128;
+// Audit 2026-09-25, LOW: slot ids are index keys, not paths — they must never
+// carry path segments. getSlot/parseSlotInput already refuse unknown ids via
+// E_SLOT; this adds an explicit format check so a crafted id fails on its own
+// terms (defense in depth, and a clearer error than "slot inconnu").
+export function assertSlotId(id) {
+    const hasPathChar = [...id].some((ch) => {
+        const c = ch.charCodeAt(0);
+        return c === 47 || c === 92 || c === 0;
+    });
+    if (id.length === 0 || id.length > SLOT_ID_MAX_LEN || id.includes("..") || hasPathChar) {
+        throw memError("E_SLOT_ID", `Invalid params: slot id illégal: ${JSON.stringify(id)}`);
+    }
+    return id;
+}
 export function parseSlotInput(args) {
     const title = typeof args?.title === "string" ? args.title : "";
     const content = typeof args?.content === "string" ? args.content : "";
@@ -435,7 +451,7 @@ export function parseSlotInput(args) {
         content,
         description: typeof args?.description === "string" ? args.description : undefined,
         tags: Array.isArray(args?.tags) ? args.tags.map(String) : undefined,
-        slotId: typeof args?.slotId === "string" ? args.slotId : undefined,
+        slotId: typeof args?.slotId === "string" ? assertSlotId(args.slotId) : undefined,
         root: typeof args?.root === "string" ? args.root : undefined
     };
 }

package/install/bootstrap.mjs

@@ -87,7 +87,7 @@ function generateOpenCodeJson(configDir, NovahizHome) {
     mcp: {
       context7: {
         type: "local",
-        command: ["context7-mcp", "--transport", "stdio"],
+        command: ["npx", "-y", "@upstash/context7-mcp@4.1.1", "--transport", "stdio"],
         enabled: true,
       },
       narsil: {
@@ -100,7 +100,7 @@ function generateOpenCodeJson(configDir, NovahizHome) {
       // (scheduler-mcp local venv); no npm install, no template entry.
       playwright: {
         type: "local",
-        command: ["npx", "@playwright/mcp@latest", "--browser=msedge"],
+        command: ["npx", "-y", "@playwright/mcp@0.0.82", "--browser=msedge"],
         enabled: true,
       },
       dart: {
@@ -189,10 +189,11 @@ async function main() {
   log("");
   log("Installing MCP servers...");
   const mcpServers = [
-    { pkg: "@upstash/context7-mcp", bin: "context7-mcp" },
     { pkg: "narsil-mcp", bin: "narsil-mcp" },
     { pkg: "security-mcp", bin: "security-mcp" },
   ];
+  // context7 is invoked via `npx -y @upstash/context7-mcp@4.1.1` (pinned in
+  // the generated config), so no global shim is installed for it.
   // `cron` has no npm package: the plugin registers it from catalog/providers.json
   // (scheduler-mcp local venv, see docs/PROVIDERS.md). Disabled by default in
   // fresh configs — users opt in explicitly.

package/install/install.mjs

@@ -296,10 +296,11 @@ async function main() {
 
   // Install MCP servers globally
   const mcpServers = [
-    { pkg: "@upstash/context7-mcp", bin: "context7-mcp", name: "context7" },
     { pkg: "narsil-mcp", bin: "narsil-mcp", name: "narsil" },
     { pkg: "security-mcp", bin: "security-mcp", name: "security" },
   ];
+  // context7 is invoked via `npx -y @upstash/context7-mcp@4.1.1` (pinned in
+  // the generated config), so no global shim is installed for it.
   // `cron` has no npm package and ships disabled (local scheduler clone only);
   // enable it after the local setup documented in docs/PROVIDERS.md.
 
@@ -393,7 +394,7 @@ async function main() {
         "mcp": {
           "context7": {
             "type": "local",
-            "command": ["context7-mcp", "--transport", "stdio"],
+            "command": ["npx", "-y", "@upstash/context7-mcp@4.1.1", "--transport", "stdio"],
             "enabled": true
           },
           "narsil": {
@@ -406,7 +407,7 @@ async function main() {
           // after the local scheduler clone setup (docs/PROVIDERS.md).
           "playwright": {
             "type": "local",
-            "command": ["npx", "@playwright/mcp@latest", "--browser=msedge"],
+            "command": ["npx", "-y", "@playwright/mcp@0.0.82", "--browser=msedge"],
             "enabled": true
           },
           "dart": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "novahiz",
-  "version": "0.3.4",
+  "version": "0.3.5",
   "description": "Enforce AI agent skills before every file edit: prompt classifier, skill catalog, and pre-edit gate.",
   "type": "module",
   "license": "Apache-2.0",

package/src/memory.ts

@@ -465,6 +465,7 @@ export function listSlots(root?: string): MemoryIndex {
 }
 
 export function getSlot(id: string, root?: string): SlotFile {
+  assertSlotId(id);
   const dir = root && root.length > 0 ? root : memoryRoot();
   const index = ensureMemoryRoot(dir);
   const meta = index.slots.find((slot) => slot.id === id);
@@ -499,6 +500,23 @@ export function rebuildIndex(root: string): MemoryIndex {
   return writeIndex(root, { version: 1, updated: nowIso(), slots });
 }
 
+const SLOT_ID_MAX_LEN = 128;
+
+// Audit 2026-09-25, LOW: slot ids are index keys, not paths — they must never
+// carry path segments. getSlot/parseSlotInput already refuse unknown ids via
+// E_SLOT; this adds an explicit format check so a crafted id fails on its own
+// terms (defense in depth, and a clearer error than "slot inconnu").
+export function assertSlotId(id: string): string {
+  const hasPathChar = [...id].some((ch) => {
+    const c = ch.charCodeAt(0);
+    return c === 47 || c === 92 || c === 0;
+  });
+  if (id.length === 0 || id.length > SLOT_ID_MAX_LEN || id.includes("..") || hasPathChar) {
+    throw memError("E_SLOT_ID", `Invalid params: slot id illégal: ${JSON.stringify(id)}`);
+  }
+  return id;
+}
+
 export function parseSlotInput(args: Record<string, unknown>): WriteEntryInput {
   const title = typeof args?.title === "string" ? args.title : "";
   const content = typeof args?.content === "string" ? args.content : "";
@@ -509,7 +527,7 @@ export function parseSlotInput(args: Record<string, unknown>): WriteEntryInput {
     content,
     description: typeof args?.description === "string" ? args.description : undefined,
     tags: Array.isArray(args?.tags) ? args.tags.map(String) : undefined,
-    slotId: typeof args?.slotId === "string" ? args.slotId : undefined,
+    slotId: typeof args?.slotId === "string" ? assertSlotId(args.slotId) : undefined,
     root: typeof args?.root === "string" ? args.root : undefined
   };
 }