nothumanallowed 16.0.47 → 16.0.49

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nothumanallowed",
-  "version": "16.0.47",
+  "version": "16.0.49",
   "description": "Local AI assistant: 80 tools (Gmail, Calendar, Drive, GitHub, Slack, browser, code, files), 38 agents, visual workflows (Studio, AWF, WebCraft). Install with `npm i -g nothumanallowed`, run with `nha ui`. Free tier built-in (Liara), no API key required. Your data stays on your PC — OAuth tokens local, no cloud. Open-source MIT.",
   "type": "module",
   "bin": {

package/src/constants.mjs

@@ -5,7 +5,7 @@ import { fileURLToPath } from 'url';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 
-export const VERSION = '16.0.47';
+export const VERSION = '16.0.49';
 export const BASE_URL = 'https://nothumanallowed.com/cli';
 export const API_BASE = 'https://nothumanallowed.com/api/v1';
 

package/src/server/routes/webcraft.mjs

@@ -1286,7 +1286,9 @@ RULES:
         return 'OK — edit applied (fuzzy match)';
       }
       emit({ type: 'tool', op: 'edit', path: relPath, result: 'old_not_found' });
-      return 'Error: old_text not found in file. Use read_file to see the EXACT current content, copy the exact lines, and retry.';
+      // Include the actual file content in the error response so the LLM can
+      // produce a correct old_text on retry without needing a separate read_file.
+      return `Error: old_text not found in file.\n\nCURRENT CONTENT OF ${relPath}:\n\`\`\`\n${src.slice(0, 16000)}\n\`\`\`\n\nPick the EXACT lines you want to replace from above, copy them as old_text, and retry edit_file.`;
     }
 
     if (toolName === 'create_file') {
@@ -1562,8 +1564,18 @@ After ALL fixes are done, emit <done/> on its own line.
             toolResults.push({ op: 'edit', path: relPath, result: 'ok' });
             emit({ type: 'tool', op: 'edit', path: relPath, result: 'ok', oldSnippet: oldStr.slice(0, 2000), newSnippet: newStr?.slice(0, 2000) });
           } else {
-            // No match — return error, let the agent retry with correct text
-            toolResults.push({ op: 'edit', path: relPath, result: 'old_not_found — your old text does not match the file. Use read tool to see the EXACT current content, then copy-paste the exact lines and retry.' });
+            // No match — auto-read the file and INCLUDE its content in the
+            // feedback. Without this, the LLM at the next step is blind and
+            // can't correct the old_text. Critical fix for text-based mode
+            // where the LLM doesn't see tool results between calls.
+            const fileContentForRetry = src.slice(0, 16000);
+            toolResults.push({
+              op: 'edit',
+              path: relPath,
+              result: 'old_not_found',
+              hint: 'Your old_text did NOT match the file. The CURRENT file content is included below — copy the EXACT lines you want to replace and retry edit with that exact text as old.',
+              content: fileContentForRetry,
+            });
             emit({ type: 'tool', op: 'edit', path: relPath, result: 'old_not_found', oldSnippet: oldStr.slice(0, 200) });
           }
         }
@@ -1825,11 +1837,16 @@ After ALL fixes are done, emit <done/> on its own line.
       break;
     }
 
-    // Build tool results feedback for next iteration
+    // Build tool results feedback for next iteration.
+    // CRITICAL: when edit fails with old_not_found, include the CURRENT
+    // file content so the LLM can produce a correct old_text on retry.
+    // Without this, text-based mode loops forever on the same wrong old_text.
     const feedbackParts = toolResults.map((r) => {
       let msg = `[${r.op}] ${r.path || ''}: ${r.result}`;
-      if (r.op === 'read' && r.content) msg += `\n\`\`\`\n${r.content}\n\`\`\``;
-      if (r.hint) msg += ` — ${r.hint}`;
+      if (r.hint) msg += `\n  HINT: ${r.hint}`;
+      if (r.content) {
+        msg += `\n\nCURRENT CONTENT OF ${r.path}:\n\`\`\`\n${r.content}\n\`\`\`\n\nTo fix: pick the exact lines you want to replace from above, use them as "old", and retry the edit.`;
+      }
       return msg;
     });
 
@@ -3146,48 +3163,59 @@ export function register(router) {
   }
 
   router.post('/api/studio/webcraft/lint', async (req, res) => {
+    // ROBUST lint endpoint — NEVER returns 500. If any linter crashes,
+    // returns 200 with empty diagnostics + the error logged. A failed lint
+    // must not break the IDE streaming flow.
     try {
       const { projectName, path: relPath } = await parseBody(req);
       if (!projectName || !relPath) return sendError(res, 400, 'projectName and path required');
-      const content = ProjectStore.readFile(projectName, relPath);
-      if (content === null) return sendJSON(res, 200, { diagnostics: [] });
+      let content;
+      try { content = ProjectStore.readFile(projectName, relPath); }
+      catch { content = null; }
+      if (content === null || content === undefined) return sendJSON(res, 200, { diagnostics: [] });
 
       const ext = (relPath.split('.').pop() || '').toLowerCase();
       let diagnostics = [];
 
-      // JavaScript / JSX — try TypeScript checkJs first, fallback to acorn
+      // Each linter wrapped individually — a crash in one doesn't kill the others
       if (['js', 'mjs', 'jsx', 'cjs'].includes(ext)) {
-        const projectDir = ProjectStore.dir(projectName);
-        const tsDiags = await lintJSWithTypeScript(projectDir, relPath);
-        diagnostics = tsDiags || lintJS(content, relPath, projectName);
-      }
-
-      // JSON — parse errors with precise location
-      if (ext === 'json') {
-        try { JSON.parse(content); } catch (e) {
-          const posMatch = e.message.match(/position (\d+)/i);
-          const pos = posMatch ? parseInt(posMatch[1]) : 0;
-          const before = content.slice(0, pos).split('\n');
-          diagnostics.push({
-            from: { line: before.length, col: (before[before.length - 1] || '').length },
-            severity: 'error',
-            message: e.message,
-          });
+        try {
+          const projectDir = ProjectStore.dir(projectName);
+          const tsDiags = await lintJSWithTypeScript(projectDir, relPath).catch(() => null);
+          diagnostics = tsDiags || lintJS(content, relPath, projectName) || [];
+        } catch (e) {
+          console.error('[lint] JS linter crashed for', relPath, ':', e.message);
+          diagnostics = [];
         }
-      }
-
-      // CSS — brace balance + property validation
-      if (ext === 'css') {
-        diagnostics = lintCSS(content);
-      }
-
-      // HTML/HTM — tag balance + reference validation
-      if (ext === 'html' || ext === 'htm') {
-        diagnostics = lintHTML(content, relPath, projectName);
+      } else if (ext === 'json') {
+        try {
+          JSON.parse(content);
+        } catch (e) {
+          try {
+            const posMatch = e.message.match(/position (\d+)/i);
+            const pos = posMatch ? parseInt(posMatch[1]) : 0;
+            const before = content.slice(0, pos).split('\n');
+            diagnostics.push({
+              from: { line: before.length, col: (before[before.length - 1] || '').length },
+              severity: 'error',
+              message: e.message,
+            });
+          } catch {}
+        }
+      } else if (ext === 'css') {
+        try { diagnostics = lintCSS(content) || []; }
+        catch (e) { console.error('[lint] CSS linter crashed:', e.message); diagnostics = []; }
+      } else if (ext === 'html' || ext === 'htm') {
+        try { diagnostics = lintHTML(content, relPath, projectName) || []; }
+        catch (e) { console.error('[lint] HTML linter crashed:', e.message); diagnostics = []; }
       }
 
       sendJSON(res, 200, { diagnostics });
-    } catch (e) { sendError(res, 500, e.message); }
+    } catch (e) {
+      // Even the outer catch returns 200 — lint failures must not break the IDE
+      console.error('[lint] outer error:', e.message);
+      sendJSON(res, 200, { diagnostics: [], error: e.message });
+    }
   });
 
   // ── File write (from IDE editor) ──────────────────────────────────────────