nothumanallowed 15.1.30 → 15.1.32

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nothumanallowed",
-  "version": "15.1.30",
+  "version": "15.1.32",
   "description": "NotHumanAllowed — 38 AI agents, 80 tools, Studio (visual agentic workflows). Email, calendar, browser automation, screen capture, canvas, cron/heartbeat, Alexandria E2E messaging, GitHub, Notion, Slack, voice chat, free AI (Liara), 28 languages. Zero-dependency CLI.",
   "type": "module",
   "bin": {

package/src/constants.mjs

@@ -5,7 +5,7 @@ import { fileURLToPath } from 'url';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 
-export const VERSION = '15.1.30';
+export const VERSION = '15.1.32';
 export const BASE_URL = 'https://nothumanallowed.com/cli';
 export const API_BASE = 'https://nothumanallowed.com/api/v1';
 

package/src/server/routes/webcraft.mjs

@@ -14,9 +14,15 @@
 
 import fs   from 'fs';
 import path from 'path';
-import { exec, spawn } from 'child_process';
-import { createServer } from 'net';
+import { exec, spawn, execSync } from 'child_process';
+import { createServer, Socket } from 'net';
 import { promisify } from 'util';
+import { createRequire } from 'module';
+// `require` shim for the rare spots where CJS-style require() was historically
+// used in this ESM file. Without this, every `require(...)` here throws
+// "ReferenceError: require is not defined" — which is exactly the bug that
+// took 31 releases to diagnose because it surfaced in the SSE error channel.
+const require = createRequire(import.meta.url);
 import { sendJSON, sendError, parseBody, sendSSE } from '../index.mjs';
 import { loadConfig }   from '../../config.mjs';
 import { callLLM, callLLMStream, callLLMWithTools, getApiKey, fixQwen3BPE } from '../../services/llm.mjs';
@@ -227,6 +233,15 @@ class SandboxManager {
       if (line) emit({ type: 'log', msg: `[stderr] ${line}` });
     });
 
+    // Capture spawn-level errors (e.g. ENOENT on 'node', permission denied).
+    // Without this handler, Node would throw an unhandled 'error' event and
+    // the whole nha ui process could die silently. This is the missing path
+    // that produced the "[error] require is not defined" with no autofix flow.
+    proc.on('error', (err) => {
+      stderrBuf += `\n[spawn error] ${err.message}\n${err.stack || ''}\n`;
+      emit({ type: 'warn', msg: `[spawn error] ${err.code || ''} ${err.message}` });
+    });
+
     // Wait for exit or healthy
     const exitPromise = new Promise((resolve) => {
       proc.once('exit', (code) => {
@@ -266,14 +281,14 @@ class SandboxManager {
       emit({ type: 'warn', msg: 'Crash handling skipped: _stoppedByUser=true (user pressed Stop, or previous stop() leaked the flag). If this is unexpected, restart nha ui to pick up the latest fix.' });
       return;
     }
-    emit({ type: 'status', msg: `Process exited with code ${exitCode}` });
+    emit({ type: 'status', msg: `Process exited with code ${exitCode} (attempt ${_attempt}/${MAX_RETRIES})` });
     // Surface the captured stderr right away so the user sees the REAL error
     // (not just the post-Tier-2 summary). This is the diagnostic gold.
     if (stderrBuf && stderrBuf.trim()) {
-      const stderrSnippet = stderrBuf.split('\n').slice(0, 12).join('\n');
-      emit({ type: 'log', msg: `[stderr captured]\n${stderrSnippet}` });
+      const stderrSnippet = stderrBuf.split('\n').slice(0, 20).join('\n');
+      emit({ type: 'log', msg: `[stderr full capture, ${stderrBuf.length} bytes]\n${stderrSnippet}` });
     } else {
-      emit({ type: 'warn', msg: 'Process exited but no stderr was captured — exit may have been instant.' });
+      emit({ type: 'warn', msg: 'Process exited but stderr is EMPTY — could be: process killed by OS, spawn failed before any output, or stdio mis-routed. Run "node .nha-launcher.js" manually in the project dir to reproduce.' });
     }
 
     // ── Tier 1: missing module → npm install + retry ─────────────────────
@@ -318,6 +333,14 @@ class SandboxManager {
     ];
 
     const matchedPattern = runtimePatterns.find(p => p.re.test(stderrBuf));
+    // ALWAYS log the autofix decision, so the user can see why Tier 2 fires
+    // or doesn't fire. Previous versions emitted nothing when matchedPattern
+    // was undefined — leaving the user confused why no autofix ran.
+    if (!matchedPattern) {
+      emit({ type: 'warn', msg: `Auto-fix: no known runtime pattern matched in stderr. Patterns checked: ${runtimePatterns.map(p => p.name).join(', ')}. stderr starts with: "${stderrBuf.slice(0, 200).replace(/\n/g, ' ⏎ ')}"` });
+    } else if (_attempt >= MAX_RETRIES) {
+      emit({ type: 'warn', msg: `Auto-fix: pattern "${matchedPattern.name}" matched but MAX_RETRIES (${MAX_RETRIES}) reached. Stopping.` });
+    }
     if (matchedPattern && _attempt < MAX_RETRIES) {
       emit({ type: 'phase', phase: 'autofix', msg: `Runtime error detected: ${matchedPattern.name} — analyzing...` });
 
@@ -2393,9 +2416,9 @@ export function register(router) {
       path.resolve(__dir, '../../../node_modules/.bin/tsc'),
       path.resolve(__dir, '../../../../node_modules/.bin/tsc'),
     ];
-    // Also try global
+    // Also try global — execSync imported at top of file (ESM).
     try {
-      const globalTsc = require('child_process').execSync('which tsc 2>/dev/null || where tsc 2>nul', { encoding: 'utf-8', timeout: 3000 }).trim();
+      const globalTsc = execSync('which tsc 2>/dev/null || where tsc 2>nul', { encoding: 'utf-8', timeout: 3000 }).trim();
       if (globalTsc) candidates.push(globalTsc);
     } catch {}
     for (const c of candidates) {
@@ -3508,8 +3531,11 @@ function _waitForPort(port, timeoutMs) {
   return new Promise((resolve) => {
     const deadline = Date.now() + timeoutMs;
     const check = () => {
-      // Try to connect to the port — if connection succeeds, the server is listening
-      const { Socket } = require('net');
+      // Use the ESM-imported Socket — NEVER `require('net')` here, this file
+      // is .mjs and `require` is not defined in ESM. The require call here
+      // was the single root cause of "[error] require is not defined" with
+      // no autofix flow visible — the crash happened INSIDE the nha ui
+      // server itself (in this exact function), not in the child sandbox.
       const sock = new Socket();
       sock.setTimeout(500);
       sock.once('connect', () => { sock.destroy(); resolve(true); });