nothumanallowed 15.1.3 → 15.1.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nothumanallowed",
-  "version": "15.1.3",
+  "version": "15.1.4",
   "description": "NotHumanAllowed — 38 AI agents, 80 tools, Studio (visual agentic workflows). Email, calendar, browser automation, screen capture, canvas, cron/heartbeat, Alexandria E2E messaging, GitHub, Notion, Slack, voice chat, free AI (Liara), 28 languages. Zero-dependency CLI.",
   "type": "module",
   "bin": {

package/src/cli.mjs

@@ -243,62 +243,93 @@ async function cmdSelfUpdate() {
     return;
   }
 
-  info(`Updating: ${npmCheck.current} → ${npmCheck.latest}`);
+  const target = npmCheck.latest;
+  info(`Updating: ${npmCheck.current} → ${target}`);
+
+  // Step 1: Detect if we need sudo (check if global npm dir is writable)
+  let needsSudo = false;
+  try {
+    const globalDir = execSync('npm root -g 2>/dev/null', { encoding: 'utf-8', timeout: 5000 }).trim();
+    if (globalDir) {
+      try {
+        const fs2 = await import('fs');
+        fs2.default.accessSync(globalDir, fs2.constants.W_OK);
+      } catch { needsSudo = true; }
+    }
+  } catch { needsSudo = true; }
 
-  // Clear npm cache first to avoid stale versions
-  try { execSync('npm cache clean --force 2>/dev/null', { timeout: 15000, stdio: 'ignore' }); } catch {}
-  try { execSync('sudo npm cache clean --force 2>/dev/null', { timeout: 15000, stdio: 'ignore' }); } catch {}
+  const sudo = needsSudo ? 'sudo ' : '';
 
-  // Install exact version (not @latest tag which can be stale)
-  const target = npmCheck.latest;
-  const cmds = [
-    `npm install -g nothumanallowed@${target}`,
-    `sudo npm install -g nothumanallowed@${target}`,
-  ];
+  // Step 2: Clean npm cache (the #1 cause of stale installs)
+  info('Cleaning npm cache...');
+  try { execSync(`${sudo}npm cache clean --force 2>/dev/null`, { timeout: 20000, stdio: 'ignore' }); } catch {}
+
+  // Step 3: Remove old package first (prevents stale symlinks)
+  info('Removing old version...');
+  try { execSync(`${sudo}npm uninstall -g nothumanallowed 2>/dev/null`, { timeout: 30000, stdio: 'ignore' }); } catch {}
+
+  // Step 4: Install exact version (NEVER use @latest — it can be stale)
+  info(`Installing v${target}...`);
+  const installCmd = `${sudo}npm install -g nothumanallowed@${target} --prefer-online --no-cache`;
+  try {
+    const output = execSync(installCmd, { encoding: 'utf-8', timeout: 120_000, stdio: ['inherit', 'pipe', 'pipe'] });
 
-  for (const cmd of cmds) {
+    // Step 5: Verify the installation actually worked
+    let installedVersion = '';
     try {
-      const usingSudo = cmd.startsWith('sudo');
-      if (usingSudo) info('Retrying with sudo...');
-      const output = execSync(cmd, { encoding: 'utf-8', timeout: 120_000, stdio: ['inherit', 'pipe', 'pipe'] });
-      if (output.includes('nothumanallowed@')) {
-        ok(`Updated to v${npmCheck.latest}!`);
-        if (usingSudo) info('(sudo was required on this system)');
-        // Auto-restart daemon if it was running (so Telegram/Discord reconnect)
-        try {
-          const { isRunning, stopDaemon } = await import('./services/ops-daemon.mjs');
-          if (isRunning()) {
-            info('Restarting ops daemon...');
-            await stopDaemon();
-            // Use the NEW nha binary to restart
-            const { execSync: execRestart } = await import('child_process');
-            try {
-              execRestart('nha ops start', { timeout: 10_000, stdio: 'inherit' });
-              ok('Ops daemon restarted (Telegram/Discord reconnected).');
-            } catch {
-              warn('Could not auto-restart daemon. Run: nha ops start');
-            }
-          }
-        } catch {}
-        return;
+      installedVersion = execSync('node -e "import(\'nothumanallowed/src/constants.mjs\').then(m=>console.log(m.VERSION)).catch(()=>{})" 2>/dev/null || true', { encoding: 'utf-8', timeout: 5000 }).trim();
+    } catch {}
+    if (!installedVersion) {
+      try {
+        const npmRoot = execSync('npm root -g', { encoding: 'utf-8', timeout: 5000 }).trim();
+        const constFile = `${npmRoot}/nothumanallowed/src/constants.mjs`;
+        const fs2 = await import('fs');
+        if (fs2.default.existsSync(constFile)) {
+          const match = fs2.default.readFileSync(constFile, 'utf-8').match(/VERSION\s*=\s*'([^']+)'/);
+          if (match) installedVersion = match[1];
+        }
+      } catch {}
+    }
+
+    if (installedVersion === target) {
+      ok(`Updated to v${target}!`);
+    } else if (output.includes('nothumanallowed@')) {
+      ok(`Updated! (npm reports success)`);
+      if (installedVersion && installedVersion !== target) {
+        warn(`Installed version appears to be ${installedVersion} — try: hash -r && nha version`);
       }
-    } catch (e) {
-      const msg = e.stderr || e.message || '';
-      // EACCES = permission denied, try sudo next
-      if (msg.includes('EACCES') || msg.includes('permission denied')) continue;
-      // Other error — report and stop
-      fail(`Update failed: ${msg.slice(0, 200)}`);
-      console.log('');
-      info('Try manually: sudo npm install -g nothumanallowed@latest');
-      return;
+    } else {
+      warn('Install completed but could not verify version.');
     }
-  }
 
-  fail('Update failed — could not install even with sudo.');
-  console.log('');
-  info('Try manually:');
-  info('  sudo npm install -g nothumanallowed@latest');
-  info('Or fix npm permissions: https://docs.npmjs.com/resolving-eacces-permissions-errors');
+    if (needsSudo) info('(sudo was required on this system)');
+
+    // Step 6: Auto-restart daemon if running
+    try {
+      const { isRunning, stopDaemon } = await import('./services/ops-daemon.mjs');
+      if (isRunning()) {
+        info('Restarting ops daemon...');
+        await stopDaemon();
+        try {
+          execSync(`${sudo}nha ops start`, { timeout: 10_000, stdio: 'inherit' });
+          ok('Ops daemon restarted.');
+        } catch { warn('Could not auto-restart daemon. Run: nha ops start'); }
+      }
+    } catch {}
+
+    // Step 7: Tell user to refresh shell
+    console.log('');
+    info('If "nha version" still shows the old version, run: hash -r');
+
+  } catch (e) {
+    const msg = e.stderr || e.stdout || e.message || '';
+    fail(`Update failed: ${msg.slice(0, 300)}`);
+    console.log('');
+    info('Try manually:');
+    info(`  ${sudo}npm cache clean --force`);
+    info(`  ${sudo}npm install -g nothumanallowed@${target}`);
+    info('  hash -r');
+  }
 }
 
 // ── nha responder ─────────────────────────────────────────────────────────