nothumanallowed 14.5.3 → 14.5.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nothumanallowed",
-  "version": "14.5.3",
+  "version": "14.5.5",
   "description": "NotHumanAllowed — 38 AI agents, 80 tools, Studio (visual agentic workflows). Email, calendar, browser automation, screen capture, canvas, cron/heartbeat, Alexandria E2E messaging, GitHub, Notion, Slack, voice chat, free AI (Liara), 28 languages. Zero-dependency CLI.",
   "type": "module",
   "bin": {

package/src/constants.mjs

@@ -5,7 +5,7 @@ import { fileURLToPath } from 'url';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 
-export const VERSION = '14.5.3';
+export const VERSION = '14.5.5';
 export const BASE_URL = 'https://nothumanallowed.com/cli';
 export const API_BASE = 'https://nothumanallowed.com/api/v1';
 

package/src/server/routes/webcraft.mjs

@@ -42,7 +42,10 @@ class SandboxManager {
   }
 
   isRunning() {
-    return this._sandbox !== null && this._sandbox.proc && !this._sandbox.proc.killed;
+    if (!this._sandbox || !this._sandbox.proc) return false;
+    if (this._sandbox.proc.killed) { this._sandbox = null; return false; }
+    // Verify the process is actually alive (not zombie)
+    try { process.kill(this._sandbox.proc.pid, 0); return true; } catch { this._sandbox = null; return false; }
   }
 
   status() {
@@ -55,17 +58,43 @@ class SandboxManager {
   get port() { return this.isRunning() ? this._sandbox.port : null; }
 
   async stop() {
-    if (!this.isRunning()) return;
-    const { proc } = this._sandbox;
+    if (!this._sandbox) return;
+    const { proc, port } = this._sandbox;
     this._sandbox = null;
+
+    // 1. Kill the entire process group (parent + all children)
     try {
-      proc.kill('SIGTERM');
-      // Give it a grace period then SIGKILL
-      await new Promise((resolve) => {
-        const t = setTimeout(() => { try { proc.kill('SIGKILL'); } catch {} resolve(); }, 4000);
-        proc.once('exit', () => { clearTimeout(t); resolve(); });
-      });
+      if (proc.pid) {
+        // Kill the process group — negative PID kills all processes in the group
+        try { process.kill(-proc.pid, 'SIGTERM'); } catch {}
+        // Grace period, then SIGKILL the group
+        await new Promise((resolve) => {
+          const t = setTimeout(() => {
+            try { process.kill(-proc.pid, 'SIGKILL'); } catch {}
+            try { proc.kill('SIGKILL'); } catch {}
+            resolve();
+          }, 1500);
+          proc.once('exit', () => { clearTimeout(t); resolve(); });
+        });
+      } else {
+        try { proc.kill('SIGKILL'); } catch {}
+      }
     } catch {}
+
+    // 2. Force-kill any orphan processes still holding the port
+    if (port) {
+      try {
+        if (process.platform === 'win32') {
+          await execAsync(`for /f "tokens=5" %a in ('netstat -ano ^| findstr :${port} ^| findstr LISTENING') do taskkill /F /PID %a`, { timeout: 3000 });
+        } else {
+          const { stdout } = await execAsync(`lsof -ti:${port} 2>/dev/null || true`, { timeout: 2000 });
+          const pids = stdout.trim().split(/\s+/).filter(Boolean);
+          for (const pid of pids) { try { process.kill(parseInt(pid), 'SIGKILL'); } catch {} }
+        }
+      } catch {}
+      // Wait for OS to release the port
+      await new Promise((r) => setTimeout(r, 500));
+    }
   }
 
   /**
@@ -155,7 +184,7 @@ class SandboxManager {
         NODE_ENV: 'development',
         NHA_SANDBOX: '1',
       },
-      detached: false,
+      detached: true,
       stdio: ['ignore', 'pipe', 'pipe'],
     });
 
@@ -947,7 +976,7 @@ RULES:
               const proc = spawn('node', [patchedEntry], {
                 cwd: projectDir,
                 env: { ...process.env, PORT: String(port), NODE_ENV: 'development', NHA_SANDBOX: '1' },
-                detached: false, stdio: ['ignore', 'pipe', 'pipe'],
+                detached: true, stdio: ['ignore', 'pipe', 'pipe'],
               });
               sandbox._sandbox = { proc, port, projectName, startedAt: new Date(), healthy: false };
               let sandboxStderr = '';
@@ -1089,7 +1118,7 @@ RULES:
           const proc = spawn('node', [patchedEntry], {
             cwd: projectDir,
             env: { ...process.env, PORT: String(port), NODE_ENV: 'development', NHA_SANDBOX: '1' },
-            detached: false,
+            detached: true,
             stdio: ['ignore', 'pipe', 'pipe'],
           });
           sandbox._sandbox = { proc, port, projectName, startedAt: new Date(), healthy: false };
@@ -2006,6 +2035,14 @@ export function register(router) {
     } catch (e) { sendError(res, 500, e.message); }
   });
 
+  // ── Sandbox stop (beacon — for beforeunload) ───────────────────────────────
+  router.post('/api/studio/webcraft/sandbox/stop-beacon', async (_req, res) => {
+    try {
+      await sandbox.stop();
+      sendJSON(res, 200, { ok: true });
+    } catch (e) { sendError(res, 500, e.message); }
+  });
+
   // ── Sandbox status ────────────────────────────────────────────────────────
   router.get('/api/studio/webcraft/sandbox/status', (_req, res) => {
     sendJSON(res, 200, sandbox.status());
@@ -2100,6 +2137,73 @@ export function register(router) {
     } catch (e) { sendError(res, 500, e.message); }
   });
 
+  // ── Full project scan — lint ALL files at once ───────────────────────────
+  router.post('/api/studio/webcraft/scan', async (req, res) => {
+    try {
+      const { projectName } = await parseBody(req);
+      if (!projectName) return sendError(res, 400, 'projectName required');
+      const dir = ProjectStore.dir(projectName);
+      if (!fs.existsSync(dir)) return sendJSON(res, 200, { issues: [] });
+
+      const files = _listProjectFiles(dir);
+      const issues = [];
+      const allFileNames = new Set(files);
+
+      for (const relPath of files) {
+        const content = ProjectStore.readFile(projectName, relPath);
+        if (!content) continue;
+        const ext = relPath.split('.').pop()?.toLowerCase();
+
+        // JS syntax check
+        if (ext === 'js' || ext === 'mjs') {
+          try { new Function(content); } catch (e) {
+            issues.push({ file: relPath, severity: 'error', message: `Syntax: ${e.message.replace(/\n.*/s, '')}` });
+          }
+        }
+
+        // JSON parse check
+        if (ext === 'json') {
+          try { JSON.parse(content); } catch (e) {
+            issues.push({ file: relPath, severity: 'error', message: `JSON: ${e.message}` });
+          }
+        }
+
+        // CSS brace balance
+        if (ext === 'css') {
+          const o = (content.match(/\{/g) || []).length, c = (content.match(/\}/g) || []).length;
+          if (o !== c) issues.push({ file: relPath, severity: 'warning', message: `Unbalanced braces: ${o} open, ${c} close` });
+        }
+
+        // HTML closing tag + reference check
+        if (ext === 'html' || ext === 'htm') {
+          if (!content.includes('</html>')) {
+            issues.push({ file: relPath, severity: 'warning', message: 'Missing </html>' });
+          }
+          // Check file references
+          const refRegex = /(?:src|href)=["']([^"']*?\.(?:js|css|mjs))["']/gi;
+          let m;
+          while ((m = refRegex.exec(content)) !== null) {
+            const ref = m[1];
+            if (ref.startsWith('http') || ref.startsWith('//') || ref.startsWith('data:')) continue;
+            const htmlDir = path.dirname(relPath);
+            const refPath = ref.startsWith('/') ? ref.slice(1) : path.join(htmlDir, ref).replace(/\\/g, '/');
+            const publicRef = refPath.startsWith('public/') ? refPath : `public/${refPath}`;
+            if (!allFileNames.has(refPath) && !allFileNames.has(publicRef) && !allFileNames.has(ref)) {
+              issues.push({ file: relPath, severity: 'error', message: `Missing file: ${ref}` });
+            }
+          }
+        }
+
+        // Truncation check
+        if (isFileTruncated(content, relPath)) {
+          issues.push({ file: relPath, severity: 'warning', message: 'File appears truncated' });
+        }
+      }
+
+      sendJSON(res, 200, { issues, scanned: files.length });
+    } catch (e) { sendError(res, 500, e.message); }
+  });
+
   // ── Syntax check ──────────────────────────────────────────────────────────
   router.post('/api/studio/webcraft/syntax-check', async (req, res) => {
     try {