note-connector 0.2.7 → 0.2.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "note-connector",
-  "version": "0.2.7",
+  "version": "0.2.9",
   "publishConfig": {
     "access": "public"
   },

package/py/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "note-connector"
-version = "0.2.7"
+version = "0.2.9"
 description = "note-connector: MCP server and ChatGPT connector for note.com"
 readme = "README.md"
 requires-python = ">=3.13"

package/py/src/note_mcp/api/images.py

@@ -117,6 +117,43 @@ _MAGIC_BYTES: dict[str, tuple[bytes, int]] = {
 }
 
 
+def _extract_image_url_from_response(response: dict[str, Any]) -> str | None:
+    """Extract image URL from API response, trying multiple possible field names.
+
+    note.com API may return the URL under different field names.
+    This function tries known field names in order of preference.
+
+    Args:
+        response: Full API response dictionary
+
+    Returns:
+        Image URL string if found, None otherwise
+    """
+    data = response.get("data", {})
+
+    # Try known field names for image URL
+    candidate_keys = [
+        "url",
+        "image_url",
+        "src",
+        "download_url",
+        "note_image_url",
+    ]
+
+    for key in candidate_keys:
+        value = data.get(key)
+        if value and isinstance(value, str) and value.strip():
+            return str(value)
+
+    # Check if the top-level response itself is a string URL
+    for key in candidate_keys:
+        value = response.get(key)
+        if value and isinstance(value, str) and value.strip():
+            return str(value)
+
+    return None
+
+
 def validate_image_file(file_path: str) -> None:
     """Validate image file before upload.
 
@@ -207,25 +244,36 @@ async def _upload_image_internal(
     async with NoteAPIClient(session) as client:
         response = await client.post(endpoint, files=files, data=data)
 
-    # Parse response - Article 6: validate required fields, no fallback
-    image_data = response.get("data", {})
+    # Debug: log full API response for investigation
+    logger.debug(
+        "Image upload response for note_id=%s, endpoint=%s: %s",
+        numeric_note_id,
+        endpoint,
+        {k: v for k, v in response.items() if k != "data"},
+    )
+    if "data" in response:
+        logger.debug("Image upload response data keys: %s", list(response["data"].keys()))
+        logger.debug("Image upload response data: %s", response["data"])
 
-    # Note: The eyecatch upload endpoint (/v1/image_upload/note_eyecatch) returns
-    # only 'url' in the response, not 'key'. This is expected behavior based on
-    # API testing - body images (via presigned_post) return 'key', eyecatch does not.
+    # Extract image URL from response (tries multiple field names)
+    image_url = _extract_image_url_from_response(response)
+
+    image_data = response.get("data", {})
     image_key = image_data.get("key")
 
-    image_url = image_data.get("url")
+    # URL is optional - eyecatch API may not always return it
+    # The eyecatch is set server-side even without a URL in the response
     if not image_url:
-        raise NoteAPIError(
-            code=ErrorCode.API_ERROR,
-            message="Image upload failed: API response missing required field 'url'",
-            details={"response": response},
+        logger.warning(
+            "Image upload response missing image URL for note_id=%s. Response keys: top=%s, data=%s",
+            numeric_note_id,
+            list(response.keys()),
+            list(image_data.keys()) if image_data else "none",
         )
 
     return Image(
         key=str(image_key) if image_key else None,
-        url=str(image_url),
+        url=str(image_url) if image_url else "",
         original_path=file_path,
         size_bytes=file_size,
         uploaded_at=int(time.time()),
@@ -522,14 +570,30 @@ def _decode_base64_image(image_base64: str) -> bytes:
     """
     clean = _strip_data_url_prefix(image_base64)
 
-    if not clean.strip():
+    # Strip whitespace and newlines (common in ChatGPT output)
+    clean = re.sub(r"\s+", "", clean)
+
+    if not clean:
         raise NoteAPIError(
             code=ErrorCode.INVALID_BASE64,
             message="image_base64 が空です。",
         )
 
+    # Fix missing padding: base64 length must be a multiple of 4
+    # ChatGPT sometimes drops trailing '=' padding chars
+    remainder = len(clean) % 4
+    if remainder:
+        clean += "=" * (4 - remainder)
+
     try:
-        return base64.b64decode(clean, validate=True)
+        # validate=False: tolerate non-strict base64 (extra chars, minor format issues)
+        result = base64.b64decode(clean, validate=False)
+        if not result:
+            raise NoteAPIError(
+                code=ErrorCode.INVALID_BASE64,
+                message="image_base64 をデコードしましたが、データが空でした。",
+            )
+        return result
     except (binascii.Error, ValueError) as e:
         raise NoteAPIError(
             code=ErrorCode.INVALID_BASE64,

package/py/src/note_mcp/server.py

@@ -285,7 +285,9 @@ async def note_upload_eyecatch(
         アップロード結果（画像URLを含む）
     """
     image = await upload_eyecatch_image(session, file_path, note_id=note_id)
-    return f"アイキャッチ画像をアップロードしました。URL: {image.url}"
+    if image.url:
+        return f"アイキャッチ画像をアップロードしました。URL: {image.url}"
+    return "アイキャッチ画像をアップロードしました。"
 
 
 @mcp.tool()
@@ -319,7 +321,9 @@ async def note_set_eyecatch_base64(
         mime_type=mime_type,
         image_base64=image_base64,
     )
-    return f"アイキャッチ画像を設定しました。URL: {image.url}"
+    if image.url:
+        return f"アイキャッチ画像を設定しました。URL: {image.url}"
+    return "アイキャッチ画像を設定しました。"
 
 
 @mcp.tool()