not-node 5.1.16 → 5.1.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "not-node",
-  "version": "5.1.16",
+  "version": "5.1.19",
   "description": "node complimentary part for client side notFramework.",
   "main": "index.js",
   "scripts": {

package/src/auth/fields.js

@@ -13,7 +13,6 @@ function getOwnerId(data, ownerFieldName = CONST.DOCUMENT_OWNER_FIELD_NAME) {
         return undefined;
     }
     if (
-        objHas(data, ownerFieldName) &&
         data[ownerFieldName] &&
         COMMON.validateObjectId(data[ownerFieldName].toString())
     ) {

package/src/exceptions/db.js

@@ -21,3 +21,10 @@ class DBExceptionDocumentIsNotOwnerByActiveUser extends notRequestError {
 }
 module.exports.DBExceptionDocumentIsNotOwnerByActiveUser =
     DBExceptionDocumentIsNotOwnerByActiveUser;
+
+class DBExceptionDocumentIsNotFound extends notRequestError {
+    constructor({ params = {}, cause = null } = {}) {
+        super("DB document is not found", { code: 404, ...params }, cause);
+    }
+}
+module.exports.DBExceptionDocumentIsNotFound = DBExceptionDocumentIsNotFound;

package/src/generic/logic.js

@@ -1,7 +1,10 @@
 const { objHas, isFunc, executeFunctionAsAsync } = require("../common");
 const ModelRoutine = require("../model/routine");
 const { deleteResponseSuccess } = require("../model/utils.js");
-const { DBExceptionDeleteWasNotSuccessful } = require("../exceptions/db.js");
+const {
+    DBExceptionDocumentIsNotFound,
+    DBExceptionDeleteWasNotSuccessful,
+} = require("../exceptions/db.js");
 const {
     DBExceptionDocumentIsNotOwnerByActiveUser,
 } = require("../exceptions/http");
@@ -416,7 +419,10 @@ module.exports = ({
             const versioning = ModelRoutine.versioning(model);
             if (versioning) {
                 let itm = await model.getOneRaw(targetId);
-                if (shouldOwn && !isOwner(itm, activeUser)) {
+                if (!itm) {
+                    throw new DBExceptionDocumentIsNotFound();
+                }
+                if (shouldOwn && !isOwner(itm, activeUser._id)) {
                     throw new DBExceptionDocumentIsNotOwnerByActiveUser({
                         params: {
                             targetId,