noobs 0.0.6 → 0.0.29

package/README.md

@@ -1,8 +1,15 @@
 # No(de)obs
+> Previously named "warcraft-recorder-obs-engine"
 
-Node bindings to libobs, built for Warcraft Recorder. An alternative but less mature `obs-studio-node` with a focus on recording gameplay from a replay buffer.
+This library is still very young, you probably don't want to use it.
 
-Uses a [custom](https://github.com/aza547/warcraft-recorder-obs-studio) fork of libobs to enable "replay_buffer to recording" as well as some less interesting improvements to allow libobs to be easier used as a library and not through OBS studio itself.
+Native node bindings to libobs, built for Warcraft Recorder. 
+
+An alternative but less mature `obs-studio-node` with a focus on recording gameplay from a replay buffer.
+
+Uses a [custom](https://github.com/aza547/warcraft-recorder-obs-studio) fork of libobs to:
+- Enable "replay_buffer to recording".
+- Allow libobs to be used as a library easier.
 
 ## Installation
 
@@ -37,8 +44,12 @@ TODO
 ## Building from Source
 
 ```bash
-npm install
-npm run build
+npm install       # install deps
+npm run build     # compile it
+
+npm version patch # version bump
+npm pack          # build tgz locally
+npm publish       # publish to npm
 ```
 
 ## License

package/index.d.ts

@@ -1,19 +1,9 @@
-interface ProcessInfo {
-  name: string;
-  pid: number;
-  parentPid: number;
-  threads: number;
-}
-
 type Signal = { // TODO export type? 
   id: string;
   code: number;
 }
 
 interface Noobs {
-  getUptime(): number;
-  listProcesses(): Promise<ProcessInfo[]>;
-
   ObsInit(
     pluginPath: string, 
     logPath: string, 
@@ -28,10 +18,9 @@ interface Noobs {
   ObsStopRecording(): void;
   ObsGetLastRecording(): string;
 
-  ObsShowPreview(hwnd: Buffer): void;
+  ObsInitPreview(hwnd: Buffer): void;
+  ObsShowPreview(x: number, y: number, width: number, height: number): void;
   ObsHidePreview(): void;
-  ObsResizePreview(width: number, height: number): void;
-  ObsMovePreview(x: number, y: number): void;
 }
 
 declare const noobs: Noobs;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "noobs",
-  "version": "0.0.6",
+  "version": "0.0.29",
   "description": "A native Node.js addon with libobs bindings for Warcraft Recorder.",
   "main": "index.js",
   "types": "index.d.ts",
@@ -20,7 +20,7 @@
     "dist/**/*"
   ],
   "author": "Warcraft Recorder LTD",
-  "license": "ISC",
+  "license": "LGPL-2.0",
   "devDependencies": {
     "@types/node": "^24.1.0",
     "node-gyp": "^11.2.0"

package/src/main.cpp

@@ -12,41 +12,6 @@
 
 ObsInterface* obs = nullptr;
 
-LRESULT CALLBACK WindowProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) {
-    if (uMsg == WM_DESTROY) {
-        PostQuitMessage(0);
-        return 0;
-    }
-    return DefWindowProc(hwnd, uMsg, wParam, lParam);
-}
-
-
-void WindowThread(std::promise<HWND> hwndPromise) {
-    const wchar_t CLASS_NAME[] = L"MyWindowClass";
-    HINSTANCE hInstance = GetModuleHandle(nullptr);
-
-    WNDCLASSW wc = {};
-    wc.lpfnWndProc = WindowProc;
-    wc.hInstance = hInstance;
-    wc.lpszClassName = CLASS_NAME;
-    RegisterClassW(&wc);
-
-    HWND hwnd = CreateWindowExW(
-        0, CLASS_NAME, L"My Window",
-        WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, 800, 600,
-        nullptr, nullptr, hInstance, nullptr
-    );
-
-    hwndPromise.set_value(hwnd);  // Send hwnd back to main thread
-    ShowWindow(hwnd, SW_SHOW);
-
-    MSG msg = {};
-    while (GetMessage(&msg, nullptr, 0, 0)) {
-        TranslateMessage(&msg);
-        DispatchMessage(&msg);
-    }
-}
-
 Napi::Value ObsInit(const Napi::CallbackInfo& info) {
   bool valid = info.Length() == 5 &&
    info[0].IsString() && // Plugin path
@@ -73,7 +38,6 @@ Napi::Value ObsInit(const Napi::CallbackInfo& info) {
   return info.Env().Undefined();
 }
 
-
 Napi::Value ObsShutdown(const Napi::CallbackInfo& info) {
   delete obs;
   obs = nullptr;
@@ -83,8 +47,10 @@ Napi::Value ObsShutdown(const Napi::CallbackInfo& info) {
 Napi::Value ObsStartBuffer(const Napi::CallbackInfo& info) {
   blog(LOG_INFO, "ObsStartBuffer called");
 
-  if (!obs) 
+  if (!obs) {
+    blog(LOG_ERROR, "ObsStartBuffer called but obs is not initialized");
     throw std::runtime_error("Obs not initialized");
+  }
 
   obs->startBuffering();
   return info.Env().Undefined();
@@ -92,6 +58,7 @@ Napi::Value ObsStartBuffer(const Napi::CallbackInfo& info) {
 
 Napi::Value ObsStartRecording(const Napi::CallbackInfo& info) {
   if (!obs) {
+    blog(LOG_ERROR, "ObsStartRecording called but obs is not initialized");
     throw std::runtime_error("Obs not initialized");
   }
 
@@ -106,29 +73,37 @@ Napi::Value ObsStartRecording(const Napi::CallbackInfo& info) {
 }
 
 Napi::Value ObsStopRecording(const Napi::CallbackInfo& info) {
-  if (!obs) 
+  if (!obs) {
+    blog(LOG_ERROR, "ObsStopRecording called but obs is not initialized");
     throw std::runtime_error("Obs not initialized");
+  }
 
   obs->stopRecording();
   return info.Env().Undefined();
 }
 
 Napi::Value ObsGetLastRecording(const Napi::CallbackInfo& info) {
-  if (!obs)
+  if (!obs) {
+    blog(LOG_ERROR, "ObsGetLastRecording called but obs is not initialized");
     throw std::runtime_error("Obs not initialized");
+  }
 
   std::string lastRecording = obs->getLastRecording();
   return Napi::String::New(info.Env(), lastRecording);
 }
 
-Napi::Value ObsShowPreview(const Napi::CallbackInfo& info) {
-  blog(LOG_INFO, "ObsShowPreview called");
+Napi::Value ObsInitPreview(const Napi::CallbackInfo& info) {
+  blog(LOG_INFO, "ObsInitPreview called");
 
-  if (!obs) 
+  if (!obs) {
+    blog(LOG_ERROR, "ObsInitPreview called but obs is not initialized");
     throw std::runtime_error("Obs not initialized");
+  }
 
-  if (info.Length() < 1 || !info[0].IsBuffer()) {
-    Napi::TypeError::New(info.Env(), "Expected HWND as Buffer").ThrowAsJavaScriptException();
+  bool valid = info.Length() == 1 && info[0].IsBuffer();
+
+  if (!valid) {
+    Napi::TypeError::New(info.Env(), "Invalid arguments passed to ObsInitPreview").ThrowAsJavaScriptException();
     return info.Env().Undefined();
   }
 
@@ -137,184 +112,63 @@ Napi::Value ObsShowPreview(const Napi::CallbackInfo& info) {
   if (buffer.Length() < sizeof(HWND)) {
     Napi::TypeError::New(info.Env(), "Buffer too small for HWND").ThrowAsJavaScriptException();
     return info.Env().Undefined();
-  } else {
-    blog(LOG_INFO, "ObsShowPreview buffer length: %zu", buffer.Length());
-    blog(LOG_INFO, "ObsShowPreview hwnd length: %zu", sizeof(HWND));
   }
 
-  // Union to safely read the bytes
-  union {
-    uint8_t bytes[8];
-    uint64_t value;
-    HWND hwnd;
-  } hwndUnion;
-  
-  memcpy(hwndUnion.bytes, buffer.Data(), sizeof(hwndUnion.bytes));
-
-  obs->showPreview(hwndUnion.hwnd);
+  HWND hwnd = *reinterpret_cast<HWND*>(buffer.Data());
+  obs->initPreview(hwnd);
   return info.Env().Undefined();
 }
 
-Napi::Value ObsResizePreview(const Napi::CallbackInfo& info) {
-  if (!obs) 
-    throw std::runtime_error("Obs not initialized");
+Napi::Value ObsShowPreview(const Napi::CallbackInfo& info) {
+  blog(LOG_INFO, "ObsShowPreview called");
 
-  if (info.Length() < 2) {
-    Napi::TypeError::New(info.Env(), "Expected width and height").ThrowAsJavaScriptException();
-    return info.Env().Undefined();
+  if (!obs) {
+    blog(LOG_ERROR, "ObsShowPreview called but obs is not initialized");
+    throw std::runtime_error("Obs not initialized");
   }
 
-  int width = info[0].As<Napi::Number>().Int32Value();
-  int height = info[1].As<Napi::Number>().Int32Value();
+  bool valid = info.Length() == 4 &&
+    info[0].IsNumber() && // X
+    info[1].IsNumber() && // Y
+    info[2].IsNumber() && // Width
+    info[3].IsNumber(); // Height
 
-  obs->resizePreview(width, height);
-  return info.Env().Undefined();
-}
-
-Napi::Value ObsMovePreview(const Napi::CallbackInfo& info) {
-  if (!obs) 
-    throw std::runtime_error("Obs not initialized");
-
-  if (info.Length() < 2) {
-    Napi::TypeError::New(info.Env(), "Expected x and y").ThrowAsJavaScriptException();
+  if (!valid) {
+    Napi::TypeError::New(info.Env(), "Invalid arguments passed to ObsShowPreview").ThrowAsJavaScriptException();
     return info.Env().Undefined();
   }
 
   int x = info[0].As<Napi::Number>().Int32Value();
   int y = info[1].As<Napi::Number>().Int32Value();
+  int width = info[2].As<Napi::Number>().Int32Value();
+  int height = info[3].As<Napi::Number>().Int32Value();
 
-  obs->movePreview(x, y);
+  obs->showPreview(x, y, width, height);
   return info.Env().Undefined();
 }
 
 Napi::Value ObsHidePreview(const Napi::CallbackInfo& info) {
-  if (!obs) 
+  if (!obs) {
+    blog(LOG_ERROR, "ObsHidePreview called but obs is not initialized");
     throw std::runtime_error("Obs not initialized");
+  }
 
   obs->hidePreview();
   return info.Env().Undefined();
 }
 
-
-Napi::Number GetUptime(const Napi::CallbackInfo& info) {
-  DWORD ticks = GetTickCount();
-  return Napi::Number::New(info.Env(), static_cast<double>(ticks));
-}
-
-class ProcessListWorker : public Napi::AsyncWorker {
-public:
-    ProcessListWorker(Napi::Function& callback) 
-        : Napi::AsyncWorker(callback) {}
-
-    ~ProcessListWorker() {}
-
-    // This runs on a background thread - won't block JS
-    void Execute() override {
-        HANDLE snapshot = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
-        if (snapshot == INVALID_HANDLE_VALUE) {
-            SetError("Failed to create process snapshot");
-            return;
-        }
-        
-        PROCESSENTRY32W pe32;
-        pe32.dwSize = sizeof(PROCESSENTRY32W);
-        
-        if (!Process32FirstW(snapshot, &pe32)) {
-            CloseHandle(snapshot);
-            SetError("Failed to get first process");
-            return;
-        }
-        
-        do {
-            ProcessInfo info;
-            
-            // Convert wide string to UTF-8
-            int utf8Length = WideCharToMultiByte(CP_UTF8, 0, pe32.szExeFile, -1, nullptr, 0, nullptr, nullptr);
-            if (utf8Length > 0) {
-                std::vector<char> utf8Buffer(utf8Length);
-                WideCharToMultiByte(CP_UTF8, 0, pe32.szExeFile, -1, utf8Buffer.data(), utf8Length, nullptr, nullptr);
-                
-                info.name = std::string(utf8Buffer.data());
-                info.pid = pe32.th32ProcessID;
-                info.parentPid = pe32.th32ParentProcessID;
-                info.threads = pe32.cntThreads;
-                
-                processes.push_back(info);
-            }
-        } while (Process32NextW(snapshot, &pe32));
-        
-        CloseHandle(snapshot);
-    }
-
-    // This runs back on the main thread
-    void OnOK() override {
-        Napi::HandleScope scope(Env());
-        Napi::Array result = Napi::Array::New(Env());
-        
-        for (size_t i = 0; i < processes.size(); i++) {
-            Napi::Object process = Napi::Object::New(Env());
-            process.Set("name", Napi::String::New(Env(), processes[i].name));
-            process.Set("pid", Napi::Number::New(Env(), processes[i].pid));
-            process.Set("parentPid", Napi::Number::New(Env(), processes[i].parentPid));
-            process.Set("threads", Napi::Number::New(Env(), processes[i].threads));
-            result.Set(i, process);
-        }
-        
-        Callback().Call({Env().Null(), result});
-    }
-
-    void OnError(const Napi::Error& e) override {
-        Napi::HandleScope scope(Env());
-        Callback().Call({e.Value(), Env().Undefined()});
-    }
-
-private:
-    struct ProcessInfo {
-        std::string name;
-        DWORD pid;
-        DWORD parentPid;
-        DWORD threads;
-    };
-    
-    std::vector<ProcessInfo> processes;
-};
-
-Napi::Value ListProcesses(const Napi::CallbackInfo& info) {
-    Napi::Env env = info.Env();
-    auto deferred = Napi::Promise::Deferred::New(env);
-    
-    auto callback = Napi::Function::New(env, [deferred](const Napi::CallbackInfo& info) {
-        if (!info[0].IsNull()) {
-            // Error case
-            deferred.Reject(info[0]);
-        } else {
-            // Success case
-            deferred.Resolve(info[1]);
-        }
-        return info.Env().Undefined();
-    });
-    
-    ProcessListWorker* worker = new ProcessListWorker(callback);
-    worker->Queue();
-    
-    return deferred.Promise();
-}
-
 Napi::Object Init(Napi::Env env, Napi::Object exports) {
   exports.Set("ObsInit", Napi::Function::New(env, ObsInit));
   exports.Set("ObsShutdown", Napi::Function::New(env, ObsShutdown));
+
   exports.Set("ObsStartBuffer", Napi::Function::New(env, ObsStartBuffer));
   exports.Set("ObsStartRecording", Napi::Function::New(env, ObsStartRecording));
   exports.Set("ObsStopRecording", Napi::Function::New(env, ObsStopRecording));
   exports.Set("ObsGetLastRecording", Napi::Function::New(env, ObsGetLastRecording));
 
+  exports.Set("ObsInitPreview", Napi::Function::New(env, ObsInitPreview));
   exports.Set("ObsShowPreview", Napi::Function::New(env, ObsShowPreview));
   exports.Set("ObsHidePreview", Napi::Function::New(env, ObsHidePreview));
-  exports.Set("ObsResizePreview", Napi::Function::New(env, ObsResizePreview));
-  exports.Set("ObsMovePreview", Napi::Function::New(env, ObsMovePreview));
-  
-  exports.Set("getUptime", Napi::Function::New(env, GetUptime));
-  exports.Set("listProcesses", Napi::Function::New(env, ListProcesses));
   return exports;
 }
 

package/src/obs_interface.cpp

@@ -7,8 +7,6 @@
 #include <vector>
 #include <thread>
 
-
-
 std::vector<std::string> ObsInterface::get_available_video_encoders()
 {
   std::vector<std::string> encoders;
@@ -200,23 +198,23 @@ obs_output_t* ObsInterface::create_output(const std::string& recordingPath) {
   obs_data_release(settings);
 
   blog(LOG_INFO, "Create venc");
-  video_encoder = obs_video_encoder_create("h264_texture_amf", "simple_h264_stream", NULL, NULL);
+  video_encoder = obs_video_encoder_create("obs_x264", "simple_h264_stream", NULL, NULL);
 
   if (!video_encoder) {
     blog(LOG_ERROR, "Failed to create video encoder!");
     throw std::runtime_error("Failed to create video encoder!");
   }
 
-  blog(LOG_INFO, "Set video encoder settings");
-  obs_data_t* amf_settings = obs_data_create();
-  obs_data_set_string(amf_settings, "preset", "speed");  // Faster preset
-  //obs_data_set_int(amf_settings, "bitrate", 2500);
-  obs_data_set_string(amf_settings, "rate_control", "CQP");
-  obs_data_set_int(amf_settings, "cqp", 30);
-  obs_data_set_string(amf_settings, "profile", "main");
-  obs_data_set_int(amf_settings, "keyint_sec", 1); // Set keyframe interval to 1 second
-  obs_encoder_update(video_encoder, amf_settings);
-  obs_data_release(amf_settings);
+  // blog(LOG_INFO, "Set video encoder settings");
+  // obs_data_t* amf_settings = obs_data_create();
+  // obs_data_set_string(amf_settings, "preset", "speed");  // Faster preset
+  // //obs_data_set_int(amf_settings, "bitrate", 2500);
+  // obs_data_set_string(amf_settings, "rate_control", "CQP");
+  // obs_data_set_int(amf_settings, "cqp", 30);
+  // obs_data_set_string(amf_settings, "profile", "main");
+  // obs_data_set_int(amf_settings, "keyint_sec", 1); // Set keyframe interval to 1 second
+  // obs_encoder_update(video_encoder, amf_settings);
+  // obs_data_release(amf_settings);
 
   blog(LOG_INFO, "Create aenc");
   audio_encoder = obs_audio_encoder_create("ffmpeg_aac", "simple_aac", NULL, 0, NULL);
@@ -326,134 +324,94 @@ void ObsInterface::create_signal_handlers(obs_output_t *output) {
 }
 
 void draw_callback(void* data, uint32_t cx, uint32_t cy) {
-  // Render the OBS preview scene here
   obs_render_main_texture();
 }
 
-void ObsInterface::showPreview(HWND hwnd) {
+void ObsInterface::initPreview(HWND parent) {
   blog(LOG_INFO, "ObsInterface::showPreview");
 
-  if (display) {
-    blog(LOG_INFO, "Display already exists, returning early");
-    return;  // Return early if display already exists
-  }
-
-  // Create an embedded child window for OBS preview
-  HWND previewWindow = CreateWindowExA(
-    0,                    // No extended styles
-    "STATIC",            // Simple static control class (ANSI string)
-    "OBS Preview",       // Window name (ANSI string)
-    WS_CHILD | WS_VISIBLE | WS_BORDER,  // Child + visible + border
-    20, 20,              // Position within parent (x, y)
-    1920, 1080,           // Size (width, height)
-    hwnd,                // Parent window (your Electron app)
-    NULL,                // No menu
-    GetModuleHandle(NULL), 
-    NULL
-  );
-
-  if (!previewWindow) {
-    blog(LOG_ERROR, "Failed to create preview child window");
-    return;
+  if (!preview_hwnd) {
+    blog(LOG_INFO, "Creating preview child window");
+
+    preview_hwnd = CreateWindowExA(
+      0,                      // No extended styles
+      "STATIC",               // Simple static control class (ANSI string)
+      "OBS Preview",          // Window name (ANSI string)
+      WS_CHILD | WS_BORDER,   // Child + border, NOT visible initially
+      0, 0,                   // Initial position (x, y)
+      0, 0,                   // Initial size (width, height)
+      parent,                 // Parent window (your Electron app)
+      NULL,                   // No menu
+      GetModuleHandle(NULL),
+      NULL
+    );
+
+    if (!preview_hwnd) {
+      blog(LOG_ERROR, "Failed to create preview child window");
+      return;
+    }
   }
 
-  // Store for cleanup
-  previewHwnd = previewWindow;
+  if (!display) {
+    blog(LOG_INFO, "Create OBS display in child window");
 
-  blog(LOG_INFO, "Create OBS display in child window");
-  gs_init_data gs_data = {};
-  gs_data.adapter = 0;
-  gs_data.cx = 1920;              // Match child window size
-  gs_data.cy = 1080;              
-  gs_data.format = GS_BGRA;
-  gs_data.zsformat = GS_ZS_NONE;
-  gs_data.num_backbuffers = 1;
-  gs_data.window.hwnd = previewWindow;  // Use child window, not parent
+    gs_init_data gs_data = {};
+    gs_data.adapter = 0;
+    gs_data.cx = 1920; // TODO get from video context?
+    gs_data.cy = 1080; // TODO get from video context?
+    gs_data.format = GS_BGRA;
+    gs_data.zsformat = GS_ZS_NONE;
+    gs_data.num_backbuffers = 1;
+    gs_data.window.hwnd = preview_hwnd;
+
+    display = obs_display_create(&gs_data, 0x0);
+
+    if (!display) {
+      blog(LOG_ERROR, "Failed to create OBS display");
+      return;
+    }
 
-  display = obs_display_create(&gs_data, 0x0);
-  if (display) {
     obs_display_add_draw_callback(display, draw_callback, NULL);
-    blog(LOG_INFO, "OBS preview embedded successfully");
-  } else {
-    blog(LOG_ERROR, "Failed to create OBS display");
-    DestroyWindow(previewWindow);
-    previewHwnd = nullptr;
   }
+
+  obs_display_set_enabled(display, false);
 }
 
-void ObsInterface::resizePreview(int width, int height) {
-  blog(LOG_INFO, "ObsInterface::resizePreview to size (%d x %d)", width, height);
+void ObsInterface::showPreview(int x, int y, int width, int height) {
+  blog(LOG_INFO, "ObsInterface::showPreview");
 
-  if (!previewHwnd) {
-    blog(LOG_WARNING, "No preview window to resize");
+  if (!preview_hwnd || !display) {
+    blog(LOG_ERROR, "Preview window not initialized");
     return;
   }
 
-  // Resize the child window
-  BOOL windowSuccess = SetWindowPos(
-    previewHwnd,           // Handle to the child window
-    NULL,                  // No Z-order change
-    0, 0,                  // Keep current position (ignored due to SWP_NOMOVE)
-    width, height,         // New size (width, height)
-    SWP_NOMOVE | SWP_NOZORDER | SWP_NOACTIVATE  // Don't change position, Z-order, or activation
+  // Resize and move the existing child window.
+  bool success = SetWindowPos(
+    preview_hwnd,                  // Handle to the child window
+    NULL,                          // No Z-order change
+    x, y,                          // New position (x, y)
+    width, height,                 // New size (width, height)
+    SWP_NOZORDER | SWP_NOACTIVATE  // Don't change position, Z-order, or activation
   );
 
-  if (!windowSuccess) {
+  if (!success) {
     blog(LOG_ERROR, "Failed to resize preview window to (%d x %d)", width, height);
     return;
   }
 
-  blog(LOG_INFO, "Preview window resized successfully to (%d x %d)", width, height);
-
-  // Resize the OBS display to match the new window size
-  if (display) {
-    obs_display_resize(display, width, height);
-    blog(LOG_INFO, "OBS display resized to (%d x %d)", width, height);
-  } else {
-    blog(LOG_WARNING, "No OBS display to resize");
-  }
-}
-
-void ObsInterface::movePreview(int x, int y) {
-  blog(LOG_INFO, "ObsInterface::movePreview to position (%d, %d)", x, y);
-
-  if (!previewHwnd) {
-    blog(LOG_WARNING, "No preview window to move");
-    return;
-  }
-
-  // Move the child window to the new position within the parent
-  BOOL success = SetWindowPos(
-    previewHwnd,           // Handle to the child window
-    NULL,                  // No Z-order change
-    x, y,                  // New position (x, y)
-    0, 0,                  // Keep current size (ignored due to SWP_NOSIZE)
-    SWP_NOSIZE | SWP_NOZORDER | SWP_NOACTIVATE  // Don't change size, Z-order, or activation
-  );
-
-  if (success) {
-    blog(LOG_INFO, "Preview window moved successfully to (%d, %d)", x, y);
-  } else {
-    blog(LOG_ERROR, "Failed to move preview window to (%d, %d)", x, y);
-  }
+  ShowWindow(preview_hwnd, SW_SHOW);
+  obs_display_set_enabled(display, true);
 }
 
 void ObsInterface::hidePreview() {
   blog(LOG_INFO, "ObsInterface::hidePreview");
 
-  if (display) {
-    obs_display_remove_draw_callback(display, draw_callback, NULL);
-    obs_display_destroy(display);
-    display = nullptr;
-    blog(LOG_INFO, "OBS display destroyed");
+  if (preview_hwnd) {
+    ShowWindow(preview_hwnd, SW_HIDE);
+    blog(LOG_INFO, "Preview child window hidden");
   }
 
-  // Destroy the child window to fully clean up the preview
-  if (previewHwnd) {
-    DestroyWindow(previewHwnd);
-    previewHwnd = nullptr;
-    blog(LOG_INFO, "Preview child window destroyed");
-  }
+  obs_display_set_enabled(display, false);
 }
 
 ObsInterface::ObsInterface(

package/src/obs_interface.h

@@ -24,16 +24,13 @@ class ObsInterface {
     void stopRecording();
     std::string getLastRecording();
 
-    void showPreview(HWND hwnd);
+    void initPreview(HWND parent); // Must call this before showPreview to setup resources.
+    void showPreview(int x, int y, int width, int height); // Also used for moving and resizing.
     void hidePreview();
-    void resizePreview(int width, int height);
-    void movePreview(int x, int y);
 
     std::vector<std::string> get_available_video_encoders();
 
     // TODO
-    // Show preview
-    // Hide preview
     // Configure video 
     // Configure audio
     // List audio source
@@ -48,7 +45,7 @@ class ObsInterface {
     obs_encoder_t *video_encoder = nullptr;
     obs_encoder_t *audio_encoder = nullptr;
     obs_display_t *display = nullptr;
-    HWND previewHwnd = nullptr; // window handle for scene preview
+    HWND preview_hwnd = nullptr; // window handle for scene preview
     Napi::ThreadSafeFunction jscb; // javascript callback
 
     void init_obs(const std::string& pluginPath, const std::string& dataPath);

package/src/utils.cpp

@@ -15,7 +15,7 @@ void log_handler(int lvl, const char *msg, va_list args, void *p) {
     auto time_t = std::chrono::system_clock::to_time_t(now);
     
     std::stringstream filename_stream;
-    filename_stream << "ObsEngine-" << std::put_time(std::localtime(&time_t), "%Y-%m-%d") << ".log";
+    filename_stream << "OBS-" << std::put_time(std::localtime(&time_t), "%Y-%m-%d") << ".log";
     
     // Use the provided directory path and append the filename
     std::string log_dir = static_cast<const char*>(p);