noobs 0.0.187 → 0.0.190

package/README.md

@@ -93,6 +93,8 @@ npm run build     # compile it
 
 npm version patch # version bump
 npm pack          # build tgz locally
+
+npm login
 npm publish       # publish to npm
 ```
 

package/index.d.ts

@@ -171,6 +171,7 @@ interface Noobs {
 
   // Recording functions.
   SetBuffering(buffering: boolean): void; // In buffering mode, the recording is stored in memory and can be converted to a file later.
+  SetFragmentation(fragmented: boolean): void; // Use fragmented MP4.
   StartBuffer(): void;
   StartRecording(offset: number): void;
   StopRecording(): void;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "noobs",
-  "version": "0.0.187",
+  "version": "0.0.190",
   "description": "A native Node.js addon with libobs bindings for Warcraft Recorder.",
   "main": "index.js",
   "types": "index.d.ts",

package/src/main.cpp

@@ -156,6 +156,28 @@ Napi::Value ObsSetBuffering(const Napi::CallbackInfo& info) {
   return info.Env().Undefined();
 }
 
+Napi::Value ObsSetFragmentation(const Napi::CallbackInfo& info) {
+  blog(LOG_INFO, "ObsSetFragmentation called");
+
+  if (!obs) {
+    blog(LOG_ERROR, "ObsSetFragmentation called but obs is not initialized");
+    Napi::Error::New(info.Env(), "Obs not initialized").ThrowAsJavaScriptException();
+    return info.Env().Undefined();
+  }
+
+  bool valid = info.Length() == 1 && info[0].IsBoolean();
+
+  if (!valid) {
+    Napi::TypeError::New(info.Env(), "Invalid arguments passed to ObsSetFragmentation").ThrowAsJavaScriptException();
+    return info.Env().Undefined();
+  }
+
+  bool fragmented = info[0].As<Napi::Boolean>().Value();
+  obs->setFragmentation(fragmented);
+
+  return info.Env().Undefined();
+}
+
 Napi::Value ObsStartBuffer(const Napi::CallbackInfo& info) {
   blog(LOG_INFO, "ObsStartBuffer called");
 
@@ -678,6 +700,7 @@ Napi::Object Init(Napi::Env env, Napi::Object exports) {
   exports.Set("SetVideoEncoder", Napi::Function::New(env, ObsSetVideoEncoder));
 
   exports.Set("SetBuffering", Napi::Function::New(env, ObsSetBuffering));
+  exports.Set("SetFragmentation", Napi::Function::New(env, ObsSetFragmentation));
   exports.Set("StartBuffer", Napi::Function::New(env, ObsStartBuffer));
   exports.Set("StartRecording", Napi::Function::New(env, ObsStartRecording));
   exports.Set("StopRecording", Napi::Function::New(env, ObsStopRecording));

package/src/obs_interface.cpp

@@ -271,6 +271,12 @@ void ObsInterface::create_output() {
     unbuffered_output_filename = filename;
   }
 
+  if (fragmented && file_extension == "mp4") {
+    blog(LOG_INFO, "Fragmentation enabled");
+    std::string mux_frag = "movflags=frag_keyframe+empty_moov+delay_moov";
+    obs_data_set_string(settings, "muxer_settings", mux_frag.c_str());
+  }
+
   obs_output_update(output, settings);
   obs_data_release(settings);
   connect_signal_handlers(output);
@@ -1047,6 +1053,16 @@ void ObsInterface::setBuffering(bool value) {
   create_output();
 }
 
+void ObsInterface::setFragmentation(bool value) {
+  if (obs_output_active(output)) {
+    blog(LOG_ERROR, "Cannot change fragmentation state while output is active");
+    throw new std::runtime_error("Cannot change fragmentation state while output is active");
+  }
+
+  fragmented = value;
+  create_output();
+}
+
 void ObsInterface::startBuffering() {
   blog(LOG_INFO, "ObsInterface::startBuffering called");
 

package/src/obs_interface.h

@@ -52,6 +52,7 @@ class ObsInterface {
     void forceStopRecording(); // Force stop the recording, this will not save the current recording.
     std::string getLastRecording(); // Get the last recorded file path.
     void setBuffering(bool buffer); // Enable or disable buffering.
+    void setFragmentation(bool fragmented); // Enable or disable fragmented MP4.
     void setRecordingCfg(const std::string& recordingPath, const std::string& fileExtension); // Set the recording path.
     void setVideoContext(int fps, int width, int height); // Reset video settings.
 
@@ -108,6 +109,7 @@ class ObsInterface {
     std::string file_extension = "mp4"; // File extension for recordings.
 
     bool buffering = false; // Whether we are buffering the recording in memory.
+    bool fragmented = false; // Use fragmented MP4.
     bool drawSourceOutline = false; // Draw red outline around source
     void init_obs(const std::string& distPath);
     int reset_video(int fps, int width, int height);