nolo-cli 0.1.32 → 0.1.34

package/client/agentRun.test.ts

@@ -49,8 +49,8 @@ describe("cli agent run client", () => {
   });
 
   test("calls the Nolo HTTP API directly when AUTH_TOKEN is present", async () => {
-    const output = new CaptureOutput();
-    const requests: Array<{ url: string; body: any; auth: string | null }> = [];
+    const output = new CaptureOutput();
+    const requests: Array<{ url: string; body: any; auth: string | null }> = [];
 
     const result = await runAgentTurn({
       agentName: "nolo",
@@ -97,124 +97,10 @@ describe("cli agent run client", () => {
     ]);
     expect(result).toEqual({ exitCode: 0, dialogId: "dialog-1" });
     expect(output.text()).toContain("nolo -> working");
-    expect(output.text()).toContain("nolo > hi");
+    expect(output.text()).toContain("nolo > hi");
     expect(output.text()).not.toContain("tokens=");
   });
 
-  test("retries machine-bound cluster runs on a sibling server when the primary registry is unavailable", async () => {
-    const output = new CaptureOutput();
-    const requests: string[] = [];
-
-    const result = await runAgentTurn({
-      agentName: "frontend",
-      agentKey: "frontend-implementer",
-      serverUrl: "https://nolo.chat",
-      message: "hello",
-      scriptDir: "C:/missing/scripts",
-      env: { AUTH_TOKEN: "token-123" },
-      output,
-      runtimeMode: "server",
-      scriptPathExists: () => false,
-      fetchImpl: async (url) => {
-        requests.push(String(url));
-        if (String(url) === "https://nolo.chat/api/agent/run") {
-          return Response.json({
-            error: "Runtime binding unavailable",
-            reason: "bound_machine_unavailable",
-            message: "Bound runtime machine is not available on this cluster node.",
-          }, { status: 409 });
-        }
-        return Response.json({
-          content: "cluster ok",
-          dialogId: "dialog-us",
-        });
-      },
-    });
-
-    expect(result).toEqual({ exitCode: 0, dialogId: "dialog-us" });
-    expect(requests).toEqual([
-      "https://nolo.chat/api/agent/run",
-      "https://us.nolo.chat/api/agent/run",
-    ]);
-    expect(output.text()).toContain("retrying https://us.nolo.chat");
-    expect(output.text()).toContain("frontend > cluster ok");
-  });
-
-  test("follows an explicit retryServerBase hint before cluster sibling fallback", async () => {
-    const output = new CaptureOutput();
-    const requests: string[] = [];
-
-    const result = await runAgentTurn({
-      agentName: "frontend",
-      agentKey: "frontend-implementer",
-      serverUrl: "https://router.nolo.chat",
-      message: "hello",
-      scriptDir: "C:/missing/scripts",
-      env: { AUTH_TOKEN: "token-123" },
-      output,
-      runtimeMode: "server",
-      scriptPathExists: () => false,
-      fetchImpl: async (url) => {
-        requests.push(String(url));
-        if (String(url) === "https://router.nolo.chat/api/agent/run") {
-          return Response.json({
-            error: "Runtime binding unavailable",
-            reason: "bound_machine_unavailable",
-            message: "Bound runtime machine is not available on this cluster node.",
-            retryServerBase: "https://us.nolo.chat",
-          }, { status: 409 });
-        }
-        return Response.json({
-          content: "sticky ok",
-          dialogId: "dialog-sticky",
-        });
-      },
-    });
-
-    expect(result).toEqual({ exitCode: 0, dialogId: "dialog-sticky" });
-    expect(requests).toEqual([
-      "https://router.nolo.chat/api/agent/run",
-      "https://us.nolo.chat/api/agent/run",
-    ]);
-    expect(output.text()).toContain("retrying https://us.nolo.chat");
-    expect(output.text()).toContain("frontend > sticky ok");
-  });
-
-  test("does not retry sibling cluster nodes on owner mismatch and prints the detailed binding message", async () => {
-    const output = new CaptureOutput();
-    const requests: string[] = [];
-
-    const result = await runAgentTurn({
-      agentName: "frontend",
-      agentKey: "frontend-implementer",
-      serverUrl: "https://nolo.chat",
-      message: "hello",
-      scriptDir: "C:/missing/scripts",
-      env: { AUTH_TOKEN: "token-123" },
-      output,
-      runtimeMode: "server",
-      scriptPathExists: () => false,
-      fetchImpl: async (url) => {
-        requests.push(String(url));
-        return Response.json({
-          error: "Runtime binding unavailable",
-          reason: "bound_machine_owner_mismatch",
-          message:
-            "Bound runtime machine machine-main is online for the current caller account, " +
-            "but this agent is bound to a different runtimeBinding.ownerUserId. " +
-            "Rebind the agent or connect the machine under the binding owner account.",
-        }, { status: 409 });
-      },
-    });
-
-    expect(result).toEqual({ exitCode: 1 });
-    expect(requests).toEqual(["https://nolo.chat/api/agent/run"]);
-    expect(output.text()).toContain("Runtime binding unavailable");
-    expect(output.text()).toContain("Bound runtime machine machine-main is online for the current caller account");
-    expect(output.text()).toContain("reason=bound_machine_owner_mismatch");
-    expect(output.text()).not.toContain("retrying https://us.nolo.chat");
-  });
-
   test("prepends task-run context for HTTP agent runs", async () => {
     const output = new CaptureOutput();
     const requests: Array<{ body: any }> = [];
@@ -363,66 +249,6 @@ describe("cli agent run client", () => {
     expect(result).toEqual({ exitCode: 0, dialogId: "dialog-1" });
   });
 
-  test("drops inherited lineage when continueDialogId is authoritative for HTTP runs and trims it", async () => {
-    const output = new CaptureOutput();
-    const requests: Array<{ body: any }> = [];
-
-    await runAgentTurn({
-      agentName: "nolo",
-      agentKey: "agent-pub-test",
-      serverUrl: "https://nolo.chat",
-      message: "hello",
-      continueDialogId: "  dialog-existing  ",
-      inheritedFromDialogKey: "dialog-user-1-dialog-2",
-      parentDialogId: "dialog-2",
-      scriptDir: "C:/missing/scripts",
-      env: { AUTH_TOKEN: "token-123" },
-      output,
-      runtimeMode: "server",
-      scriptPathExists: () => false,
-      fetchImpl: async (_url, init) => {
-        requests.push({ body: JSON.parse(String(init?.body)) });
-        return Response.json({ content: "ok", dialogId: "dialog-1" });
-      },
-    });
-
-    expect(requests[0]?.body).toMatchObject({
-      continueDialogId: "dialog-existing",
-    });
-    expect(requests[0]?.body).not.toHaveProperty("inheritedFromDialogKey");
-    expect(requests[0]?.body).not.toHaveProperty("parentDialogId");
-  });
-
-  test("treats blank continueDialogId as absent for HTTP runs", async () => {
-    const output = new CaptureOutput();
-    const requests: Array<{ body: any }> = [];
-
-    await runAgentTurn({
-      agentName: "nolo",
-      agentKey: "agent-pub-test",
-      serverUrl: "https://nolo.chat",
-      message: "hello",
-      continueDialogId: "   ",
-      inheritedFromDialogKey: "dialog-user-1-dialog-2",
-      parentDialogId: "dialog-2",
-      scriptDir: "C:/missing/scripts",
-      env: { AUTH_TOKEN: "token-123" },
-      output,
-      runtimeMode: "server",
-      scriptPathExists: () => false,
-      fetchImpl: async (_url, init) => {
-        requests.push({ body: JSON.parse(String(init?.body)) });
-        return Response.json({ content: "ok", dialogId: "dialog-1" });
-      },
-    });
-
-    expect(requests[0]?.body).not.toHaveProperty("continueDialogId");
-    expect(requests[0]?.body).toMatchObject({
-      inheritedFromDialogKey: "dialog-user-1-dialog-2",
-      parentDialogId: "dialog-2",
-    });
-  });
-
   test("records background task-run handoff as running instead of completed", async () => {
     const output = new CaptureOutput();
     const writebacks: any[] = [];
@@ -1040,7 +866,7 @@ describe("cli agent run client", () => {
     expect(output.text()).toContain("queryTableRows, taskRun");
   });
 
-  test("auto mode falls back to HTTP when local config cannot be read for a non-platform agent", async () => {
+  test("auto mode skips known platform agents when local config cannot be read", async () => {
     const output = new CaptureOutput();
     const httpCalls: Array<{ url: string; body: any }> = [];
 
@@ -1082,7 +908,7 @@ describe("cli agent run client", () => {
     expect(result).toEqual({ exitCode: 0, dialogId: "dialog-server" });
     expect(httpCalls).toHaveLength(1);
     expect(httpCalls[0]?.body.agentKey).toBe(NOLO_PROJECT_MANAGER_AGENT_KEY);
-    expect(output.text()).toContain("nolo-project-manager -> working locally");
+    expect(output.text()).toContain("known platform agent");
     expect(output.text()).toContain("nolo-project-manager -> working");
     expect(output.text()).toContain("nolo-project-manager > server ok");
   });
@@ -1238,8 +1064,8 @@ describe("cli agent run client", () => {
     expect(output.text()).toContain("Set AUTH_TOKEN");
   });
 
-  test("prints a friendly connection hint instead of crashing on transport errors", async () => {
-    const output = new CaptureOutput();
+  test("prints a friendly connection hint instead of crashing on transport errors", async () => {
+    const output = new CaptureOutput();
 
     const result = await runAgentTurn({
       agentName: "nolo",
@@ -1255,30 +1081,8 @@ describe("cli agent run client", () => {
       },
     });
 
-    expect(result).toEqual({ exitCode: 1 });
-    expect(output.text()).toContain("Could not reach http://127.0.0.1:38123/api/agent/run");
-    expect(output.text()).toContain("set NOLO_SERVER");
-  });
-
-  test("mentions sandboxed network isolation for remote transport failures", async () => {
-    const output = new CaptureOutput();
-
-    const result = await runAgentTurn({
-      agentName: "nolo",
-      agentKey: "agent-pub-test",
-      serverUrl: "https://nolo.chat",
-      message: "hello",
-      scriptDir: "C:/missing/scripts",
-      env: { AUTH_TOKEN: "token-123" },
-      output,
-      scriptPathExists: () => false,
-      fetchImpl: async () => {
-        throw new TypeError("Unable to connect. Is the computer able to access the url?");
-      },
-    });
-
-    expect(result).toEqual({ exitCode: 1 });
-    expect(output.text()).toContain("sandboxed agent session");
-    expect(output.text()).toContain("host machine can reach the server");
-  });
-});
+    expect(result).toEqual({ exitCode: 1 });
+    expect(output.text()).toContain("Could not reach http://127.0.0.1:38123/api/agent/run");
+    expect(output.text()).toContain("set NOLO_SERVER");
+  });
+});