nolo-cli 0.1.21 → 0.1.22

package/ai/skills/skillDocProtocol.ts

@@ -47,12 +47,30 @@ export interface SkillEvalConfig {
   cases: SkillEvalCase[];
 }
 
+export interface WorkflowReferenceConfig {
+  version: "0.1";
+  kind: "workflow";
+  id?: string;
+  name: string;
+  description: string;
+  defaultAgent?: string;
+  inputs?: string[];
+  recommendedTools?: string[];
+  requiredTools?: string[];
+  requiredOutputs?: string[];
+  gates?: string[];
+  budgetTier?: SkillBudgetTier;
+  contextStrategy?: string;
+  failureProtocol?: string;
+}
+
 export interface PageSkillMetadata {
   kind?: SkillDocKind;
   requiredSkills?: string[];
   recommendedSkills?: string[];
   skillConfig?: SkillDocConfig;
   evalConfig?: SkillEvalConfig;
+  workflowConfig?: WorkflowReferenceConfig;
 }
 
 export interface ParsedSkillDocProtocol {
@@ -71,6 +89,7 @@ export interface ParsedExternalSkillMarkdown {
 
 const SKILL_CONFIG_BLOCK = "skill-config";
 const EVAL_CONFIG_BLOCK = "eval-config";
+const WORKFLOW_CONFIG_BLOCK = "workflow-config";
 
 const normalizeStringArray = (value: unknown): string[] | undefined => {
   if (!Array.isArray(value)) return undefined;
@@ -200,6 +219,49 @@ const normalizeEvalConfig = (value: unknown): SkillEvalConfig | undefined => {
     : undefined;
 };
 
+const normalizeWorkflowConfig = (value: unknown): WorkflowReferenceConfig | undefined => {
+  if (!value || typeof value !== "object") return undefined;
+  const record = value as Record<string, unknown>;
+  const name =
+    typeof record.name === "string" && record.name.trim()
+      ? record.name.trim()
+      : "";
+  const description =
+    typeof record.description === "string" && record.description.trim()
+      ? record.description.trim()
+      : "";
+  if (!name || !description) return undefined;
+  const budgetTier = normalizeSkillEnumValue("budgetTier", record.budgetTier);
+  return {
+    version: "0.1",
+    kind: "workflow",
+    id:
+      typeof record.id === "string" && record.id.trim()
+        ? record.id.trim()
+        : undefined,
+    name,
+    description,
+    defaultAgent:
+      typeof record.defaultAgent === "string" && record.defaultAgent.trim()
+        ? record.defaultAgent.trim()
+        : undefined,
+    inputs: normalizeStringArray(record.inputs),
+    recommendedTools: normalizeStringArray(record.recommendedTools),
+    requiredTools: normalizeStringArray(record.requiredTools),
+    requiredOutputs: normalizeStringArray(record.requiredOutputs),
+    gates: normalizeStringArray(record.gates),
+    budgetTier,
+    contextStrategy:
+      typeof record.contextStrategy === "string" && record.contextStrategy.trim()
+        ? record.contextStrategy.trim()
+        : undefined,
+    failureProtocol:
+      typeof record.failureProtocol === "string" && record.failureProtocol.trim()
+        ? record.failureProtocol.trim()
+        : undefined,
+  };
+};
+
 const normalizePageSkillMetadata = (
   value: unknown,
   fallbackTools?: string[]
@@ -214,17 +276,22 @@ const normalizePageSkillMetadata = (
     recommendedSkills: normalizeStringArray(record.recommendedSkills),
     skillConfig: normalizeSkillConfig(record.skillConfig, fallbackTools),
     evalConfig: normalizeEvalConfig(record.evalConfig),
+    workflowConfig: normalizeWorkflowConfig(record.workflowConfig),
   };
 
   if (meta.skillConfig && !meta.kind) {
     meta.kind = "skill";
   }
+  if (meta.workflowConfig && !meta.kind) {
+    meta.kind = "instruction";
+  }
 
   return meta.kind ||
     meta.requiredSkills ||
     meta.recommendedSkills ||
     meta.skillConfig ||
-    meta.evalConfig
+    meta.evalConfig ||
+    meta.workflowConfig
     ? meta
     : undefined;
 };
@@ -268,9 +335,13 @@ export const parseSkillDocProtocol = (
   const source = typeof markdown === "string" ? markdown : "";
   const skillBlock = parseYamlObject(extractCommentBlock(source, SKILL_CONFIG_BLOCK));
   const evalBlock = parseYamlObject(extractCommentBlock(source, EVAL_CONFIG_BLOCK));
+  const workflowBlock = parseYamlObject(extractCommentBlock(source, WORKFLOW_CONFIG_BLOCK));
   const cleanedContent = removeCommentBlock(
-    removeCommentBlock(source, SKILL_CONFIG_BLOCK),
-    EVAL_CONFIG_BLOCK
+    removeCommentBlock(
+      removeCommentBlock(source, SKILL_CONFIG_BLOCK),
+      EVAL_CONFIG_BLOCK
+    ),
+    WORKFLOW_CONFIG_BLOCK
   )
     .replace(/\n{3,}/g, "\n\n")
     .trim();
@@ -292,6 +363,7 @@ export const parseSkillDocProtocol = (
           }
         : {}),
       ...(evalBlock ? { evalConfig: evalBlock } : {}),
+      ...(workflowBlock ? { workflowConfig: workflowBlock } : {}),
     },
     fallbackTools
   );
@@ -364,15 +436,35 @@ export const buildEvalConfigComment = (config: SkillEvalConfig): string =>
     cases: config.cases,
   })}\n-->`;
 
+export const buildWorkflowConfigComment = (config: WorkflowReferenceConfig): string =>
+  `<!-- ${WORKFLOW_CONFIG_BLOCK}\n${yamlBlock({
+    version: config.version,
+    kind: config.kind,
+    ...(config.id ? { id: config.id } : {}),
+    name: config.name,
+    description: config.description,
+    ...(config.defaultAgent ? { defaultAgent: config.defaultAgent } : {}),
+    ...(config.inputs?.length ? { inputs: config.inputs } : {}),
+    ...(config.recommendedTools?.length ? { recommendedTools: config.recommendedTools } : {}),
+    ...(config.requiredTools?.length ? { requiredTools: config.requiredTools } : {}),
+    ...(config.requiredOutputs?.length ? { requiredOutputs: config.requiredOutputs } : {}),
+    ...(config.gates?.length ? { gates: config.gates } : {}),
+    ...(config.budgetTier ? { budgetTier: config.budgetTier } : {}),
+    ...(config.contextStrategy ? { contextStrategy: config.contextStrategy } : {}),
+    ...(config.failureProtocol ? { failureProtocol: config.failureProtocol } : {}),
+  })}\n-->`;
+
 export const buildSkillDocMarkdown = (options: {
   body?: string;
   skillConfig: SkillDocConfig;
   evalConfig?: SkillEvalConfig;
+  workflowConfig?: WorkflowReferenceConfig;
 }): string => {
   const sections = [
     options.body?.trim() || "",
     buildSkillConfigComment(options.skillConfig),
     options.evalConfig ? buildEvalConfigComment(options.evalConfig) : "",
+    options.workflowConfig ? buildWorkflowConfigComment(options.workflowConfig) : "",
   ].filter(Boolean);
   return sections.join("\n\n").trim();
 };

package/client/agentRun.test.ts

@@ -7,6 +7,7 @@ import {
   runAgentTurn,
   shouldUseScriptBridge,
 } from "./agentRun";
+import { NOLO_PROJECT_MANAGER_AGENT_KEY } from "../agentAliases";
 
 class CaptureOutput extends Writable {
   chunks: string[] = [];
@@ -571,7 +572,7 @@ describe("cli agent run client", () => {
 
     const result = await runAgentTurn({
       agentName: "pm",
-      agentKey: "nolo-project-manager",
+      agentKey: "agent-custom-platform-tools",
       serverUrl: "https://nolo.chat",
       message: "write task rows",
       scriptDir: "C:/missing/scripts",
@@ -608,13 +609,60 @@ describe("cli agent run client", () => {
 
     expect(result).toEqual({ exitCode: 0, dialogId: "dialog-server" });
     expect(httpCalls).toHaveLength(1);
-    expect(httpCalls[0]?.body.agentKey).toBe("nolo-project-manager");
+    expect(httpCalls[0]?.body.agentKey).toBe("agent-custom-platform-tools");
     expect(output.text()).toContain("auto runtime: skipping local runtime");
     expect(output.text()).toContain("queryTableRows, addTableRow, updateTableRow");
     expect(output.text()).toContain("pm -> working");
     expect(output.text()).toContain("pm > server ok");
   });
 
+  test("auto mode skips known platform agents when local config cannot be read", async () => {
+    const output = new CaptureOutput();
+    const httpCalls: Array<{ url: string; body: any }> = [];
+
+    const result = await runAgentTurn({
+      agentName: "nolo-project-manager",
+      agentKey: NOLO_PROJECT_MANAGER_AGENT_KEY,
+      serverUrl: "https://us.nolo.chat",
+      message: "write task rows",
+      scriptDir: "C:/missing/scripts",
+      env: { AUTH_TOKEN: "token-123", OPENAI_API_KEY: "local-provider-present" },
+      output,
+      runtimeMode: "auto",
+      localRuntimeAdapter: {
+        host: "cli",
+        capabilities: ["leveldb-agent-config", "local-provider", "local-tools"],
+        loadAgentConfig: async () => {
+          throw new Error("Database failed to open: LOCK");
+        },
+        loadDialogHistory: async () => {
+          throw new Error("local runtime should be skipped");
+        },
+        saveTurn: async () => {
+          throw new Error("local runtime should be skipped");
+        },
+        resolveProvider: async () => {
+          throw new Error("local provider should be skipped");
+        },
+        executeTool: async () => {
+          throw new Error("local tools should be skipped");
+        },
+      },
+      scriptPathExists: () => false,
+      fetchImpl: async (url, init) => {
+        httpCalls.push({ url: String(url), body: JSON.parse(String(init?.body)) });
+        return Response.json({ content: "server ok", dialogId: "dialog-server" });
+      },
+    });
+
+    expect(result).toEqual({ exitCode: 0, dialogId: "dialog-server" });
+    expect(httpCalls).toHaveLength(1);
+    expect(httpCalls[0]?.body.agentKey).toBe(NOLO_PROJECT_MANAGER_AGENT_KEY);
+    expect(output.text()).toContain("known platform agent");
+    expect(output.text()).toContain("nolo-project-manager -> working");
+    expect(output.text()).toContain("nolo-project-manager > server ok");
+  });
+
   test("builds the default local adapter when env requests local mode", async () => {
     const output = new CaptureOutput();
     const builtModes: string[] = [];

package/client/agentRun.ts

@@ -1,6 +1,13 @@
 import { existsSync } from "node:fs";
 import { join } from "node:path";
 import { runLocalAgentTurn } from "../agentRuntimeLocal";
+import {
+  FRONTEND_IMPLEMENTER_AGENT_KEY,
+  NOLO_FULLSTACK_AGENT_KEY,
+  NOLO_PROJECT_MANAGER_AGENT_KEY,
+  NOLO_REVIEW_AGENT_KEY,
+  NOLO_SENIOR_FULLSTACK_AGENT_KEY,
+} from "../agentAliases";
 import type { LocalAgentToolEvent } from "../agent-runtime/localLoop";
 import type { AgentRuntimeHostAdapter, AgentRuntimeRequestedMode } from "../agentRuntimeLocal";
 import { createCliLocalRuntimeAdapter } from "./localRuntimeAdapter";
@@ -84,6 +91,38 @@ const SERVER_PLATFORM_TOOL_NAMES = new Set([
   "updateTableRows",
 ]);
 
+const KNOWN_SERVER_PLATFORM_AGENT_KEYS = new Set([
+  FRONTEND_IMPLEMENTER_AGENT_KEY,
+  NOLO_FULLSTACK_AGENT_KEY,
+  NOLO_PROJECT_MANAGER_AGENT_KEY,
+  NOLO_REVIEW_AGENT_KEY,
+  NOLO_SENIOR_FULLSTACK_AGENT_KEY,
+]);
+
+const KNOWN_SERVER_PLATFORM_AGENT_ALIASES = new Set([
+  "code-review",
+  "frontend",
+  "frontend-agent",
+  "frontend-implementer",
+  "full-stack",
+  "fullstack",
+  "nolo code review",
+  "nolo frontend",
+  "nolo fullstack",
+  "nolo project manager",
+  "nolo reviewer",
+  "nolo-code-review",
+  "nolo-frontend",
+  "nolo-fullstack",
+  "nolo-pm",
+  "nolo-project-manager",
+  "nolo-reviewer",
+  "pm",
+  "project-manager",
+  "review",
+  "reviewer",
+]);
+
 export function shouldUseScriptBridge(decision: ScriptBridgeDecision) {
   return !decision.hasAuthToken && decision.scriptPathExists;
 }
@@ -92,6 +131,16 @@ export function findServerPlatformTools(toolNames?: string[]) {
   if (!Array.isArray(toolNames)) return [];
   return toolNames.filter((toolName) => SERVER_PLATFORM_TOOL_NAMES.has(toolName));
 }
+
+function normalizeAgentRef(ref?: string) {
+  return ref?.trim().toLowerCase().replace(/\s+/g, " ");
+}
+
+function isKnownServerPlatformAgent(options: RunAgentTurnOptions) {
+  if (KNOWN_SERVER_PLATFORM_AGENT_KEYS.has(options.agentKey)) return true;
+  const normalizedKey = normalizeAgentRef(options.agentKey);
+  return Boolean(normalizedKey && KNOWN_SERVER_PLATFORM_AGENT_ALIASES.has(normalizedKey));
+}
 
 function resolveAuthToken(env: EnvLike) {
   return env.AUTH_TOKEN || env.AUTH || env.BENCHMARK_AUTH_TOKEN || "";
@@ -126,6 +175,13 @@ function resolveLocalRuntimeAdapter(options: RunAgentTurnOptions) {
 }
 
 async function shouldSkipAutoLocalForServerPlatformTools(options: RunAgentTurnOptions) {
+  if (isKnownServerPlatformAgent(options)) {
+    options.output.write(
+      `[nolo] auto runtime: skipping local runtime because ${options.agentKey} is a known platform agent. ` +
+        "Use --local explicitly to force local workspace tools.\n"
+    );
+    return true;
+  }
   const adapter = resolveLocalRuntimeAdapter(options);
   if (!adapter) return false;
   let agentConfig;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nolo-cli",
-  "version": "0.1.21",
+  "version": "0.1.22",
   "type": "module",
   "description": "Agent-first terminal workspace for Nolo",
   "bin": {