noiton 2.0.0 → 2.0.2

package/src/lib/detect.js

@@ -1,18 +1,15 @@
 /**
  * NOITON Agent Detection
  *
- * Detects which AI coding agents are installed on the system by:
- *   1. Checking if the CLI binary is on PATH (which)
- *   2. Checking if the config file exists
- *
- * Returns a list of detected agents with metadata.
+ * Detects which AI coding agents are installed on the system.
+ * Detection requires the CLI binary to be on PATH (not just config files,
+ * which can be leftover from uninstalled tools).
  */
 
 import { existsSync } from "node:fs";
 import { join } from "node:path";
 import { homedir } from "node:os";
 import { execSync } from "node:child_process";
-import { c } from "../constants.js";
 
 const HOME = homedir();
 const XDG = process.env.XDG_CONFIG_HOME || join(HOME, ".config");
@@ -24,7 +21,7 @@ const XDG = process.env.XDG_CONFIG_HOME || join(HOME, ".config");
  */
 function hasBin(bin) {
   try {
-    execSync(`which ${bin} 2>/dev/null`, { stdio: "ignore" });
+    execSync(`command -v ${bin} 2>/dev/null`, { stdio: "ignore" });
     return true;
   } catch {
     return false;
@@ -44,7 +41,6 @@ function getBinVersion(bin) {
         encoding: "utf8",
         timeout: 5000,
       }).trim();
-      // Extract first version-like token
       const match = out.match(/(\d+\.\d+(?:\.\d+)?(?:-\w+)?)/);
       if (match) return match[1];
       return out.split("\n")[0];
@@ -76,8 +72,6 @@ function getNpmLatest(pkg) {
 /**
  * Compare two semver-like version strings.
  * Returns: 1 if a > b, -1 if a < b, 0 if equal.
- * @param {string} a
- * @param {string} b
  */
 function compareVersions(a, b) {
   const pa = a.split(".").map(Number);
@@ -93,10 +87,6 @@ function compareVersions(a, b) {
 
 // ============= AGENT DEFINITIONS =============
 
-/**
- * Registry of all supported agents.
- * Each entry describes how to detect the agent and where its config lives.
- */
 export const AGENT_REGISTRY = [
   {
     id: "opencode",
@@ -125,109 +115,42 @@ export const AGENT_REGISTRY = [
     description: "Assistente que faz tarefas e se integra com apps",
     useCase: "assistant",
   },
-  {
-    id: "openclaw",
-    name: "OpenClaw",
-    type: "CLI",
-    bin: "openclaw",
-    npmPkg: null,
-    installMethod: null,
-    installCmd: null,
-    configPath: join(HOME, ".openclaw", "openclaw.json"),
-    supportsMultipleModels: true,
-    description: "Agente de IA open-source com providers customizáveis",
-    useCase: "programming",
-  },
-  {
-    id: "cline",
-    name: "Cline",
-    type: "VSCode Extension",
-    bin: null,
-    npmPkg: null,
-    installMethod: null,
-    installCmd: null,
-    configPath: join(XDG, "Code", "User", "settings.json"),
-    supportsMultipleModels: true,
-    description: "Extensão VS Code para programação com IA",
-    useCase: "programming",
-  },
-  {
-    id: "aider",
-    name: "Aider",
-    type: "CLI",
-    bin: "aider",
-    npmPkg: null,
-    installMethod: "pip",
-    installCmd: "pip install aider-chat",
-    configPath: join(HOME, ".aider.conf.yml"),
-    supportsMultipleModels: false,
-    description: "Pair programmer de terminal que edita código com você",
-    useCase: "programming",
-  },
-  {
-    id: "kilo",
-    name: "Kilo Code",
-    type: "CLI + VSCode",
-    bin: "kilo",
-    npmPkg: "@kilocode/cli",
-    installMethod: "npm",
-    installCmd: "npm install -g @kilocode/cli",
-    configPath: join(XDG, "kilo", "kilo.jsonc"),
-    supportsMultipleModels: true,
-    description: "Agente de IA com CLI e extensão VS Code",
-    useCase: "programming",
-  },
-  {
-    id: "kimi",
-    name: "Kimi Code",
-    type: "CLI + VSCode",
-    bin: "kimi",
-    npmPkg: null,
-    installMethod: null,
-    installCmd: null,
-    configPath: join(HOME, ".kimi-code", "config.toml"),
-    supportsMultipleModels: false,
-    description: "Agente de IA da Moonshot com CLI e VS Code",
-    useCase: "programming",
-  },
 ];
 
 /**
  * Detect all installed agents.
+ * An agent is "installed" only if its binary is on PATH.
+ * Config files alone are NOT enough (could be leftover from uninstalled tools).
  * @returns {Array} detected agents with status info
  */
 export function detectAgents() {
   const detected = [];
   for (const agent of AGENT_REGISTRY) {
-    const binFound = agent.bin ? hasBin(agent.bin) : false;
-    const configFound = existsSync(agent.configPath);
-    const installed = binFound || configFound;
-
-    if (installed) {
-      const version = binFound ? getBinVersion(agent.bin) : null;
-      detected.push({
-        ...agent,
-        installed: true,
-        version,
-        binFound,
-        configFound,
-      });
-    }
+    if (!agent.bin) continue;
+    const binFound = hasBin(agent.bin);
+    if (!binFound) continue;
+
+    const version = getBinVersion(agent.bin);
+    detected.push({
+      ...agent,
+      installed: true,
+      version,
+      binFound: true,
+      configFound: existsSync(agent.configPath),
+    });
   }
   return detected;
 }
 
 /**
- * Check if a specific agent is installed.
+ * Check if a specific agent is installed (binary on PATH).
  * @param {string} id
  * @returns {boolean}
  */
 export function isAgentInstalled(id) {
   const agent = AGENT_REGISTRY.find((a) => a.id === id);
-  if (!agent) return false;
-  const binFound = agent.bin ? hasBin(agent.bin) : false;
-  const configFound = existsSync(agent.configPath);
-  return binFound || configFound;
+  if (!agent || !agent.bin) return false;
+  return hasBin(agent.bin);
 }
 
 /**
@@ -240,13 +163,10 @@ export function getOpenCodeStatus() {
   if (!agent) return null;
 
   const binFound = hasBin("opencode");
-  const configFound = existsSync(agent.configPath);
-  const installed = binFound || configFound;
+  if (!binFound) return null;
 
-  if (!installed) return null;
-
-  const version = binFound ? getBinVersion("opencode") : null;
-  const latest = binFound ? getNpmLatest("opencode-ai") : null;
+  const version = getBinVersion("opencode");
+  const latest = getNpmLatest("opencode-ai");
   const updateAvailable =
     version && latest ? compareVersions(latest, version) > 0 : false;
 
@@ -256,8 +176,29 @@ export function getOpenCodeStatus() {
     version,
     latest,
     updateAvailable,
-    binFound,
-    configFound,
+    binFound: true,
+    configFound: existsSync(agent.configPath),
+  };
+}
+
+/**
+ * Get the Hermes agent status.
+ * @returns {object|null}
+ */
+export function getHermesStatus() {
+  const agent = AGENT_REGISTRY.find((a) => a.id === "hermes");
+  if (!agent) return null;
+
+  const binFound = hasBin("hermes");
+  if (!binFound) return null;
+
+  const version = getBinVersion("hermes");
+  return {
+    ...agent,
+    installed: true,
+    version,
+    binFound: true,
+    configFound: existsSync(agent.configPath),
   };
 }
 
@@ -275,7 +216,6 @@ export function getInstallableAgents() {
  * @returns {object|null}
  */
 export function getRecommendedAgent(useCase) {
-  // Prefer OpenCode for programming, Hermes for assistant
   if (useCase === "programming") {
     return AGENT_REGISTRY.find((a) => a.id === "opencode");
   }

package/src/lib/install.js

@@ -80,8 +80,6 @@ export async function updateAgent(agentId) {
 
   const updateCmds = {
     opencode: "curl -fsSL https://opencode.ai/install | bash",
-    kilo: "npm update -g @kilocode/cli",
-    aider: "pip install --upgrade aider-chat",
     hermes: "pip install --upgrade nous-hermes",
   };