noibu-react-native 0.2.35-rc.4 → 0.2.35-rc.6

package/android/build.gradle

@@ -66,5 +66,5 @@ def kotlin_version = getExtOrDefault("kotlinVersion")
 dependencies {
     implementation "com.facebook.react:react-native:+"
     implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
-    implementation "com.noibu:sessionreplay-recorder:1.0.5-rc.2"
+    implementation "com.noibu:sessionreplay-recorder:1.0.5-rc.3"
 }

package/dist/constants.js

@@ -24,7 +24,7 @@ const CONTENT_TYPE = 'content-type';
  * Gets the script id from the cookie object, returns default if cannot be found
  */
 function GET_SCRIPT_ID() {
-    return "1.0.104-rn-sdk-0.2.35-rc.4" ;
+    return "1.0.104-rn-sdk-0.2.35-rc.6" ;
 }
 /**
  * Gets the max metro recon number

package/dist/monitors/RequestMonitor.js

@@ -10,6 +10,7 @@ import { HTTPDataBundler } from './http-tools/HTTPDataBundler.js';
 import GqlErrorValidator from './http-tools/GqlErrorValidator.js';
 import { Singleton } from './BaseMonitor.js';
 import { Severity, PageVisitErrorSource } from 'noibu-metroplex-ts-bindings';
+import { removePII } from '../utils/piiRedactor.js';
 
 /** request monitor */
 const BODY_USED_ERROR = 'Response data unavailable due to an improperly wrapped fetch call';
@@ -162,7 +163,15 @@ class RequestMonitor extends Singleton {
                     ? yield GqlErrorValidator.fromFetchResponseText(url, options, request, status, responseText)
                     : null;
                 const isHttpError = isHttpCodeFailure(status);
-                const maybeRequestText = shouldCaptureBody ? yield Promise.resolve((_a = request === null || request === void 0 ? void 0 : request.text) === null || _a === void 0 ? void 0 : _a.call(request)) : undefined;
+                let maybeRequestText;
+                if (shouldCaptureBody) {
+                    try {
+                        maybeRequestText = yield ((_a = request === null || request === void 0 ? void 0 : request.text) === null || _a === void 0 ? void 0 : _a.call(request));
+                    }
+                    catch (_b) {
+                        // request body unavailable (e.g. whatwg-fetch polyfill "Already read") — proceed without it
+                    }
+                }
                 const responseTextForHttp = shouldCaptureBody
                     ? responseText !== null && responseText !== void 0 ? responseText : BODY_USED_ERROR
                     : undefined;
@@ -173,7 +182,7 @@ class RequestMonitor extends Singleton {
                 const seq = saveHTTPEvent(httpEvent, httpData, !!gqlError);
                 if (isHttpError) {
                     // this does not consume response body so no need to clone it
-                    saveErrorToPagevisit(Object.assign(Object.assign({}, ogResponse), { type: PageVisitErrorSource.Response }), seq);
+                    saveErrorToPagevisit(JSON.parse(removePII(JSON.stringify(Object.assign(Object.assign({}, ogResponse), { type: PageVisitErrorSource.Response })))), seq);
                 }
                 if (gqlError) {
                     gqlError.forEach(error => saveErrorToPagevisit({
@@ -244,22 +253,28 @@ class RequestMonitor extends Singleton {
                  * once and rebuild a fresh Response to avoid mutating the customer's bodyUsed.
                  */
                 const customerPromise = promiseFromOriginalFetch.then((ogResponse) => __awaiter(this, void 0, void 0, function* () {
-                    const shouldCheckGql = GqlErrorValidator.shouldCheckRequest(url, options, request);
-                    const shouldCaptureBody = HTTPDataBundler.getInstance().shouldContinueForURL(url);
-                    const shouldReadBody = shouldCaptureBody || shouldCheckGql;
-                    let customerResponse = ogResponse;
-                    let responseText;
-                    if (shouldReadBody) {
-                        const buffered = yield RequestMonitor.readResponseBody(ogResponse);
-                        if (buffered) {
-                            responseText = buffered.text;
-                            customerResponse = RequestMonitor.buildCustomerResponse(ogResponse, buffered.body);
+                    try {
+                        const shouldCheckGql = GqlErrorValidator.shouldCheckRequest(url, options, request);
+                        const shouldCaptureBody = HTTPDataBundler.getInstance().shouldContinueForURL(url);
+                        const shouldReadBody = shouldCaptureBody || shouldCheckGql;
+                        let customerResponse = ogResponse;
+                        let responseText;
+                        if (shouldReadBody) {
+                            const buffered = yield RequestMonitor.readResponseBody(ogResponse);
+                            if (buffered) {
+                                responseText = buffered.text;
+                                customerResponse = RequestMonitor.buildCustomerResponse(ogResponse, buffered.body);
+                            }
                         }
+                        RequestMonitor.handleFetchResponse(startTime, url, method, options, request, ogResponse, responseText, shouldCaptureBody, shouldCheckGql).catch(() => {
+                            // errors are handled inside handleFetchResponse
+                        });
+                        return customerResponse;
+                    }
+                    catch (_a) {
+                        // SDK processing failed — return original response so the customer is never affected
+                        return ogResponse;
                     }
-                    RequestMonitor.handleFetchResponse(startTime, url, method, options, request, ogResponse, responseText, shouldCaptureBody, shouldCheckGql).catch(() => {
-                        // errors are handled inside handleFetchResponse
-                    });
-                    return customerResponse;
                 }));
                 customerPromise.catch(err => {
                     RequestMonitor.handleFetchFailure(err, url);

package/dist/utils/piiRedactor.js

@@ -60,6 +60,7 @@ const exactFieldsToRedact = [
     'cardnumber',
     'email',
 ];
+const MAX_NESTED_JSON_REDACTION_DEPTH = 5;
 /**
  * Redacts one string, returns redacted value or false if nothing to redact
  */
@@ -70,10 +71,12 @@ function shouldRedact(field) {
 /**
  * Try to parse content as a JSON object and
  * iterate it recursively removing PII.
- * Returns original content if nothing was changes or error is thrown.
- * @param {String} content
+ * Also handles string values that contain serialized JSON by parsing and redacting them recursively.
+ * Returns original content if nothing was changed or error is thrown.
+ * @param {String} content - The string to parse and redact PII from
+ * @param {Number} maxDepth - Maximum recursion depth for nested JSON strings (default: MAX_NESTED_JSON_REDACTION_DEPTH)
  */
-function tryParseObjectAndRemovePII(content) {
+function tryParseObjectAndRemovePII(content, maxDepth = MAX_NESTED_JSON_REDACTION_DEPTH) {
     const first = content[0];
     const isParsable = first === '{' || first === '[';
     if (!isParsable) {
@@ -82,7 +85,7 @@ function tryParseObjectAndRemovePII(content) {
     let redacted = false;
     try {
         const instance = JSON.parse(content);
-        iterateObjectRecursively(instance, (current, property) => {
+        iterateObjectRecursively(instance, (current, property, value) => {
             if (typeof property !== 'string') {
                 return undefined;
             }
@@ -92,6 +95,23 @@ function tryParseObjectAndRemovePII(content) {
                 redacted = true;
                 return PII_REDACTION_REPLACEMENT_STRING;
             }
+            // If the value is a JSON string, parse it and redact recursively
+            // maxDepth guards against deeply nested structures affecting performance
+            if (typeof value === 'string' && maxDepth > 1) {
+                try {
+                    const parsed = JSON.parse(value);
+                    if (typeof parsed === 'object' && parsed !== null) {
+                        const redactedString = tryParseObjectAndRemovePII(value, maxDepth - 1);
+                        if (redactedString !== value) {
+                            redacted = true;
+                            return redactedString;
+                        }
+                    }
+                }
+                catch (_a) {
+                    // not valid JSON, leave as is
+                }
+            }
             return undefined;
         });
         return redacted ? stringifyJSON(instance) : content;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "noibu-react-native",
-  "version": "0.2.35-rc.4",
+  "version": "0.2.35-rc.6",
   "targetNjsVersion": "1.0.104",
   "description": "React-Native SDK for NoibuJS to collect errors in React-Native applications",
   "main": "dist/entry/index.js",