nofax 0.2.4 → 0.2.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nofax",
-  "version": "0.2.4",
+  "version": "0.2.6",
   "mcpName": "io.github.AKzar1el/nofax",
   "description": "Human-in-the-loop approvals and notifications for AI coding agents via CLI, MCP, and agent hooks.",
   "type": "module",

package/src/mcp-server.mjs

@@ -74,7 +74,7 @@ const LIST_PENDING_OUTPUT_SCHEMA = z.object({
 
 export function buildMcpServer({ handlers = createMcpToolHandlers() } = {}) {
   const server = new McpServer(
-    { name: 'nofax', version: '0.2.4' },
+    { name: 'nofax', version: '0.2.6' },
     { instructions: SERVER_INSTRUCTIONS }
   );
 
@@ -156,7 +156,7 @@ export function buildMcpServer({ handlers = createMcpToolHandlers() } = {}) {
         waitSeconds: z.number().int().min(1).max(240).optional().describe('Maximum seconds to long-poll during this call; defaults to 240. A timeout still returns pending, never approval.')
       }),
       outputSchema: WAIT_OUTPUT_SCHEMA,
-      annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: true }
+      annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: true, openWorldHint: true }
     },
     async (args) => result(await handlers.waitForResponse(args))
   );

package/src/mcp-tools.mjs

@@ -140,6 +140,17 @@ export function createMcpToolHandlers(overrides = {}) {
     return pendingResult(remote.requestId);
   }
 
+  async function createDurableRemote(kind, input) {
+    let persisted;
+    const remote = await deps.createRemoteRequestImpl({
+      ...input,
+      beforePublish: async (prepared) => {
+        persisted = await persistRemote({ kind, remote: prepared });
+      }
+    });
+    return persisted ?? persistRemote({ kind, remote });
+  }
+
   return {
     async notify({ title = 'Nofax', message }) {
       const current = await config();
@@ -153,7 +164,7 @@ export function createMcpToolHandlers(overrides = {}) {
 
     async requestApproval({ title = 'Nofax approval', message, allowRefine = false }) {
       const current = await config();
-      const remote = await deps.createRemoteRequestImpl({
+      return createDurableRemote('approval', {
         config: current,
         title: validateText(title, 'TITLE', 120),
         message: validateText(message, 'MESSAGE'),
@@ -163,32 +174,29 @@ export function createMcpToolHandlers(overrides = {}) {
         ],
         includeRefine: allowRefine === true
       });
-      return persistRemote({ kind: 'approval', remote });
     },
 
     async requestChoice({ title = 'Nofax choice', message, options }) {
       const current = await config();
       const normalized = validateChoiceOptions(options);
-      const remote = await deps.createRemoteRequestImpl({
+      return createDurableRemote('choice', {
         config: current,
         title: validateText(title, 'TITLE', 120),
         message: validateText(message, 'MESSAGE'),
         options: normalized,
         includeRefine: false
       });
-      return persistRemote({ kind: 'choice', remote });
     },
 
     async requestRefinement({ title = 'Nofax refinement', message }) {
       const current = await config();
-      const remote = await deps.createRemoteRequestImpl({
+      return createDurableRemote('refinement', {
         config: current,
         title: validateText(title, 'TITLE', 120),
         message: validateText(message, 'MESSAGE'),
         options: [],
         includeRefine: true
       });
-      return persistRemote({ kind: 'refinement', remote });
     },
 
     async waitForResponse({ requestId, waitSeconds }) {
@@ -213,11 +221,15 @@ export function createMcpToolHandlers(overrides = {}) {
             response,
             resolvedAt: new Date(deps.nowImpl()).toISOString()
           });
-          await deps.sendResponseConfirmationImpl({
-            config: current,
-            response,
-            title: request.kind === 'approval' ? 'Approval' : request.kind === 'refinement' ? 'Refinement' : 'Choice'
-          });
+          const acceptedResponse = request.decision === response.decision
+            && (request.text ?? undefined) === (response.text ?? undefined);
+          if (acceptedResponse) {
+            await deps.sendResponseConfirmationImpl({
+              config: current,
+              response,
+              title: request.kind === 'approval' ? 'Approval' : request.kind === 'refinement' ? 'Refinement' : 'Choice'
+            });
+          }
           return terminalResult(request);
         }
         const remaining = deadline - deps.nowImpl();

package/src/ntfy.mjs

@@ -96,6 +96,7 @@ export async function createRemoteRequest({
   options = [],
   includeRefine = false,
   shortcutName = config.refineShortcutName ?? DEFAULT_REFINE_SHORTCUT,
+  beforePublish = async () => {},
   fetchImpl = fetch
 }) {
   const normalized = normalizeOptions(options);
@@ -126,8 +127,10 @@ export async function createRemoteRequest({
     }
   }
 
+  const remote = { requestId, responseTopic, allowed };
+  await beforePublish(remote);
   await sendNotification({ config, title, message, actions, fetchImpl });
-  return { requestId, responseTopic, allowed };
+  return remote;
 }
 
 function parseNtfyPoll(text, requestId, allowed) {
@@ -149,7 +152,7 @@ function parseNtfyPoll(text, requestId, allowed) {
 export async function pollRemoteResponse({ config, responseTopic, requestId, allowed, fetchImpl = fetch }) {
   let response;
   try {
-    response = await fetchImpl(`${config.server}/${responseTopic}/json?poll=1&since=10m`, {
+    response = await fetchImpl(`${config.server}/${responseTopic}/json?poll=1&since=all`, {
       method: 'GET',
       headers: { accept: 'application/x-ndjson' }
     });