nodester 0.4.0 → 0.4.1

package/lib/controllers/mixins/index.js

@@ -151,12 +151,12 @@ function _withDefaultErrorProcessing(controller, options={}) {
 		switch(error.name) {
 			case UNAUTHORIZED_ERROR: {
 				statusCode = 401;
-				errorResponse.details = { message: 'Unauthorized' };
+				errorResponse.details = error?.details ?? { message: 'Unauthorized' };
 				break;
 			}
 			case NOT_FOUND_ERROR: {
 				statusCode = 404;
-				errorResponse.details = { message: errorMessage };
+				errorResponse.details = error?.details ?? { message: errorMessage };
 				break;
 			}
 			case NODESTER_QUERY_ERROR: {
@@ -166,7 +166,7 @@ function _withDefaultErrorProcessing(controller, options={}) {
 			}
 			case VALIDATION_ERROR: {
 				statusCode = 422;
-				errorResponse.details = error?.details;
+				errorResponse.details = error?.details ?? error?.details;
 				break;
 			}
 			case CONFLICT_ERROR: {
@@ -181,11 +181,11 @@ function _withDefaultErrorProcessing(controller, options={}) {
 			}
 			case INTERNAL_VALIDATION_ERROR: {
 				statusCode = 500;
-				errorResponse.details = { message: errorMessage };
+				errorResponse.details = error?.details ?? { message: errorMessage };
 				break;
 			}
 			default: {
-				errorResponse.details = { message: errorMessage };
+				errorResponse.details = error?.details ?? { message: errorMessage };
 				break;
 			}
 		}

package/lib/facades/methods/index.js

@@ -5,6 +5,10 @@
  
 'use strict';
 
+// Constants:
+const HTTP_CODES = require('nodester/http/codes');
+const HTTP_CODE_DESCRIPTIONS = require('nodester/http/codes/descriptions');
+
 const Params = require('nodester/params');
 
 const log = require('nodester/loggers/dev');
@@ -184,8 +188,18 @@ async function _deleteOne(params) {
 
 		const count = await this.model.deleteOne(query);
 
+		// Model was not found:
+		if (count === 0) {
+			const err = new Error(HTTP_CODE_DESCRIPTIONS.NOT_FOUND);
+			err.statusCode = HTTP_CODES.NOT_FOUND;
+			err.details = {
+				message: 'Resource not found. Nothing was deleted.'
+			}
+
+			throw err;
+		}
+
 		const result = {
-			success: count > 0,
 			count: count
 		};
 
@@ -195,7 +209,12 @@ async function _deleteOne(params) {
 		return Promise.resolve(result);
 	}
 	catch(error) {
-		log.error(`${ this.name }.deleteOne error:`, error);
+		
+		// 404 will not be logged:
+		if (error.statusCode !== HTTP_CODES.NOT_FOUND) {
+			log.error(`${ this.name }.deleteOne error:`, error);
+		}
+
 		return Promise.reject(error);
 	}
 }

package/lib/query/traverse/index.js

@@ -389,7 +389,6 @@ function _traverseIncludedOrders(resultQuery, rootModel) {
 	for (let i=0; i < resultQuery.include.length; i++) {
 		const include = resultQuery.include[i];
 
-		console.log({ irder: include?.order });
 		if (!include?.order) {
 			continue;
 		}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodester",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "A versatile REST framework for Node.js",
   "directories": {
     "docs": "docs",