nodejs-audio-visualizer 4.2.5 → 4.3.6

package/src/tests/subtitleConvert.test.ts

@@ -0,0 +1,23 @@
+import { expect } from 'chai';
+import { lrcToSrt, isLikelyLrc, normalizeInlineSubtitlesToSrt } from '../subtitleConvert';
+
+describe('subtitleConvert', function () {
+  it('isLikelyLrc', function () {
+    expect(isLikelyLrc('[00:01.00]Hello')).equal(true);
+    expect(isLikelyLrc('1\n00:00:01,000 --> 00:00:02,000\nSRT')).equal(false);
+  });
+
+  it('lrcToSrt converts basic LRC to SRT', function () {
+    const lrc = '[00:01.00]Line one\n[00:03.50]Line two';
+    const srt = lrcToSrt(lrc);
+    expect(srt).to.include('00:00:01,000 --> 00:00:03,500');
+    expect(srt).to.include('Line one');
+    expect(srt).to.include('00:00:03,500 -->');
+    expect(srt).to.include('Line two');
+  });
+
+  it('normalizeInlineSubtitlesToSrt leaves SRT unchanged', function () {
+    const s = '1\n00:00:00,000 --> 00:00:01,000\nX';
+    expect(normalizeInlineSubtitlesToSrt(s)).equal(s);
+  });
+});

package/src/tests/video.test.ts

@@ -68,4 +68,71 @@ describe('video', function () {
     expect(tIdx).greaterThan(-1);
     expect(spawnArgs[tIdx + 1]).to.equal('15');
   });
+
+  it('spawnFfmpegVideoWriter adds subtitles filter when subtitle file is provided', function () {
+    const childProcessReadableStream = new Readable();
+    childProcessReadableStream._read = () => { };
+    const childProcessWritableStream = new Writable();
+    (<Pipe>childProcessWritableStream.pipe) = () => childProcessWritableStream;
+
+    childProcessStream.stdin = childProcessWritableStream;
+    childProcessStream.stderr = childProcessReadableStream;
+
+    let spawnArgs: string[] = [];
+    const spawnStub = child_process.spawn as SinonStub;
+    spawnStub.callsFake((_cmd: string, args: string[]) => {
+      spawnArgs = args;
+      return childProcessStream as ChildProcessWithoutNullStreams;
+    });
+
+    spawnFfmpegVideoWriter({
+      audioFilename: 'audio.mp3',
+      subtitleFilename: '/tmp/subtitles.srt',
+      videoFileName: 'out.mp4',
+      fps: 25,
+    });
+
+    spawnStub.resetBehavior();
+    spawnStub.returns(childProcessStream as ChildProcessWithoutNullStreams);
+
+    const vfIdx = spawnArgs.indexOf('-vf');
+    expect(vfIdx).greaterThan(-1);
+    expect(spawnArgs[vfIdx + 1]).to.equal(
+      "subtitles='/tmp/subtitles.srt':force_style='Alignment=2'",
+    );
+  });
+
+  it('spawnFfmpegVideoWriter passes subtitle Alignment from subtitleAlignmentAss', function () {
+    const childProcessReadableStream = new Readable();
+    childProcessReadableStream._read = () => { };
+    const childProcessWritableStream = new Writable();
+    (<Pipe>childProcessWritableStream.pipe) = () => childProcessWritableStream;
+
+    childProcessStream.stdin = childProcessWritableStream;
+    childProcessStream.stderr = childProcessReadableStream;
+
+    let spawnArgs: string[] = [];
+    const spawnStub = child_process.spawn as SinonStub;
+    spawnStub.callsFake((_cmd: string, args: string[]) => {
+      spawnArgs = args;
+      return childProcessStream as ChildProcessWithoutNullStreams;
+    });
+
+    spawnFfmpegVideoWriter({
+      audioFilename: 'audio.mp3',
+      subtitleFilename: '/tmp/subtitles.srt',
+      subtitleAlignmentAss: 8,
+      videoFileName: 'out.mp4',
+      fps: 25,
+    });
+
+    spawnStub.resetBehavior();
+    spawnStub.returns(childProcessStream as ChildProcessWithoutNullStreams);
+
+    const vfIdx = spawnArgs.indexOf('-vf');
+    expect(vfIdx).greaterThan(-1);
+    expect(spawnArgs[vfIdx + 1]).to.equal(
+      "subtitles='/tmp/subtitles.srt':force_style='Alignment=8'",
+    );
+  });
 });

package/src/video.ts

@@ -12,6 +12,9 @@ export interface AudioMuxSegment {
 
 interface FfmpegVideoWriterConfig {
   audioFilename: string;
+  subtitleFilename?: string;
+  /** ASS `Alignment` in FFmpeg `subtitles` `force_style` (e.g. 2 bottom, 5 middle, 8 top). Default 2. */
+  subtitleAlignmentAss?: number;
   videoFileName: string;
   fps: number;
   crf?: string;
@@ -24,6 +27,15 @@ interface FfmpegVideoWriterConfig {
   audioSegment?: AudioMuxSegment;
 }
 
+const escapeSubtitleFilterPath = (subtitlePath: string) =>
+  subtitlePath
+    .replace(/\\/g, '\\\\')
+    .replace(/:/g, '\\:')
+    .replace(/'/g, "\\'")
+    .replace(/,/g, '\\,')
+    .replace(/\[/g, '\\[')
+    .replace(/\]/g, '\\]');
+
 export const spawnFfmpegVideoWriter = (config: FfmpegVideoWriterConfig) => {
   if (!ffmpegPath) {
     throw new Error('ffmpeg path not found');
@@ -42,7 +54,21 @@ export const spawnFfmpegVideoWriter = (config: FfmpegVideoWriterConfig) => {
     '-i', config.audioFilename,
     '-crf', crf,
     '-c:a', 'aac', '-b:a', '384k', '-profile:a', 'aac_low',
-    '-c:v', 'libx264', '-r', `${config.fps}`, '-pix_fmt', 'yuv420p', '-preset', preset, config.videoFileName,
+    '-c:v', 'libx264',
+    '-r', `${config.fps}`,
+    '-pix_fmt', 'yuv420p',
+    '-preset', preset,
+  );
+  if (config.subtitleFilename) {
+    const subPath = escapeSubtitleFilterPath(config.subtitleFilename);
+    const alignment = config.subtitleAlignmentAss ?? 2;
+    args.push(
+      '-vf',
+      `subtitles='${subPath}':force_style='Alignment=${alignment}'`,
+    );
+  }
+  args.push(
+    config.videoFileName,
     '-r', `${config.fps}`,
     '-i', '-'
   );
@@ -364,6 +390,12 @@ export const writeConcatFile = (
   return concatPath;
 };
 
+export const writeSubtitlesFile = (subtitles: string): string => {
+  const subtitlePath = joinPath(tmpdir(), `av-subtitles-${Date.now()}.srt`);
+  writeFileSync(subtitlePath, subtitles, 'utf-8');
+  return subtitlePath;
+};
+
 export const spawnConcatVideoFrameReader = (config: {
   concatFilePath: string;
   fps: number;
@@ -398,6 +430,8 @@ export const spawnConcatVideoFrameReader = (config: {
   return spawn(ffmpegPath, args);
 };
 
-export const cleanupConcatFile = (filePath: string) => {
+export const cleanupTempFile = (filePath: string) => {
   try { unlinkSync(filePath); } catch {}
 };
+
+export const cleanupConcatFile = cleanupTempFile;