nodebb-theme-persona 14.0.15 → 14.0.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-theme-persona",
-  "version": "14.0.15",
+  "version": "14.0.16",
   "nbbpm": {
     "compatibility": "^4.0.0"
   },

package/public/modules/mobile-menu.js

@@ -19,7 +19,7 @@ define('persona/mobile-menu', [
 		if (!menuEl || !chatsMenuEl) {
 			return;
 		}
-		const chatMenuVisible = app.user && parseInt(app.user.uid, 10);
+		const chatMenuVisible = app.user && app.user.userslug;
 		let swapped = !!Storage.getItem('persona:menus:legacy-layout');
 		const margin = window.innerWidth;
 
@@ -118,7 +118,7 @@ define('persona/mobile-menu', [
 		$('#user-control-list').children().clone(true, true).appendTo($('#chats-menu [data-section="profile"] ul'));
 
 		socket.on('event:user_status_change', function (data) {
-			if (parseInt(data.uid, 10) === app.user.uid) {
+			if (String(data.uid) === String(app.user.uid)) {
 				app.updateUserStatus($('#chats-menu [component="user/status"]'), data.status);
 				navSlideout.close();
 			}

package/public/persona.js

@@ -166,35 +166,30 @@ $(document).ready(function () {
 	function generateUserCard(ev) {
 		var avatar = $(this);
 		var uid = avatar.parents('[data-uid]').attr('data-uid');
-		var data = (ajaxify.data.topics || ajaxify.data.posts);
-
-		for (var i = 0, ii = data.length; i < ii; i++) {
-			if (parseInt(data[i].uid, 10) === parseInt(uid, 10)) {
-				data = data[i].user;
-				break;
-			}
-		}
+		const topicOrPost = (ajaxify.data.topics || ajaxify.data.posts || []).find(d => String(d.uid) === String(uid));
+		if (!topicOrPost) return;
+		const user = topicOrPost.user;
 
 		$('.persona-usercard').remove();
 
-		if (parseInt(data.uid, 10) === 0) {
+		if (!user.userslug) {
 			return false;
 		}
 
-		socket.emit('user.isFollowing', { uid: data.uid }, function (err, isFollowing) {
+		socket.emit('user.isFollowing', { uid: user.uid }, function (err, isFollowing) {
 			if (err) {
 				return err;
 			}
 
-			app.parseAndTranslate('modules/usercard', data, function (html) {
+			app.parseAndTranslate('modules/usercard', user, function (html) {
 				var card = $(html);
 				avatar.parents('a').after(card.hide());
 
-				if (parseInt(app.user.uid, 10) === parseInt(data.uid, 10) || !app.user.uid) {
+				if (String(app.user.uid) === String(user.uid) || !app.user.uid) {
 					card.find('.btn-morph').hide();
 				} else {
-					const uid = isFinite(data.uid) ? data.uid : encodeURIComponent(data.userslug);
-					setupFavouriteMorph(card, uid, data.username);
+					const uid = isFinite(user.uid) ? user.uid : encodeURIComponent(user.userslug);
+					setupFavouriteMorph(card, uid, user.username);
 
 					if (isFollowing) {
 						$('.btn-morph').addClass('heart');

package/templates/partials/topics_list.tpl

@@ -54,7 +54,7 @@
 					{function.buildCategoryLabel, ./category, "a", "border"}
 					{{{ end }}}
 
-					<span data-tid="{./tid}" component="topic/tags" class="lh-1 tag-list hidden-xs d-flex flex-wrap gap-1 {{{ if !./tags.length }}}hidden{{{ end }}}">
+					<span data-tid="{./tid}" component="topic/tags" class="lh-1 tag-list d-flex flex-wrap gap-1 {{{ if !./tags.length }}}hidden{{{ end }}}">
 						{{{ each ./tags }}}
 						<a href="{config.relative_path}/tags/{./valueEncoded}"><span class="badge border border-gray-300 fw-normal tag tag-class-{./class}" data-tag="{./value}">{./valueEscaped}</span></a>
 						{{{ end }}}