nodebb-plugin-web-push 0.7.8 → 0.7.10

package/lib/controllers.js

@@ -20,7 +20,10 @@ Controllers.renderSettings = async function (req, res) {
 	const payload = {
 		...res.locals.userData,
 		title: '[[web-push:profile.label]]',
-		breadcrumbs: helpers.buildBreadcrumbs([{ text: username, url: `/user/${userslug}` }, { text: '[[web-push:profile.label]]' }]),
+		breadcrumbs: helpers.buildBreadcrumbs([
+			{ text: username, url: `/user/${userslug}` },
+			{ text: '[[web-push:profile.label]]' },
+		]),
 		count,
 	};
 

package/library.js

@@ -105,7 +105,8 @@ plugin.addRoutes = async ({ router, middleware, helpers }) => {
 		const payload = await constructPayload({
 			nid: utils.generateUUID(),
 			bodyShort: 'Test notification',
-			bodyLong: 'This is a test message sent from NodeBB',
+			// test notification shouldn't show any html chars
+			bodyLong: 'This is a &lt;bdi&gt;test&lt;/bdi&gt; message sent from <strong>NodeBB</strong>',
 			path: `/me/web-push`,
 		}, req.uid, userLang);
 		await webPush.sendNotification(subscription, JSON.stringify(payload));
@@ -218,7 +219,7 @@ async function constructPayload(notification, uid, lang) {
 	const { nid, mergeId, bodyShort, bodyLong, path } = notification;
 
 	let [title, body] = await translator.translateKeys([bodyShort, bodyLong], lang);
-	([title, body] = [title, body].map(str => validator.unescape(utils.stripHTMLTags(str))));
+	([title, body] = [title, body].map(str => utils.stripHTMLTags(utils.decodeHTMLEntities(str))));
 	title = `${dir === 'rtl' ? '\u200f' : '\u200e'}${title}`;
 	const tag = mergeId || nid;
 	const url = `${nconf.get('url')}${path}`;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-web-push",
-  "version": "0.7.8",
+  "version": "0.7.10",
   "description": "A plugin for adding native push notifications to NodeBB via the Web Push API.",
   "main": "library.js",
   "repository": {
@@ -43,7 +43,7 @@
     "@eslint/js": "^10.0.1",
     "eslint-config-nodebb": "^2.0.2",
     "husky": "9.1.7",
-    "lint-staged": "17.0.5"
+    "lint-staged": "17.0.8"
   },
   "dependencies": {
     "validator": "^13.12.0",

package/public/lib/settings.js

@@ -83,15 +83,15 @@ export async function init() {
 // as value for applicationServerKey in pushManager.subscribe yet
 // https://bugs.chromium.org/p/chromium/issues/detail?id=802280
 function urlBase64ToUint8Array(base64String) {
-	var padding = '='.repeat((4 - (base64String.length % 4)) % 4);
-	var base64 = (base64String + padding)
+	const padding = '='.repeat((4 - (base64String.length % 4)) % 4);
+	const base64 = (base64String + padding)
 		.replace(/-/g, '+')
 		.replace(/_/g, '/');
 
-	var rawData = window.atob(base64);
-	var outputArray = new Uint8Array(rawData.length);
+	const rawData = window.atob(base64);
+	const outputArray = new Uint8Array(rawData.length);
 
-	for (var i = 0; i < rawData.length; ++i) {
+	for (let i = 0; i < rawData.length; ++i) {
 		outputArray[i] = rawData.charCodeAt(i);
 	}
 	return outputArray;