nodebb-plugin-web-push 0.3.0 → 0.4.0

package/library.js

@@ -127,7 +127,8 @@ plugin.onNotificationPush = async ({ notification, uidsNotified: uids }) => {
 				await webPush.sendNotification(subscription, JSON.stringify(payload));
 			} catch (e) {
 				// Errored — remove subscription from user
-				subscriptions.remove(uid, subscription);
+				winston.info(`[plugins/web-push] Push failed: ${e.code}; ${e.message}; statusCode: ${e.statusCode}`);
+				// subscriptions.remove(uid, subscription);
 			}
 		});
 	});
@@ -153,6 +154,9 @@ plugin.addProfileItem = async (data) => {
 };
 
 async function constructPayload({ bodyShort, bodyLong, path }, language) {
+	let { maxLength } = await meta.settings.get('web-push');
+	maxLength = parseInt(maxLength, 10) || 256;
+
 	if (!language) {
 		language = meta.config.defaultLang || 'en-GB';
 	}
@@ -167,6 +171,11 @@ async function constructPayload({ bodyShort, bodyLong, path }, language) {
 		title = meta.config.title || 'NodeBB';
 	}
 
+	// Truncate body if needed
+	if (body.length > maxLength) {
+		body = `${body.slice(0, maxLength)}…`;
+	}
+
 	return {
 		title,
 		body,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-web-push",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "description": "A starter kit for quickly creating NodeBB plugins",
   "main": "library.js",
   "repository": {

package/templates/admin/plugins/web-push.tpl

@@ -7,9 +7,14 @@
 				<div class="mb-4">
 					<h5 class="fw-bold tracking-tight settings-header">Settings</h5>
 
-					<p class="fst-italic">
-						There are no settings to adjust for this plugin — at this time.
-					</p>
+					<div class="mb-3">
+						<label class="form-label" for="maxLength">Maximum length</label>
+						<input type="number" min="0" max="4096" id="maxLength" name="maxLength" title="Maximum message length" class="form-control" placeholder="256">
+						<p class="form-text">
+							Additional characters beyond this specified length will be truncated.
+							Due to a software limitation, if the message body is greater than 4096 bytes, the message itself will be an attachment in the push notification.
+						</p>
+					</div>
 				</div>
 			</form>