nodebb-plugin-session-sharing 7.1.2 → 7.1.3

package/README.md

@@ -18,11 +18,6 @@ if the requisite shared cookie is found (more on that below).
 
 You can use this plugin and single sign-on plugins together, but they won't be seamlessly integrated.
 
-## Compatibility
-
-This plugin is compatible with NodeBB **v1.0.0 and up**. As of 27 January 2016, v1.0.0 has not been released
-yet, so you will need to be running the `master` branch of a NodeBB installation via GitHub.
-
 ## How does this work?
 
 This plugin checks incoming requests for a **shared cookie** that is saved by your application when a user
@@ -112,4 +107,4 @@ mode. NodeBB will then log in or create a user called "testUser", with the email
 might accidentally lock yourself out of the administrative account as you won't have a proper cookie to
 authenticate with. To reset the plugin settings, delete the "settings:session-sharing" hash/document in
 your data store. In a pinch, running `./nodebb reset -p nodebb-plugin-session-sharing` will work to disable
-the plugin so you can log back in.
+the plugin so you can log back in.

package/library.js

@@ -54,6 +54,8 @@ const plugin = {
 	},
 };
 
+plugin.defaults = Object.freeze({ ...plugin.settings });
+
 payloadKeys.forEach(function (key) {
 	plugin.settings['payload:' + key] = key;
 });
@@ -99,7 +101,7 @@ SocketPlugins.sessionSharing.showUserIds = async (socket, data) => {
 		throw new Error('no-uids-supplied');
 	}
 
-	return Promise.all(uids.map(async uid => db.getSortedSetRangeByScore(plugin.settings.name + ':uid', 0, -1, uid, uid)));
+	return Promise.all(uids.map(async (uid) => db.getSortedSetRangeByScore(plugin.settings.name + ':uid', 0, -1, uid, uid)));
 };
 
 SocketPlugins.sessionSharing.findUserByRemoteId = async (socket, data) => {
@@ -301,12 +303,12 @@ plugin.updateUserGroups = async (uid, userData) => {
 	// Retrieve user groups
 	let [userGroups] = await groups.getUserGroupsFromSet('groups:createtime', [uid]);
 	// Normalize user group data to just group names
-	userGroups = userGroups.map(groupObj => groupObj.name);
+	userGroups = userGroups.map((groupObj) => groupObj.name);
 
 	// Build join and leave arrays
-	let join = userData.groups.filter(name => !userGroups.includes(name));
+	let join = userData.groups.filter((name) => !userGroups.includes(name));
 	if (plugin.settings.syncGroupList === 'on') {
-		join = join.filter(group => plugin.settings.syncGroups.includes(group));
+		join = join.filter((group) => plugin.settings.syncGroups.includes(group));
 	}
 
 	let leave = userGroups.filter((name) => {
@@ -318,7 +320,7 @@ plugin.updateUserGroups = async (uid, userData) => {
 		return !userData.groups.includes(name);
 	});
 	if (plugin.settings.syncGroupList === 'on') {
-		leave = leave.filter(group => plugin.settings.syncGroups.includes(group));
+		leave = leave.filter((group) => plugin.settings.syncGroups.includes(group));
 	}
 
 	await executeJoinLeave(uid, join, leave);
@@ -331,14 +333,14 @@ async function executeJoinLeave(uid, join, leave) {
 				return;
 			}
 
-			await Promise.all(join.map(name => groups.join(name, uid)));
+			await Promise.all(join.map((name) => groups.join(name, uid)));
 		})(),
 		(async () => {
 			if (plugin.settings.syncGroupLeave !== 'on') {
 				return;
 			}
 
-			await Promise.all(leave.map(name => groups.leave(name, uid)));
+			await Promise.all(leave.map((name) => groups.leave(name, uid)));
 		})(),
 	]);
 }
@@ -566,7 +568,7 @@ plugin.reloadSettings = async (data) => {
 	}
 
 	winston.info('[session-sharing] Settings OK');
-	plugin.settings = _.defaults(_.pickBy(settings, Boolean), plugin.settings);
+	plugin.settings = _.defaults(_.pickBy(settings, Boolean), plugin.defaults);
 	plugin.ready = true;
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-session-sharing",
-  "version": "7.1.2",
+  "version": "7.1.3",
   "description": "Allows login sessions from your app to persist in NodeBB",
   "main": "library.js",
   "repository": {
@@ -46,9 +46,10 @@
   "devDependencies": {
     "@commitlint/cli": "^9.1.2",
     "@commitlint/config-angular": "^7.1.2",
-    "eslint": "^7.7.0",
-    "eslint-config-airbnb-base": "^12.1.0",
-    "eslint-plugin-import": "^2.8.0",
+    "eslint": "8.x",
+    "eslint-config-airbnb-base": "14.2.1",
+    "eslint-config-nodebb": "0.1.1",
+    "eslint-plugin-import": "2.x",
     "husky": "^2.4.0",
     "lint-staged": "^10.0.9",
     "request": "^2.88.2",