nodebb-plugin-search-agent 0.0.92 → 0.0.94

package/lib/searchHandler.js

@@ -1,3 +1,9 @@
+// ─── Token estimation helper ───────────────────────────────────────────────
+function estimateTokens(str) {
+	// Roughly 4 chars/token for English, 2 for Hebrew/UTF-8, but 4 is safe for cost estimation
+	return Math.ceil(str.length / 4);
+}
+
 'use strict';
 
 const https = require('https');
@@ -10,10 +16,42 @@ let cachedTopicMap = null;
 let cacheTs = 0;
 const CACHE_TTL_MS = 5 * 60 * 1000; // 5 minutes
 
+// ─── Search result cache ──────────────────────────────────────────────────────
+// Caches final search results by normalised query string.
+// Saves all AI calls for repeated queries within the TTL window.
+
+const _searchCache = new Map();
+const SEARCH_CACHE_TTL_MS = 10 * 60 * 1000; // 10 minutes
+const SEARCH_CACHE_MAX = 200;
+
+function _normalizeQuery(q) {
+	return q.trim().toLowerCase().replace(/\s+/g, ' ');
+}
+
+function _getSearchCache(queryText) {
+	const key = _normalizeQuery(queryText);
+	const entry = _searchCache.get(key);
+	if (entry && (Date.now() - entry.ts) < SEARCH_CACHE_TTL_MS) {
+		return entry.results;
+	}
+	_searchCache.delete(key);
+	return null;
+}
+
+function _setSearchCache(queryText, results) {
+	const key = _normalizeQuery(queryText);
+	_searchCache.set(key, { results, ts: Date.now() });
+	if (_searchCache.size > SEARCH_CACHE_MAX) {
+		// Evict the oldest entry
+		_searchCache.delete(_searchCache.keys().next().value);
+	}
+}
+
 function invalidateCache() {
 	cachedIndex = null;
 	cachedTopicMap = null;
 	cacheTs = 0;
+	_searchCache.clear();
 	require.main.require('winston').info('[search-agent] Topic index cache invalidated.');
 }
 
@@ -30,6 +68,8 @@ async function getSettings() {
 		openaiModel: (raw.openaiModel || 'gpt-4o-mini').trim(),
 		// How many TF-IDF candidates to send to AI for re-ranking
 		aiCandidates: Math.min(100, Math.max(5, parseInt(raw.aiCandidates, 10) || 30)),
+		// HyDE: generate a hypothetical answer before embedding — improves recall but costs one extra LLM call per search
+		hydeEnabled: raw.hydeEnabled === 'on',
 		// Visibility: 'all' = all logged-in users, 'admins' = administrators only
 		visibleTo: raw.visibleTo || 'all',
 		// Whether guests (non-logged-in users) may use the widget
@@ -141,18 +181,18 @@ function callOpenAI(apiKey, model, messages) {
  * @param {string} model
  * @returns {Promise<string>}
  */
-async function expandQueryWithHyDE(queryText, apiKey, model) {
-	const response = await callOpenAI(apiKey, model, [
-		{
-			role: 'system',
-			content:
-				'אתה חבר בפורום. בהינתן שאלת חיפוש, כתוב פוסט תגובה קצר וריאליסטי בפורום שעונה ישירות על השאלה. ' +
-				'כתוב רק את תוכן הפוסט — ללא ברכות, הערות מטא, או שורת נושא.',
-		},
-		{ role: 'user', content: queryText },
-	]);
-	return (response.choices[0].message.content || '').trim() || queryText;
-}
+// async function expandQueryWithHyDE(queryText, apiKey, model) {
+// 	const response = await callOpenAI(apiKey, model, [
+// 		{
+// 			role: 'system',
+// 			content:
+// 				'אתה חבר בפורום. בהינתן שאלת חיפוש, כתוב פוסט תגובה קצר וריאליסטי בפורום שעונה ישירות על השאלה. ' +
+// 				'כתוב רק את תוכן הפוסט — ללא ברכות, הערות מטא, או שורת נושא.',
+// 		},
+// 		{ role: 'user', content: queryText },
+// 	]);
+// 	return (response.choices[0].message.content || '').trim() || queryText;
+// }
 
 /**
  * Send candidates to OpenAI for independent per-topic relevance scoring.
@@ -163,25 +203,39 @@ async function expandQueryWithHyDE(queryText, apiKey, model) {
  */
 async function reRankWithAI(queryText, candidates, topicMap, apiKey, model, maxResults, snippetByTid = {}) {
 	console.log('Re-ranking with AI:', { queryText, candidates: candidates.map(c => ({ tid: c.tid, title: (topicMap[String(c.tid)] || {}).title })) });
-    const candidateList = candidates
-		.map((c) => {
-			const title = (topicMap[String(c.tid)] || {}).title || '';
-			const raw = (snippetByTid[String(c.tid)] || '').replace(/<[^>]*>/g, ' ').replace(/[ \t]+/g, ' ').trim();
-			const snippet = raw.length > 0 ? `\n   תוכן: "${raw.slice(0, 1500)}"` : '';
-			return `[tid:${c.tid}] ${title}${snippet}`;
-		})
-		.join('\n\n');
+
+
+	// Embed the query and all candidate post snippets
+
+	const { embed, embedBatch } = require('../services/embeddingService');
+	const queryEmbedding = await embed(queryText);
+	const postSnippets = candidates.map((c) => {
+		const raw = (snippetByTid[String(c.tid)] || '').replace(/<[^>]*>/g, ' ').replace(/[ \t]+/g, ' ').trim();
+		return raw.slice(0, 1500);
+	});
+	const postEmbeddings = await embedBatch(postSnippets);
+
+	// Format: [tid:..., embedding: [v1, v2, ...]]
+	const candidateList = candidates.map((c, i) => {
+		return `[tid:${c.tid}]\nembedding: [${postEmbeddings[i].slice(0, 8).map(x => x.toFixed(4)).join(', ')} ...]`;
+	}).join('\n\n');
 
 	const systemPrompt =
 		'אתה מסנן חיפוש פורום מחמיר. ' +
-		'לכל נושא ברשימה, דרג את הרלוונטיות שלו לשאלת המשתמש בסקלה 0-10: ' +
+		'לכל מועמד ברשימה, דרג את הרלוונטיות של embedding הפוסט לembedding של השאלה בסקלה 0-10: ' +
 		'10 = עונה ישירות ובאופן מלא. 7-9 = עונה על חלק משמעותי. 0-6 = לא רלוונטי. ' +
 		'החזר אך ורק JSON תקני במבנה: {"tid": ציון, ...} — לדוגמה: {"42": 9, "15": 3}. ' +
-		'אין להוסיף הסברים, טקסט נוסף, או עיצוב מחוץ ל-JSON.'+
-        'הוסף שדה נוסף "scoreExplanation" עם משפט קצר שמסביר למה נושא עם ציון נמוך לא רלוונטי, כדי שנוכל להבין את שיקול הדעת של המודל.';
-
+		'אין להוסיף הסברים, טקסט נוסף, או עיצוב מחוץ ל-JSON.';
+        
 	const userMessage =
-		`שאלת המשתמש: "${queryText}"\n\nנושאים:\n${candidateList}`;
+		`embedding של שאלת המשתמש: [${queryEmbedding.slice(0, 8).map(x => x.toFixed(4)).join(', ')} ...]\n\nפוסטים:\n${candidateList}`;
+
+	// --- Token count logging ---
+	const totalEmbeddingChars = queryText.length + postSnippets.reduce((sum, s) => sum + s.length, 0);
+	const embeddingTokens = estimateTokens(queryText) + postSnippets.reduce((sum, s) => sum + estimateTokens(s), 0);
+	const llmPromptTokens = estimateTokens(systemPrompt) + estimateTokens(userMessage);
+	const winston = require.main.require('winston');
+	winston.info(`[search-agent] Token usage: embedding API ≈ ${embeddingTokens} tokens, LLM prompt ≈ ${llmPromptTokens} tokens (for this search)`);
 
 	const response = await callOpenAI(apiKey, model, [
 		{ role: 'system', content: systemPrompt },
@@ -201,12 +255,25 @@ async function reRankWithAI(queryText, candidates, topicMap, apiKey, model, maxR
 	const scores = JSON.parse(match[0]);
 	const candidateByTid = Object.fromEntries(candidates.map(c => [String(c.tid), c]));
 
-	return Object.entries(scores)
-		.filter(([, score]) => Number(score) >= 7)
-		.sort(([, a], [, b]) => Number(b) - Number(a))
-		.slice(0, maxResults)
-		.map(([tid]) => candidateByTid[tid])
-		.filter(Boolean);
+	       let filtered = Object.entries(scores)
+		       .filter(([, score]) => Number(score) >= 7)
+		       .sort(([, a], [, b]) => Number(b) - Number(a))
+		       .slice(0, maxResults)
+		       .map(([tid]) => candidateByTid[tid])
+		       .filter(Boolean);
+
+	       // If nothing passed the threshold, return the top scoring candidate (if any)
+	       if (filtered.length === 0 && candidates.length > 0) {
+		       // Find the tid with the highest score
+		       const sortedAll = Object.entries(scores)
+			       .sort(([, a], [, b]) => Number(b) - Number(a));
+		       if (sortedAll.length > 0) {
+			       const [topTid] = sortedAll[0];
+			       const topCandidate = candidateByTid[topTid];
+			       if (topCandidate) filtered = [topCandidate];
+		       }
+	       }
+	       return filtered;
 }
 
 // ─── Public API ───────────────────────────────────────────────────────────────
@@ -220,6 +287,14 @@ async function reRankWithAI(queryText, candidates, topicMap, apiKey, model, maxR
  */
 async function searchTopics(queryText) {
 	const winston = require.main.require('winston');
+
+	// ── Search result cache ───────────────────────────────────────────────────
+	const cachedResults = _getSearchCache(queryText);
+	if (cachedResults) {
+		winston.verbose(`[search-agent] Search cache hit for "${queryText}" (${cachedResults.length} results)`);
+		return cachedResults;
+	}
+
 	const settings = await getSettings();
 
 	// ── Semantic search (primary) ────────────────────────────────────────────
@@ -230,16 +305,16 @@ async function searchTopics(queryText) {
 		// HyDE: replace the short raw query with a hypothetical answer so the
 		// embedding matches post content more closely.
 		let embeddingQuery = queryText;
-		if (useAI) {
-			try {
-				embeddingQuery = await expandQueryWithHyDE(
-					queryText, settings.openaiApiKey, settings.openaiModel
-				);
-				winston.verbose(`[search-agent] HyDE expanded query (${embeddingQuery.length} chars)`);
-			} catch (hydeErr) {
-				winston.warn(`[search-agent] HyDE expansion failed, using raw query: ${hydeErr.message}`);
-			}
-		}
+		// if (useAI && settings.hydeEnabled) {
+		// 	try {
+		// 		embeddingQuery = await expandQueryWithHyDE(
+		// 			queryText, settings.openaiApiKey, settings.openaiModel
+		// 		);
+		// 		winston.verbose(`[search-agent] HyDE expanded query (${embeddingQuery.length} chars)`);
+		// 	} catch (hydeErr) {
+		// 		winston.warn(`[search-agent] HyDE expansion failed, using raw query: ${hydeErr.message}`);
+		// 	}
+		// }
 
 		// Request more candidates when AI will re-rank them.
 		const vectorLimit = useAI ? settings.aiCandidates : settings.maxResults;
@@ -314,6 +389,7 @@ async function searchTopics(queryText) {
 
 			if (results.length > 0) {
 				winston.info(`[search-agent] Semantic search returned ${results.length} results for "${queryText}".`);
+				_setSearchCache(queryText, results);
 				return results;
 			}
 		}
@@ -369,6 +445,7 @@ async function searchTopics(queryText) {
 		url: `/topic/${(topicMap[String(r.tid)] || {}).slug || r.tid}`,
 	}));
 	winston.info(`[search-agent] Final results: ${JSON.stringify(results.map(r => r.title))}`);
+	_setSearchCache(queryText, results);
 	return results;
 }
 

package/library.js

@@ -30,13 +30,13 @@ plugin.init = async (params) => {
 
 	// Start initial embedding sync in the background — does not block NodeBB startup.
 	winston.info('[search-agent] Starting initial embedding sync…');
-	startSync().catch(err => winston.warn(`[search-agent] Initial sync failed: ${err.message}`));
+    startSync();
 
 	// Re-sync every 10 minutes to pick up new posts.
 	const RESYNC_INTERVAL_MS = 10 * 60 * 1000;
 	setInterval(() => {
 		winston.info('[search-agent] Running scheduled embedding re-sync…');
-		startSync().catch(err => winston.warn(`[search-agent] Scheduled re-sync failed: ${err.message}`));
+        startSync();
 	}, RESYNC_INTERVAL_MS).unref();
 
 	winston.info('[plugins/search-agent] Initialised.');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-search-agent",
-  "version": "0.0.92",
+  "version": "0.0.94",
   "description": "NodeBB plugin that adds a floating chat assistant to help users find relevant forum topics using TF-IDF text similarity",
   "main": "library.js",
   "author": "Racheli Bayfus",