nodebb-plugin-poll 3.2.2 → 3.2.4

package/.eslintrc

@@ -1,116 +1,3 @@
 {
-	"extends": "airbnb-base",
-	"ignorePatterns": ["**/vendor/*.js"],
-	"parserOptions": {
-		"sourceType": "script"
-	},
-
-	"rules": {
-		// === Configure rules for our style ===
-		// imports must be resolvable
-		"import/no-unresolved": "error",
-		// use single quotes,
-		// unless a different style allows avoiding escapes
-		"quotes": ["error", "single", {
-			"avoidEscape": true,
-			"allowTemplateLiterals": true
-		}],
-		// allow else-if return
-		"no-else-return": [ "error", { "allowElseIf": true } ],
-		// expressions split over multiple lines
-		// should break after the operator
-		"operator-linebreak": [ "error", "after" ],
-		// require arrow parens only when needed
-		// and whenever the body is a block
-		"arrow-parens": ["error", "as-needed", { "requireForBlockBody": true }],
-		// what variables are errors in callbacks
-		"handle-callback-err": [ "error","^(e$|(e|(.*(_e|E)))rr)" ],
-		// allow dangling commas in functions
-		// require them everywhere else
-		"comma-dangle": ["error", {
-			"arrays": "always-multiline",
-			"objects": "always-multiline",
-			"imports": "always-multiline",
-			"exports": "always-multiline",
-			"functions": "only-multiline"
-		}],
-		// we actually encourage `return await`
-		"no-return-await": "off",
-		// allow `while (true)`
-		"no-constant-condition": ["error", { "checkLoops": false }],
-		// allow ignoring an error with `catch`
-		"no-empty": ["error", { "allowEmptyCatch": true }],
-		// allow `3 + 5 - 1`, but not `3 * 5 - 1`
-		"no-mixed-operators": ["error", { "allowSamePrecedence": true }],
-		// require `'use strict';`
-		"strict": ["error", "global"],
-		// we actually use tabs for indentation
-		"indent": ["error", "tab", { "SwitchCase": 1 }],
-		"no-tabs": "off",
-		// we want `== null` to also handle undefined
-		"no-eq-null": "off",
-		// allow `for (..; i++)`
-		"no-plusplus": ["error", { "allowForLoopAfterthoughts": true }],
-		// allow using functions defined later
-		"no-use-before-define": ["error", "nofunc"],
-		// require consistent newlines before and after braces
-		// if contents are multiline
-		"object-curly-newline": ["error", { "consistent": true, "multiline": true }],
-		// require consistent linebreaks inline function parenthesis (arguments or params)
-		"function-paren-newline": ["error", "consistent"],
-		// only require const if all parts of destructuring can be const
-		"prefer-const": ["error", { "destructuring": "all" }],
-		// don't require destructuring for arrays or assignment
-		"prefer-destructuring": ["error", {
-			"VariableDeclarator": { "array": false, "object": true },
-			"AssignmentExpression": { "array": false, "object": false }
-		}],
-		// identical to airbnb rule, except for allowing for..of, because we want to use it
-		"no-restricted-syntax": [
-			"error",
-			{
-				"selector": "ForInStatement",
-				"message": "for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array."
-			},
-			{
-				"selector": "LabeledStatement",
-				"message": "Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand."
-			},
-			{
-				"selector": "WithStatement",
-				"message": "`with` is disallowed in strict mode because it makes code impossible to predict and optimize."
-			}
-		],
-		// allow lines of up to 120 characters
-		"max-len": ["error", { "code": 120, "tabWidth": 2, "ignoreUrls": true, "ignoreStrings": true, "ignoreTemplateLiterals": true, "ignoreRegExpLiterals": true }],
-
-		// === Disable rules ===
-		// more liberal naming
-		"camelcase": "off",
-		"no-underscore-dangle": "off",
-		// don't require anonymous function names
-		"func-names": "off",
-		// allow console
-		"no-console": "off",
-		// allow new for side effects
-		// allow new with non-capitalized
-		"no-new": "off",
-		"new-cap": "off",
-		// allow shadowing variables (usually callbacks)
-		"no-shadow": "off",
-		// allow multiple empty lines in a row
-		"no-multiple-empty-lines": "off",
-		// allow not using object shorthand
-		"object-shorthand": "off",
-
-		// TODO
-		"consistent-return": "off",
-		"no-restricted-globals": "off",
-		"no-prototype-builtins": "off",
-		"import/no-extraneous-dependencies": "off",
-		"import/no-dynamic-require": "off",
-		"global-require": "off",
-		"no-param-reassign": "off",
-		"default-case": "off"
-	}
+	"extends": "nodebb"
 }

package/README.md

@@ -11,6 +11,7 @@ Currently supported settings:
 
     maxvotes="1" //Max number of votes per user. If larger than 1, a multiple choice poll will be created
     disallowVoteUpdate="0" //if set, users won't be able to update/remove their vote
+    allowAnonVoting="0" // if set to 1, users will be able to vote anonymously
     title="Poll title" //Poll title
 
 There's also a helpful modal available that will allow you to easily create a poll:

package/languages/en_GB/poll.json

@@ -8,6 +8,7 @@
   "default_title": "Default poll title",
   "max_votes": "Maximum number of votes per user",
   "disallow_vote_update": "Don't allow users to update their vote",
+  "allow_anon_voting": "Allow anonymous voting",
   "info_choices": "A number greater than 1 will enable multiple choice polls.",
   "settings": "Settings",
   "save": "Save",
@@ -29,10 +30,12 @@
 
   "error.not_main": "Can only add poll in main post.",
   "error.privilege.create": "You're not allowed to create a poll",
+  "error.anon-voting-not-allowed": "This poll does not allow voting anonymously",
 
   "warning.redactor": "You're using Redactor. Do <strong>not</strong> edit the markup manually. Instead, re-open the poll creator.",
 
   "vote": "Vote",
+  "vote_anonymously": "Vote anonymously",
   "update_vote": "Update vote",
   "remove_vote": "Remove vote",
   "to_voting": "To Voting",

package/languages/en_US/poll.json

@@ -8,6 +8,7 @@
   "default_title": "Default poll title",
   "max_votes": "Maximum number of votes per user",
   "disallow_vote_update": "Don't allow users to update their vote",
+  "allow_anon_voting": "Allow anonymous voting",
   "info_choices": "A number greater than 1 will enable multiple choice polls.",
   "settings": "Settings",
   "save": "Save",
@@ -29,10 +30,12 @@
 
   "error.not_main": "Can only add poll in main post.",
   "error.privilege.create": "You're not allowed to create a poll",
+  "error.anon-voting-not-allowed": "This poll does not allow voting anonymously",
 
   "warning.redactor": "You're using Redactor. Do <strong>not</strong> edit the markup manually. Instead, re-open the poll creator.",
 
   "vote": "Vote",
+  "vote_anonymously": "Vote anonymously",
   "update_vote": "Update vote",
   "remove_vote": "Remove vote",
   "to_voting": "To Voting",

package/lib/config.js

@@ -28,6 +28,7 @@ Config.defaults = {
 		title: 'Poll',
 		maxvotes: 1,
 		disallowVoteUpdate: 0,
+		allowAnonVoting: 0,
 		end: 0,
 	},
 };

package/lib/sockets.js

@@ -1,5 +1,6 @@
 'use strict';
 
+const _ = require.main.require('lodash');
 const NodeBB = require('./nodebb');
 
 const Config = require('./config');
@@ -31,6 +32,10 @@ Sockets.get = async function (socket, data) {
 		throw new Error('Legacy polls are not supported');
 	}
 
+	if (parseInt(pollData.settings.allowAnonVoting, 10) === 1) {
+		await anonymizeVoters(socket.uid, data.pollId, pollData.options);
+	}
+
 	pollData.optionType = parseInt(pollData.settings.maxvotes, 10) > 1 ? 'checkbox' : 'radio';
 	return pollData;
 };
@@ -59,6 +64,10 @@ Sockets.vote = async function (socket, data) {
 		throw new Error(`You can only vote for ${settings.maxvotes} options on this poll.`);
 	}
 
+	if (data.voteAnon && parseInt(settings.allowAnonVoting, 10) !== 1) {
+		throw new Error('[[poll:error.anon-voting-not-allowed]]');
+	}
+
 	if (!canVote || !data.options.length) {
 		throw new Error('Already voted or invalid option');
 	}
@@ -128,14 +137,20 @@ Sockets.getOptionDetails = async function (socket, data) {
 	if (!socket.uid || !data || isNaN(parseInt(data.pollId, 10)) || isNaN(parseInt(data.optionId, 10))) {
 		throw new Error('Invalid request');
 	}
-	const [poll, option] = await Promise.all([
+	const [poll, settings, option] = await Promise.all([
 		Poll.getInfo(data.pollId),
+		Poll.getSettings(data.pollId),
 		Poll.getOption(data.pollId, data.optionId, true),
 	]);
 
 	if (!option.votes || !option.votes.length) {
 		return option;
 	}
+
+	if (parseInt(settings.allowAnonVoting, 10) === 1) {
+		await anonymizeVoters(socket.uid, data.pollId, [option]);
+	}
+
 	const userData = await NodeBB.User.getUsersFields(option.votes, [
 		'uid', 'username', 'userslug', 'picture',
 	]);
@@ -160,6 +175,23 @@ Sockets.canCreate = async function (socket, data) {
 	return await checkPrivs(data.cid, socket.uid);
 };
 
+async function anonymizeVoters(callerUid, pollId, options) {
+	const uids = _.uniq(options.map(opt => opt.votes).flat());
+	const [isAnon, isPrivileged] = await Promise.all([
+		NodeBB.db.isSortedSetMembers(`poll:${pollId}:anon:voters`, uids),
+		NodeBB.User.isPrivileged(callerUid),
+	]);
+	if (isPrivileged) {
+		return;
+	}
+	const uidToIsAnon = _.zipObject(uids, isAnon);
+	options.forEach((opt) => {
+		opt.votes = opt.votes.map(
+			uid => (uidToIsAnon[uid] && String(callerUid) !== uid ? 0 : uid)
+		);
+	});
+}
+
 async function checkPrivs(cid, socketUid) {
 	const can = await NodeBB.Privileges.categories.can('poll:create', cid, socketUid);
 	if (!can) {

package/lib/vote.js

@@ -9,12 +9,19 @@ Vote.add = async function (voteData) {
 	const { pollId, options, uid } = voteData;
 	const timestamp = +new Date();
 
-	await Promise.all([
+	const promises = [
 		NodeBB.db.sortedSetAdd(`poll:${pollId}:voters`, timestamp, uid),
 		NodeBB.db.sortedSetAddBulk(
 			options.map(option => ([`poll:${pollId}:options:${option}:votes`, timestamp, uid]))
 		),
-	]);
+	];
+	if (voteData.voteAnon) {
+		promises.push(
+			NodeBB.db.sortedSetAdd(`poll:${pollId}:anon:voters`, timestamp, uid)
+		);
+	}
+
+	await Promise.all(promises);
 };
 
 Vote.remove = async function (voteData) {
@@ -29,7 +36,10 @@ Vote.removeUidVote = async function (uid, pollId) {
 	const vote = await Vote.getUidVote(uid, pollId);
 	const options = vote.options || [];
 	await Promise.all([
-		NodeBB.db.sortedSetRemove(`poll:${pollId}:voters`, uid),
+		NodeBB.db.sortedSetsRemove([
+			`poll:${pollId}:voters`,
+			`poll:${pollId}:anon:voters`,
+		], uid),
 		NodeBB.db.sortedSetsRemove(
 			options.map(option => `poll:${pollId}:options:${option}:votes`),
 			uid,
@@ -49,7 +59,10 @@ Vote.getUidVote = async function (uid, pollId) {
 };
 
 Vote.update = async function (voteData) {
+	const { uid, pollId } = voteData;
+	const isVotedAnon = await NodeBB.db.isSortedSetMember(`poll:${pollId}:anon:voters`, uid);
 	await Vote.remove(voteData);
+	voteData.voteAnon = isVotedAnon;
 	await Vote.add(voteData);
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-poll",
-  "version": "3.2.2",
+  "version": "3.2.4",
   "description": "NodeBB Poll Plugin",
   "main": "library.js",
   "scripts": {
@@ -26,7 +26,7 @@
     "cron": "^1.8.2"
   },
   "nbbpm": {
-    "compatibility": "^3.2.0"
+    "compatibility": "^4.0.0"
   },
   "devDependencies": {
     "eslint": "8.57.0",

package/public/js/.eslintrc

@@ -1,82 +1,3 @@
 {
-	"globals": {
-		"app": true,
-		"io": true,
-		"socket": true,
-		"ajaxify": true,
-		"config": true,
-		"utils": true,
-		"overrides": true,
-		"componentHandler": true,
-		"bootbox": true,
-		"Visibility": true,
-		"Tinycon": true,
-		"Promise": true
-	},
-	"env": {
-		"jquery": true,
-		"amd": true,
-		"browser": true,
-		"es6": true
-	},
-	"rules": {
-		"comma-dangle": ["error", {
-			"arrays": "always-multiline",
-			"objects": "always-multiline",
-			"imports": "always-multiline",
-			"exports": "always-multiline",
-			"functions": "never"
-		}],
-		"block-scoped-var": "off",
-		"no-dupe-class-members": "off",
-		"prefer-object-spread": "off",
-		"prefer-reflect": "off",
-
-		// ES6
-		"prefer-rest-params": "off",
-		"prefer-spread": "off",
-		"prefer-arrow-callback": "off",
-		"prefer-template": "off",
-		"no-var": "off",
-		"object-shorthand": "off",
-		"vars-on-top": "off",
-		"prefer-destructuring": "off",
-		// identical to airbnb rule
-		// except for allowing for..in, because for..of is unavailable on some clients
-		"no-restricted-syntax": [
-			"error",
-			{
-				"selector": "ForOfStatement",
-				"message": "iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations."
-			},
-			{
-				"selector": "LabeledStatement",
-				"message": "Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand."
-			},
-			{
-				"selector": "WithStatement",
-				"message": "`with` is disallowed in strict mode because it makes code impossible to predict and optimize."
-			}
-		]
-	},
-	"parserOptions": {
-		"ecmaVersion": 2018,
-		"ecmaFeatures": {
-			"classes": false,
-			"defaultParams": false,
-			"blockBindings": false,
-			"forOf": false,
-			"generators": false,
-			"globalReturn": false,
-			"jsx": false,
-			"modules": false,
-			"objectLiteralComputedProperties": false,
-			"objectLiteralDuplicateProperties": false,
-			"objectLiteralShorthandMethods": false,
-			"objectLiteralShorthandProperties": false,
-			"impliedStrict": false,
-			"restParams": false,
-			"superInFunctions": false
-		}
-	}
-}
+	"extends": "nodebb/public"
+}

package/public/js/poll/creator.js

@@ -70,9 +70,12 @@
 				return alerts.error('[[error:category-not-selected]]');
 			}
 
-			socket.emit('plugins.poll.canCreate', { cid: post.cid, pid: post.pid }, function (err, canCreate) {
+			socket.emit('plugins.poll.canCreate', {
+				cid: post.cid,
+				pid: post.pid,
+			}, function (err, canCreate) {
 				if (err) {
-					return alerts.error(err.message);
+					return alerts.error(err);
 				}
 				if (!canCreate) {
 					return alerts.error('[[error:no-privileges]]');
@@ -216,6 +219,7 @@
 				title: obj['settings.title'],
 				maxvotes: obj['settings.maxvotes'],
 				disallowVoteUpdate: obj['settings.disallowVoteUpdate'] === 'on' ? 'true' : 'false',
+				allowAnonVoting: obj['settings.allowAnonVoting'] === 'on' ? 'true' : 'false',
 				end: obj['settings.end'],
 			},
 		};

package/public/js/poll/serializer.js

@@ -30,6 +30,14 @@ module.exports = function (utils) {
 				return value === 'true' || value === true ? 1 : 0;
 			},
 		},
+		allowAnonVoting: {
+			test: function (value) {
+				return /true|false/.test(value);
+			},
+			parse: function (value) {
+				return value === 'true' || value === true ? 1 : 0;
+			},
+		},
 		end: {
 			test: function (value) {
 				return (!isNaN(value) && parseInt(value, 10) > Date.now());

package/public/js/poll/view.js

@@ -1,6 +1,33 @@
 'use strict';
 
 (function (Poll) {
+	function vote(view, options) {
+		var form = view.dom.votingPanel.find('form');
+		var votes = form.serializeArray().map(function (option) {
+			return parseInt(option.value, 10);
+		});
+
+		if (votes.length > 0) {
+			var voteData = {
+				pollId: view.pollData.info.pollId,
+				options: votes,
+				voteAnon: options.voteAnon,
+			};
+
+			socket.emit('plugins.poll.vote', voteData, function (err) {
+				if (!config.loggedIn) {
+					$(window).trigger('action:poll.vote.notloggedin');
+				}
+
+				if (err) {
+					return Poll.alertError(err.message);
+				}
+
+				view.showResultsPanel();
+			});
+		}
+	}
+
 	var Actions = [
 		{
 			// Voting
@@ -11,33 +38,27 @@
 				});
 			},
 			handle: function (view) {
-				var form = view.dom.votingPanel.find('form');
-				var votes = form.serializeArray().map(function (option) {
-					return parseInt(option.value, 10);
+				vote(view, {
+					voteAnon: false,
 				});
-
-				if (votes.length > 0) {
-					var voteData = {
-						pollId: view.pollData.info.pollId,
-						options: votes,
-					};
-
-					socket.emit('plugins.poll.vote', voteData, function (err) {
-						if (!config.loggedIn) {
-							$(window).trigger('action:poll.vote.notloggedin');
-						}
-
-						if (err) {
-							return Poll.alertError(err.message);
-						}
-
-						view.showResultsPanel();
-					});
-				}
 			},
 		},
 		{
-			// Voting
+			// vote anon
+			register: function (view) {
+				var self = this;
+				view.dom.voteAnonButton.off('click').on('click', function () {
+					self.handle(view);
+				});
+			},
+			handle: function (view) {
+				vote(view, {
+					voteAnon: true,
+				});
+			},
+		},
+		{
+			// update voting
 			register: function (view) {
 				var self = this;
 				view.dom.updateVoteButton.off('click').on('click', function () {
@@ -169,6 +190,7 @@
 						votingPanel: panel.find('.poll-view-voting'),
 						resultsPanel: panel.find('.poll-view-results'),
 						voteButton: panel.find('.poll-button-vote'),
+						voteAnonButton: panel.find('.poll-button-vote-anon'),
 						updateVoteButton: panel.find('.poll-button-update-vote'),
 						removeVoteButton: panel.find('.poll-button-remove-vote'),
 						votingPanelButton: panel.find('.poll-button-voting'),
@@ -291,6 +313,9 @@
 			}
 		} else {
 			this.showVoteButton();
+			if (this.pollData.settings.allowAnonVoting) {
+				this.showVoteAnonButton();
+			}
 		}
 		this.dom.votingPanel.removeClass('hidden');
 	};
@@ -301,6 +326,7 @@
 		this.hideRemoveVoteButton();
 		this.resetVotingForm();
 		this.hideVoteButton();
+		this.hideVoteAnonButton();
 		this.dom.votingPanel.addClass('hidden');
 	};
 
@@ -327,6 +353,14 @@
 		this.dom.voteButton.addClass('hidden');
 	};
 
+	View.prototype.showVoteAnonButton = function () {
+		this.dom.voteAnonButton.removeClass('hidden');
+	};
+
+	View.prototype.hideVoteAnonButton = function () {
+		this.dom.voteAnonButton.addClass('hidden');
+	};
+
 	View.prototype.showUpdateVoteButton = function () {
 		this.dom.updateVoteButton.removeClass('hidden');
 	};

package/templates/poll/creator.tpl

@@ -26,11 +26,14 @@
                min="1" max="10" step="1" placeholder="[[poll:max_votes_placeholder]]" class="form-control">
     </div>
 
-    <div class="mb-3">
-        <div class="form-check">
-            <label class="form-check-label" for="pollDisallowVoteUpdate">[[poll:disallow_vote_update]]</label>
-            <input class="form-check-input" type="checkbox" name="settings.disallowVoteUpdate" id="pollDisallowVoteUpdate" {{{if poll.settings.disallowVoteUpdate}}}checked{{{end}}}>
-        </div>
+    <div class="form-check mb-3">
+        <label class="form-check-label" for="pollDisallowVoteUpdate">[[poll:disallow_vote_update]]</label>
+        <input class="form-check-input" type="checkbox" name="settings.disallowVoteUpdate" id="pollDisallowVoteUpdate" {{{if poll.settings.disallowVoteUpdate}}}checked{{{end}}}>
+    </div>
+
+    <div class="form-check mb-3">
+        <label class="form-check-label" for="allowAnonVoting">[[poll:allow_anon_voting]]</label>
+        <input class="form-check-input" type="checkbox" name="settings.allowAnonVoting" id="allowAnonVoting" {{{if poll.settings.allowAnonVoting}}}checked{{{end}}}>
     </div>
 
     <div class="mb-3">

package/templates/poll/view.tpl

@@ -18,11 +18,12 @@
             </div>
 
             <div class="poll-view-buttons">
-                <button type="button" class="btn btn-primary poll-button-vote hidden">[[poll:vote]]</button>
-                <button type="button" class="btn btn-primary poll-button-update-vote hidden">[[poll:update_vote]]</button>
-                <button type="button" class="btn btn-danger poll-button-remove-vote hidden">[[poll:remove_vote]]</button>
-                <button type="button" class="btn btn-link poll-button-results hidden">[[poll:to_results]]</button>
-                <button type="button" class="btn btn-link poll-button-voting hidden">[[poll:to_voting]]</button>
+                <button type="button" class="btn btn-sm btn-primary poll-button-vote hidden">[[poll:vote]]</button>
+                <button type="button" class="btn btn-sm btn-primary poll-button-vote-anon hidden">[[poll:vote_anonymously]]</button>
+                <button type="button" class="btn btn-sm btn-primary poll-button-update-vote hidden">[[poll:update_vote]]</button>
+                <button type="button" class="btn btn-sm btn-danger poll-button-remove-vote hidden">[[poll:remove_vote]]</button>
+                <button type="button" class="btn btn-sm btn-link poll-button-results hidden">[[poll:to_results]]</button>
+                <button type="button" class="btn btn-sm btn-link poll-button-voting hidden">[[poll:to_voting]]</button>
             </div>
         </div>
     </div>