nodebb-plugin-phone-verification 1.2.2

package/templates/admin/settings/phone-verification.tpl

@@ -0,0 +1,163 @@
+<div class="acp-page-container">
+    <div class="row">
+        <div class="col-lg-12">
+            
+            <div class="panel panel-primary">
+                <div class="panel-heading">
+                    <h3 class="panel-title">
+                        <i class="fa fa-cog"></i> הגדרות Call2All - שיחות קוליות
+                    </h3>
+                </div>
+                <div class="panel-body">
+                    <form id="voice-settings-form">
+                        <div class="form-group">
+                            <label for="voiceServerEnabled">
+                                <input type="checkbox" id="voiceServerEnabled" name="voiceServerEnabled" />
+                                הפעל שיחות קוליות
+                            </label>
+                            <p class="help-block">כאשר מופעל, התוסף ישלח שיחה קולית עם קוד האימות דרך Call2All</p>
+                        </div>
+                        
+                        <div class="form-group">
+                            <label for="voiceServerApiKey">Token של Call2All</label>
+                            <input type="password" class="form-control" id="voiceServerApiKey" name="voiceServerApiKey" 
+                                   placeholder="WU1BUElL.apik_xxxxx..." dir="ltr" />
+                            <p class="help-block">ה-Token שקיבלת מ-Call2All (מתחיל ב-WU1BUElL)</p>
+                        </div>
+
+                        <div class="form-group">
+                            <details style="border: 1px solid #ddd; padding: 10px; border-radius: 4px; background-color: #f9f9f9;">
+                                <summary style="cursor: pointer; font-weight: bold; color: #337ab7; outline: none;">
+                                    <i class="fa fa-cogs"></i> הגדרות מתקדמות (עריכת פרמטרים ותוכן ההודעה)
+                                </summary>
+                                <div style="margin-top: 15px; padding-left: 10px; border-left: 3px solid #337ab7;">
+                                    <div class="form-group">
+                                        <label for="voiceServerUrl">כתובת ה-API (Endpoint)</label>
+                                        <input type="text" class="form-control" id="voiceServerUrl" name="voiceServerUrl" 
+                                               placeholder="https://www.call2all.co.il/ym/api/RunCampaign" dir="ltr" />
+                                        <p class="help-block">כתובת השרת אליו נשלחת הבקשה.</p>
+                                    </div>
+                                    <div class="form-group">
+                                        <label for="voiceTtsMode">מצב ה-TTS (ttsMode)</label>
+                                        <input type="text" class="form-control" id="voiceTtsMode" name="voiceTtsMode" 
+                                               placeholder="1" dir="ltr" />
+                                        <p class="help-block">ערך הפרמטר <code>ttsMode</code> הנשלח ל-API (ברירת מחדל: 1).</p>
+                                    </div>
+                                    <div class="form-group">
+                                        <label for="voiceMessageTemplate">תוכן ההודעה (Template)</label>
+                                        <textarea class="form-control" id="voiceMessageTemplate" name="voiceMessageTemplate" rows="3" dir="rtl"></textarea>
+                                        <p class="help-block">
+                                            הטקסט שיוקרא למשתמש.<br/>
+                                            Placeholders חובה: <code>{code}</code> (הקוד), <code>{siteTitle}</code> (שם האתר)
+                                        </p>
+                                    </div>
+                                </div>
+                            </details>
+                        </div>
+                        <hr />
+
+                        <div class="form-group">
+                            <div class="checkbox">
+                                <label class="mdl-switch mdl-js-switch mdl-js-ripple-effect">
+                                    <input type="checkbox" class="mdl-switch__input" id="blockUnverifiedUsers" name="blockUnverifiedUsers">
+                                    <span class="mdl-switch__label"><strong>חסום כתיבה למשתמשים לא מאומתים</strong></span>
+                                </label>
+                            </div>
+                            <p class="help-block">
+                                אם מופעל, משתמשים רשומים שלא אימתו את הטלפון שלהם לא יוכלו לפתוח נושאים חדשים או להגיב.
+                            </p>
+                        </div>
+
+                        <div class="form-group">
+                            <button type="submit" class="btn btn-primary" id="save-settings-btn">
+                                <i class="fa fa-save"></i> שמור הגדרות
+                            </button>
+                            <span id="settings-status" class="text-success" style="margin-right: 10px; display: none;">
+                                <i class="fa fa-check"></i> נשמר!
+                            </span>
+                        </div>
+                    </form>
+                    
+                    <hr />
+                    
+                    <h4>בדיקת שיחה</h4>
+                    <div class="form-inline">
+                        <div class="form-group">
+                            <input type="text" class="form-control" id="test-phone" 
+                                   placeholder="05X-XXXXXXX" dir="ltr" style="width: 150px;" />
+                        </div>
+                        <button type="button" class="btn btn-warning" id="test-call-btn">
+                            <i class="fa fa-phone"></i> שלח שיחת בדיקה
+                        </button>
+                        <span id="test-status" style="margin-right: 10px;"></span>
+                    </div>
+                </div>
+            </div>
+            
+            <div class="panel panel-default">
+                <div class="panel-heading">
+                    <h3 class="panel-title"><i class="fa fa-phone"></i> ניהול אימות טלפון</h3>
+                </div>
+                <div class="panel-body">
+                    
+                    <div class="well">
+                        <div class="row">
+                            <div class="col-md-6">
+                                <h4>חיפוש משתמש לפי מספר טלפון</h4>
+                                <div class="form-group">
+                                    <div class="input-group">
+                                        <input type="text" class="form-control" id="phone-search" placeholder="הזן מספר טלפון" dir="ltr">
+                                        <span class="input-group-btn">
+                                            <button class="btn btn-primary" type="button" id="search-btn"><i class="fa fa-search"></i> חפש</button>
+                                        </span>
+                                    </div>
+                                </div>
+                            </div>
+                            <div class="col-md-6 text-left" style="padding-top: 35px;">
+                                <button class="btn btn-success" id="btn-add-manual-user">
+                                    <i class="fa fa-plus"></i> הוסף משתמש מאומת ידנית
+                                </button>
+                            </div>
+                        </div>
+                        <div id="search-result" style="display:none;"><div class="alert" id="search-alert"></div></div>
+                    </div>
+                    
+                    <div class="row" style="margin-bottom: 20px;">
+                        <div class="col-md-4">
+                            <div class="panel panel-info">
+                                <div class="panel-heading"><h4 class="panel-title">סה"כ משתמשים עם טלפון</h4></div>
+                                <div class="panel-body text-center"><h2 id="total-users">0</h2></div>
+                            </div>
+                        </div>
+                        <div class="col-md-4">
+                            <div class="panel panel-success">
+                                <div class="panel-heading"><h4 class="panel-title">משתמשים מאומתים</h4></div>
+                                <div class="panel-body text-center"><h2 id="verified-count">0</h2></div>
+                            </div>
+                        </div>
+                    </div>
+                    
+                    <h4>רשימת משתמשים</h4>
+                    <div class="table-responsive">
+                        <table class="table table-striped table-hover" id="users-table">
+                            <thead>
+                                <tr>
+                                    <th>מזהה (UID)</th>
+                                    <th>שם משתמש</th>
+                                    <th>מספר טלפון</th>
+                                    <th>תאריך אימות</th>
+                                    <th>סטטוס</th>
+                                    <th class="text-right">פעולות לניהול</th>
+                                </tr>
+                            </thead>
+                            <tbody id="users-tbody">
+                                <tr><td colspan="6" class="text-center">טוען...</td></tr>
+                            </tbody>
+                        </table>
+                    </div>
+                    <nav aria-label="ניווט עמודים" class="text-center"><ul class="pagination" id="users-pagination"></ul></nav>
+                </div>
+            </div>
+        </div>
+    </div>
+</div>

package/test/helpers.test.js

@@ -0,0 +1,158 @@
+'use strict';
+
+const assert = require('assert');
+const fc = require('fast-check');
+const plugin = require('../library');
+
+describe('Phone Verification Helper Functions', function () {
+    
+    // **Feature: nodebb-phone-verification, Property 1: ולידציית מספר טלפון ישראלי**
+    // **Validates: Requirements 1.2**
+    describe('validatePhoneNumber', function () {
+        
+        it('Property 1: should return true for valid Israeli mobile numbers (05X format)', function () {
+            // Generator for valid Israeli phone numbers
+            const validPhoneArb = fc.tuple(
+                fc.constantFrom('050', '051', '052', '053', '054', '055', '056', '057', '058', '059'),
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, suffix]) => prefix + suffix);
+            
+            fc.assert(
+                fc.property(validPhoneArb, (phone) => {
+                    return plugin.validatePhoneNumber(phone) === true;
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('Property 1: should return true for valid phones with hyphen (05X-XXXXXXX)', function () {
+            const validPhoneWithHyphenArb = fc.tuple(
+                fc.constantFrom('050', '051', '052', '053', '054', '055', '056', '057', '058', '059'),
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, suffix]) => prefix + '-' + suffix);
+            
+            fc.assert(
+                fc.property(validPhoneWithHyphenArb, (phone) => {
+                    return plugin.validatePhoneNumber(phone) === true;
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('Property 1: should return false for invalid phone formats', function () {
+            // Generator for invalid phones (wrong prefix, wrong length, etc.)
+            const invalidPhoneArb = fc.oneof(
+                // Wrong prefix (not starting with 05)
+                fc.tuple(
+                    fc.constantFrom('04', '06', '07', '08', '09', '00', '01', '02', '03'),
+                    fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 8, maxLength: 8 })
+                ).map(([prefix, suffix]) => prefix + suffix),
+                // Too short
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 1, maxLength: 9 }),
+                // Too long
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 11, maxLength: 15 }),
+                // Contains letters
+                fc.tuple(
+                    fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 5, maxLength: 8 }),
+                    fc.stringOf(fc.constantFrom('a', 'b', 'c', 'd', 'e', 'A', 'B', 'C'), { minLength: 1, maxLength: 3 })
+                ).map(([digits, letters]) => digits + letters)
+            );
+            
+            fc.assert(
+                fc.property(invalidPhoneArb, (phone) => {
+                    return plugin.validatePhoneNumber(phone) === false;
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('should return false for null, undefined, or non-string inputs', function () {
+            assert.strictEqual(plugin.validatePhoneNumber(null), false);
+            assert.strictEqual(plugin.validatePhoneNumber(undefined), false);
+            assert.strictEqual(plugin.validatePhoneNumber(123), false);
+            assert.strictEqual(plugin.validatePhoneNumber({}), false);
+            assert.strictEqual(plugin.validatePhoneNumber([]), false);
+            assert.strictEqual(plugin.validatePhoneNumber(''), false);
+        });
+    });
+
+    
+    // **Feature: nodebb-phone-verification, Property 8: נרמול מספר טלפון**
+    // **Validates: Requirements 4.3**
+    describe('normalizePhone', function () {
+        
+        it('Property 8: normalized phone should have no hyphens and be 10 characters', function () {
+            // Generator for valid phones with optional hyphens
+            const phoneWithOptionalHyphenArb = fc.tuple(
+                fc.constantFrom('050', '051', '052', '053', '054', '055', '056', '057', '058', '059'),
+                fc.boolean(),
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, hasHyphen, suffix]) => hasHyphen ? prefix + '-' + suffix : prefix + suffix);
+            
+            fc.assert(
+                fc.property(phoneWithOptionalHyphenArb, (phone) => {
+                    const normalized = plugin.normalizePhone(phone);
+                    // Should have no hyphens
+                    const noHyphens = !normalized.includes('-');
+                    // Should be 10 characters
+                    const correctLength = normalized.length === 10;
+                    // Should only contain digits
+                    const onlyDigits = /^\d+$/.test(normalized);
+                    
+                    return noHyphens && correctLength && onlyDigits;
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('Property 8: normalizing twice should give same result', function () {
+            const phoneArb = fc.tuple(
+                fc.constantFrom('050', '051', '052', '053', '054', '055', '056', '057', '058', '059'),
+                fc.boolean(),
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, hasHyphen, suffix]) => hasHyphen ? prefix + '-' + suffix : prefix + suffix);
+            
+            fc.assert(
+                fc.property(phoneArb, (phone) => {
+                    const once = plugin.normalizePhone(phone);
+                    const twice = plugin.normalizePhone(once);
+                    return once === twice;
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('should return empty string for invalid inputs', function () {
+            assert.strictEqual(plugin.normalizePhone(null), '');
+            assert.strictEqual(plugin.normalizePhone(undefined), '');
+            assert.strictEqual(plugin.normalizePhone(123), '');
+        });
+    });
+    
+    // **Feature: nodebb-phone-verification, Property 2: יצירת קוד אימות תקין**
+    // **Validates: Requirements 2.1**
+    describe('generateVerificationCode', function () {
+        
+        it('Property 2: generated code should always be exactly 6 digits', function () {
+            fc.assert(
+                fc.property(fc.constant(null), () => {
+                    const code = plugin.generateVerificationCode();
+                    // Should be exactly 6 characters
+                    const correctLength = code.length === 6;
+                    // Should only contain digits
+                    const onlyDigits = /^\d{6}$/.test(code);
+                    
+                    return correctLength && onlyDigits;
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('Property 2: generated codes should be strings', function () {
+            for (let i = 0; i < 100; i++) {
+                const code = plugin.generateVerificationCode();
+                assert.strictEqual(typeof code, 'string');
+            }
+        });
+    });
+});

package/test/phone-storage.test.js

@@ -0,0 +1,216 @@
+'use strict';
+
+const assert = require('assert');
+const fc = require('fast-check');
+const plugin = require('../library');
+
+describe('Phone Storage', function () {
+    
+    beforeEach(function () {
+        plugin.clearAllPhones();
+    });
+    
+    // **Feature: nodebb-phone-verification, Property 6: ייחודיות מספר טלפון**
+    // **Validates: Requirements 4.1**
+    describe('Phone Uniqueness (Property 6)', function () {
+        
+        it('Property 6: duplicate phone should be rejected for different user', function () {
+            const validPhoneArb = fc.tuple(
+                fc.constantFrom('050', '052', '054'),
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, suffix]) => prefix + suffix);
+            
+            const uidArb = fc.integer({ min: 1, max: 100000 });
+            
+            fc.assert(
+                fc.property(validPhoneArb, uidArb, uidArb, (phone, uid1, uid2) => {
+                    // Skip if same user
+                    if (uid1 === uid2) return true;
+                    
+                    plugin.clearAllPhones();
+                    
+                    // First user saves phone
+                    const result1 = plugin.savePhoneToUser(uid1, phone);
+                    
+                    // Second user tries same phone
+                    const result2 = plugin.savePhoneToUser(uid2, phone);
+                    
+                    return result1.success === true && 
+                           result2.success === false && 
+                           result2.error === 'PHONE_EXISTS';
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('Property 6: isPhoneExists should return true for existing phone', function () {
+            const phone = '0501234567';
+            const uid = 1;
+            
+            assert.strictEqual(plugin.isPhoneExists(phone), false);
+            plugin.savePhoneToUser(uid, phone);
+            assert.strictEqual(plugin.isPhoneExists(phone), true);
+        });
+        
+        it('Property 6: same user can update their own phone', function () {
+            const uid = 1;
+            const phone1 = '0501234567';
+            const phone2 = '0521234567';
+            
+            plugin.savePhoneToUser(uid, phone1);
+            const result = plugin.savePhoneToUser(uid, phone1); // Same phone, same user
+            assert.strictEqual(result.success, true);
+        });
+    });
+    
+    // **Feature: nodebb-phone-verification, Property 7: שמירה ושליפה (Round-trip)**
+    // **Validates: Requirements 4.2, 4.3**
+    describe('Save and Retrieve Round-trip (Property 7)', function () {
+        
+        it('Property 7: saved phone should be retrievable with same normalized value', function () {
+            const validPhoneArb = fc.tuple(
+                fc.constantFrom('050', '052', '054'),
+                fc.boolean(), // with or without hyphen
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, hasHyphen, suffix]) => hasHyphen ? prefix + '-' + suffix : prefix + suffix);
+            
+            const uidArb = fc.integer({ min: 1, max: 100000 });
+            
+            fc.assert(
+                fc.property(validPhoneArb, uidArb, (phone, uid) => {
+                    plugin.clearAllPhones();
+                    
+                    plugin.savePhoneToUser(uid, phone);
+                    const retrieved = plugin.getUserPhone(uid);
+                    
+                    // Retrieved phone should be normalized (no hyphens)
+                    const expectedNormalized = plugin.normalizePhone(phone);
+                    
+                    return retrieved !== null && 
+                           retrieved.phone === expectedNormalized &&
+                           retrieved.phone.length === 10 &&
+                           !retrieved.phone.includes('-');
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('Property 7: findUserByPhone should return correct uid', function () {
+            const validPhoneArb = fc.tuple(
+                fc.constantFrom('050', '052', '054'),
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, suffix]) => prefix + suffix);
+            
+            const uidArb = fc.integer({ min: 1, max: 100000 });
+            
+            fc.assert(
+                fc.property(validPhoneArb, uidArb, (phone, uid) => {
+                    plugin.clearAllPhones();
+                    
+                    plugin.savePhoneToUser(uid, phone);
+                    const foundUid = plugin.findUserByPhone(phone);
+                    
+                    return foundUid === uid;
+                }),
+                { numRuns: 100 }
+            );
+        });
+    });
+    
+    describe('getAllUsersWithPhones', function () {
+        
+        it('should return all users with phones', function () {
+            plugin.savePhoneToUser(1, '0501111111');
+            plugin.savePhoneToUser(2, '0502222222');
+            plugin.savePhoneToUser(3, '0503333333');
+            
+            const all = plugin.getAllUsersWithPhones();
+            assert.strictEqual(all.length, 3);
+        });
+    });
+});
+
+
+    // **Feature: nodebb-phone-verification, Property 9: חיפוש לפי מספר טלפון**
+    // **Validates: Requirements 5.2**
+    describe('Search by Phone (Property 9)', function () {
+        
+        it('Property 9: findUserByPhone should return correct user for saved phone', function () {
+            const validPhoneArb = fc.tuple(
+                fc.constantFrom('050', '052', '054'),
+                fc.stringOf(fc.constantFrom('0', '1', '2', '3', '4', '5', '6', '7', '8', '9'), { minLength: 7, maxLength: 7 })
+            ).map(([prefix, suffix]) => prefix + suffix);
+            
+            const uidArb = fc.integer({ min: 1, max: 100000 });
+            
+            fc.assert(
+                fc.property(validPhoneArb, uidArb, (phone, uid) => {
+                    plugin.clearAllPhones();
+                    
+                    plugin.savePhoneToUser(uid, phone);
+                    const foundUid = plugin.findUserByPhone(phone);
+                    
+                    return foundUid === uid;
+                }),
+                { numRuns: 100 }
+            );
+        });
+        
+        it('Property 9: search with hyphen should find same user as without', function () {
+            const phone = '0501234567';
+            const phoneWithHyphen = '050-1234567';
+            const uid = 42;
+            
+            plugin.savePhoneToUser(uid, phone);
+            
+            const found1 = plugin.findUserByPhone(phone);
+            const found2 = plugin.findUserByPhone(phoneWithHyphen);
+            
+            assert.strictEqual(found1, uid);
+            assert.strictEqual(found2, uid);
+        });
+    });
+    
+    // **Feature: nodebb-phone-verification, Property 10: הסתרת טלפון ממשתמשים רגילים**
+    // **Validates: Requirements 5.3**
+    describe('Phone Privacy (Property 10)', function () {
+        
+        it('Property 10: admin can view any phone', function () {
+            const uid = 1;
+            const callerUid = 999;
+            const isAdmin = true;
+            
+            assert.strictEqual(plugin.canViewPhone(uid, callerUid, isAdmin), true);
+        });
+        
+        it('Property 10: regular user cannot view other user phone', function () {
+            const uid = 1;
+            const callerUid = 2;
+            const isAdmin = false;
+            
+            assert.strictEqual(plugin.canViewPhone(uid, callerUid, isAdmin), false);
+        });
+        
+        it('Property 10: user can view own phone', function () {
+            const uid = 1;
+            const callerUid = 1;
+            const isAdmin = false;
+            
+            assert.strictEqual(plugin.canViewPhone(uid, callerUid, isAdmin), true);
+        });
+        
+        it('Property 10: privacy rule applies to all users', function () {
+            const uidArb = fc.integer({ min: 1, max: 100000 });
+            
+            fc.assert(
+                fc.property(uidArb, uidArb, (uid, callerUid) => {
+                    const isAdmin = false;
+                    const canView = plugin.canViewPhone(uid, callerUid, isAdmin);
+                    
+                    // Non-admin can only view own phone
+                    return canView === (uid === callerUid);
+                }),
+                { numRuns: 100 }
+            );
+        });
+    });