nodebb-plugin-onekite-discord 1.0.7 → 1.0.9

package/library.js

@@ -1,5 +1,44 @@
 'use strict';
 
+
+
+/**
+ * Discord doesn't support masked links like [text](url) inside embed descriptions.
+ * To keep links clickable, convert them to plain URLs (Discord auto-linkifies).
+ */
+function formatDiscordLinks(str) {
+  if (!str || typeof str !== 'string') return str;
+
+  const normalizeUrl = (u) => {
+    if (!u) return u;
+    let url = String(u).trim();
+
+    // Strip wrapping <> if present
+    url = url.replace(/^<(.+)>$/, '$1');
+
+    // Fix common "https:/" typo
+    url = url.replace(/^https:\//i, 'https://');
+    url = url.replace(/^http:\//i, 'http://');
+
+    // If it's a bare domain starting with www., add scheme
+    if (/^www\./i.test(url)) url = 'https://' + url;
+
+    return url;
+  };
+
+  // HTML links -> URL
+  str = str.replace(/<a\s+[^>]*href=["']([^"']+)["'][^>]*>(.*?)<\/a>/gi, (_m, href, _text) => {
+    return normalizeUrl(href);
+  });
+
+  // Markdown links [text](url) -> URL
+  str = str.replace(/\[([^\]]+)\]\(([^)]+)\)/g, (_m, _text, url) => {
+    return normalizeUrl(url);
+  });
+
+  return str;
+}
+
 const { request } = require('undici');
 
 const routeHelpers = require.main.require('./src/routes/helpers');
@@ -201,7 +240,7 @@ async function buildEmbed({ tid, pid, isReply }) {
   const embedTitle = `${replyIcon}${safeTitle} – ${username}`.slice(0, 256);
 
   // Embed title becomes clickable via embed.url
-  return { topicData, content: '', embed: { title: embedTitle, url: targetUrl, description: excerpt || '' } };
+  return { topicData, content: '', embed: { title: embedTitle, url: targetUrl, description: formatDiscordLinks(excerpt || '') } };
 }
 
 function extractTidPid(data) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-onekite-discord",
-  "version": "1.0.7",
+  "version": "1.0.9",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -31,5 +31,5 @@
   "acpScripts": [
     "public/admin.js"
   ],
-  "version": "1.0.7"
+  "version": "1.0.9"
 }