nodebb-plugin-onekite-discord 1.0.15 → 1.0.16

package/library.js

@@ -2,46 +2,22 @@
 
 
 
-/**
- * Discord embed descriptions do not support masked links like [text](url).
- * To keep links clickable, flatten any link-like markup into plain URLs,
- * which Discord auto-linkifies.
- */
-function flattenLinksToUrls(str) {
-  if (!str || typeof str !== 'string') return str;
 
-  const normalizeUrl = (u) => {
-    if (!u) return '';
-    let url = String(u).trim();
-    url = url.replace(/^<(.+)>$/, '$1');
-    // fix common typos
-    url = url.replace(/^https:\//i, 'https://');
-    url = url.replace(/^http:\//i, 'http://');
-    // add scheme for bare www.
-    if (/^www\./i.test(url)) url = 'https://' + url;
-    return url;
-  };
 
-  // HTML links -> URL
-  str = str.replace(/<a\s+[^>]*href=["']([^"']+)["'][^>]*>.*?<\/a>/gi, (_m, href) => {
-    return normalizeUrl(href);
-  });
 
-  // Markdown masked links -> URL
-  str = str.replace(/\[([^\]]+)\]\(([^)]+)\)/g, (_m, _text, url) => {
-    return normalizeUrl(url);
-  });
 
-  // NodeBB rendered: "texte du lien(url)" or "texte du lien (url)" -> URL
-  str = str.replace(/([^\n\r()]{1,200}?)\s*\((https?:\/\/[^)\s]+|www\.[^)\s]+)\)/g, (_m, _text, url) => {
-    return normalizeUrl(url);
-  });
+/**
+ * Simplified:
+ * - Convert masked markdown links: [text](url) -> url
+ * - Do NOT modify anything else.
+ * Discord will auto-linkify URLs if it can.
+ */
+function simplifyMaskedLinks(str) {
+  if (!str || typeof str !== 'string') return str;
 
-  // Ensure bare "www.xxx" tokens become "https://www.xxx"
-  str = str.replace(/\b(www\.[^\s<>()]+)\b/g, (_m, url) => {
-    // strip trailing punctuation
-    const clean = url.replace(/[),.;!?]+$/g, '');
-    return normalizeUrl(clean);
+  // [text](url) -> url (as-is)
+  str = str.replace(/\[([^\]]+)\]\(([^)]+)\)/g, (_m, _text, url) => {
+    return url;
   });
 
   return str;
@@ -227,7 +203,7 @@ async function buildEmbed({ tid, pid, isReply }) {
   const embedTitle = `${replyIcon}${safeTitle} – ${username}`.slice(0, 256);
 
   // Embed title becomes clickable via embed.url
-  return { topicData, content: '', embed: { title: embedTitle, url: targetUrl, description: flattenLinksToUrls(excerpt || '') } };
+  return { topicData, content: '', embed: { title: embedTitle, url: targetUrl, description: simplifyMaskedLinks(excerpt || '') } };
 }
 
 function extractTidPid(data) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-onekite-discord",
-  "version": "1.0.15",
+  "version": "1.0.16",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -31,5 +31,5 @@
   "acpScripts": [
     "public/admin.js"
   ],
-  "version": "1.0.15"
+  "version": "1.0.16"
 }