nodebb-plugin-onekite-calendar 2.0.97 → 2.0.98

package/lib/helloassoWebhook.js

@@ -133,6 +133,27 @@ function getCheckoutIntentIdFromPayload(payload) {
   return null;
 }
 
+// Returns true for event types and states that represent a HelloAsso refund.
+function isRefundEvent(payload) {
+  try {
+    if (!payload) return false;
+    const eventType = String(payload.eventType || '').toLowerCase();
+    if (eventType === 'refund') return true;
+    const data = _payloadData(payload);
+    if (!data) return false;
+    const orderPayments = (data.order && Array.isArray(data.order.payments)) ? data.order.payments : [];
+    const state = String(
+      data.state || data.status || data.paymentState ||
+      (orderPayments.length ? (orderPayments[0].state || orderPayments[0].status) : '') ||
+      (data.order && (data.order.state || data.order.status)) ||
+      ''
+    ).toLowerCase();
+    return ['refunded', 'refund', 'refundpending'].includes(state);
+  } catch (e) {
+    return false;
+  }
+}
+
 // Returns true for event types and states that represent a completed payment.
 function isConfirmedPayment(payload) {
   try {
@@ -235,6 +256,129 @@ async function tryRecoverRidFromPayment(settings, paymentId) {
   }
 }
 
+// ---------------------------------------------------------------------------
+// Refund handler (called from main handler when isRefundEvent() is true)
+// ---------------------------------------------------------------------------
+
+async function handleRefund(req, res, payload, settings, _d) {
+  try {
+    const rid = getReservationIdFromPayload(payload);
+    const checkoutIntentId = getCheckoutIntentIdFromPayload(payload);
+
+    // Refund idempotency key — prefix with "refund_" to avoid collision with payment IDs.
+    const _payments = (_d && _d.order && Array.isArray(_d.order.payments)) ? _d.order.payments : [];
+    const refundId = _d && _d.id != null ? String(_d.id) : null;
+    const idempotencyKey = refundId
+      ? `refund_${refundId}`
+      : (!payload.data && checkoutIntentId ? `refund_ci_${checkoutIntentId}` : null);
+
+    if (!idempotencyKey) {
+      // eslint-disable-next-line no-console
+      console.warn('[calendar-onekite] HelloAsso webhook refund: missing refund id', { dataKeys: _d ? Object.keys(_d) : [] });
+      return res.json({ ok: true, ignored: true, missingRefundId: true });
+    }
+
+    if (await alreadyProcessed(idempotencyKey)) {
+      return res.json({ ok: true, duplicate: true });
+    }
+
+    // Resolve reservation ID
+    let resolvedRid = rid;
+    if (!resolvedRid && checkoutIntentId) {
+      resolvedRid = await tryRecoverRidFromCheckoutIntent(settings, checkoutIntentId);
+    }
+    const paymentIdForRecovery = payload.data
+      ? (_d && (_d.id || _d.paymentId))
+      : (_payments.length ? _payments[0].id : null);
+    if (!resolvedRid && paymentIdForRecovery) {
+      resolvedRid = await tryRecoverRidFromPayment(settings, paymentIdForRecovery);
+    }
+    if (!resolvedRid) {
+      // eslint-disable-next-line no-console
+      console.warn('[calendar-onekite] HelloAsso webhook refund: could not resolve reservationId', { refundId, checkoutIntentId });
+      return res.json({ ok: true, processed: false, missingReservationId: true });
+    }
+
+    // eslint-disable-next-line no-console
+    console.info('[calendar-onekite] HelloAsso webhook refund received', { rid: resolvedRid, refundId });
+
+    const r = await dbLayer.getReservation(resolvedRid);
+    if (!r) {
+      await markProcessed(idempotencyKey);
+      return res.json({ ok: true, processed: true, reservationNotFound: true });
+    }
+
+    if (r.status === 'cancelled') {
+      await markProcessed(idempotencyKey);
+      return res.json({ ok: true, processed: true, alreadyCancelled: true });
+    }
+
+    r.status = 'cancelled';
+    r.cancelledAt = Date.now();
+    r.cancelledBy = 0;
+    r.cancelledByUsername = 'HelloAsso (remboursement)';
+    r.refundedAt = r.cancelledAt;
+    if (refundId) r.refundId = refundId;
+
+    await dbLayer.saveReservation(r);
+
+    await auditLog('reservation_refunded', 0, {
+      targetType: 'reservation',
+      targetId: String(r.rid),
+      reservationUid: Number(r.uid) || 0,
+      reservationUsername: String(r.username || ''),
+      itemIds: arrayifyIds(r),
+      itemNames: arrayifyNames(r),
+      startDate: r.startDate || '',
+      endDate: r.endDate || '',
+      refundId: refundId || '',
+    });
+
+    realtime.emitCalendarUpdated({ kind: 'reservation', action: 'cancelled', rid: String(r.rid), status: r.status });
+
+    // Email requester
+    try {
+      const requesterUid = parseInt(r.uid, 10);
+      const requester = await user.getUserFields(requesterUid, ['username']);
+      if (requesterUid) {
+        await sendEmail('calendar-onekite_cancelled', requesterUid, 'Location matériel - Réservation annulée (remboursement)', {
+          uid: requesterUid,
+          username: requester && requester.username ? requester.username : '',
+          itemName: arrayifyNames(r).join(', '),
+          itemNames: arrayifyNames(r),
+          dateRange: `Du ${formatFR(r.start)} au ${formatFR(r.end)}`,
+          cancelledBy: 'HelloAsso (remboursement)',
+          cancelledByUrl: '',
+        });
+      }
+    } catch (e) {}
+
+    // Discord notification
+    try {
+      await discord.notifyReservationCancelled(settings, {
+        rid: r.rid,
+        uid: r.uid,
+        username: r.username || '',
+        itemIds: arrayifyIds(r),
+        itemNames: arrayifyNames(r),
+        start: r.start,
+        end: r.end,
+        status: r.status,
+        cancelledAt: r.cancelledAt,
+        cancelledBy: 0,
+        cancelledByUsername: r.cancelledByUsername,
+      });
+    } catch (e) {}
+
+    await markProcessed(idempotencyKey);
+    return res.json({ ok: true, processed: true, refunded: true });
+  } catch (err) {
+    // eslint-disable-next-line no-console
+    console.error('[calendar-onekite] HelloAsso webhook refund: unhandled error', err && err.message ? err.message : String(err));
+    return res.status(500).json({ ok: false, error: 'internal-error' });
+  }
+}
+
 // ---------------------------------------------------------------------------
 // Webhook handler
 // ---------------------------------------------------------------------------
@@ -308,6 +452,11 @@ async function handler(req, res, next) {
       contentType: req.headers && req.headers['content-type'],
     });
 
+    // Handle refund events before the confirmed-payment check.
+    if (isRefundEvent(payload)) {
+      return await handleRefund(req, res, payload, settings, _d);
+    }
+
     if (!isConfirmedPayment(payload)) {
       // eslint-disable-next-line no-console
       console.warn('[calendar-onekite] HelloAsso webhook: payment not confirmed — ignored', {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-onekite-calendar",
-  "version": "2.0.97",
+  "version": "2.0.98",
   "description": "FullCalendar-based equipment reservation workflow with admin approval & HelloAsso payment for NodeBB",
   "main": "library.js",
   "license": "MIT",