nodebb-plugin-onekite-calendar 2.0.68 → 2.0.70

package/lib/api.js

@@ -647,6 +647,7 @@ api.getSpecialEventDetails = async function (req, res) {
   const settings = await getSettings();
   const canMod = uid ? await canValidate(uid, settings) : false;
   const canSpecialDelete = uid ? await canDeleteSpecial(uid, settings) : false;
+  const canSpecialCreate = uid ? await canCreateSpecial(uid, settings) : false;
 
   const eid = String(req.params.eid || '').trim();
   if (!eid) return res.status(400).json({ error: 'missing-eid' });
@@ -680,6 +681,7 @@ api.getSpecialEventDetails = async function (req, res) {
     notes: ev.notes || '',
     participants,
     participantsUsernames: await usernamesByUids(participants),
+    canEditSpecial: canSpecialCreate,
     canDeleteSpecial: canSpecialDelete,
     canJoin: uid ? await canJoinSpecial(uid, settings) : false,
     isParticipant: uid ? participants.includes(String(uid)) : false,
@@ -871,6 +873,37 @@ api.deleteSpecialEvent = async function (req, res) {
   res.json({ ok: true });
 };
 
+api.updateSpecialEvent = async function (req, res) {
+  const settings = await getSettings();
+  if (!req.uid) return res.status(401).json({ error: 'not-logged-in' });
+  const ok = await canCreateSpecial(req.uid, settings);
+  if (!ok) return res.status(403).json({ error: 'not-allowed' });
+
+  const eid = String(req.params.eid || '').replace(/^special:/, '').trim();
+  if (!eid) return res.status(400).json({ error: 'bad-id' });
+
+  const ev = await dbLayer.getSpecialEvent(eid);
+  if (!ev) return res.status(404).json({ error: 'not-found' });
+
+  const startTs = toTs(req.body && req.body.start);
+  const endTs = toTs(req.body && req.body.end);
+  if (!Number.isFinite(startTs) || !Number.isFinite(endTs) || !(startTs < endTs)) {
+    return res.status(400).json({ error: 'bad-dates' });
+  }
+
+  ev.title = String((req.body && req.body.title) || '').trim() || ev.title || 'Évènement';
+  ev.start = String(startTs);
+  ev.end = String(endTs);
+  ev.address = String((req.body && req.body.address) || '').trim();
+  ev.lat = String((req.body && req.body.lat) || '').trim();
+  ev.lon = String((req.body && req.body.lon) || '').trim();
+  ev.notes = String((req.body && req.body.notes) || '').trim();
+
+  await dbLayer.saveSpecialEvent(ev);
+  realtime.emitCalendarUpdated({ kind: 'specialEvent', action: 'updated', eid });
+  return res.json({ ok: true });
+};
+
 /**
  * Get detailed information about an outing (prévision de sortie).
  * 
@@ -911,6 +944,7 @@ api.getOutingDetails = async function (req, res) {
   });
 
   const participants = normalizeUidList(o.participants);
+  const canEditOuting = uid ? await canRequest(uid, settings, Date.now()) : false;
   const out = {
     oid: o.oid,
     title: o.title || '',
@@ -922,7 +956,8 @@ api.getOutingDetails = async function (req, res) {
     notes: o.notes || '',
     participants,
     participantsUsernames: await usernamesByUids(participants),
-    canJoin: uid ? await canRequest(uid, settings, Date.now()) : false,
+    canEditOuting,
+    canJoin: canEditOuting,
     isParticipant: uid ? participants.includes(String(uid)) : false,
     canDeleteOuting: canMod || (uid && String(uid) === String(o.uid)),
     icsUrl: links.icsUrl,
@@ -1090,6 +1125,37 @@ api.deleteOuting = async function (req, res) {
   return res.json({ ok: true });
 };
 
+api.updateOuting = async function (req, res) {
+  const settings = await getSettings();
+  if (!req.uid) return res.status(401).json({ error: 'not-logged-in' });
+  const ok = await canRequest(req.uid, settings, Date.now());
+  if (!ok) return res.status(403).json({ error: 'not-allowed' });
+
+  const oid = String(req.params.oid || '').replace(/^outing:/, '').trim();
+  if (!oid) return res.status(400).json({ error: 'bad-id' });
+
+  const o = await dbLayer.getOuting(oid);
+  if (!o) return res.status(404).json({ error: 'not-found' });
+
+  const startTs = toTs(req.body && req.body.start);
+  const endTs = toTs(req.body && req.body.end);
+  if (!Number.isFinite(startTs) || !Number.isFinite(endTs) || !(startTs < endTs)) {
+    return res.status(400).json({ error: 'bad-dates' });
+  }
+
+  o.title = String((req.body && req.body.title) || '').trim() || o.title || 'Sortie';
+  o.start = String(startTs);
+  o.end = String(endTs);
+  o.address = String((req.body && req.body.address) || '').trim();
+  o.lat = String((req.body && req.body.lat) || '').trim();
+  o.lon = String((req.body && req.body.lon) || '').trim();
+  o.notes = String((req.body && req.body.notes) || '').trim();
+
+  await dbLayer.saveOuting(o);
+  realtime.emitCalendarUpdated({ kind: 'outing', action: 'updated', oid });
+  return res.json({ ok: true });
+};
+
 api.getItems = async function (req, res) {
   const settings = await getSettings();
 

package/lib/discord.js

@@ -2,7 +2,7 @@
 
 const https = require('https');
 const { URL } = require('url');
-const { formatFRShort } = require('./shared');
+const { formatFRShort, forumBaseUrl } = require('./shared');
 
 function isEnabled(v, defaultValue) {
   if (v === undefined || v === null || v === '') return defaultValue !== false;
@@ -53,7 +53,7 @@ function postWebhook(webhookUrl, payload) {
 }
 
 function buildReservationMessage(kind, reservation) {
-  const calUrl = 'https://www.onekite.com/calendar';
+  const calUrl = forumBaseUrl() + '/calendar';
   const username = reservation && reservation.username ? String(reservation.username) : '';
   const items = (reservation && Array.isArray(reservation.itemNames) && reservation.itemNames.length)
     ? reservation.itemNames.map(String)
@@ -87,7 +87,7 @@ function buildWebhookPayload(kind, reservation) {
     ? 'Onekite • Paiement'
     : (kind === 'cancelled' ? 'Onekite • Annulation' : 'Onekite • Réservation');
 
-  const calUrl = 'https://www.onekite.com/calendar';
+  const calUrl = forumBaseUrl() + '/calendar';
   const username = reservation && reservation.username ? String(reservation.username) : '';
   const items = (reservation && Array.isArray(reservation.itemNames) && reservation.itemNames.length)
     ? reservation.itemNames.map(String)
@@ -186,7 +186,7 @@ async function notifyReservationCancelled(settings, reservation) {
 
 function buildSimpleCalendarPayload(kind, label, entity, opts) {
   const options = opts || {};
-  const calUrl = options.calUrl || 'https://www.onekite.com/calendar';
+  const calUrl = options.calUrl || forumBaseUrl() + '/calendar';
   const webhookUsername = options.webhookUsername || `Onekite • ${label}`;
 
   const title = kind === 'deleted' ? '❌ ' + label + ' annulé(e)' : label + ' créé(e)';

package/lib/shared.js

@@ -44,6 +44,7 @@ function hmacSecret() {
     const s = String(nconf.get('secret') || '').trim();
     if (s) return s;
   } catch (_) { /* ignore */ }
+  console.warn('[calendar-onekite] nconf.secret not set — ICS URLs use weak fallback key');
   return 'calendar-onekite';
 }
 

package/lib/widgets.js

@@ -17,8 +17,7 @@ function makeDomId() {
 }
 
 function widgetCalendarUrl() {
-  // Per request, keep the public URL fixed (even if forum base differs)
-  return 'https://www.onekite.com/calendar';
+  return forumBaseUrl() + '/calendar';
 }
 
 const widgets = {};

package/library.js

@@ -82,6 +82,7 @@ Plugin.init = async function (params) {
   router.post('/api/v3/plugins/calendar-onekite/special-events', ...publicExpose, api.createSpecialEvent);
   router.get('/api/v3/plugins/calendar-onekite/special-events/:eid', ...publicExpose, api.getSpecialEventDetails);
   router.delete('/api/v3/plugins/calendar-onekite/special-events/:eid', ...publicExpose, api.deleteSpecialEvent);
+  router.put('/api/v3/plugins/calendar-onekite/special-events/:eid', ...publicExpose, api.updateSpecialEvent);
   // Participants (self-join) for special events
   router.post('/api/v3/plugins/calendar-onekite/special-events/:eid/participants', ...publicExpose, api.joinSpecialEvent);
   router.delete('/api/v3/plugins/calendar-onekite/special-events/:eid/participants', ...publicExpose, api.leaveSpecialEvent);
@@ -90,6 +91,7 @@ Plugin.init = async function (params) {
   router.post('/api/v3/plugins/calendar-onekite/outings', ...publicExpose, api.createOuting);
   router.get('/api/v3/plugins/calendar-onekite/outings/:oid', ...publicExpose, api.getOutingDetails);
   router.delete('/api/v3/plugins/calendar-onekite/outings/:oid', ...publicExpose, api.deleteOuting);
+  router.put('/api/v3/plugins/calendar-onekite/outings/:oid', ...publicExpose, api.updateOuting);
   // Participants (self-join) for outings
   router.post('/api/v3/plugins/calendar-onekite/outings/:oid/participants', ...publicExpose, api.joinOuting);
   router.delete('/api/v3/plugins/calendar-onekite/outings/:oid/participants', ...publicExpose, api.leaveOuting);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-onekite-calendar",
-  "version": "2.0.68",
+  "version": "2.0.70",
   "description": "FullCalendar-based equipment reservation workflow with admin approval & HelloAsso payment for NodeBB",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -39,5 +39,5 @@
   "acpScripts": [
     "public/admin.js"
   ],
-  "version": "2.0.66"
+  "version": "2.0.70"
 }

package/public/client.js

@@ -239,8 +239,32 @@ define('forum/calendar-onekite', ['alerts', 'bootbox', 'hooks'], function (alert
     return opts.join('');
   }
 
+  function buildInitialValuesFromEvent(details) {
+    function toLocal(ts) {
+      const d = new Date(parseInt(ts, 10));
+      return {
+        ymd: `${d.getFullYear()}-${pad2(d.getMonth() + 1)}-${pad2(d.getDate())}`,
+        time: `${pad2(d.getHours())}:${pad2(d.getMinutes())}`,
+      };
+    }
+    const s = toLocal(details.start);
+    const e = toLocal(details.end);
+    return {
+      title: details.title || '',
+      startYmd: s.ymd,
+      startTime: s.time,
+      endYmd: e.ymd,
+      endTime: e.time,
+      address: details.address || details.pickupAddress || '',
+      lat: details.lat || details.pickupLat || '',
+      lon: details.lon || details.pickupLon || '',
+      notes: details.notes || '',
+    };
+  }
+
   async function openSpecialEventDialog(selectionInfo, opts) {
     const kind = (opts && opts.kind) ? String(opts.kind) : 'special';
+    const iv = opts && opts.initialValues;
     const start = selectionInfo.start;
     // FullCalendar can omit `end` for certain interactions. Also, for all-day
     // selections, `end` is exclusive (next day at 00:00). We normalise below
@@ -289,12 +313,20 @@ define('forum/calendar-onekite', ['alerts', 'bootbox', 'hooks'], function (alert
       }
     }
 
+    // Edit mode: override computed dates with existing event values.
+    if (iv) {
+      if (iv.startYmd && iv.startTime) seStart = new Date(`${iv.startYmd}T${iv.startTime}`);
+      if (iv.endYmd && iv.endTime) seEnd = new Date(`${iv.endYmd}T${iv.endTime}`);
+    }
+
     const seStartTime = timeString(seStart);
     const seEndTime = timeString(seEnd);
-    // Same UX for all types: an example placeholder, but never pre-fill the value.
-    // If left empty, the server can still apply its own default label.
     const defaultTitlePlaceholder = 'Ex: ...';
-    const defaultTitleValue = '';
+    const defaultTitleValue = iv ? (iv.title || '') : '';
+    const ivAddress = iv ? (iv.address || '') : '';
+    const ivLat = iv ? (iv.lat || '') : '';
+    const ivLon = iv ? (iv.lon || '') : '';
+    const ivNotes = iv ? (iv.notes || '') : '';
 
     const html = `
       <div class="mb-3">
@@ -328,16 +360,16 @@ define('forum/calendar-onekite', ['alerts', 'bootbox', 'hooks'], function (alert
       <div class="mt-3">
         <label class="form-label">Adresse</label>
         <div class="input-group">
-          <input type="text" class="form-control" id="onekite-se-address" placeholder="Adresse complète" />
+          <input type="text" class="form-control" id="onekite-se-address" placeholder="Adresse complète" value="${escapeHtml(ivAddress)}" />
           <button class="btn btn-outline-secondary" type="button" id="onekite-se-geocode">Rechercher</button>
         </div>
         <div id="onekite-se-map" style="height:220px; border:1px solid #ddd; border-radius:6px; margin-top:0.5rem;"></div>
-        <input type="hidden" id="onekite-se-lat" />
-        <input type="hidden" id="onekite-se-lon" />
+        <input type="hidden" id="onekite-se-lat" value="${escapeHtml(ivLat)}" />
+        <input type="hidden" id="onekite-se-lon" value="${escapeHtml(ivLon)}" />
       </div>
       <div class="mt-3">
         <label class="form-label">Notes (facultatif)</label>
-        <textarea class="form-control" id="onekite-se-notes" rows="3" placeholder="..."></textarea>
+        <textarea class="form-control" id="onekite-se-notes" rows="3" placeholder="...">${escapeHtml(ivNotes)}</textarea>
       </div>
       ${(kind !== 'outing' && opts && opts.withContent) ? `
       <div class="mt-3">
@@ -349,8 +381,11 @@ define('forum/calendar-onekite', ['alerts', 'bootbox', 'hooks'], function (alert
 
     return await new Promise((resolve) => {
       let resolved = false;
+      const isEditMode = !!iv;
       const dialog = bootbox.dialog({
-        title: kind === 'outing' ? 'Créer une prévision de sortie' : 'Créer un évènement',
+        title: isEditMode
+          ? (kind === 'outing' ? 'Modifier la sortie' : "Modifier l'évènement")
+          : (kind === 'outing' ? 'Créer une prévision de sortie' : 'Créer un évènement'),
         message: html,
         buttons: {
           cancel: {
@@ -362,7 +397,7 @@ define('forum/calendar-onekite', ['alerts', 'bootbox', 'hooks'], function (alert
             },
           },
           ok: {
-            label: 'Créer',
+            label: isEditMode ? 'Enregistrer' : 'Créer',
             className: 'btn-primary',
             callback: () => {
               const title = (document.getElementById('onekite-se-title')?.value || '').trim();
@@ -446,6 +481,14 @@ define('forum/calendar-onekite', ['alerts', 'bootbox', 'hooks'], function (alert
             document.getElementById('onekite-se-lon').value = String(lon);
             map.setView([lat, lon], 14);
           }
+          // Pre-fill marker if editing an event with existing coordinates.
+          if (ivLat && ivLon) {
+            const initLat = Number(ivLat);
+            const initLon = Number(ivLon);
+            if (Number.isFinite(initLat) && Number.isFinite(initLon)) {
+              setMarker(initLat, initLon);
+            }
+          }
           const geocodeBtn = document.getElementById('onekite-se-geocode');
           const addrInput = document.getElementById('onekite-se-address');
           try {
@@ -1223,8 +1266,14 @@ function toDatetimeLocalValue(date) {
     }
 
     if (typeof FullCalendar === 'undefined') {
-      showAlert('error', 'FullCalendar non chargé');
-      return;
+      const loaded = await new Promise((resolve) => {
+        const start = Date.now();
+        const iv = setInterval(() => {
+          if (typeof FullCalendar !== 'undefined') { clearInterval(iv); resolve(true); }
+          else if (Date.now() - start > 5000) { clearInterval(iv); resolve(false); }
+        }, 50);
+      });
+      if (!loaded) { showAlert('error', 'FullCalendar non chargé'); return; }
     }
 
     const items = await loadItems();
@@ -1763,11 +1812,39 @@ function toDatetimeLocalValue(date) {
               ${notes ? `<div class="mb-2"><strong>Notes</strong><br>${escapeHtml(notes).replace(/\n/g,'<br>')}</div>` : ''}
             `;
             const canDel = !!(p.canDeleteSpecial || canDeleteSpecial);
+            const canEdit = !!p.canEditSpecial;
             const dlg = bootbox.dialog({
               title: 'Évènement',
               message: html,
               buttons: {
                 close: { label: 'Fermer', className: 'btn-secondary' },
+                ...(canEdit ? {
+                  edit: {
+                    label: 'Éditer',
+                    className: 'btn-default',
+                    callback: () => {
+                      (async () => {
+                        try { dlg.modal('hide'); } catch (e) { try { bootbox.hideAll(); } catch (e2) {} }
+                        const eid = String(p.eid || ev.id).replace(/^special:/, '');
+                        const initialValues = buildInitialValuesFromEvent(p);
+                        const payload = await openSpecialEventDialog({}, { kind: 'special', initialValues });
+                        if (!payload) return;
+                        try {
+                          await fetchJson(`/api/v3/plugins/calendar-onekite/special-events/${encodeURIComponent(eid)}`, {
+                            method: 'PUT',
+                            body: JSON.stringify(payload),
+                          });
+                          showAlert('success', 'Évènement mis à jour.');
+                          invalidateEventsCache();
+                          scheduleRefetch(calendar);
+                        } catch (e) {
+                          showAlert('error', 'Mise à jour impossible.');
+                        }
+                      })();
+                      return false;
+                    },
+                  },
+                } : {}),
                 ...(canDel ? {
                   del: {
                     label: 'Supprimer',
@@ -1913,11 +1990,39 @@ function toDatetimeLocalValue(date) {
               ${notes ? `<div class="mb-2"><strong>Notes</strong><br>${escapeHtml(notes).replace(/\n/g,'<br>')}</div>` : ''}
             `;
             const canDel = !!(p.canDeleteOuting);
+            const canEditOuting = !!p.canEditOuting;
             const dlg = bootbox.dialog({
               title: 'Sortie',
               message: html,
               buttons: {
                 close: { label: 'Fermer', className: 'btn-secondary' },
+                ...(canEditOuting ? {
+                  edit: {
+                    label: 'Éditer',
+                    className: 'btn-default',
+                    callback: () => {
+                      (async () => {
+                        try { dlg.modal('hide'); } catch (e) { try { bootbox.hideAll(); } catch (e2) {} }
+                        const oid = String(p.oid || ev.id).replace(/^outing:/, '');
+                        const initialValues = buildInitialValuesFromEvent(p);
+                        const payload = await openSpecialEventDialog({}, { kind: 'outing', initialValues });
+                        if (!payload) return;
+                        try {
+                          await fetchJson(`/api/v3/plugins/calendar-onekite/outings/${encodeURIComponent(oid)}`, {
+                            method: 'PUT',
+                            body: JSON.stringify(payload),
+                          });
+                          showAlert('success', 'Sortie mise à jour.');
+                          invalidateEventsCache();
+                          scheduleRefetch(calendar);
+                        } catch (e) {
+                          showAlert('error', 'Mise à jour impossible.');
+                        }
+                      })();
+                      return false;
+                    },
+                  },
+                } : {}),
                 ...(canDel ? {
                   del: {
                     label: 'Supprimer',