nodebb-plugin-onekite-calendar 1.0.26 → 1.0.28

package/lib/admin.js

@@ -41,11 +41,8 @@ async function sendEmail(template, uid, subject, data) {
   try {
     if (typeof emailer.send !== 'function') return;
     // NodeBB 4.x: send(template, uid, params)
-    if (emailer.send.length >= 3) {
-      await emailer.send(template, toUid, params);
-    } else {
-      await emailer.send(template, toUid);
-    }
+    // Do NOT branch on function.length (unreliable once wrapped/bound).
+    await emailer.send(template, toUid, params);
   } catch (err) {
     console.warn('[calendar-onekite] Failed to send email', {
       template,

package/lib/api.js

@@ -123,12 +123,11 @@ async function sendEmail(template, uid, subject, data) {
 
   try {
     if (typeof emailer.send !== 'function') return;
-    // NodeBB: send(template, uid, params)
-    if (emailer.send.length >= 3) {
-      await emailer.send(template, toUid, params);
-    } else {
-      await emailer.send(template, toUid);
-    }
+    // NodeBB 4.x: send(template, uid, params)
+    // NOTE: Do NOT branch on function.length: it is unreliable once the function
+    // is wrapped/bound (common in production builds) and can lead to params being
+    // dropped, resulting in empty email bodies and missing subjects.
+    await emailer.send(template, toUid, params);
   } catch (err) {
     // eslint-disable-next-line no-console
     console.warn('[calendar-onekite] Failed to send email', { template, uid: toUid, err: String((err && err.message) || err) });

package/lib/helloassoWebhook.js

@@ -32,11 +32,9 @@ async function sendEmail(template, uid, subject, data) {
     if (typeof emailer.send !== 'function') return;
     const params = Object.assign({}, data || {}, subject ? { subject } : {});
     // NodeBB 4.x: send(template, uid, params)
-    if (emailer.send.length >= 3) {
-      await emailer.send(template, toUid, params);
-    } else {
-      await emailer.send(template, toUid);
-    }
+    // Do NOT branch on function.length: it is unreliable once wrapped/bound and
+    // can lead to params being dropped (empty email bodies / missing subjects).
+    await emailer.send(template, toUid, params);
   } catch (err) {
     // eslint-disable-next-line no-console
     console.warn('[calendar-onekite] Failed to send email (webhook)', { template, uid: toUid, err: String((err && err.message) || err) });

package/lib/scheduler.js

@@ -66,12 +66,9 @@ async function processAwaitingPayment() {
 
     try {
       if (typeof emailer.send !== 'function') return;
-      // NodeBB: send(template, uid, params)
-      if (emailer.send.length >= 3) {
-        await emailer.send(template, toUid, params);
-      } else {
-        await emailer.send(template, toUid);
-      }
+      // NodeBB 4.x: send(template, uid, params)
+      // Do NOT branch on function.length (unreliable once wrapped/bound).
+      await emailer.send(template, toUid, params);
     } catch (err) {
       // eslint-disable-next-line no-console
       console.warn('[calendar-onekite] Failed to send email (scheduler)', {

package/lib/widgets.js

@@ -279,7 +279,7 @@ dateClick: function() { window.location.href = calUrl; },
           const title = (ep.itemNameLine || ep.title || ev.title || '').toString();
           const statusLabel = (function(s){
             const map = {
-              pending: 'En attente',
+              pending: 'En attente de validation',
               awaiting_payment: 'Validée – paiement en attente',
               paid: 'Payée',
               rejected: 'Rejetée',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-onekite-calendar",
-  "version": "1.0.26",
+  "version": "1.0.28",
   "description": "FullCalendar-based equipment reservation workflow with admin approval & HelloAsso payment for NodeBB",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -39,5 +39,5 @@
   "acpScripts": [
     "public/admin.js"
   ],
-  "version": "1.0.26"
+  "version": "1.0.28"
 }

package/public/client.js

@@ -387,7 +387,7 @@ define('forum/calendar-onekite', ['alerts', 'bootbox', 'hooks'], function (alert
 
   function statusLabel(s) {
     const map = {
-      pending: 'En attente',
+      pending: 'En attente de validation',
       awaiting_payment: 'Validée – paiement en attente',
       paid: 'Payée',
       rejected: 'Rejetée',