nodebb-plugin-moving-topics 1.0.0 → 1.1.0

package/README.md

@@ -9,6 +9,7 @@ Allow topic owners to move their own topics between categories, without granting
 - Moves are blocked for **locked** or **deleted** topics.
 - Target categories are filtered by `topics:create` + `topics:read`.
 - Admins/moderators retain existing move permissions.
+- Optional limit by number of posts in the topic (default: 5).
 
 ## Requirements
 
@@ -39,7 +40,11 @@ Then rebuild and restart:
 
 ## Configuration
 
-No settings are required. The plugin respects existing category permissions.
+Admin control panel: `/admin/settings/post`
+
+- **Maximum posts to allow owner moves** (`movingTopicsMaxPosts`)
+  - Default: `5`
+  - Set to `0` for no limit
 
 ## Usage
 

package/languages/en-GB/moving-topics.json

@@ -0,0 +1,6 @@
+{
+  "admin.settings.title": "Topic move (owners)",
+  "admin.settings.max-posts": "Maximum posts to allow owner moves",
+  "admin.settings.max-posts-help": "Set to 0 for no limit. Default: 5.",
+  "error.max-posts": "Cannot move a topic with more than %1 posts"
+}

package/languages/he/moving-topics.json

@@ -0,0 +1,6 @@
+{
+  "admin.settings.title": "העברת נושאים (בעלים)",
+  "admin.settings.max-posts": "מספר פוסטים מקסימלי להעברת נושא",
+  "admin.settings.max-posts-help": "קבעו 0 ללא הגבלה. ברירת מחדל: 5.",
+  "error.max-posts": "לא ניתן להעביר נושא שיש בו מעל %1 פוסטים"
+}

package/library.js

@@ -9,6 +9,14 @@ function getCore(path) {
 	return require.main.require(path);
 }
 
+function getMaxMovablePosts(meta) {
+	const value = parseInt(meta.config.movingTopicsMaxPosts, 10);
+	if (Number.isNaN(value)) {
+		return 5;
+	}
+	return value;
+}
+
 plugin.init = async function () {
 	if (patchedMove) {
 		return;
@@ -25,6 +33,7 @@ plugin.init = async function () {
 	const activitypubApi = getCore('./src/api/activitypub');
 	const activitypub = getCore('./src/activitypub');
 	const user = getCore('./src/user');
+	const meta = getCore('./src/meta');
 
 	originalMove = topicsApi.move;
 	
@@ -48,6 +57,7 @@ plugin.init = async function () {
 
 		const uids = await user.getUidsFromSet('users:online', 0, -1);
 		const cids = [targetCid];
+		const maxPosts = getMaxMovablePosts(meta);
 
 		await batch.processArray(tids, async (batchTids) => {
 			await Promise.all(batchTids.map(async (tid) => {
@@ -59,6 +69,7 @@ plugin.init = async function () {
 					'slug',
 					'deleted',
 					'locked',
+					'postcount',
 				]);
 
 				if (!topicData) {
@@ -66,6 +77,10 @@ plugin.init = async function () {
 				}
 
 				const isOwner = parseInt(topicData.uid, 10) === parseInt(caller.uid, 10);
+				const exceedsMax = maxPosts > 0 && topicData.postcount > maxPosts;
+				if (exceedsMax) {
+					throw new Error(`[[moving-topics:error.max-posts, ${maxPosts}]]`);
+				}
 				if (!isOwner || topicData.locked || topicData.deleted) {
 					throw new Error('[[error:no-privileges]]');
 				}
@@ -106,13 +121,22 @@ plugin.init = async function () {
 
 plugin.filterTopicPrivileges = async function (data) {
 	const topics = getCore('./src/topics');
-	const topicData = await topics.getTopicFields(data.tid, ['uid', 'locked', 'deleted']);
+	const meta = getCore('./src/meta');
+	const topicData = await topics.getTopicFields(data.tid, ['uid', 'locked', 'deleted', 'postcount']);
 	if (!topicData) {
 		return data;
 	}
 
+	const maxPosts = getMaxMovablePosts(meta);
+	const exceedsMax = maxPosts > 0 && topicData.postcount > maxPosts;
 	const isOwner = parseInt(topicData.uid, 10) === parseInt(data.uid, 10);
-	data.canMoveOwnTopic = !!(isOwner && !data.isAdminOrMod && !topicData.locked && !topicData.deleted);
+	data.canMoveOwnTopic = !!(
+		isOwner &&
+		!data.isAdminOrMod &&
+		!topicData.locked &&
+		!topicData.deleted &&
+		!exceedsMax
+	);
 
 	if (data.canMoveOwnTopic && !data.view_thread_tools) {
 		data.view_thread_tools = true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-moving-topics",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "Allow topic owners to move their own topics.",
   "main": "library.js",
   "license": "MIT"

package/plugin.json

@@ -8,7 +8,12 @@
     { "hook": "static:app.load", "method": "init" },
     { "hook": "filter:privileges.topics.get", "method": "filterTopicPrivileges" }
   ],
+  "acpScripts": [
+    "static/lib/admin.js"
+  ],
   "scripts": [
     "static/lib/client.js"
-  ]
+  ],
+  "languages": "languages",
+  "defaultLang": "en-GB"
 }

package/static/lib/admin.js

@@ -0,0 +1,50 @@
+'use strict';
+
+/* global ajaxify, app */
+
+let inserted = false;
+
+$(window).on('action:app.load', function () {
+	require(['hooks', 'translator', 'admin/settings'], function (hooks, translator, Settings) {
+		hooks.on('action:ajaxify.end', function () {
+			if (!ajaxify.data || !ajaxify.data.template || !ajaxify.data.template['admin/settings/post']) {
+				inserted = false;
+				return;
+			}
+
+			const container = $('#spy-container');
+			if (!container.length) {
+				return;
+			}
+
+			if (inserted) {
+				return;
+			}
+
+			const sectionHtml = [
+				'<hr/>',
+				'<div id="moving-topics-settings" class="mb-4">',
+				'<h5 class="fw-bold tracking-tight settings-header">[[moving-topics:admin.settings.title]]</h5>',
+				'<div class="mb-3">',
+				'<label class="form-label" for="movingTopicsMaxPosts">[[moving-topics:admin.settings.max-posts]]</label>',
+				'<input id="movingTopicsMaxPosts" type="number" min="0" class="form-control" data-field="movingTopicsMaxPosts" placeholder="5">',
+				'<p class="form-text">[[moving-topics:admin.settings.max-posts-help]]</p>',
+				'</div>',
+				'</div>',
+			].join('');
+
+			translator.translate(sectionHtml, function (translated) {
+				container.append(translated);
+				inserted = true;
+
+				if (!app.config.hasOwnProperty('movingTopicsMaxPosts')) {
+					$('#movingTopicsMaxPosts').val(5);
+				} else {
+					$('#movingTopicsMaxPosts').val(app.config.movingTopicsMaxPosts);
+				}
+
+				Settings.prepare();
+			});
+		});
+	});
+});