nodebb-plugin-mentions 4.8.14 → 4.8.16

package/library.js

@@ -607,8 +607,10 @@ SocketPlugins.mentions.listGroups = async function () {
 	const noMentionGroups = await getNoMentionGroups();
 	const filteredGroups = groups.filter(g => g && !noMentionGroups.includes(g))
 		.map(g => validator.escape(String(g)));
-
-	return filteredGroups;
+	const fields = ['name', 'slug', 'icon', 'memberCount', 'labelColor', 'textColor'];
+	return (await Groups.getGroupsFields(filteredGroups, fields))
+		.filter(g => g && g.name && g.slug)
+		.map(g => ({ ..._.pick(g, fields), isGroup: true }));
 };
 
 SocketPlugins.mentions.userSearch = async (socket, data) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-mentions",
-  "version": "4.8.14",
+  "version": "4.8.16",
   "description": "NodeBB Plugin that allows users to mention other users by prepending an '@' sign to their username",
   "main": "library.js",
   "repository": {

package/static/autofill.js

@@ -7,7 +7,6 @@ $(document).ready(function () {
 	const categorySlugMap = new Map();
 	let localUserList = [];
 	let helpers;
-	let groupTranslation = '';
 
 	function showAlert(type, message) {
 		require(['alerts'], function (alerts) {
@@ -26,14 +25,6 @@ $(document).ready(function () {
 			loadCategoryList();
 		}
 
-		if (!groupTranslation) {
-			require(['translator'], function (translator) {
-				translator.translate('[[groups:group]]', function (translation) {
-					groupTranslation = translation;
-				});
-			});
-		}
-
 		let slugify;
 		const strategy = {
 			match: /\B@([^\s\n]*)?$/,
@@ -131,8 +122,12 @@ $(document).ready(function () {
 				return `${avatar} ${entry.name}${!utils.isNumber(entry.cid) ? ` (${entry.slug})` : ''}`;
 			}
 			case entry.isGroup: {
-				const icon = '<i class="fa-fw fa-solid fa-users text-secondary" style="width: 24px;"></i>';
-				return `${icon} ${entry.name} (${groupTranslation})`;
+				const icon = helpers.buildCategoryIcon({
+					icon: entry.icon || 'fa-users',
+					bgColor: entry.labelColor,
+					color: entry.textColor,
+				}, '24px', 'rounded-circle');
+				return `${icon} ${entry.name} <span class="text-sm text-secondary">(${entry.memberCountText})</span>`;
 			}
 
 			default:
@@ -173,14 +168,13 @@ $(document).ready(function () {
 		});
 	}
 
-	function loadGroupList() {
-		socket.emit('plugins.mentions.listGroups', async function (err, groupNames) {
-			if (err) {
-				return showAlert('error', err.message);
-			}
-			const s = await app.require('slugify');
-			groupList = groupNames.map(name => ({ name, slug: s(name), isGroup: true }));
-		});
+	async function loadGroupList() {
+		groupList = await socket.emit('plugins.mentions.listGroups');
+		const [translator, helpers] = await app.require(['translator', 'helpers']);
+		await Promise.all(groupList.map(async (group) => {
+			const key = translator.compile('groups:x-members', helpers.formattedNumber(group.memberCount));
+			group.memberCountText = await translator.translate(key);
+		}));
 	}
 
 	function loadCategoryList() {