nodebb-plugin-mentions 4.7.0 → 4.7.2

package/library.js

@@ -81,7 +81,7 @@ function getNoMentionGroups() {
 }
 
 Mentions.notify = async function ({ post }) {
-	const postOwner = parseInt(post.uid, 10);
+	const postOwner = String(post.uid);
 
 	let uidsToNotify;
 	let groupsToNotify;
@@ -109,9 +109,9 @@ Mentions.notify = async function ({ post }) {
 	} else if (post._activitypub) { // ActivityPub
 		const { tag } = post._activitypub;
 		groupsToNotify = []; // cannot mention groups for now
-
+		let slugs = [];
 		if (Array.isArray(tag) && tag.length) {
-			const slugs = tag.reduce((slugs, tag) => {
+			slugs = tag.reduce((slugs, tag) => {
 				if (tag.type === 'Mention' && tag.name && typeof tag.name === 'string') {
 					const [slug, hostname] = tag.name.slice(1).split('@');
 					if (hostname === nconf.get('url_parsed').hostname) {
@@ -120,18 +120,16 @@ Mentions.notify = async function ({ post }) {
 				}
 				return slugs;
 			}, []);
-
-			uidsToNotify = slugs.length ? await db.sortedSetScores('userslug:uid', slugs) : [];
-		} else {
-			uidsToNotify = [];
 		}
+		uidsToNotify = slugs.length ? await db.sortedSetScores('userslug:uid', slugs) : [];
+		uidsToNotify = uidsToNotify.map(String);
 	}
 
 	if ((!uidsToNotify && !groupsToNotify) || (!uidsToNotify.length && !groupsToNotify.length)) {
 		return;
 	}
 
-	let [topic, userData, topicFollowers] = await Promise.all([
+	const [topic, userData, topicFollowers] = await Promise.all([
 		Topics.getTopicFields(post.tid, ['title', 'cid']),
 		User.getUserFields(post.uid, ['username']),
 		Mentions._settings.disableFollowedTopics === 'on' ? Topics.getFollowers(post.tid) : [],
@@ -139,10 +137,9 @@ Mentions.notify = async function ({ post }) {
 	const { displayname } = userData;
 	const title = entitiesDecode(topic.title);
 	const titleEscaped = title.replace(/%/g, '%').replace(/,/g, ',');
-	topicFollowers = topicFollowers.map(uid => parseInt(uid, 10));
 
 	let uids = uidsToNotify.filter(
-		uid => parseInt(uid, 10) !== postOwner && !topicFollowers.includes(parseInt(uid, 10))
+		uid => uid !== postOwner && !topicFollowers.includes(uid)
 	);
 
 	if (Mentions._settings.privilegedDirectReplies === 'on') {
@@ -158,7 +155,7 @@ Mentions.notify = async function ({ post }) {
 			}
 			groupMemberUids[uid] = 1;
 			return !uids.includes(uid) &&
-				parseInt(uid, 10) !== postOwner &&
+				uid !== postOwner &&
 				!topicFollowers.includes(uid);
 		});
 	});
@@ -492,7 +489,7 @@ Mentions.parseRaw = async (content, type = 'default') => {
 					if (type === 'markdown') {
 						str = `[${match}](${nconf.get('url')}${url})`;
 					} else {
-						str = `<a class="plugin-mentions-${mentionType} plugin-mentions-a" href="${url}">${match}</a>`;
+						str = `<a class="plugin-mentions-${mentionType} plugin-mentions-a" href="${url}">@<bdi>${match.slice(1)}</bdi></a>`;
 					}
 
 					return plain + str;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-mentions",
-  "version": "4.7.0",
+  "version": "4.7.2",
   "description": "NodeBB Plugin that allows users to mention other users by prepending an '@' sign to their username",
   "main": "library.js",
   "repository": {
@@ -28,7 +28,7 @@
   },
   "devDependencies": {
     "eslint": "^9.0.0",
-    "eslint-config-nodebb": "0.2.1",
+    "eslint-config-nodebb": "1.0.7",
     "eslint-plugin-import": "2.31.0",
     "mocha": "11.1.0"
   }