nodebb-plugin-mentions 4.6.7 → 4.6.9

package/library.js

@@ -127,11 +127,11 @@ Mentions.notify = async function ({ post }) {
 		}
 	}
 
-	if (!uidsToNotify.length && !groupsToNotify.length) {
+	if ((!uidsToNotify && !groupsToNotify) || (!uidsToNotify.length && !groupsToNotify.length)) {
 		return;
 	}
 
-	const [topic, userData, topicFollowers] = await Promise.all([
+	let [topic, userData, topicFollowers] = await Promise.all([
 		Topics.getTopicFields(post.tid, ['title', 'cid']),
 		User.getUserFields(post.uid, ['username']),
 		Mentions._settings.disableFollowedTopics === 'on' ? Topics.getFollowers(post.tid) : [],
@@ -139,6 +139,7 @@ Mentions.notify = async function ({ post }) {
 	const { displayname } = userData;
 	const title = entitiesDecode(topic.title);
 	const titleEscaped = title.replace(/%/g, '%').replace(/,/g, ',');
+	topicFollowers = topicFollowers.map(uid => parseInt(uid, 10));
 
 	let uids = uidsToNotify.filter(
 		uid => parseInt(uid, 10) !== postOwner && !topicFollowers.includes(uid)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-mentions",
-  "version": "4.6.7",
+  "version": "4.6.9",
   "description": "NodeBB Plugin that allows users to mention other users by prepending an '@' sign to their username",
   "main": "library.js",
   "repository": {
@@ -29,7 +29,7 @@
   "devDependencies": {
     "eslint": "^9.0.0",
     "eslint-config-nodebb": "0.2.1",
-    "eslint-plugin-import": "2.29.1",
-    "mocha": "10.6.0"
+    "eslint-plugin-import": "2.30.0",
+    "mocha": "10.7.3"
   }
 }

package/static/autofill.js

@@ -37,6 +37,14 @@ $(document).ready(function () {
 						composerObj: composer.posts[uuid],
 					}, function (err, users) {
 						if (err) {
+							require(['alerts'], function (alerts) {
+								alerts.alert({
+									id: 'mention-error',
+									type: 'danger',
+									message: err.message,
+									timeout: 5000,
+								});
+							});
 							return callback([]);
 						}
 						const termLowerCase = term.toLocaleLowerCase();