nodebb-plugin-mentions 3.0.4 → 3.0.7

package/library.js

@@ -388,7 +388,8 @@ async function stripDisallowedFullnames(users) {
 
 SocketPlugins.mentions.getTopicUsers = async (socket, data) => {
 	const uids = await Topics.getUids(data.tid);
-	const users = await User.getUsers(uids);
+	let users = await User.getUsers(uids);
+	users = users.filter(u => u && u.userslug);
 	if (Meta.config.hideFullname) {
 		return users;
 	}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-mentions",
-  "version": "3.0.4",
+  "version": "3.0.7",
   "description": "NodeBB Plugin that allows users to mention other users by prepending an '@' sign to their username",
   "main": "library.js",
   "scripts": {
@@ -31,9 +31,9 @@
     "xregexp": "^5.1.0"
   },
   "devDependencies": {
-    "mocha": "9.1.3",
-    "eslint": "8.4.0",
+    "mocha": "9.2.1",
+    "eslint": "8.10.0",
     "eslint-config-nodebb": "0.1.1",
-    "eslint-plugin-import": "2.25.3"
+    "eslint-plugin-import": "2.25.4"
   }
 }

package/plugin.json

@@ -22,9 +22,9 @@
 	"scripts": [
 		"static/autofill.js"
 	],
-	"acpScripts": [
-		"static/admin.js"
-	],
+	"modules": {
+		"../admin/plugins/mentions.js": "./static/admin.js"
+	},
 	"languages": "languages",
 	"defaultLang": "en_GB",
 	"templates": "templates"

package/static/.eslintrc

@@ -0,0 +1,3 @@
+{
+	"extends": "nodebb/public"
+}

package/static/autofill.js

@@ -1,12 +1,11 @@
-"use strict";
-/* globals socket, app */
 
+'use strict';
 
-$(document).ready(function() {
+$(document).ready(function () {
 	let groupList = [];
 	let localUserList = [];
 
-	$(window).on('composer:autocomplete:init chat:autocomplete:init', function(ev, data) {
+	$(window).on('composer:autocomplete:init chat:autocomplete:init', function (ev, data) {
 		loadTopicUsers(data.element);
 
 		if (!groupList.length) {
@@ -30,7 +29,7 @@ $(document).ready(function() {
 					socket.emit('plugins.mentions.userSearch', {
 						query: term,
 						composerObj: composer.posts[uuid],
-					}, function(err, users) {
+					}, function (err, users) {
 						if (err) {
 							return callback([]);
 						}
@@ -40,7 +39,7 @@ $(document).ready(function() {
 						// Add groups that start with the search term
 						const groupMentions = groupList.filter(function (groupName) {
 							return groupName.toLocaleLowerCase().startsWith(term.toLocaleLowerCase());
-						}).sort(function(a, b) {
+						}).sort(function (a, b) {
 							return a.toLocaleLowerCase() > b.toLocaleLowerCase() ? 1 : -1;
 						});
 						// Add group mentions at the bottom of dropdown
@@ -59,24 +58,24 @@ $(document).ready(function() {
 				mention.find('span').remove();
 				return '@' + slugify(mention.text(), true) + ' ';
 			},
-			cache: true
+			cache: true,
 		};
 
 		data.strategies.push(strategy);
 	});
 
-	$(window).on('action:composer.loaded', function(e, data) {
+	$(window).on('action:composer.loaded', function (ev, data) {
 		const composer = $('#cmp-uuid-' + data.post_uuid + ' .write');
 		composer.attr('data-mentions', '1');
 	});
 
-	function sortUsers (users) {
+	function sortUsers(users) {
 		return users.sort(function (user1, user2) {
 			return user1.username.toLocaleLowerCase() > user2.username.toLocaleLowerCase() ? 1 : -1;
 		});
 	}
 
-	function usersToMentions (users, helpers) {
+	function usersToMentions(users, helpers) {
 		return users.reduce(function (carry, user) {
 			// Don't add current user to suggestions
 			if (app.user.username && app.user.username === user.username) {
@@ -93,7 +92,7 @@ $(document).ready(function() {
 	}
 
 	function loadTopicUsers(element) {
-		require(['composer'], function (composer) {
+		require(['composer', 'alerts'], function (composer, alerts) {
 			const composerEl = element.parents('.composer').get(0);
 			if (!composerEl) {
 				return;
@@ -110,21 +109,23 @@ $(document).ready(function() {
 			socket.emit('plugins.mentions.getTopicUsers', {
 				tid: composerObj.tid,
 			}, function (err, users) {
+				if (err) {
+					return alerts.error(err);
+				}
 				localUserList = users;
 			});
 		});
 	}
 
 	function loadGroupList() {
-		socket.emit('plugins.mentions.listGroups', function(err, groupNames) {
+		socket.emit('plugins.mentions.listGroups', function (err, groupNames) {
 			if (err) {
 				require(['alerts'], function (alerts) {
 					alerts.error(err);
-				})
+				});
 				return;
 			}
 			groupList = groupNames;
 		});
 	}
-
 });