nodebb-plugin-integration 0.4.2 → 0.4.4

package/src/routes/api.js

@@ -1,97 +1,255 @@
-"use strict";
-
-/**
- * NodeBB Integration Layer
- *
- * API controllers
- */
-
-const Config = require("../config");
-const Search = require("../ai/search");
-const Meta = require("../nodebb/meta");
-
-/**
- * GET /api/v3/integration/info
- */
-exports.apiInfo = async function (req, res) {
-
-    try {
-
-        const forum = await Meta.getInfo();
-        const settings = await Config.info();
-
-        res.json({
-            success: true,
-            forum,
-            settings
-        });
-
-    } catch (err) {
-
-        res.status(500).json({
-            success: false,
-            error: err.message
-        });
-
-    }
-
-};
-
-/**
- * POST /api/v3/integration/search
- */
-exports.apiSearch = async function (req, res) {
-
-    try {
-
-        const query = req.body?.query || "";
-        const limit = Number(req.body?.limit || 5);
-
-        const result = await Search.searchText(
-            query,
-            limit
-        );
-
-        res.json({
-            success: true,
-            result
-        });
-
-    } catch (err) {
-
-        res.status(500).json({
-            success: false,
-            error: err.message
-        });
-
-    }
-
-};
-
-/**
- * ACP page
- */
-exports.renderAdmin = async function (req, res) {
-
-    try {
-
-        const settings = await Config.get();
-
-        res.render(
-            "admin/plugins/integration",
-            {
-                title: "NodeBB Integration",
-
-                settings
-            }
-        );
-
-    } catch (err) {
-
-        res.status(500).render("500", {
-            error: err.message
-        });
-
-    }
-
-};
+"use strict";
+
+const crypto = require("crypto");
+
+const Config = require("../config");
+const Search = require("../ai/search");
+const Categories = require("../nodebb/categories");
+const Meta = require("../nodebb/meta");
+const Posts = require("../nodebb/posts");
+const Topics = require("../nodebb/topics");
+const Users = require("../nodebb/users");
+const Privileges = require("../nodebb/privileges");
+
+function validId(value) {
+    const id = Number(value);
+    return Number.isSafeInteger(id) && id > 0 ? id : 0;
+}
+
+function internalTokenMatches(req, expected) {
+    const authorization = req.headers.authorization || "";
+    const match = authorization.match(/^Bearer\s+([^\s]+)$/i);
+
+    if (!match || typeof expected !== "string" || !expected) {
+        return false;
+    }
+
+    const actualBuffer = Buffer.from(match[1]);
+    const expectedBuffer = Buffer.from(expected);
+
+    return actualBuffer.length === expectedBuffer.length &&
+        crypto.timingSafeEqual(actualBuffer, expectedBuffer);
+}
+
+exports.internalAuth = async function (req, res, next) {
+    try {
+        const settings = await Config.get();
+
+        if (!settings.mcpEnabled) {
+            return res.status(403).json({ error: "MCP is disabled" });
+        }
+
+        if (!internalTokenMatches(req, settings.internalApiToken)) {
+            return res.status(401).json({ error: "Unauthorized" });
+        }
+
+        req.integrationSettings = settings;
+        return next();
+    } catch (error) {
+        console.error("[Integration] Internal authentication failed:", error.message);
+        return res.status(500).json({ error: "Internal API error" });
+    }
+};
+
+exports.apiSearch = async function (req, res) {
+    try {
+        const query = typeof req.body?.query === "string"
+            ? req.body.query.trim()
+            : "";
+
+        if (!query || query.length > 2000) {
+            return res.status(400).json({ error: "Invalid search query" });
+        }
+
+        const results = await Search.searchText(query, req.uid);
+
+        return res.json({ results });
+    } catch (error) {
+        if (error.code === "AI_DISABLED") {
+            return res.status(503).json({ error: error.message });
+        }
+
+        console.error("[NodeBB Integration] Search failed:", error);
+        return res.status(500).json({ error: "Search failed" });
+    }
+};
+
+exports.internalInfo = async function (req, res) {
+    try {
+        return res.json(await Meta.getInfo());
+    } catch (error) {
+        console.error("[Integration] Forum info failed:", error.message);
+        return res.status(500).json({ error: "Unable to get forum information" });
+    }
+};
+
+exports.internalPost = async function (req, res) {
+    try {
+        const pid = validId(req.body?.pid);
+        const uid = req.integrationSettings.mcpServiceUid;
+
+        if (!pid) {
+            return res.status(400).json({ error: "Invalid post ID" });
+        }
+
+        const post = await Posts.getPostMeta(pid);
+
+        if (!post || post.deleted) {
+            return res.status(404).json({ error: "Post not found" });
+        }
+
+        const tid = validId(post.tid);
+
+        if (!tid) {
+            return res.status(404).json({ error: "Post not found" });
+        }
+
+        const [postAllowed, topicAllowed] = await Promise.all([
+            Privileges.canReadPost(pid, uid),
+            Privileges.canReadTopic(tid, uid)
+        ]);
+
+        if (!postAllowed || !topicAllowed) {
+            return res.status(404).json({ error: "Post not found" });
+        }
+
+        const content = await Posts.getPostContent(pid);
+
+        if (!content) {
+            return res.status(404).json({ error: "Post not found" });
+        }
+
+        return res.json({
+            pid: Number(post.pid),
+            tid,
+            uid: Number(post.uid),
+            cid: Number(post.cid),
+            content: content.content,
+            timestamp: post.timestamp
+        });
+    } catch (error) {
+        console.error("[Integration] MCP post retrieval failed:", error.message);
+        return res.status(500).json({ error: "Unable to get post" });
+    }
+};
+
+exports.internalTopic = async function (req, res) {
+    try {
+        const tid = validId(req.body?.tid);
+        const uid = req.integrationSettings.mcpServiceUid;
+
+        if (!tid) {
+            return res.status(400).json({ error: "Invalid topic ID" });
+        }
+
+        if (!(await Privileges.canReadTopic(tid, uid))) {
+            return res.status(404).json({ error: "Topic not found" });
+        }
+
+        const topic = await Topics.getTopic(tid);
+
+        if (!topic || topic.deleted) {
+            return res.status(404).json({ error: "Topic not found" });
+        }
+
+        return res.json({
+            tid: Number(topic.tid),
+            uid: Number(topic.uid),
+            title: topic.title,
+            cid: Number(topic.cid),
+            timestamp: topic.timestamp,
+            mainPid: Number(topic.mainPid)
+        });
+    } catch (error) {
+        console.error("[Integration] MCP topic retrieval failed:", error.message);
+        return res.status(500).json({ error: "Unable to get topic" });
+    }
+};
+
+exports.internalUser = async function (req, res) {
+    try {
+        const uid = validId(req.body?.uid);
+
+        if (!uid) {
+            return res.status(400).json({ error: "Invalid user ID" });
+        }
+
+        const user = await Users.getUser(uid);
+
+        if (!user || !Number(user.uid)) {
+            return res.status(404).json({ error: "User not found" });
+        }
+
+        return res.json({
+            uid: Number(user.uid),
+            username: user.username,
+            userslug: user.userslug,
+            picture: user.picture
+        });
+    } catch (error) {
+        console.error("[Integration] MCP user retrieval failed:", error.message);
+        return res.status(500).json({ error: "Unable to get user" });
+    }
+};
+
+exports.internalSearch = async function (req, res) {
+    try {
+        const query = typeof req.body?.query === "string"
+            ? req.body.query.trim()
+            : "";
+
+        const requestedLimit = Number(req.body?.limit ?? 5);
+
+        if (!query || query.length > 2000) {
+            return res.status(400).json({ error: "Invalid search query" });
+        }
+
+        if (!Number.isSafeInteger(requestedLimit) || requestedLimit < 1) {
+            return res.status(400).json({ error: "Invalid search limit" });
+        }
+
+        const limit = Math.min(requestedLimit, 20);
+        const uid = req.integrationSettings.mcpServiceUid;
+
+        const results = await Search.searchText(query, uid, limit);
+
+        return res.json({ results });
+    } catch (error) {
+        if (error.code === "AI_DISABLED") {
+            return res.status(503).json({ error: error.message });
+        }
+
+        console.error("[Integration] MCP search failed:", error.message);
+        return res.status(500).json({ error: "Search failed" });
+    }
+};
+
+exports.renderAdmin = async function (req, res) {
+    try {
+        const [settings, allCategories] = await Promise.all([
+            Config.info(),
+            Categories.getAll()
+        ]);
+
+        const excluded = new Set(settings.excludedCategories.map(Number));
+
+        const categories = allCategories
+            .filter(category => category.cid > 0)
+            .map(category => ({
+                ...category,
+                selected: excluded.has(Number(category.cid))
+            }));
+
+        return res.render("admin/plugins/integration", {
+            title: "NodeBB Integration",
+            settings,
+            categories
+        });
+    } catch (error) {
+        console.error("[NodeBB Integration] ACP render failed:", error);
+
+        return res.status(500).render("500", {
+            title: "NodeBB Integration error"
+        });
+    }
+};

package/src/routes/index.js

@@ -1,49 +1,64 @@
-"use strict";
-
-/**
- * NodeBB Integration Layer
- *
- * Routes
- */
-
-const API = require("./api");
-
-exports.init = function (router, middleware) {
-
-    if (!router) {
-        return;
-    }
-
-    /*
-     * REST API
-     */
-
-    router.get(
-        "/api/v3/integration/info",
-        API.apiInfo
-    );
-
-    router.post(
-        "/api/v3/integration/search",
-        API.apiSearch
-    );
-
-    /*
-     * ACP page
-     */
-
-    if (
-        middleware &&
-        middleware.admin &&
-        typeof middleware.admin.buildHeader === "function"
-    ) {
-
-        router.get(
-            "/admin/plugins/integration",
-            middleware.admin.buildHeader,
-            API.renderAdmin
-        );
-
-    }
-
-};
+"use strict";
+
+const API = require("./api");
+
+exports.init = function (router, middleware) {
+    if (!router || !middleware) {
+        throw new Error("[Integration] Router middleware unavailable");
+    }
+
+    if (typeof middleware.pluginHooks !== "function") {
+        throw new Error("[Integration] pluginHooks middleware unavailable");
+    }
+
+    const helpers = nodebb.require("./src/routes/helpers");
+
+    if (typeof helpers.setupAdminPageRoute !== "function") {
+        throw new Error("[Integration] setupAdminPageRoute unavailable");
+    }
+
+    // Existing user-facing semantic search.
+    router.post(
+        "/api/v3/integration/search",
+        middleware.ensureLoggedIn,
+        API.apiSearch
+    );
+
+    router.get(
+        "/api/v3/integration/internal/info",
+        API.internalAuth,
+        API.internalInfo
+    );
+
+    router.post(
+        "/api/v3/integration/internal/post",
+        API.internalAuth,
+        API.internalPost
+    );
+
+    router.post(
+        "/api/v3/integration/internal/topic",
+        API.internalAuth,
+        API.internalTopic
+    );
+
+    router.post(
+        "/api/v3/integration/internal/user",
+        API.internalAuth,
+        API.internalUser
+    );
+
+    router.post(
+        "/api/v3/integration/internal/search",
+        API.internalAuth,
+        API.internalSearch
+    );
+
+    // Existing ACP page.
+    helpers.setupAdminPageRoute(
+        router,
+        "/admin/plugins/integration",
+        [middleware.pluginHooks],
+        API.renderAdmin
+    );
+};

package/templates/admin/plugins/integration.tpl

@@ -1,130 +0,0 @@
-<div class="acp-page-container">
-
-    <h1>
-        <i class="fa fa-robot"></i>
-        {{title}}
-    </h1>
-
-    <hr />
-
-    <form role="form">
-
-        <div class="mb-3">
-
-            <label class="form-label">
-                {{settings.ai-provider}}
-            </label>
-
-            <select
-                class="form-select"
-                name="aiProvider"
-            >
-                <option value="fake">Fake</option>
-                <option value="openai">OpenAI</option>
-            </select>
-
-        </div>
-
-        <div class="mb-3">
-
-            <label class="form-label">
-                OpenAI API Key
-            </label>
-
-            <input
-                type="password"
-                class="form-control"
-                name="openaiApiKey"
-                autocomplete="off"
-            />
-
-        </div>
-
-        <div class="mb-3">
-
-            <label class="form-label">
-                OpenAI Embedding Model
-            </label>
-
-            <input
-                class="form-control"
-                name="openaiModel"
-            />
-
-        </div>
-
-        <div class="mb-3">
-
-            <label class="form-label">
-                Qdrant URL
-            </label>
-
-            <input
-                class="form-control"
-                name="qdrantUrl"
-            />
-
-        </div>
-
-        <div class="mb-3">
-
-            <label class="form-label">
-                Collection
-            </label>
-
-            <input
-                class="form-control"
-                name="collection"
-            />
-
-        </div>
-
-        <div class="form-check mb-3">
-
-            <input
-                id="mcpEnabled"
-                class="form-check-input"
-                type="checkbox"
-                name="mcpEnabled"
-            />
-
-            <label
-                class="form-check-label"
-                for="mcpEnabled"
-            >
-                Enable MCP Server
-            </label>
-
-        </div>
-
-        <div class="mb-3">
-
-            <label class="form-label">
-                MCP Port
-            </label>
-
-            <input
-                class="form-control"
-                name="mcpPort"
-                type="number"
-            />
-
-        </div>
-
-        <hr />
-
-        <button
-            id="save"
-            class="btn btn-primary"
-            type="button"
-        >
-
-            <i class="fa fa-save"></i>
-
-            Save Settings
-
-        </button>
-
-    </form>
-
-</div>