nodebb-plugin-facebook-post 1.0.9 → 1.0.11

package/library.js

@@ -383,15 +383,6 @@ Plugin.addAdminNavigation = async function (header) {
   return header;
 };
 
-Plugin.addClientScripts = async function (scripts) {
-  scripts.push('/plugins/nodebb-plugin-facebook-post/lib/composer.js');
-  return scripts;
-};
-
-Plugin.addAdminScripts = async function (scripts) {
-  scripts.push('/plugins/nodebb-plugin-facebook-post/lib/admin.js');
-  return scripts;
-};
 
 // Save custom composer data into post fields
 Plugin.onPostCreate = async function (hookData) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-facebook-post",
-  "version": "1.0.9",
+  "version": "1.0.11",
   "description": "Auto-post new NodeBB topics to a fixed Facebook Page (text + NodeBB uploads + place id).",
   "main": "library.js",
   "dependencies": {

package/plugin.json

@@ -3,7 +3,6 @@
   "name": "Facebook Post",
   "description": "Publie automatiquement les nouveaux topics NodeBB sur une Page Facebook fixe (images uploads + place).",
   "url": "https://example.invalid/nodebb-plugin-facebook-post",
-  "library": "./library.js",
   "hooks": [
     {
       "hook": "static:app.load",
@@ -13,14 +12,6 @@
       "hook": "filter:admin.header.build",
       "method": "addAdminNavigation"
     },
-    {
-      "hook": "filter:scripts.get",
-      "method": "addClientScripts"
-    },
-    {
-      "hook": "filter:admin.scripts.get",
-      "method": "addAdminScripts"
-    },
     {
       "hook": "filter:post.create",
       "method": "onPostCreate"
@@ -31,7 +22,14 @@
     }
   ],
   "staticDirs": {
-    "static": "static"
+    "lib": "static/lib",
+    "templates": "static/templates"
   },
-  "templates": "static/templates"
+  "templates": "static/templates",
+  "scripts": [
+    "static/lib/composer.js"
+  ],
+  "acpScripts": [
+    "static/lib/admin.js"
+  ]
 }

package/static/lib/admin.js

@@ -5,14 +5,15 @@
   function toCsv(arr) {
     return (arr || []).map(String).map(s => s.trim()).filter(Boolean).join(',');
   }
+  function fromCsv(s) {
+    return (s || '').split(',').map(v => v.trim()).filter(Boolean);
+  }
 
   function init() {
     const $form = $('.facebook-post-settings');
     if (!$form.length) return;
 
     require(['settings', 'alerts'], function (Settings, alerts) {
-      Settings.load('facebook-post', $form);
-
       const $select = $('#allowedGroupsSelect');
       const $hidden = $('#allowedGroups');
 
@@ -20,15 +21,21 @@
         $hidden.val(toCsv($select.val() || []));
       }
 
-      // initial sync (after Settings.load fills hidden input)
-      const existing = ($hidden.val() || '').split(',').map(s => s.trim()).filter(Boolean);
-      if (existing.length) {
-        $select.val(existing);
-      }
-      syncHidden();
+      // Prevent full page refresh if user hits Enter
+      $form.off('submit.fbpost').on('submit.fbpost', function (e) { e.preventDefault(); return false; });
+
+      // IMPORTANT: wait for Settings.load to finish before reading hidden input
+      Settings.load('facebook-post', $form, function () {
+        const existing = fromCsv($hidden.val());
+        if (existing.length) {
+          $select.val(existing);
+        } else {
+          $select.val([]);
+        }
+        syncHidden();
+      });
 
       $select.off('change.fbpost').on('change.fbpost', syncHidden);
-      $form.off('submit.fbpost').on('submit.fbpost', function (e) { e.preventDefault(); return false; });
 
       $('#save').off('click.fbpost').on('click.fbpost', function (e) {
         e.preventDefault();