nodebb-plugin-facebook-post 1.0.4 → 1.0.5

package/README.md

@@ -1,32 +1,55 @@
-# nodebb-plugin-facebook-post (worker) + Instagram
+# nodebb-plugin-facebook-post
 
-Cette version publie :
-- **Facebook Page** : toujours (si checkbox cochée dans le composer)
-- **Instagram** : option ACP “Publier aussi sur Instagram” ET seulement si une image est présente.
+Plugin NodeBB 4.x : publie automatiquement les **nouveaux topics** sur une **Page Facebook fixe** (association),
+avec images (uploads du forum) et tag de lieu (Facebook Place ID).
 
-## Instagram: carrousel (jusqu’à 10 médias)
-Si le message contient plusieurs images, le worker publie un **carrousel Instagram** :
-1. crée un container enfant par image (`is_carousel_item=true`)
-2. crée un container parent (`media_type=CAROUSEL`, `children=<ids>`)
-3. publie via `/{ig-user-id}/media_publish`
-Le worker attend que les containers passent à `FINISHED` via `status_code`. citeturn0search1turn0search0
+## Fonctionnement
 
-## Variables d’environnement
+- L’utilisateur (si autorisé) voit dans le composer :
+  - une checkbox : “Publier ce nouveau topic sur Facebook”
+  - un champ optionnel : “Lieu (Facebook Place ID)”
+- Le plugin ne publie **que le 1er post d’un topic** (pas les réponses).
+- Les images sont extraites du contenu (Markdown/HTML) et **filtrées sur le domaine du forum** (uploads NodeBB).
+- Publication Facebook :
+  - upload des photos en `published=false`
+  - création du post `/feed` avec `attached_media[]`
+  - ajout du paramètre `place` si un Place ID est fourni
 
-### Communes (NodeBB + worker)
-- `NODEBB_FB_PAGE_ID`
-- `NODEBB_FB_PAGE_ACCESS_TOKEN`
-- `NODEBB_FB_GRAPH_VERSION` (optionnel, défaut `v25.0`)
-- `NODEBB_FB_QUEUE_REDIS_URL`
-- `NODEBB_FB_WORKER_SECRET`
+## Variables d’environnement (OBLIGATOIRES)
 
-### Instagram
-- `NODEBB_IG_USER_ID` (obligatoire si Instagram activé)
+- `NODEBB_FB_PAGE_ID` : l’ID de la Page Facebook (celle de l’association)
+- `NODEBB_FB_PAGE_ACCESS_TOKEN` : token d’accès de la Page
+- `NODEBB_FB_GRAPH_VERSION` : optionnel (défaut `v25.0`)
+- `NODEBB_FB_ALLOWED_GROUPS` : liste de groupes NodeBB autorisés (séparés par virgules)
+  - ex: `Staff,Communication`
 
-### Tuning (optionnel)
-- `NODEBB_IG_POLL_INTERVAL_MS` (défaut 2000)
-- `NODEBB_IG_POLL_MAX_MS` (défaut 120000)
+Exemple :
 
-## Note sur la géolocalisation
-Le plugin réutilise ton `placeId` comme `place` (Facebook) et `location_id` (Instagram) lors de la création du container. citeturn0search0turn0search1
+```bash
+export NODEBB_FB_PAGE_ID="1234567890"
+export NODEBB_FB_PAGE_ACCESS_TOKEN="EAAB..."
+export NODEBB_FB_GRAPH_VERSION="v25.0"
+export NODEBB_FB_ALLOWED_GROUPS="Staff,Communication"
+```
+
+> ⚠️ Après modification des variables d’environnement, redémarre NodeBB.
+
+## Installation
+
+1. Copier le dossier du plugin dans `node_modules/nodebb-plugin-facebook-post`
+   (ou publier via git/npm, au choix).
+2. Rebuild & restart :
+
+```bash
+./nodebb build
+./nodebb restart
+```
+
+3. ACP → Plugins → activer “Facebook Post”.
+4. ACP → Plugins → Facebook Post : activer + régler options.
+
+## Notes
+
+- Le plugin enregistre `fbPostedId` et `fbPostedAt` dans le post pour éviter les doubles publications.
+- Si une image n’est pas accessible publiquement (permissions/catégorie privée), Facebook ne pourra pas la récupérer via `url=`.
 

package/library.js

@@ -1,62 +1,42 @@
 'use strict';
 
-const Redis = require('ioredis');
-const { v4: uuidv4 } = require('uuid');
+const axios = require('axios');
 
 let meta = {};
 let settings = {};
 let appRef;
 
 const SETTINGS_KEY = 'facebook-post';
-const QUEUE_KEY = 'fbpost:queue';
 
+// Non-sensitive settings kept in ACP DB
 const DEFAULT_SETTINGS = {
   enabled: false,
 
+  // Behaviour
   includeExcerpt: true,
   excerptMaxLen: 220,
 
-  categoriesWhitelist: '',
+  // Filters
+  categoriesWhitelist: '', // comma-separated cids, empty = all
   minimumReputation: 0,
 
+  // Image handling
   maxImages: 4,
 
+  // Location
   enablePlaceTagging: true,
-
-  allowedGroups: '',
-
-  // Also publish to Instagram (worker only does it if at least 1 image)
-  publishInstagram: false,
 };
 
-
-function getAuthMiddleware(mw) {
-  // NodeBB versions/plugins may expose different auth middleware names.
-  // Ensure we always pass a real callback to express.
-  const candidates = [
-    mw && mw.authenticate,
-    mw && mw.ensureLoggedIn,
-    mw && mw.requireUser,
-    mw && mw.checkAuth,
-  ].filter(fn => typeof fn === 'function');
-
-  return candidates[0] || function (req, res, next) { next(); };
+function bool(v) {
+  return v === true || v === 'true' || v === 1 || v === '1' || v === 'on';
 }
-
-function getCoreMiddleware(params) {
-  if (params && middleware) return middleware;
-  try {
-    return require.main.require('./src/middleware');
-  } catch {
-    return {};
-  }
+function int(v, def) {
+  const n = parseInt(v, 10);
+  return Number.isFinite(n) ? n : def;
+}
+function trimStr(v) {
+  return (v || '').toString().trim();
 }
-
-let redisClient = null;
-
-function bool(v) { return v === true || v === 'true' || v === 1 || v === '1' || v === 'on'; }
-function int(v, def) { const n = parseInt(v, 10); return Number.isFinite(n) ? n : def; }
-function trimStr(v) { return (v || '').toString().trim(); }
 function parseCsvInts(csv) {
   const s = trimStr(csv);
   if (!s) return [];
@@ -65,15 +45,15 @@ function parseCsvInts(csv) {
 
 function readEnv() {
   const env = process.env || {};
+  // Fixed Facebook page target (association page)
   return {
     fbGraphVersion: trimStr(env.NODEBB_FB_GRAPH_VERSION) || 'v25.0',
     fbPageId: trimStr(env.NODEBB_FB_PAGE_ID),
     fbPageAccessToken: trimStr(env.NODEBB_FB_PAGE_ACCESS_TOKEN),
 
-    igUserId: trimStr(env.NODEBB_IG_USER_ID) || '',
-
-    redisUrl: trimStr(env.NODEBB_FB_QUEUE_REDIS_URL) || 'redis://127.0.0.1:6379',
-    workerSecret: trimStr(env.NODEBB_FB_WORKER_SECRET) || '',
+    // Restrict availability to NodeBB groups (comma-separated)
+    // If empty => nobody can use Facebook posting
+    allowedGroups: trimStr(env.NODEBB_FB_ALLOWED_GROUPS || ''),
   };
 }
 
@@ -82,6 +62,7 @@ async function loadSettings() {
   settings = Object.assign({}, DEFAULT_SETTINGS, raw || {});
 
   settings.enabled = bool(settings.enabled);
+
   settings.includeExcerpt = bool(settings.includeExcerpt);
   settings.excerptMaxLen = int(settings.excerptMaxLen, DEFAULT_SETTINGS.excerptMaxLen);
 
@@ -90,18 +71,13 @@ async function loadSettings() {
   settings.enablePlaceTagging = bool(settings.enablePlaceTagging);
 
   settings.categoriesWhitelist = trimStr(settings.categoriesWhitelist);
-  settings.allowedGroups = trimStr(settings.allowedGroups);
-
-  settings.publishInstagram = bool(settings.publishInstagram);
 
+  // ENV overrides / secrets
   const env = readEnv();
   settings.fbGraphVersion = env.fbGraphVersion;
   settings.fbPageId = env.fbPageId;
   settings.fbPageAccessToken = env.fbPageAccessToken;
-  settings.igUserId = env.igUserId;
-
-  settings.redisUrl = env.redisUrl;
-  settings.workerSecret = env.workerSecret;
+  settings.allowedGroups = env.allowedGroups;
 }
 
 function getForumBaseUrl() {
@@ -120,28 +96,40 @@ function absolutizeUrl(url) {
 function isForumHosted(urlAbs) {
   const base = getForumBaseUrl();
   if (!base) return false;
-  try { return new URL(urlAbs).host === new URL(base).host; } catch { return false; }
+  try {
+    return new URL(urlAbs).host === new URL(base).host;
+  } catch {
+    return false;
+  }
 }
 
 function extractImageUrlsFromContent(rawContent) {
   const urls = new Set();
   if (!rawContent) return [];
 
+  // Markdown images
   const mdImg = /!\[[^\]]*]\(([^)\s]+)(?:\s+"[^"]*")?\)/g;
   let m;
   while ((m = mdImg.exec(rawContent)) !== null) urls.add(m[1]);
 
+  // HTML images
   const htmlImg = /<img[^>]+src=["']([^"']+)["'][^>]*>/gi;
   while ((m = htmlImg.exec(rawContent)) !== null) urls.add(m[1]);
 
+  // Fallback: bare image URLs
   const bare = /(https?:\/\/[^\s<>"']+\.(?:png|jpe?g|gif|webp))(?:\?[^\s<>"']*)?/gi;
   while ((m = bare.exec(rawContent)) !== null) urls.add(m[1]);
 
-  return Array.from(urls).map(u => trimStr(u)).filter(Boolean).map(absolutizeUrl);
+  return Array.from(urls)
+    .map(u => trimStr(u))
+    .filter(Boolean)
+    .map(absolutizeUrl);
 }
 
 function sanitizeExcerpt(text, maxLen) {
-  const s = trimStr(text).replace(/\s+/g, ' ').replace(/<[^>]*>/g, '');
+  const s = trimStr(text)
+    .replace(/\s+/g, ' ')
+    .replace(/<[^>]*>/g, '');
   if (!s) return '';
   if (s.length <= maxLen) return s;
   return s.slice(0, Math.max(0, maxLen - 1)).trimEnd() + '…';
@@ -152,17 +140,23 @@ function parseAllowedGroupsList() {
   if (!s) return [];
   return s.split(',').map(x => x.trim()).filter(Boolean);
 }
+
 async function userIsAllowed(uid) {
   const allowed = parseAllowedGroupsList();
   if (!allowed.length) return false;
 
   const Groups = require.main.require('./src/groups');
   for (const groupName of allowed) {
+    // Group names are case-sensitive in NodeBB
+    // If any match => allowed
+    // groups.isMember(uid, groupName) returns boolean
     try {
       // eslint-disable-next-line no-await-in-loop
       const ok = await Groups.isMember(uid, groupName);
       if (ok) return true;
-    } catch {}
+    } catch {
+      // ignore
+    }
   }
   return false;
 }
@@ -188,18 +182,26 @@ async function getPostContext(postData) {
   return { post, topic, user, topicUrlAbs };
 }
 
-function shouldEnqueue(ctx) {
+function shouldProcessPost(ctx) {
   if (!ctx || !ctx.post || !ctx.topic || !ctx.user) return false;
+
+  // Plugin enabled
   if (!settings.enabled) return false;
+
+  // Secrets set
   if (!settings.fbPageId || !settings.fbPageAccessToken) return false;
 
+  // Only first post of topic
   const isFirstPost = (ctx.post.isMainPost === true) || (ctx.post.index === 0);
   if (!isFirstPost) return false;
 
+  // User opted-in on composer checkbox
   if (!bool(ctx.post.fbPostEnabled)) return false;
 
+  // reputation filter
   if ((ctx.user.reputation || 0) < settings.minimumReputation) return false;
 
+  // category whitelist
   const whitelist = parseCsvInts(settings.categoriesWhitelist);
   if (whitelist.length > 0) {
     const cid = parseInt(ctx.topic.cid, 10);
@@ -209,22 +211,46 @@ function shouldEnqueue(ctx) {
   return true;
 }
 
-async function getRedis() {
-  if (redisClient) return redisClient;
-  const winston = require.main.require('winston');
-  redisClient = new Redis(settings.redisUrl, {
-    maxRetriesPerRequest: 2,
-    enableReadyCheck: true,
-    lazyConnect: true,
+async function uploadPhotoToFacebook(urlAbs) {
+  const endpoint = `https://graph.facebook.com/${settings.fbGraphVersion}/${settings.fbPageId}/photos`;
+
+  const resp = await axios.post(endpoint, null, {
+    params: {
+      url: urlAbs,
+      published: false,
+      access_token: settings.fbPageAccessToken,
+    },
+    timeout: 20000,
   });
-  redisClient.on('error', (err) => {
-    winston.error(`[facebook-post] Redis error: ${err && err.message ? err.message : err}`);
+
+  return resp.data && resp.data.id;
+}
+
+async function publishFeedPost({ message, link, photoIds, placeId }) {
+  const endpoint = `https://graph.facebook.com/${settings.fbGraphVersion}/${settings.fbPageId}/feed`;
+
+  const form = new URLSearchParams();
+  form.append('message', String(message || ''));
+  form.append('access_token', String(settings.fbPageAccessToken));
+
+  if (link) form.append('link', String(link));
+  if (placeId) form.append('place', String(placeId));
+
+  if (Array.isArray(photoIds) && photoIds.length) {
+    photoIds.forEach((id, idx) => {
+      form.append(`attached_media[${idx}]`, JSON.stringify({ media_fbid: id }));
+    });
+  }
+
+  const resp = await axios.post(endpoint, form, {
+    headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
+    timeout: 20000,
   });
-  await redisClient.connect();
-  return redisClient;
+
+  return resp.data && resp.data.id;
 }
 
-function buildJob(ctx) {
+async function postToFacebook(ctx) {
   const rawContent = ctx.post.content || '';
   const topicTitle = ctx.topic.title || 'Nouveau sujet';
   const author = ctx.user.username || 'Quelqu’un';
@@ -232,12 +258,14 @@ function buildJob(ctx) {
 
   const excerpt = settings.includeExcerpt ? sanitizeExcerpt(rawContent, settings.excerptMaxLen) : '';
 
+  // Images: user said uploads NodeBB => enforce forum-hosted only
   let imageUrls = extractImageUrlsFromContent(rawContent)
     .map(absolutizeUrl)
     .filter(isForumHosted);
 
   imageUrls = imageUrls.slice(0, Math.max(0, settings.maxImages));
 
+  // Place tagging
   let placeId = null;
   if (settings.enablePlaceTagging) {
     const pid = trimStr(ctx.post.fbPlaceId);
@@ -251,53 +279,18 @@ function buildJob(ctx) {
   lines.push(`\n— ${author}`);
   const message = lines.join('\n');
 
-  return {
-    id: uuidv4(),
-    createdAt: Date.now(),
-    attempts: 0,
-
-    pid: ctx.post.pid,
-    tid: ctx.post.tid,
-    uid: ctx.post.uid,
-
-    message,
-    link,
-    imageUrls,
-    placeId,
-
-    publishInstagram: !!settings.publishInstagram,
-
-    nodebbBaseUrl: getForumBaseUrl(),
-  };
-}
-
-async function enqueueJob(job) {
-  const redis = await getRedis();
-  await redis.lpush(QUEUE_KEY, JSON.stringify(job));
-}
-
-async function ensureAdmin(req) {
-  const User = require.main.require('./src/user');
-  const uid = req.uid || (req.user && (req.user.uid || req.user.uid === 0 ? req.user.uid : null)) || (req.session && req.session.uid);
-  if (uid === undefined || uid === null) return false;
+  if (!imageUrls.length) {
+    return await publishFeedPost({ message, link, photoIds: [], placeId });
+  }
 
-  try { if (await User.isAdministrator(uid)) return true; } catch {}
-  try { if (await User.isAdminOrGlobalMod(uid)) return true; } catch {}
-  if (req.user && req.user.isAdmin) return true;
-  return false;
-}
+  const photoIds = [];
+  for (const urlAbs of imageUrls) {
+    // eslint-disable-next-line no-await-in-loop
+    const id = await uploadPhotoToFacebook(urlAbs);
+    if (id) photoIds.push(id);
+  }
 
-async function listAllGroups() {
-  const Groups = require.main.require('./src/groups');
-  try {
-    const groups = await Groups.getGroupsFromSet('groups:createtime', 0, -1);
-    if (Array.isArray(groups)) return groups;
-  } catch {}
-  try {
-    const groups2 = await Groups.getGroups('groups:createtime', 0, 9999);
-    if (Array.isArray(groups2)) return groups2;
-  } catch {}
-  return [];
+  return await publishFeedPost({ message, link, photoIds, placeId });
 }
 
 const Plugin = {};
@@ -308,42 +301,36 @@ Plugin.init = async function (params) {
 
   meta = (params && params.meta) ? params.meta : require.main.require('./src/meta');
 
-  await loadSettings();
+  // Used to render group list in ACP
+  const groups = require.main.require('./src/groups');
+  const db = require.main.require('./src/database');
 
-  const routeHelpers = require.main.require('./src/routes/helpers');
+  await loadSettings();
 
-  // ACP page (clean signature: router, route, middlewares, controller)
-  routeHelpers.setupAdminPageRoute(router, '/admin/plugins/facebook-post', [], (req, res) => {
-    res.render('admin/facebook-post', {});
-  });
+  async function getAllGroups() {
+    let names = await db.getSortedSetRange('groups:createtime', 0, -1);
+    if (!names?.length) {
+      names = await db.getSortedSetRange('groups:visible:createtime', 0, -1);
+    }
 
-  // Admin API: list groups (used by ACP UI)
-  routeHelpers.setupApiRoute(router, 'get', '/api/admin/plugins/facebook-post/groups', [
-    middleware.ensureLoggedIn,
-  ], async (req, res) => {
-    try {
-      await loadSettings();
+    const data = await groups.getGroupsData(
+      (names || []).filter(name => !groups.isPrivilegeGroup(name))
+    );
 
-      const ok = await ensureAdmin(req);
-      if (!ok) return res.status(403).json({ error: 'forbidden' });
+    return (data || [])
+      .filter(g => g?.name && g.name.toLowerCase() !== 'guests')
+      .sort((a, b) => String(a.name).localeCompare(String(b.name), undefined, { sensitivity: 'base' }));
+  }
 
-      const groups = await listAllGroups();
-      const names = (groups || [])
-        .map(g => g && (g.name || g.displayName || g.slug))
-        .filter(Boolean)
-        .filter(n => n.toLowerCase() !== 'guests');
+  async function render(req, res) {
+    const allGroups = await getAllGroups();
+    res.render('admin/facebook-post', { allGroups });
+  }
 
-      const uniq = Array.from(new Set(names)).sort((a, b) => a.localeCompare(b));
-      return res.json({ groups: uniq });
-    } catch {
-      return res.status(500).json({ error: 'failed' });
-    }
-  });
+  router.get('/admin/plugins/facebook-post', middleware.admin.buildHeader, render);
+  router.get('/api/admin/plugins/facebook-post', render);
 
-  // User API: check if current user can see the composer checkbox
-  routeHelpers.setupApiRoute(router, 'get', '/api/facebook-post/can-post', [
-    middleware.ensureLoggedIn,
-  ], async (req, res) => {
+  router.get('/api/facebook-post/can-post', middleware.ensureLoggedIn, async (req, res) => {
     try {
       await loadSettings();
       if (!settings.enabled) return res.json({ allowed: false, reason: 'disabled' });
@@ -355,10 +342,7 @@ Plugin.init = async function (params) {
     }
   });
 
-  // Admin API: worker can mark posts as posted (optional)
-  routeHelpers.setupApiRoute(router, 'post', '/api/admin/plugins/facebook-post/mark-posted', [
-    middleware.ensureLoggedIn,
-  ], async (req, res) => {
+  router.post('/api/admin/plugins/facebook-post/mark-posted', middleware.ensureLoggedIn, async (req, res) => {
     try {
       await loadSettings();
 
@@ -385,29 +369,15 @@ Plugin.init = async function (params) {
       return res.status(500).json({ error: 'failed' });
     }
   });
-
-  router.on && router.on('nodebb:settings:reload', async (payload) => {
-    if (payload && payload.plugin === SETTINGS_KEY) {
-      await loadSettings();
-    }
-  });
-
-  // Also support the legacy app event emitter (older NodeBB versions)
-  try {
-    const app = params.app;
-    if (app && typeof app.on === 'function') {
-      app.on('nodebb:settings:reload', async (payload) => {
-        if (payload && payload.plugin === SETTINGS_KEY) {
-          await loadSettings();
-        }
-      });
-    }
-  } catch {}
 };
 
-Plugin.addAdminNavigation = async function (header) {
+Plugin.addAdminNavigation = async function (header) { = async function (header) {
   header.plugins = header.plugins || [];
-  header.plugins.push({ route: '/plugins/facebook-post', icon: 'fa-facebook', name: 'Facebook/Instagram Post' });
+  header.plugins.push({
+    route: '/plugins/facebook-post',
+    icon: 'fa-facebook',
+    name: 'Facebook Post',
+  });
   return header;
 };
 
@@ -421,13 +391,18 @@ Plugin.addAdminScripts = async function (scripts) {
   return scripts;
 };
 
+// Save custom composer data into post fields
 Plugin.onPostCreate = async function (hookData) {
   try {
     if (!hookData?.post || !hookData?.data) return hookData;
+
     hookData.post.fbPostEnabled = bool(hookData.data.fbPostEnabled);
+
     const fbPlaceId = trimStr(hookData.data.fbPlaceId);
     if (fbPlaceId) hookData.post.fbPlaceId = fbPlaceId;
-  } catch {}
+  } catch (e) {
+    // swallow
+  }
   return hookData;
 };
 
@@ -440,24 +415,26 @@ Plugin.onPostSave = async function (hookData) {
     const ctx = await getPostContext(hookData && hookData.post ? hookData.post : hookData);
     if (!ctx) return;
 
+    // Allowed group check (server-side enforcement)
     const allowed = await userIsAllowed(ctx.post.uid);
     if (!allowed) return;
 
-    if (!shouldEnqueue(ctx)) return;
+    if (!shouldProcessPost(ctx)) return;
 
     const Posts = require.main.require('./src/posts');
-    const alreadyPosted = await Posts.getPostField(ctx.post.pid, 'fbPostedId');
-    const alreadyQueued = await Posts.getPostField(ctx.post.pid, 'fbQueueJobId');
-    if (alreadyPosted || alreadyQueued) return;
 
-    const job = buildJob(ctx);
-    await enqueueJob(job);
+    // Avoid double-post
+    const already = await Posts.getPostField(ctx.post.pid, 'fbPostedId');
+    if (already) return;
 
-    await Posts.setPostField(ctx.post.pid, 'fbQueueJobId', job.id);
-    await Posts.setPostField(ctx.post.pid, 'fbQueuedAt', Date.now());
+    const fbId = await postToFacebook(ctx);
+    if (fbId) {
+      await Posts.setPostField(ctx.post.pid, 'fbPostedId', fbId);
+      await Posts.setPostField(ctx.post.pid, 'fbPostedAt', Date.now());
+    }
   } catch (e) {
     const detail = e && (e.response && JSON.stringify(e.response.data) || e.message || e);
-    winston.error(`[facebook-post] Enqueue failed: ${detail}`);
+    winston.error(`[facebook-post] Failed: ${detail}`);
   }
 };
 

package/package.json

@@ -1,12 +1,10 @@
 {
   "name": "nodebb-plugin-facebook-post",
-  "version": "1.0.4",
-  "description": "Queue-based worker to auto-post new NodeBB topics to a fixed Facebook Page and optionally Instagram (images only).",
+  "version": "1.0.5",
+  "description": "Auto-post new NodeBB topics to a fixed Facebook Page (text + NodeBB uploads + place id).",
   "main": "library.js",
   "dependencies": {
-    "axios": "^1.6.0",
-    "ioredis": "^5.4.1",
-    "uuid": "^9.0.1"
+    "axios": "^1.6.0"
   },
   "engines": {
     "node": ">=18"

package/plugin.json

@@ -1,8 +1,9 @@
 {
   "id": "nodebb-plugin-facebook-post",
-  "name": "Facebook/Instagram Post (Worker)",
-  "description": "Enqueue new NodeBB topics to a worker that posts to a fixed Facebook Page (+ optional Instagram).",
+  "name": "Facebook Post",
+  "description": "Publie automatiquement les nouveaux topics NodeBB sur une Page Facebook fixe (images uploads + place).",
   "url": "https://example.invalid/nodebb-plugin-facebook-post",
+  "library": "./library.js",
   "hooks": [
     {
       "hook": "static:app.load",

package/static/lib/admin.js

@@ -1,74 +1,27 @@
-/* global $, app, socket */
+/* globals ajaxify */
 'use strict';
 
-function parseCsv(s) { return (s || '').split(',').map(x => x.trim()).filter(Boolean); }
-function toCsv(arr) { return (arr || []).map(x => String(x).trim()).filter(Boolean).join(','); }
-
-async function fetchGroupsList() {
-  const res = await fetch('/api/admin/plugins/facebook-post/groups', { credentials: 'same-origin' });
-  if (!res.ok) throw new Error('groups api not ok');
-  const data = await res.json();
-  return (data && data.groups) ? data.groups : [];
-}
-
-$(document).ready(function () {
-  socket.emit('admin.settings.get', { hash: 'facebook-post' }, async function (err, data) {
-    if (err) return app.alertError(err.message || err);
-
-    data = data || {};
-    const savedAllowed = parseCsv(data.allowedGroups);
-
-    for (const [k, v] of Object.entries(data)) {
-      if (k === 'allowedGroups') continue;
-      const $el = $('[name="' + k + '"]');
-      if (!$el.length) continue;
-
-      if ($el.attr('type') === 'checkbox') {
-        $el.prop('checked', v === true || v === 'true' || v === 1 || v === '1' || v === 'on');
-      } else {
-        $el.val(v);
-      }
-    }
-
-    const $select = $('#allowedGroupsSelect');
-    const $hidden = $('input[type="hidden"][name="allowedGroups"]');
-
-    function syncHidden() {
-      const selected = $select.val() || [];
-      $hidden.val(toCsv(selected));
-    }
-
-    try {
-      const groups = await fetchGroupsList();
-      $select.empty();
-      groups.forEach(name => {
-        const opt = document.createElement('option');
-        opt.value = name;
-        opt.textContent = name;
-        if (savedAllowed.includes(name)) opt.selected = true;
-        $select.append(opt);
+(function () {
+  function init() {
+    const $form = $('.facebook-post-settings');
+    if (!$form.length) return;
+
+    require(['settings', 'alerts'], function (Settings, alerts) {
+      Settings.load('facebook-post', $form);
+
+      $('#save').off('click.fbpost').on('click.fbpost', function (e) {
+        e.preventDefault();
+        Settings.save('facebook-post', $form, function () {
+          if (alerts && typeof alerts.success === 'function') {
+            alerts.success('[[admin/settings:saved]]');
+          } else if (window.app && typeof window.app.alertSuccess === 'function') {
+            window.app.alertSuccess('[[admin/settings:saved]]');
+          }
+        });
       });
-      $select.on('change', syncHidden);
-      syncHidden();
-    } catch (e) {
-      app.alertError('Impossible de charger la liste des groupes. Vérifie les droits admin et les logs serveur.');
-    }
-  });
-
-  $('#save').on('click', function () {
-    const payload = {};
-    $('.facebook-post-settings [name]').each(function () {
-      const $el = $(this);
-      const name = $el.attr('name');
-      if ($el.attr('type') === 'checkbox') payload[name] = $el.is(':checked');
-      else payload[name] = $el.val();
-    });
-
-    socket.emit('admin.settings.set', { hash: 'facebook-post', values: payload }, function (err) {
-      if (err) return app.alertError(err.message || err);
-      app.alertSuccess('Enregistré.');
-      socket.emit('admin.settings.sync', { hash: 'facebook-post' });
     });
-  });
-});
+  }
 
+  $(document).ready(init);
+  $(window).on('action:ajaxify.end', init);
+})();

package/static/lib/composer.js

@@ -19,7 +19,7 @@
       <div class="mb-2" data-fbpost-wrap>
         <div class="form-check mb-2">
           <input type="checkbox" class="form-check-input" id="fbPostEnabled" data-fbpost-enabled>
-          <label class="form-check-label" for="fbPostEnabled">Publier ce nouveau topic sur Facebook (et Insta si activé)</label>
+          <label class="form-check-label" for="fbPostEnabled">Publier ce nouveau topic sur Facebook</label>
         </div>
 
         <div class="mb-2" data-fbpost-place-wrap style="display:none;">
@@ -28,7 +28,7 @@
           </label>
           <input type="text" class="form-control" data-fbpost-place-id placeholder="ex: 123456789012345">
           <div class="form-text" style="font-size: 11px;">
-            Utilisé comme <code>place</code> sur Facebook et <code>location_id</code> sur Instagram.
+            Place ID Facebook (sert à tagger le lieu sur la Page).
           </div>
         </div>
       </div>
@@ -45,6 +45,7 @@
       $placeWrap.toggle($enabled.is(':checked'));
     });
 
+    // Inject custom data at submit time
     $(window).off('filter:composer.submit.fbpost')
       .on('filter:composer.submit.fbpost', function (ev2, submitData) {
         const enabled = $enabled.is(':checked');
@@ -68,7 +69,7 @@
       if (!perm.allowed) return;
 
       injectUI($composer);
-    } catch {
+    } catch (e) {
       // ignore
     }
   });

package/static/templates/admin/facebook-post.tpl

@@ -17,7 +17,7 @@
     </ul>
   </div>
 
-  <form role="form" class="facebook-post-settings">
+  <form class="facebook-post-settings" role="form">
     <div class="form-check mb-3">
       <input type="checkbox" class="form-check-input" id="enabled" name="enabled">
       <label class="form-check-label" for="enabled">Activer</label>
@@ -34,12 +34,15 @@
     <p class="text-muted">Groupes NodeBB autorisés à voir la case “Publier sur Facebook” dans le composer (et donc déclencher Facebook + Insta).</p>
 
     <div class="mb-3">
-      <label class="form-label" for="allowedGroupsSelect">Groupes autorisés</label>
-      <select class="form-select" id="allowedGroupsSelect" multiple size="10"></select>
+      <label class="form-label" for="allowedGroups">Groupes autorisés</label>
+      <select id="allowedGroups" name="allowedGroups" class="form-select" multiple size="12">
+        <!-- BEGIN allGroups -->
+        <option value="{allGroups.name}">{allGroups.name}</option>
+        <!-- END allGroups -->
+      </select>
+      <p class="form-text">Sans fallback : si aucun groupe n’est sélectionné, personne ne verra la case.</p>
     </div>
 
-    <input type="hidden" id="allowedGroups" name="allowedGroups" value="">
-
     <hr/>
 
     <h4>Message</h4>
@@ -87,7 +90,6 @@
       <label class="form-check-label" for="enablePlaceTagging">Activer le tag de lieu (Place ID / location_id)</label>
     </div>
 
-    <button type="button" class="btn btn-primary" id="save">Enregistrer</button>
+    <button id="save" class="btn btn-primary">Enregistrer</button>
   </form>
 </div>
-

package/worker.js

@@ -1,260 +0,0 @@
-#!/usr/bin/env node
-'use strict';
-
-const Redis = require('ioredis');
-const axios = require('axios');
-
-const QUEUE_KEY = 'fbpost:queue';
-
-function trimStr(v) { return (v || '').toString().trim(); }
-function int(v, def) { const n = parseInt(v, 10); return Number.isFinite(n) ? n : def; }
-function sleep(ms) { return new Promise(r => setTimeout(r, ms)); }
-
-const env = process.env || {};
-const redisUrl = trimStr(env.NODEBB_FB_QUEUE_REDIS_URL) || 'redis://127.0.0.1:6379';
-
-const graphVersion = trimStr(env.NODEBB_FB_GRAPH_VERSION) || 'v25.0';
-const pageId = trimStr(env.NODEBB_FB_PAGE_ID);
-const pageToken = trimStr(env.NODEBB_FB_PAGE_ACCESS_TOKEN);
-
-const igUserId = trimStr(env.NODEBB_IG_USER_ID);
-
-const workerSecret = trimStr(env.NODEBB_FB_WORKER_SECRET);
-
-const maxAttempts = int(env.NODEBB_FB_WORKER_MAX_ATTEMPTS, 5);
-const retryDelayMs = int(env.NODEBB_FB_WORKER_RETRY_DELAY_MS, 30000);
-
-// Instagram polling (containers processing)
-const igPollIntervalMs = int(env.NODEBB_IG_POLL_INTERVAL_MS, 2000);
-const igPollMaxMs = int(env.NODEBB_IG_POLL_MAX_MS, 120000); // 2 minutes
-
-if (!pageId || !pageToken) {
-  console.error('[fb-worker] Missing NODEBB_FB_PAGE_ID or NODEBB_FB_PAGE_ACCESS_TOKEN');
-  process.exit(2);
-}
-if (!workerSecret) {
-  console.error('[fb-worker] Missing NODEBB_FB_WORKER_SECRET (required to mark posts as posted)');
-  process.exit(2);
-}
-
-const redis = new Redis(redisUrl, { enableReadyCheck: true });
-
-/* ---------- Facebook ---------- */
-async function fbUploadPhoto(urlAbs) {
-  const endpoint = `https://graph.facebook.com/${graphVersion}/${pageId}/photos`;
-  const resp = await axios.post(endpoint, null, {
-    params: { url: urlAbs, published: false, access_token: pageToken },
-    timeout: 20000,
-  });
-  return resp.data && resp.data.id;
-}
-
-async function fbPublishFeed({ message, link, photoIds, placeId }) {
-  const endpoint = `https://graph.facebook.com/${graphVersion}/${pageId}/feed`;
-  const form = new URLSearchParams();
-  form.append('message', String(message || ''));
-  form.append('access_token', String(pageToken));
-  if (link) form.append('link', String(link));
-  if (placeId) form.append('place', String(placeId));
-  if (Array.isArray(photoIds) && photoIds.length) {
-    photoIds.forEach((id, idx) => {
-      form.append(`attached_media[${idx}]`, JSON.stringify({ media_fbid: id }));
-    });
-  }
-  const resp = await axios.post(endpoint, form, {
-    headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
-    timeout: 20000,
-  });
-  return resp.data && resp.data.id;
-}
-
-/* ---------- Instagram ---------- */
-/**
- * Instagram posting uses containers:
- * - Single image: POST /{ig-user-id}/media (image_url + caption) -> creation_id; then POST /media_publish
- * - Carousel: create N child containers with is_carousel_item=true, then create parent container media_type=CAROUSEL with children,
- *   then publish parent. Poll child/parent status_code until FINISHED.
- */
-async function igCreateImageContainer({ imageUrl, caption, locationId, isCarouselItem }) {
-  const endpoint = `https://graph.facebook.com/${graphVersion}/${igUserId}/media`;
-  const form = new URLSearchParams();
-  form.append('image_url', String(imageUrl));
-  if (caption) form.append('caption', String(caption));
-  form.append('access_token', String(pageToken));
-  if (locationId) form.append('location_id', String(locationId));
-  if (isCarouselItem) form.append('is_carousel_item', 'true');
-
-  const resp = await axios.post(endpoint, form, {
-    headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
-    timeout: 20000,
-  });
-  return resp.data && resp.data.id; // creation_id
-}
-
-async function igCreateCarouselContainer({ childrenIds, caption, locationId }) {
-  const endpoint = `https://graph.facebook.com/${graphVersion}/${igUserId}/media`;
-  const form = new URLSearchParams();
-  form.append('media_type', 'CAROUSEL');
-  // children is a comma-separated string of container IDs
-  form.append('children', childrenIds.join(','));
-  if (caption) form.append('caption', String(caption));
-  form.append('access_token', String(pageToken));
-  if (locationId) form.append('location_id', String(locationId));
-
-  const resp = await axios.post(endpoint, form, {
-    headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
-    timeout: 20000,
-  });
-  return resp.data && resp.data.id; // creation_id
-}
-
-async function igGetContainerStatus(containerId) {
-  const endpoint = `https://graph.facebook.com/${graphVersion}/${containerId}`;
-  const resp = await axios.get(endpoint, {
-    params: { fields: 'status_code', access_token: pageToken },
-    timeout: 20000,
-  });
-  return resp.data && resp.data.status_code;
-}
-
-async function igWaitFinished(containerId) {
-  const deadline = Date.now() + igPollMaxMs;
-  while (Date.now() < deadline) {
-    // eslint-disable-next-line no-await-in-loop
-    const status = await igGetContainerStatus(containerId);
-    if (status === 'FINISHED') return;
-    if (status === 'ERROR') throw new Error(`Instagram container ${containerId} status ERROR`);
-    // IN_PROGRESS or unknown
-    // eslint-disable-next-line no-await-in-loop
-    await sleep(igPollIntervalMs);
-  }
-  throw new Error(`Instagram container ${containerId} timeout after ${igPollMaxMs}ms`);
-}
-
-async function igPublishContainer(creationId) {
-  const endpoint = `https://graph.facebook.com/${graphVersion}/${igUserId}/media_publish`;
-  const form = new URLSearchParams();
-  form.append('creation_id', String(creationId));
-  form.append('access_token', String(pageToken));
-  const resp = await axios.post(endpoint, form, {
-    headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
-    timeout: 20000,
-  });
-  return resp.data && resp.data.id;
-}
-
-/* ---------- NodeBB callback (optional) ---------- */
-async function markPosted(job, fbPostedId) {
-  const bearer = trimStr(env.NODEBB_FB_NODEBB_BEARER_TOKEN);
-  if (!bearer) return;
-
-  const url = `${trimStr(job.nodebbBaseUrl).replace(/\/$/, '')}/api/admin/plugins/facebook-post/mark-posted`;
-  const payload = { pid: job.pid, fbPostedId, fbPostedAt: Date.now(), secret: workerSecret };
-
-  await axios.post(url, payload, {
-    headers: { Authorization: `Bearer ${bearer}` },
-    timeout: 15000,
-  });
-}
-
-async function handleJob(job) {
-  const imgs = Array.isArray(job.imageUrls) ? job.imageUrls : [];
-  const placeId = job.placeId ? String(job.placeId) : null;
-
-  // Facebook
-  let fbId;
-  if (!imgs.length) {
-    fbId = await fbPublishFeed({ message: job.message, link: job.link, photoIds: [], placeId });
-  } else {
-    const photoIds = [];
-    for (const urlAbs of imgs) {
-      // eslint-disable-next-line no-await-in-loop
-      const id = await fbUploadPhoto(urlAbs);
-      if (id) photoIds.push(id);
-    }
-    fbId = await fbPublishFeed({ message: job.message, link: job.link, photoIds, placeId });
-  }
-
-  // Instagram (only if enabled AND at least one image)
-  if (job.publishInstagram && imgs.length) {
-    if (!igUserId) {
-      console.warn('[fb-worker] publishInstagram enabled but NODEBB_IG_USER_ID missing; skipping Instagram.');
-    } else {
-      const caption = job.message;
-
-      // Instagram carousel limit: up to 10 items.
-      const igImgs = imgs.slice(0, 10);
-
-      if (igImgs.length === 1) {
-        const creationId = await igCreateImageContainer({ imageUrl: igImgs[0], caption, locationId: placeId, isCarouselItem: false });
-        await igWaitFinished(creationId);
-        const igPostId = await igPublishContainer(creationId);
-        console.log(`[fb-worker] Instagram published (single): ${igPostId}`);
-      } else {
-        const childIds = [];
-        for (const imageUrl of igImgs) {
-          // eslint-disable-next-line no-await-in-loop
-          const childId = await igCreateImageContainer({ imageUrl, caption: null, locationId: null, isCarouselItem: true });
-          // eslint-disable-next-line no-await-in-loop
-          await igWaitFinished(childId);
-          childIds.push(childId);
-        }
-
-        const parentId = await igCreateCarouselContainer({ childrenIds: childIds, caption, locationId: placeId });
-        await igWaitFinished(parentId);
-        const igPostId = await igPublishContainer(parentId);
-        console.log(`[fb-worker] Instagram published (carousel ${igImgs.length}): ${igPostId}`);
-      }
-    }
-  }
-
-  return fbId;
-}
-
-async function requeue(job) {
-  job.attempts = int(job.attempts, 0) + 1;
-  if (job.attempts >= maxAttempts) {
-    console.error(`[fb-worker] Job ${job.id} reached max attempts (${maxAttempts}). Dropping.`);
-    return;
-  }
-  console.warn(`[fb-worker] Requeue job ${job.id} in ${retryDelayMs}ms (attempt ${job.attempts}/${maxAttempts})`);
-  setTimeout(async () => {
-    try { await redis.lpush(QUEUE_KEY, JSON.stringify(job)); }
-    catch (e) { console.error('[fb-worker] Failed to requeue:', e && e.message ? e.message : e); }
-  }, retryDelayMs);
-}
-
-async function loop() {
-  console.log('[fb-worker] Started. Waiting for jobs…');
-  while (true) {
-    try {
-      const res = await redis.brpop(QUEUE_KEY, 0);
-      const payload = res && res[1];
-      if (!payload) continue;
-
-      let job;
-      try { job = JSON.parse(payload); }
-      catch { console.error('[fb-worker] Bad job payload, skipping.'); continue; }
-
-      console.log(`[fb-worker] Processing job ${job.id} pid=${job.pid} tid=${job.tid}`);
-      try {
-        const fbId = await handleJob(job);
-        console.log(`[fb-worker] Facebook posted: ${fbId}`);
-        try { await markPosted(job, fbId); } catch (e) {
-          console.warn('[fb-worker] mark-posted failed:', e && e.message ? e.message : e);
-        }
-      } catch (e) {
-        console.error('[fb-worker] Job failed:', e && (e.response && JSON.stringify(e.response.data) || e.message || e));
-        await requeue(job);
-      }
-    } catch (e) {
-      console.error('[fb-worker] Loop error:', e && e.message ? e.message : e);
-      await sleep(2000);
-    }
-  }
-}
-
-loop().catch((e) => {
-  console.error('[fb-worker] Fatal:', e && e.message ? e.message : e);
-  process.exit(1);
-});