nodebb-plugin-facebook-post 1.0.37 → 1.0.39

package/library.js

@@ -247,6 +247,26 @@ async function getInstagramUserId() {
   return igId;
 }
 
+async function waitForIgContainer(containerId, accessToken, graphVersion, { maxAttempts = 20, intervalMs = 3000 } = {}) {
+  const url = `https://graph.facebook.com/${graphVersion}/${containerId}`;
+  for (let i = 0; i < maxAttempts; i++) {
+    // eslint-disable-next-line no-await-in-loop
+    await new Promise(resolve => setTimeout(resolve, intervalMs));
+    // eslint-disable-next-line no-await-in-loop
+    const resp = await axios.get(url, {
+      params: { fields: 'status_code,status', access_token: accessToken },
+      timeout: 10000,
+    });
+    const statusCode = resp.data && resp.data.status_code;
+    if (statusCode === 'FINISHED') return;
+    if (statusCode === 'ERROR' || statusCode === 'EXPIRED') {
+      throw new Error(`Instagram container ${containerId} status: ${statusCode} (${resp.data && resp.data.status})`);
+    }
+    // IN_PROGRESS or PUBLISHED → keep waiting
+  }
+  throw new Error(`Instagram container ${containerId} did not reach FINISHED after ${maxAttempts} attempts`);
+}
+
 async function postToInstagram(ctx) {
   const rawContent = ctx.post.content || '';
   const topicTitle = decodeHtmlEntities(ctx.topic.title || 'Nouveau sujet');
@@ -269,17 +289,21 @@ async function postToInstagram(ctx) {
 
   const igUserId = await getInstagramUserId();
   const baseUrl = `https://graph.facebook.com/${settings.fbGraphVersion}/${igUserId}`;
+  const token = settings.fbPageAccessToken;
+  const graphVersion = settings.fbGraphVersion;
 
   if (imageUrls.length === 1) {
     const containerResp = await axios.post(`${baseUrl}/media`, null, {
-      params: { image_url: imageUrls[0], caption, access_token: settings.fbPageAccessToken },
+      params: { image_url: imageUrls[0], caption, access_token: token },
       timeout: 20000,
     });
     const containerId = containerResp.data && containerResp.data.id;
     if (!containerId) return null;
 
+    await waitForIgContainer(containerId, token, graphVersion);
+
     const publishResp = await axios.post(`${baseUrl}/media_publish`, null, {
-      params: { creation_id: containerId, access_token: settings.fbPageAccessToken },
+      params: { creation_id: containerId, access_token: token },
       timeout: 20000,
     });
     return publishResp.data && publishResp.data.id;
@@ -294,25 +318,30 @@ async function postToInstagram(ctx) {
         image_url: url,
         media_type: 'IMAGE',
         is_carousel_item: true,
-        access_token: settings.fbPageAccessToken,
+        access_token: token,
       },
       timeout: 20000,
     });
     const childId = childResp.data && childResp.data.id;
-    if (childId) childIds.push(childId);
+    if (childId) {
+      // eslint-disable-next-line no-await-in-loop
+      await waitForIgContainer(childId, token, graphVersion);
+      childIds.push(childId);
+    }
   }
   if (!childIds.length) return null;
 
   // Instagram requires at least 2 children for a carousel; fall back to single image
   if (childIds.length < 2) {
     const singleResp = await axios.post(`${baseUrl}/media`, null, {
-      params: { image_url: imageUrls[0], caption, access_token: settings.fbPageAccessToken },
+      params: { image_url: imageUrls[0], caption, access_token: token },
       timeout: 20000,
     });
     const singleId = singleResp.data && singleResp.data.id;
     if (!singleId) return null;
+    await waitForIgContainer(singleId, token, graphVersion);
     const pubResp = await axios.post(`${baseUrl}/media_publish`, null, {
-      params: { creation_id: singleId, access_token: settings.fbPageAccessToken },
+      params: { creation_id: singleId, access_token: token },
       timeout: 20000,
     });
     return pubResp.data && pubResp.data.id;
@@ -321,8 +350,8 @@ async function postToInstagram(ctx) {
   const form = new URLSearchParams();
   form.append('media_type', 'CAROUSEL');
   form.append('caption', caption);
-  form.append('children', childIds.join(','));
-  form.append('access_token', settings.fbPageAccessToken);
+  form.append('children', JSON.stringify(childIds));
+  form.append('access_token', token);
 
   const carouselResp = await axios.post(`${baseUrl}/media`, form, {
     headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
@@ -331,8 +360,10 @@ async function postToInstagram(ctx) {
   const carouselId = carouselResp.data && carouselResp.data.id;
   if (!carouselId) return null;
 
+  await waitForIgContainer(carouselId, token, graphVersion);
+
   const publishResp = await axios.post(`${baseUrl}/media_publish`, null, {
-    params: { creation_id: carouselId, access_token: settings.fbPageAccessToken },
+    params: { creation_id: carouselId, access_token: token },
     timeout: 20000,
   });
   return publishResp.data && publishResp.data.id;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-facebook-post",
-  "version": "1.0.37",
+  "version": "1.0.39",
   "description": "Auto-post new NodeBB topics to a fixed Facebook Page (text + NodeBB uploads + place id).",
   "main": "library.js",
   "dependencies": {