nodebb-plugin-facebook-post 1.0.14 → 1.0.16

package/library.js

@@ -98,7 +98,7 @@ function isForumHosted(urlAbs) {
   if (!base) return false;
   try {
     return new URL(urlAbs).host === new URL(base).host;
-  } catch {
+  } catch (err) {
     return false;
   }
 }
@@ -159,6 +159,11 @@ function parseAllowedGroupsList() {
   return s.split(',').map(v => v.trim()).filter(Boolean);
 }
 
+
+function getUidFromReq(req) {
+  return req && (req.uid || (req.user && req.user.uid) || (req.session && req.session.uid));
+}
+
 async function userIsAllowed(uid) {
   const allowed = parseAllowedGroupsList();
   if (!allowed.length) return false;
@@ -172,7 +177,7 @@ async function userIsAllowed(uid) {
       // eslint-disable-next-line no-await-in-loop
       const ok = await Groups.isMember(uid, groupName);
       if (ok) return true;
-    } catch {
+    } catch (err) {
       // ignore
     }
   }
@@ -355,10 +360,17 @@ Plugin.init = async function (params) {
     try {
       await loadSettings();
       if (!settings.enabled) return res.json({ allowed: false, reason: 'disabled' });
-
-      const ok = await userIsAllowed(req.uid);
-      return res.json({ allowed: ok });
-    } catch {
+      const uid = getUidFromReq(req);
+      if (!uid) return res.json({ allowed: false, reason: 'no_uid' });
+      const allowedGroups = parseAllowedGroupsList();
+      if (!allowedGroups.length) return res.json({ allowed: false, reason: 'no_groups_configured' });
+      const ok = await userIsAllowed(uid);
+      return res.json({ allowed: ok, reason: ok ? 'ok' : 'not_in_group' });
+    } catch (err) {
+      return res.json({ allowed: false, reason: 'error' });
+    }
+  });
+    } catch (err) {
       return res.json({ allowed: false });
     }
   });
@@ -386,7 +398,7 @@ Plugin.init = async function (params) {
       await Posts.deletePostField(pid, 'fbQueueJobId');
       await Posts.deletePostField(pid, 'fbQueuedAt');
       return res.json({ ok: true });
-    } catch {
+    } catch (err) {
       return res.status(500).json({ error: 'failed' });
     }
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-facebook-post",
-  "version": "1.0.14",
+  "version": "1.0.16",
   "description": "Auto-post new NodeBB topics to a fixed Facebook Page (text + NodeBB uploads + place id).",
   "main": "library.js",
   "dependencies": {

package/static/lib/composer.js

@@ -10,7 +10,7 @@
       });
       if (!res.ok) return { allowed: false };
       return await res.json();
-    } catch {
+    } catch (err) {
       return { allowed: false };
     }
   }
@@ -71,7 +71,7 @@
       if (!perm.allowed) return;
 
       injectUI($composer);
-    } catch {
+    } catch (err) {
       // ignore
     }
   });