nodebb-plugin-facebook-post 1.0.0 → 1.0.2

package/library.js

@@ -29,6 +29,29 @@ const DEFAULT_SETTINGS = {
   publishInstagram: false,
 };
 
+
+function getAuthMiddleware(mw) {
+  // NodeBB versions/plugins may expose different auth middleware names.
+  // Ensure we always pass a real callback to express.
+  const candidates = [
+    mw && mw.authenticate,
+    mw && mw.ensureLoggedIn,
+    mw && mw.requireUser,
+    mw && mw.checkAuth,
+  ].filter(fn => typeof fn === 'function');
+
+  return candidates[0] || function (req, res, next) { next(); };
+}
+
+function getCoreMiddleware(params) {
+  if (params && middleware) return middleware;
+  try {
+    return require.main.require('./src/middleware');
+  } catch {
+    return {};
+  }
+}
+
 let redisClient = null;
 
 function bool(v) { return v === true || v === 'true' || v === 1 || v === '1' || v === 'on'; }
@@ -280,19 +303,27 @@ async function listAllGroups() {
 const Plugin = {};
 
 Plugin.init = async function (params) {
-  appRef = params.app;
+  // NodeBB v4.9.x: params provides { router, middleware, meta, ... }
+  const { router, middleware } = params;
+
   meta = (params && params.meta) ? params.meta : require.main.require('./src/meta');
 
   await loadSettings();
 
   const routeHelpers = require.main.require('./src/routes/helpers');
-  routeHelpers.setupAdminPageRoute(appRef, '/admin/plugins/facebook-post', params.middleware, [], (req, res) => {
+
+  // ACP page (clean signature: router, route, middlewares, controller)
+  routeHelpers.setupAdminPageRoute(router, '/admin/plugins/facebook-post', [], (req, res) => {
     res.render('admin/facebook-post', {});
   });
 
-  appRef.get('/api/admin/plugins/facebook-post/groups', params.middleware.authenticate, async (req, res) => {
+  // Admin API: list groups (used by ACP UI)
+  routeHelpers.setupApiRoute(router, 'get', '/api/admin/plugins/facebook-post/groups', [
+    middleware.ensureLoggedIn,
+  ], async (req, res) => {
     try {
       await loadSettings();
+
       const ok = await ensureAdmin(req);
       if (!ok) return res.status(403).json({ error: 'forbidden' });
 
@@ -309,7 +340,10 @@ Plugin.init = async function (params) {
     }
   });
 
-  appRef.get('/api/facebook-post/can-post', params.middleware.authenticate, async (req, res) => {
+  // User API: check if current user can see the composer checkbox
+  routeHelpers.setupApiRoute(router, 'get', '/api/facebook-post/can-post', [
+    middleware.ensureLoggedIn,
+  ], async (req, res) => {
     try {
       await loadSettings();
       if (!settings.enabled) return res.json({ allowed: false, reason: 'disabled' });
@@ -321,13 +355,18 @@ Plugin.init = async function (params) {
     }
   });
 
-  appRef.post('/api/admin/plugins/facebook-post/mark-posted', params.middleware.authenticate, async (req, res) => {
+  // Admin API: worker can mark posts as posted (optional)
+  routeHelpers.setupApiRoute(router, 'post', '/api/admin/plugins/facebook-post/mark-posted', [
+    middleware.ensureLoggedIn,
+  ], async (req, res) => {
     try {
       await loadSettings();
+
       const secret = trimStr(req.body && req.body.secret);
       if (!secret || secret !== settings.workerSecret) {
         return res.status(403).json({ error: 'bad_secret' });
       }
+
       const ok = await ensureAdmin(req);
       if (!ok) return res.status(403).json({ error: 'forbidden' });
 
@@ -347,11 +386,23 @@ Plugin.init = async function (params) {
     }
   });
 
-  appRef.on('nodebb:settings:reload', async (payload) => {
+  router.on && router.on('nodebb:settings:reload', async (payload) => {
     if (payload && payload.plugin === SETTINGS_KEY) {
       await loadSettings();
     }
   });
+
+  // Also support the legacy app event emitter (older NodeBB versions)
+  try {
+    const app = params.app;
+    if (app && typeof app.on === 'function') {
+      app.on('nodebb:settings:reload', async (payload) => {
+        if (payload && payload.plugin === SETTINGS_KEY) {
+          await loadSettings();
+        }
+      });
+    }
+  } catch {}
 };
 
 Plugin.addAdminNavigation = async function (header) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-facebook-post",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "Queue-based worker to auto-post new NodeBB topics to a fixed Facebook Page and optionally Instagram (images only).",
   "main": "library.js",
   "dependencies": {

package/plugin.json

@@ -3,7 +3,6 @@
   "name": "Facebook/Instagram Post (Worker)",
   "description": "Enqueue new NodeBB topics to a worker that posts to a fixed Facebook Page (+ optional Instagram).",
   "url": "https://example.invalid/nodebb-plugin-facebook-post",
-  "library": "./library.js",
   "hooks": [
     {
       "hook": "static:app.load",