nodebb-plugin-ezoic-infinite 1.8.89 → 1.8.91

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.8.89",
+  "version": "1.8.91",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -81,7 +81,6 @@
     kind:         null,
     cfg:          null,
     poolsReady:   false,
-    ezEnabled:    false,
     pools:        { topics: [], posts: [], categories: [] },
     cursors:      { topics: 0,  posts: 0,  categories: 0  },
     mountedIds:   new Set(),
@@ -135,23 +134,6 @@
     S.poolsReady = true;
   }
 
-  function enableEzoic(cfg) {
-    if (S.ezEnabled) return;
-    const ids = [
-      ...parseIds(cfg.placeholderIds),
-      ...parseIds(cfg.messagePlaceholderIds),
-      ...parseIds(cfg.categoryPlaceholderIds),
-    ];
-    if (!ids.length) return;
-    S.ezEnabled = true; // set synchronously to block concurrent calls before the callback runs
-    window.ezstandalone = window.ezstandalone || {};
-    const ez = window.ezstandalone;
-    const doEnable = () => {
-      try { ez.define(...ids); ez.enable(); } catch (_) {}
-    };
-    typeof ez.cmd?.push === 'function' ? ez.cmd.push(doEnable) : doEnable();
-  }
-
   // ── Page identity ──────────────────────────────────────────────────────────
 
   function pageKey() {
@@ -642,7 +624,6 @@
     const cfg = await fetchConfig();
     if (!cfg || cfg.excluded) return 0;
     initPools(cfg);
-    enableEzoic(cfg);
 
     const kind = getKind();
     if (kind === 'other') return 0;
@@ -722,8 +703,6 @@
     S.wrapByKey.clear();
     S.wrapsByClass.clear();
     S.kind       = null;
-    // S.ezEnabled intentionally NOT reset: ez.define()+ez.enable() must be called
-    // only once per full page load, not on every SPA navigation.
     S.inflight   = 0;
     S.pending.clear();
     S.burstActive = false;
@@ -907,25 +886,56 @@
 
   // Retry boot: sa.min.js async + Cloudflare Rocket Loader + NodeBB SPA
   // can cause client.js to boot before DOM/Ezoic are ready.
-  // Retries stop once ads are mounted or after ~10s.
-  // If Ezoic defineScript failed (CMP race on first load), reload sa.min.js once.
+  //
+  // Two reload cases:
+  // 1. sa.min.js never injected (Rocket Loader stripped it) — reload immediately.
+  // 2. Cold-start crash: first visit with no Ezoic cookies causes sa.min.js to set
+  //    loadingStatus='LOADING' but never reach 'complete' (_ezaq.ab_test_id undefined
+  //    in ez-standalone.js → onStandaloneLoadEvent crash). After ~6s, remove and reload
+  //    sa.min.js; Ezoic's partial first-run state may let the second run succeed.
+  //    Once recovered, re-enqueue all mounted placeholders so showAds() fires.
   let _retries = 0;
   let _scriptReloaded = false;
+  let _postReloadShown = false;
   function retryBoot() {
-    if (_retries >= 12 || S.mountedIds.size > 0) return;
+    if (_retries >= 12) return;
     _retries++;
     patchShowAds();
 
-    // Reload sa.min.js only if Ezoic never initialized at all (no loadingStatus)
-    // AND sa.min.js is not already present in the DOM (to avoid duplicates on first load
-    // when the script is injected server-side but loadingStatus hasn't been set yet).
-    // Do NOT reload when loadingStatus === 'complete' (post-defineScript-failure):
-    // that would trigger a second defineScript failed error.
-    if (!_scriptReloaded && _retries <= 3) {
-      const ez = window.ezstandalone;
-      if (!ez?.loadingStatus && !document.querySelector('script[src*="sa.min.js"]')) {
+    const ez = window.ezstandalone;
+    const status = ez?.loadingStatus;
+
+    // After reload: once Ezoic reaches 'complete', re-call showAds for all mounted placeholders
+    if (_scriptReloaded && !_postReloadShown && status === 'complete') {
+      _postReloadShown = true;
+      for (const id of S.mountedIds) { try { enqueueShow(id); } catch (_) {} }
+      return;
+    }
+
+    // Normal exit: placeholders mounted, no reload triggered (healthy load)
+    if (S.mountedIds.size > 0 && !_scriptReloaded) return;
+    // Exit once reload is done and re-show has been triggered
+    if (_scriptReloaded && _postReloadShown) return;
+
+    if (!_scriptReloaded) {
+      // Case 1: sa.min.js never injected (Rocket Loader stripped it, etc.)
+      const neverInjected = !status && !document.querySelector('script[src*="sa.min.js"]') && _retries <= 3;
+      // Case 2: cold-start crash — loadingStatus stuck before 'complete' after enough wait.
+      // Do NOT reload when status==='complete' (post-defineScript-failure would re-trigger).
+      const anyFilled = !!document.querySelector(`.${WRAP_CLASS} ${FILL_SEL}`);
+      const crashed = _retries >= 8 && !anyFilled && status && status !== 'complete';
+      if (neverInjected || crashed) {
         _scriptReloaded = true;
         try {
+          if (crashed) {
+            // Remove the broken script before re-adding to avoid a duplicate
+            const old = document.querySelector('script[src*="sa.min.js"]');
+            if (old) old.remove();
+            // Reset ezstandalone to initial state, preserving queued cmd items
+            const savedCmd = Array.isArray(ez?.cmd) ? [...ez.cmd] : [];
+            window.ezstandalone = { cmd: savedCmd };
+            window.__nbbEzPatched = false;
+          }
           const s = document.createElement('script');
           s.setAttribute('data-cfasync', 'false');
           s.src = '//www.ezojs.com/ezoic/sa.min.js';