nodebb-plugin-ezoic-infinite 1.8.45 → 1.8.47

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.8.45",
+  "version": "1.8.47",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -1,16 +1,12 @@
 /**
- * NodeBB Ezoic Infinite Ads — client.js v3.0.1
+ * NodeBB Ezoic Infinite Ads — client.js v2.2.0
  *
- * Ezoic API usage per official docs:
- * https://docs.ezoic.com/docs/ezoicads/dynamic-content/
- *
- *   NEW PLACEHOLDERS:  ez.cmd.push(() => ez.showAds(id1, id2, ...))
- *   RECYCLE (reuse ID): ez.cmd.push(() => ez.destroyPlaceholders(id))
- *                       → remove old HTML → create fresh placeholder
- *                       → ez.cmd.push(() => ez.showAds(id))
- *
- * phState per placeholder ID:
- *   new → displayed → [destroyed → new]  (recycle loop)
+ * Based on working v2-fixed with targeted fixes:
+ * - Ezoic API: showAds() + destroyPlaceholders() only (per official docs)
+ * - cleanup(): destroyAll() before DOM removal, only on real page change
+ * - Recycling: conservative threshold (-3vh), age/inflight guards
+ * - aria-hidden: MutationObserver protection
+ * - Empty check: more conservative timing and GPT slot awareness
  */
 (function nbbEzoicInfinite() {
   'use strict';
@@ -28,20 +24,22 @@
   };
 
   const TIMING = {
-    EMPTY_CHECK_MS:    20_000,
-    MIN_PRUNE_AGE_MS:   8_000,
-    SHOW_THROTTLE_MS:     900,
-    BURST_COOLDOWN_MS:    200,
-    BLOCK_DURATION_MS:  1_500,
-    // Batch Ezoic API calls a bit more aggressively on SPA transitions.
-    // This reduces early collector calls (e.g. samo.go) during ajaxify route swaps.
-    BATCH_FLUSH_MS:       500,
-    RECYCLE_DESTROY_MS:   300,
-    RECYCLE_SHOW_MS:      300,
+    EMPTY_CHECK_EARLY_MS: 30_000,
+    EMPTY_CHECK_LATE_MS:  60_000,
+    MIN_PRUNE_AGE_MS:      8_000,
+    SHOW_THROTTLE_MS:        900,
+    BURST_COOLDOWN_MS:       200,
+    BLOCK_DURATION_MS:     1_500,
+    SHOW_TIMEOUT_MS:       7_000,
+    SHOW_RELEASE_MS:         700,
+    BATCH_FLUSH_MS:           80,
+    RECYCLE_DELAY_MS:        450,
   };
 
   const LIMITS = {
     MAX_INSERTS_RUN: 6,
+    MAX_INFLIGHT:    4,
+    BATCH_SIZE:      3,
     MAX_BURST_STEPS: 8,
     BURST_WINDOW_MS: 2_000,
   };
@@ -64,9 +62,7 @@
   };
 
   const FILL_SEL = 'iframe, ins, img, video, [data-google-container-id], div[id$="__container__"]';
-
-  // Reduce "ad popping" from aggressive ID recycling.
-  const RECYCLE_MIN_AGE_MS = 20_000;
+  const RECYCLE_MIN_AGE_MS = 5_000;
 
   // ── Utility ────────────────────────────────────────────────────────────────
 
@@ -74,17 +70,24 @@
   const isMobile = () => window.innerWidth < 768;
   const normBool = v  => v === true || v === 'true' || v === 1 || v === '1' || v === 'on';
 
-  function isFilled(node)        { return node?.querySelector?.(FILL_SEL) != null; }
+  function isFilled(node) {
+    return node?.querySelector?.(FILL_SEL) != null;
+  }
+
   function isPlaceholderUsed(ph) {
     if (!ph?.isConnected) return false;
     return ph.querySelector('ins.adsbygoogle, iframe, [data-google-container-id], div[id$="__container__"]') != null;
   }
 
   function parseIds(raw) {
-    const out = [], seen = new Set();
+    const out = [];
+    const seen = new Set();
     for (const line of String(raw || '').split(/[\r\n,\s]+/)) {
       const n = parseInt(line, 10);
-      if (n > 0 && Number.isFinite(n) && !seen.has(n)) { seen.add(n); out.push(n); }
+      if (n > 0 && Number.isFinite(n) && !seen.has(n)) {
+        seen.add(n);
+        out.push(n);
+      }
     }
     return out;
   }
@@ -92,29 +95,37 @@
   // ── State ──────────────────────────────────────────────────────────────────
 
   const state = {
-    pageKey: null, kind: null, cfg: null,
+    pageKey:    null,
+    kind:       null,
+    cfg:        null,
 
     poolsReady: false,
-    pools:   { topics: [], posts: [], categories: [] },
-    cursors: { topics: 0,  posts: 0,  categories: 0  },
+    pools:      { topics: [], posts: [], categories: [] },
+    cursors:    { topics: 0,  posts: 0,  categories: 0  },
+
+    mountedIds: new Set(),
+    phState:    new Map(),  // id → 'new' | 'show-queued' | 'shown' | 'destroyed'
+    lastShow:   new Map(),  // id → timestamp
 
-    mountedIds:   new Set(),
-    // phState: 'new' | 'displayed' | 'destroyed'
-    phState:      new Map(),
-    lastShow:     new Map(),
     wrapByKey:    new Map(),
     wrapsByClass: new Map(),
 
-    io: null, domObs: null,
-    mutGuard: 0, blockedUntil: 0,
+    io:     null,
+    domObs: null,
 
-    // Ezoic batch queue: ids waiting for define+displayMore
-    ezBatch:      new Set(),
-    ezFlushTimer: null,
+    mutGuard:     0,
+    blockedUntil: 0,
 
-    // Lifecycle
-    runQueued:    false,
-    burstActive:  false, burstDeadline: 0, burstCount: 0, lastBurstTs: 0,
+    inflight:   0,
+    pending:    [],
+    pendingSet: new Set(),
+
+    runQueued:     false,
+    burstActive:   false,
+    burstDeadline: 0,
+    burstCount:    0,
+    lastBurstTs:   0,
+    firstShown:    false,
   };
 
   const isBlocked = () => now() < state.blockedUntil;
@@ -130,7 +141,10 @@
     if (state.cfg) return state.cfg;
     try {
       const inline = window.__nbbEzoicCfg;
-      if (inline && typeof inline === 'object') { state.cfg = inline; return state.cfg; }
+      if (inline && typeof inline === 'object') {
+        state.cfg = inline;
+        return state.cfg;
+      }
     } catch (_) {}
     try {
       const r = await fetch('/api/plugins/ezoic-infinite/config', { credentials: 'same-origin' });
@@ -169,12 +183,15 @@
     return 'other';
   }
 
-  function getKind() { return state.kind || (state.kind = detectKind()); }
+  function getKind() {
+    return state.kind || (state.kind = detectKind());
+  }
 
   // ── DOM queries ────────────────────────────────────────────────────────────
 
   function getPosts() {
-    const all = document.querySelectorAll(SEL.post), out = [];
+    const all = document.querySelectorAll(SEL.post);
+    const out = [];
     for (let i = 0; i < all.length; i++) {
       const el = all[i];
       if (!el.isConnected) continue;
@@ -186,6 +203,7 @@
     }
     return out;
   }
+
   function getTopics()     { return Array.from(document.querySelectorAll(SEL.topic)); }
   function getCategories() { return Array.from(document.querySelectorAll(SEL.category)); }
 
@@ -193,10 +211,15 @@
 
   function stableId(klass, el) {
     const attr = KIND[klass]?.anchorAttr;
-    if (attr) { const v = el.getAttribute(attr); if (v != null && v !== '') return v; }
+    if (attr) {
+      const v = el.getAttribute(attr);
+      if (v != null && v !== '') return v;
+    }
     const children = el.parentElement?.children;
     if (!children) return 'i0';
-    for (let i = 0; i < children.length; i++) { if (children[i] === el) return `i${i}`; }
+    for (let i = 0; i < children.length; i++) {
+      if (children[i] === el) return `i${i}`;
+    }
     return 'i0';
   }
 
@@ -208,12 +231,49 @@
   }
 
   function getWrapSet(klass) {
-    let s = state.wrapsByClass.get(klass);
-    if (!s) { s = new Set(); state.wrapsByClass.set(klass, s); }
-    return s;
+    let set = state.wrapsByClass.get(klass);
+    if (!set) { set = new Set(); state.wrapsByClass.set(klass, set); }
+    return set;
+  }
+
+  // ── GC disconnected wraps (NodeBB virtualization) ──────────────────────────
+
+  function gcDisconnectedWraps() {
+    for (const [key, w] of Array.from(state.wrapByKey.entries())) {
+      if (!w?.isConnected) state.wrapByKey.delete(key);
+    }
+    for (const [klass, set] of Array.from(state.wrapsByClass.entries())) {
+      for (const w of Array.from(set)) {
+        if (w?.isConnected) continue;
+        set.delete(w);
+        try {
+          const id = parseInt(w.getAttribute(ATTR.WRAPID), 10);
+          if (Number.isFinite(id)) {
+            state.mountedIds.delete(id);
+            state.phState.delete(id);
+            state.lastShow.delete(id);
+          }
+        } catch (_) {}
+      }
+      if (!set.size) state.wrapsByClass.delete(klass);
+    }
+    try {
+      const live = new Set();
+      for (const w of document.querySelectorAll(`.${WRAP_CLASS}`)) {
+        const id = parseInt(w.getAttribute(ATTR.WRAPID) || '0', 10);
+        if (id > 0) live.add(id);
+      }
+      for (const id of Array.from(state.mountedIds)) {
+        if (!live.has(id)) {
+          state.mountedIds.delete(id);
+          state.phState.delete(id);
+          state.lastShow.delete(id);
+        }
+      }
+    } catch (_) {}
   }
 
-  // ── Wrap lifecycle ─────────────────────────────────────────────────────────
+  // ── Wrap lifecycle detection ───────────────────────────────────────────────
 
   function wrapIsLive(wrap) {
     if (!wrap?.classList?.contains(WRAP_CLASS)) return false;
@@ -221,17 +281,22 @@
     if (!key) return false;
     if (state.wrapByKey.get(key) === wrap) return wrap.isConnected;
     const colonIdx = key.indexOf(':');
-    const klass = key.slice(0, colonIdx), anchorId = key.slice(colonIdx + 1);
+    const klass    = key.slice(0, colonIdx);
+    const anchorId = key.slice(colonIdx + 1);
     const cfg = KIND[klass];
     if (!cfg) return false;
     const parent = wrap.parentElement;
     if (parent) {
       const sel = `${cfg.baseTag || ''}[${cfg.anchorAttr}="${anchorId}"]`;
       for (const sib of parent.children) {
-        if (sib !== wrap) { try { if (sib.matches(sel)) return sib.isConnected; } catch (_) {} }
+        if (sib !== wrap) {
+          try { if (sib.matches(sel)) return sib.isConnected; } catch (_) {}
+        }
       }
     }
-    try { return document.querySelector(`${cfg.sel}[${cfg.anchorAttr}="${anchorId}"]`)?.isConnected === true; } catch (_) { return false; }
+    try {
+      return document.querySelector(`${cfg.sel}[${cfg.anchorAttr}="${anchorId}"]`)?.isConnected === true;
+    } catch (_) { return false; }
   }
 
   function adjacentWrap(el) {
@@ -246,7 +311,7 @@
     if (!ph || !isFilled(ph)) return false;
     wrap.classList.remove('is-empty');
     const id = parseInt(wrap.getAttribute(ATTR.WRAPID) || '0', 10);
-    if (id > 0) state.phState.set(id, 'displayed');
+    if (id > 0) state.phState.set(id, 'shown');
     return true;
   }
 
@@ -257,7 +322,7 @@
     }
   }
 
-  // ── Pool ───────────────────────────────────────────────────────────────────
+  // ── Pool management ────────────────────────────────────────────────────────
 
   function pickId(poolKey) {
     const pool = state.pools[poolKey];
@@ -271,112 +336,10 @@
     return null;
   }
 
-  // ── Ezoic API layer ────────────────────────────────────────────────────────
-  //
-  // Correct Ezoic infinite scroll flow:
-  //   First batch:  ez.cmd.push(() => { ez.define(...ids); ez.enable(); })
-  //   Next batches: ez.cmd.push(() => { ez.define(...ids); ez.displayMore(...ids); })
-  //   Recycle:      ez.cmd.push(() => { ez.destroyPlaceholders(id); })
-  //                 → wait → new DOM → ez.cmd.push(() => { ez.define(id); ez.displayMore(id); })
-  //
-  // We batch define+displayMore calls using ezBatch to avoid calling the
-  // Ezoic API on every single placeholder insertion.
-
-  function ezCmd(fn) {
-    window.ezstandalone = window.ezstandalone || {};
-    const ez = window.ezstandalone;
-    if (Array.isArray(ez.cmd)) {
-      ez.cmd.push(fn);
-    } else {
-      try { fn(); } catch (_) {}
-    }
-  }
-
-  /**
-   * Queue a placeholder ID for the next batched showAds call.
-   */
-  function ezEnqueue(id) {
-    if (isBlocked()) return;
-    state.ezBatch.add(id);
-    if (!state.ezFlushTimer) {
-      state.ezFlushTimer = setTimeout(ezFlush, TIMING.BATCH_FLUSH_MS);
-    }
-  }
-
-  /**
-   * Flush: call showAds() for all queued IDs.
-   *
-   * Per Ezoic docs (https://docs.ezoic.com/docs/ezoicads/dynamic-content/):
-   *   - New placeholders: ez.showAds(id1, id2, ...)
-   *   - After destroy+recreate: ez.showAds(id) again
-   *   - No define(), no enable(), no displayMore()
-   */
-  function ezFlush() {
-    state.ezFlushTimer = null;
-    if (isBlocked() || !state.ezBatch.size) return;
-
-    // Filter to only valid, connected, unfilled placeholders
-    const ids = [];
-    for (const id of state.ezBatch) {
-      const ph = document.getElementById(`${PH_PREFIX}${id}`);
-      if (!ph?.isConnected) { state.phState.delete(id); continue; }
-      if (isPlaceholderUsed(ph)) { state.phState.set(id, 'displayed'); continue; }
-      ids.push(id);
-    }
-    state.ezBatch.clear();
-    if (!ids.length) return;
-
-    ezCmd(() => {
-      const ez = window.ezstandalone;
-      if (typeof ez?.showAds !== 'function') return;
-
-      try { ez.showAds(...ids); } catch (_) {}
-
-      // Mark as displayed and schedule fill checks
-      for (const id of ids) {
-        state.phState.set(id, 'displayed');
-        state.lastShow.set(id, now());
-        const ph = document.getElementById(`${PH_PREFIX}${id}`);
-        const wrap = ph?.closest(`.${WRAP_CLASS}`);
-        if (wrap) {
-          wrap.setAttribute(ATTR.SHOWN, String(now()));
-          scheduleUncollapseChecks(wrap);
-        }
-        scheduleEmptyCheck(id);
-      }
-    });
-  }
-
-  function scheduleEmptyCheck(id) {
-    const showTs = now();
-    // Check at 30s, then again at 60s — very conservative to avoid
-    // collapsing slow-loading ads
-    for (const delay of [30_000, 60_000]) {
-      setTimeout(() => {
-        try {
-          const ph   = document.getElementById(`${PH_PREFIX}${id}`);
-          const wrap = ph?.closest(`.${WRAP_CLASS}`);
-          if (!wrap || !ph?.isConnected) return;
-          // Don't collapse if a newer show happened
-          if (parseInt(wrap.getAttribute(ATTR.SHOWN) || '0', 10) > showTs) return;
-          // If already collapsed or uncollapsed, skip
-          if (clearEmptyIfFilled(wrap)) return;
-          // Don't collapse if there's any GPT slot, even unfilled
-          // (GPT may still be processing the ad request)
-          if (ph.querySelector('[id^="div-gpt-ad"]')) return;
-          // Don't collapse if there's any child with meaningful height
-          if (ph.offsetHeight > 10) return;
-          wrap.classList.add('is-empty');
-        } catch (_) {}
-      }, delay);
-    }
-  }
-
   // ── Recycling ──────────────────────────────────────────────────────────────
   //
-  // Per Ezoic docs: when reusing placeholder IDs in infinite scroll,
-  // call destroyPlaceholders(id) first, remove the old HTML, recreate
-  // a fresh placeholder div, then call showAds(id) again.
+  // Per Ezoic docs: destroyPlaceholders(id) → remove old HTML →
+  // recreate fresh placeholder → showAds(id).
 
   function recycleWrap(klass, targetEl, newKey) {
     const ez = window.ezstandalone;
@@ -384,8 +347,7 @@
         typeof ez?.showAds             !== 'function') return null;
 
     const vh = window.innerHeight || 800;
-    // Recycle only when the wrap is well above the viewport to avoid visible jumps.
-    const threshold = -(6 * vh);
+    const threshold = -(3 * vh);
     const t = now();
     let bestEmpty = null, bestEmptyY = Infinity;
     let bestFull  = null, bestFullY  = Infinity;
@@ -395,11 +357,13 @@
 
     for (const wrap of wraps) {
       try {
+        // Skip young wraps (ad might still be loading)
         const created = parseInt(wrap.getAttribute(ATTR.CREATED) || '0', 10);
         if (t - created < RECYCLE_MIN_AGE_MS) continue;
+        // Skip wraps with inflight showAds
         const wid = parseInt(wrap.getAttribute(ATTR.WRAPID), 10);
-        const st = state.phState.get(wid);
-        if (st === 'new') continue;  // not yet shown, don't recycle
+        if (wid > 0 && state.phState.get(wid) === 'show-queued') continue;
+
         const bottom = wrap.getBoundingClientRect().bottom;
         if (bottom > threshold) continue;
         if (!isFilled(wrap)) {
@@ -424,16 +388,13 @@
       if (ph) state.io?.unobserve(ph);
     } catch (_) {}
 
-    state.phState.set(id, 'destroyed');
-
-    // Step 1: destroyPlaceholders(id)
-    // Step 2: remove old HTML, create fresh placeholder at new position
-    // Step 3: showAds(id)
-    ezCmd(() => {
+    // Ezoic recycle: destroy → new DOM → showAds
+    const doRecycle = () => {
+      state.phState.set(id, 'destroyed');
       try { ez.destroyPlaceholders(id); } catch (_) {}
 
       setTimeout(() => {
-        // Recreate placeholder DOM
+        // Recreate fresh placeholder DOM at new position
         mutate(() => {
           best.setAttribute(ATTR.ANCHOR,  newKey);
           best.setAttribute(ATTR.CREATED, String(now()));
@@ -452,14 +413,18 @@
         if (oldKey && state.wrapByKey.get(oldKey) === best) state.wrapByKey.delete(oldKey);
         state.wrapByKey.set(newKey, best);
 
-        // showAds again after DOM is ready
+        // Re-show after DOM is settled
         setTimeout(() => {
-          state.phState.set(id, 'new');
           observePlaceholder(id);
-          ezEnqueue(id);
-        }, TIMING.RECYCLE_SHOW_MS);
-      }, TIMING.RECYCLE_DESTROY_MS);
-    });
+          state.phState.set(id, 'new');
+          enqueueShow(id);
+        }, TIMING.RECYCLE_DELAY_MS);
+      }, TIMING.RECYCLE_DELAY_MS);
+    };
+
+    try {
+      (typeof ez.cmd?.push === 'function') ? ez.cmd.push(doRecycle) : doRecycle();
+    } catch (_) {}
 
     return { id, wrap: best };
   }
@@ -474,6 +439,7 @@
     w.setAttribute(ATTR.CREATED, String(now()));
     w.setAttribute(ATTR.SHOWN,   '0');
     w.style.cssText = 'width:100%;display:block';
+
     const ph = document.createElement('div');
     ph.id = `${PH_PREFIX}${id}`;
     ph.setAttribute('data-ezoic-id', String(id));
@@ -488,6 +454,7 @@
     if (state.mountedIds.has(id)) return null;
     const existing = document.getElementById(`${PH_PREFIX}${id}`);
     if (existing?.isConnected) return null;
+
     const w = makeWrap(id, klass, key);
     mutate(() => el.insertAdjacentElement('afterend', w));
     state.mountedIds.add(id);
@@ -502,12 +469,16 @@
       const ph = w.querySelector(`[id^="${PH_PREFIX}"]`);
       if (ph instanceof Element) state.io?.unobserve(ph);
       const id = parseInt(w.getAttribute(ATTR.WRAPID), 10);
-      if (Number.isFinite(id)) { state.mountedIds.delete(id); state.phState.delete(id); }
+      if (Number.isFinite(id)) {
+        state.mountedIds.delete(id);
+        state.phState.delete(id);
+      }
       const key = w.getAttribute(ATTR.ANCHOR);
       if (key && state.wrapByKey.get(key) === w) state.wrapByKey.delete(key);
       for (const cls of w.classList) {
         if (cls !== WRAP_CLASS && cls.startsWith('ezoic-ad-')) {
-          state.wrapsByClass.get(cls)?.delete(w); break;
+          state.wrapsByClass.get(cls)?.delete(w);
+          break;
         }
       }
       w.remove();
@@ -521,18 +492,22 @@
     const cfg   = KIND[klass];
     const wraps = state.wrapsByClass.get(klass);
     if (!wraps?.size) return;
+
     const liveAnchors = new Set();
     for (const el of document.querySelectorAll(`${cfg.baseTag}[${cfg.anchorAttr}]`)) {
       const v = el.getAttribute(cfg.anchorAttr);
       if (v) liveAnchors.add(v);
     }
+
     const t = now();
     for (const w of wraps) {
       const created = parseInt(w.getAttribute(ATTR.CREATED) || '0', 10);
       if (t - created < TIMING.MIN_PRUNE_AGE_MS) continue;
       const key = w.getAttribute(ATTR.ANCHOR) ?? '';
       const sid = key.slice(klass.length + 1);
-      if (!sid || !liveAnchors.has(sid)) mutate(() => dropWrap(w));
+      if (!sid || !liveAnchors.has(sid)) {
+        mutate(() => dropWrap(w));
+      }
     }
   }
 
@@ -560,9 +535,11 @@
     for (const el of items) {
       if (inserted >= LIMITS.MAX_INSERTS_RUN) break;
       if (!el?.isConnected) continue;
+
       const ord = ordinal(klass, el);
       if (!(showFirst && ord === 0) && (ord + 1) % interval !== 0) continue;
       if (adjacentWrap(el)) continue;
+
       const key = anchorKey(klass, el);
       if (findWrap(key)) continue;
 
@@ -571,8 +548,7 @@
         const w = insertAfter(el, id, klass, key);
         if (w) {
           observePlaceholder(id);
-          // Queue for batched define+enable/displayMore
-          ezEnqueue(id);
+          if (!state.firstShown) { state.firstShown = true; enqueueShow(id); }
           inserted++;
         }
       } else {
@@ -585,12 +561,6 @@
   }
 
   // ── IntersectionObserver ───────────────────────────────────────────────────
-  //
-  // The IO is used to eagerly observe placeholders so that when they enter
-  // the viewport margin, we can queue them for Ezoic. However, the actual
-  // Ezoic API calls (define/displayMore) happen in the batched flush.
-  // The IO callback is mainly useful for re-triggering after NodeBB
-  // virtualisation re-inserts posts.
 
   function getIO() {
     if (state.io) return state.io;
@@ -598,19 +568,9 @@
       state.io = new IntersectionObserver(entries => {
         for (const entry of entries) {
           if (!entry.isIntersecting) continue;
-          const target = entry.target;
-          if (target instanceof Element) state.io?.unobserve(target);
-          const id = parseInt(target.getAttribute('data-ezoic-id'), 10);
-          if (!id || id <= 0) continue;
-          const st = state.phState.get(id);
-          // Only enqueue if not yet processed by Ezoic
-          if (st === 'new') {
-            ezEnqueue(id);
-          } else if (st === 'displayed') {
-            // Already shown — check if the placeholder is actually filled.
-            // If not (Ezoic had no ad), don't re-trigger — it won't help.
-            // If yes, nothing to do.
-          }
+          if (entry.target instanceof Element) state.io?.unobserve(entry.target);
+          const id = parseInt(entry.target.getAttribute('data-ezoic-id'), 10);
+          if (id > 0) enqueueShow(id);
         }
       }, {
         root: null,
@@ -623,16 +583,196 @@
 
   function observePlaceholder(id) {
     const ph = document.getElementById(`${PH_PREFIX}${id}`);
-    if (ph?.isConnected) { try { getIO()?.observe(ph); } catch (_) {} }
+    if (ph?.isConnected) {
+      try { getIO()?.observe(ph); } catch (_) {}
+    }
+  }
+
+  // ── Show queue ─────────────────────────────────────────────────────────────
+
+  function enqueueShow(id) {
+    if (!id || isBlocked()) return;
+    const st = state.phState.get(id);
+    if (st === 'show-queued' || st === 'shown') return;
+    if (now() - (state.lastShow.get(id) ?? 0) < TIMING.SHOW_THROTTLE_MS) return;
+
+    if (state.inflight >= LIMITS.MAX_INFLIGHT) {
+      if (!state.pendingSet.has(id)) {
+        state.pending.push(id);
+        state.pendingSet.add(id);
+        state.phState.set(id, 'show-queued');
+      }
+      return;
+    }
+    state.phState.set(id, 'show-queued');
+    startShow(id);
+  }
+
+  function drainQueue() {
+    if (isBlocked()) return;
+    while (state.inflight < LIMITS.MAX_INFLIGHT && state.pending.length) {
+      const id = state.pending.shift();
+      state.pendingSet.delete(id);
+      startShow(id);
+    }
+  }
+
+  function startShow(id) {
+    if (!id || isBlocked()) return;
+    state.inflight++;
+
+    let released = false;
+    const release = () => {
+      if (released) return;
+      released = true;
+      state.inflight = Math.max(0, state.inflight - 1);
+      drainQueue();
+    };
+    const timer = setTimeout(release, TIMING.SHOW_TIMEOUT_MS);
+
+    requestAnimationFrame(() => {
+      try {
+        if (isBlocked()) { clearTimeout(timer); return release(); }
+
+        const ph = document.getElementById(`${PH_PREFIX}${id}`);
+        if (!ph?.isConnected) {
+          state.phState.delete(id);
+          clearTimeout(timer);
+          return release();
+        }
+
+        if (isFilled(ph) || isPlaceholderUsed(ph)) {
+          state.phState.set(id, 'shown');
+          clearTimeout(timer);
+          return release();
+        }
+
+        const t = now();
+        if (t - (state.lastShow.get(id) ?? 0) < TIMING.SHOW_THROTTLE_MS) {
+          clearTimeout(timer);
+          return release();
+        }
+        state.lastShow.set(id, t);
+
+        try { ph.closest(`.${WRAP_CLASS}`)?.setAttribute(ATTR.SHOWN, String(t)); } catch (_) {}
+        state.phState.set(id, 'shown');
+
+        window.ezstandalone = window.ezstandalone || {};
+        const ez = window.ezstandalone;
+
+        const doShow = () => {
+          const wrap = ph.closest(`.${WRAP_CLASS}`);
+          try { ez.showAds(id); } catch (_) {}
+          if (wrap) scheduleUncollapseChecks(wrap);
+          scheduleEmptyCheck(id, t);
+          setTimeout(() => { clearTimeout(timer); release(); }, TIMING.SHOW_RELEASE_MS);
+        };
+
+        Array.isArray(ez.cmd) ? ez.cmd.push(doShow) : doShow();
+      } catch (_) {
+        clearTimeout(timer);
+        release();
+      }
+    });
+  }
+
+  function scheduleEmptyCheck(id, showTs) {
+    // Two-pass check: conservative to avoid collapsing slow-loading ads
+    for (const delay of [TIMING.EMPTY_CHECK_EARLY_MS, TIMING.EMPTY_CHECK_LATE_MS]) {
+      setTimeout(() => {
+        try {
+          const ph   = document.getElementById(`${PH_PREFIX}${id}`);
+          const wrap = ph?.closest(`.${WRAP_CLASS}`);
+          if (!wrap || !ph?.isConnected) return;
+          if (parseInt(wrap.getAttribute(ATTR.SHOWN) || '0', 10) > showTs) return;
+          if (clearEmptyIfFilled(wrap)) return;
+          // Don't collapse if a GPT slot exists (might still be loading)
+          if (ph.querySelector('[id^="div-gpt-ad"]')) return;
+          // Don't collapse if placeholder has meaningful height
+          if (ph.offsetHeight > 10) return;
+          wrap.classList.add('is-empty');
+        } catch (_) {}
+      }, delay);
+    }
+  }
+
+  // ── Patch Ezoic showAds ────────────────────────────────────────────────────
+  //
+  // Intercepts ez.showAds() to batch calls and filter disconnected placeholders.
+  // IMPORTANT: no-arg showAds() calls (used by Ezoic for page transitions)
+  // are passed through unmodified.
+
+  function patchShowAds() {
+    const apply = () => {
+      try {
+        window.ezstandalone = window.ezstandalone || {};
+        const ez = window.ezstandalone;
+        if (window.__nbbEzPatched || typeof ez.showAds !== 'function') return;
+        window.__nbbEzPatched = true;
+
+        const orig = ez.showAds.bind(ez);
+        const queue = new Set();
+        let flushTimer = null;
+
+        const flush = () => {
+          flushTimer = null;
+          if (isBlocked() || !queue.size) return;
+          const ids = Array.from(queue).sort((a, b) => a - b);
+          queue.clear();
+          const valid = ids.filter(id => {
+            const ph = document.getElementById(`${PH_PREFIX}${id}`);
+            if (!ph?.isConnected) { state.phState.delete(id); return false; }
+            if (isPlaceholderUsed(ph)) { state.phState.set(id, 'shown'); return false; }
+            return true;
+          });
+          for (let i = 0; i < valid.length; i += LIMITS.BATCH_SIZE) {
+            const chunk = valid.slice(i, i + LIMITS.BATCH_SIZE);
+            try { orig(...chunk); } catch (_) {
+              for (const cid of chunk) { try { orig(cid); } catch (_) {} }
+            }
+          }
+        };
+
+        ez.showAds = function (...args) {
+          // No-arg call = Ezoic page refresh — pass through unmodified
+          if (args.length === 0) {
+            return orig();
+          }
+          if (isBlocked()) return;
+          const ids = args.length === 1 && Array.isArray(args[0]) ? args[0] : args;
+          for (const v of ids) {
+            const id = parseInt(v, 10);
+            if (!Number.isFinite(id) || id <= 0) continue;
+            const ph = document.getElementById(`${PH_PREFIX}${id}`);
+            if (!ph?.isConnected) continue;
+            if (isPlaceholderUsed(ph)) { state.phState.set(id, 'shown'); continue; }
+            state.phState.set(id, 'show-queued');
+            queue.add(id);
+          }
+          if (queue.size && !flushTimer) {
+            flushTimer = setTimeout(flush, TIMING.BATCH_FLUSH_MS);
+          }
+        };
+      } catch (_) {}
+    };
+
+    apply();
+    if (!window.__nbbEzPatched) {
+      window.ezstandalone = window.ezstandalone || {};
+      (window.ezstandalone.cmd = window.ezstandalone.cmd || []).push(apply);
+    }
   }
 
   // ── Core ───────────────────────────────────────────────────────────────────
 
   async function runCore() {
     if (isBlocked()) return 0;
+    try { gcDisconnectedWraps(); } catch (_) {}
+
     const cfg = await fetchConfig();
     if (!cfg || cfg.excluded) return 0;
     initPools(cfg);
+
     const kind = getKind();
     if (kind === 'other') return 0;
 
@@ -643,16 +783,22 @@
     };
 
     if (kind === 'topic') {
-      return exec('ezoic-ad-message', getPosts,
-        cfg.enableMessageAds, cfg.messageIntervalPosts, cfg.showFirstMessageAd, 'posts');
+      return exec(
+        'ezoic-ad-message', getPosts,
+        cfg.enableMessageAds, cfg.messageIntervalPosts, cfg.showFirstMessageAd, 'posts'
+      );
     }
     if (kind === 'categoryTopics') {
       pruneOrphansBetween();
-      return exec('ezoic-ad-between', getTopics,
-        cfg.enableBetweenAds, cfg.intervalPosts, cfg.showFirstTopicAd, 'topics');
+      return exec(
+        'ezoic-ad-between', getTopics,
+        cfg.enableBetweenAds, cfg.intervalPosts, cfg.showFirstTopicAd, 'topics'
+      );
     }
-    return exec('ezoic-ad-categories', getCategories,
-      cfg.enableCategoryAds, cfg.intervalCategories, cfg.showFirstCategoryAd, 'categories');
+    return exec(
+      'ezoic-ad-categories', getCategories,
+      cfg.enableCategoryAds, cfg.intervalCategories, cfg.showFirstCategoryAd, 'categories'
+    );
   }
 
   // ── Scheduler & burst ──────────────────────────────────────────────────────
@@ -681,30 +827,25 @@
     state.burstCount  = 0;
     const step = () => {
       if (pageKey() !== state.pageKey || isBlocked() || now() > state.burstDeadline || state.burstCount >= LIMITS.MAX_BURST_STEPS) {
-        state.burstActive = false; return;
+        state.burstActive = false;
+        return;
       }
       state.burstCount++;
       scheduleRun(n => {
-        if (!n && !state.ezBatch.size) { state.burstActive = false; return; }
+        if (!n && !state.pending.length) { state.burstActive = false; return; }
         setTimeout(step, n > 0 ? 150 : 300);
       });
     };
     step();
   }
 
-  // ── Cleanup on navigation ────────────────────────────────────────────────
-  //
-  // Only runs on actual page transitions (pageKey changes).
-  // Uses destroyAll() to properly clean up Ezoic state before removing DOM.
+  // ── Cleanup on navigation ──────────────────────────────────────────────────
 
   function cleanup() {
     state.blockedUntil = now() + TIMING.BLOCK_DURATION_MS;
 
-    // Cancel pending Ezoic batch
-    if (state.ezFlushTimer) { clearTimeout(state.ezFlushTimer); state.ezFlushTimer = null; }
-    state.ezBatch.clear();
-
-    // Tell Ezoic to destroy all its placeholders BEFORE we remove DOM
+    // Tell Ezoic to destroy all placeholders BEFORE we remove DOM elements.
+    // This prevents GPT slotDestroyed events and Ezoic 400 errors.
     try {
       const ez = window.ezstandalone;
       if (typeof ez?.destroyAll === 'function') {
@@ -715,26 +856,32 @@
     mutate(() => {
       for (const w of document.querySelectorAll(`.${WRAP_CLASS}`)) dropWrap(w);
     });
-    state.cfg = null;
-    state.poolsReady = false;
-    state.pools   = { topics: [], posts: [], categories: [] };
-    state.cursors = { topics: 0, posts: 0, categories: 0 };
+    state.cfg          = null;
+    state.poolsReady   = false;
+    state.pools        = { topics: [], posts: [], categories: [] };
+    state.cursors      = { topics: 0, posts: 0, categories: 0 };
     state.mountedIds.clear();
     state.lastShow.clear();
     state.wrapByKey.clear();
     state.wrapsByClass.clear();
-    state.kind = null;
+    state.kind         = null;
     state.phState.clear();
+    state.inflight     = 0;
+    state.pending      = [];
+    state.pendingSet.clear();
     state.burstActive  = false;
     state.runQueued    = false;
+    state.firstShown   = false;
   }
 
   // ── MutationObserver ───────────────────────────────────────────────────────
 
   function ensureDomObserver() {
     if (state.domObs) return;
+
     state.domObs = new MutationObserver(muts => {
       if (state.mutGuard > 0 || isBlocked()) return;
+
       let needsBurst = false;
       const kind = getKind();
       const relevantSels =
@@ -745,6 +892,20 @@
 
       for (const m of muts) {
         if (m.type !== 'childList') continue;
+
+        // Free IDs from wraps removed by NodeBB virtualization
+        for (const node of m.removedNodes) {
+          if (!(node instanceof Element)) continue;
+          try {
+            if (node.classList?.contains(WRAP_CLASS)) {
+              dropWrap(node);
+            } else {
+              const wraps = node.querySelectorAll?.(`.${WRAP_CLASS}`);
+              if (wraps?.length) { for (const w of wraps) dropWrap(w); }
+            }
+          } catch (_) {}
+        }
+
         for (const node of m.addedNodes) {
           if (!(node instanceof Element)) continue;
 
@@ -781,54 +942,88 @@
         }
         if (needsBurst) break;
       }
+
       if (needsBurst) requestBurst();
     });
-    try { state.domObs.observe(document.body, { childList: true, subtree: true }); } catch (_) {}
+
+    try {
+      state.domObs.observe(document.body, { childList: true, subtree: true });
+    } catch (_) {}
   }
 
-  // ── TCF / CMP Protection ───────────────────────────────────────────────────
+  // ── TCF / CMP Protection (3 layers) ────────────────────────────────────────
 
   function ensureTcfLocator() {
     if (!window.__tcfapi && !window.__cmp) return;
+
     const LOCATOR_ID = '__tcfapiLocator';
+
     const ensureInHead = () => {
       let existing = document.getElementById(LOCATOR_ID);
       if (existing) {
         if (existing.parentElement !== document.head) {
           try { document.head.appendChild(existing); } catch (_) {}
         }
-        return;
+        return existing;
       }
       const f = document.createElement('iframe');
-      f.style.display = 'none'; f.id = f.name = LOCATOR_ID;
+      f.style.display = 'none';
+      f.id = f.name = LOCATOR_ID;
       try { document.head.appendChild(f); } catch (_) {
         (document.body || document.documentElement).appendChild(f);
       }
+      return f;
     };
+
     ensureInHead();
+
     if (!window.__nbbCmpGuarded) {
       window.__nbbCmpGuarded = true;
       if (typeof window.__tcfapi === 'function') {
-        const orig = window.__tcfapi;
-        window.__tcfapi = function (cmd, ver, cb, param) {
-          try { return orig.call(this, cmd, ver, function (...a) { try { cb?.(...a); } catch (_) {} }, param); }
-          catch (e) { if (e?.message?.includes('null')) { ensureInHead(); try { return orig.call(this, cmd, ver, cb, param); } catch (_) {} } }
+        const origTcf = window.__tcfapi;
+        window.__tcfapi = function (cmd, version, cb, param) {
+          try {
+            return origTcf.call(this, cmd, version, function (...args) {
+              try { cb?.(...args); } catch (_) {}
+            }, param);
+          } catch (e) {
+            if (e?.message?.includes('null')) {
+              ensureInHead();
+              try { return origTcf.call(this, cmd, version, cb, param); } catch (_) {}
+            }
+          }
         };
       }
       if (typeof window.__cmp === 'function') {
-        const orig = window.__cmp;
-        window.__cmp = function (...a) {
-          try { return orig.apply(this, a); }
-          catch (e) { if (e?.message?.includes('null')) { ensureInHead(); try { return orig.apply(this, a); } catch (_) {} } }
+        const origCmp = window.__cmp;
+        window.__cmp = function (...args) {
+          try { return origCmp.apply(this, args); }
+          catch (e) {
+            if (e?.message?.includes('null')) {
+              ensureInHead();
+              try { return origCmp.apply(this, args); } catch (_) {}
+            }
+          }
         };
       }
     }
+
     if (!window.__nbbTcfObs) {
       window.__nbbTcfObs = new MutationObserver(() => {
         if (!document.getElementById(LOCATOR_ID)) ensureInHead();
       });
-      try { window.__nbbTcfObs.observe(document.body || document.documentElement, { childList: true, subtree: false }); } catch (_) {}
-      try { if (document.head) window.__nbbTcfObs.observe(document.head, { childList: true, subtree: false }); } catch (_) {}
+      try {
+        window.__nbbTcfObs.observe(document.body || document.documentElement, {
+          childList: true, subtree: false,
+        });
+      } catch (_) {}
+      try {
+        if (document.head) {
+          window.__nbbTcfObs.observe(document.head, {
+            childList: true, subtree: false,
+          });
+        }
+      } catch (_) {}
     }
   }
 
@@ -837,11 +1032,20 @@
   function protectAriaHidden() {
     if (window.__nbbAriaObs) return;
     const remove = () => {
-      try { if (document.body.getAttribute('aria-hidden') === 'true') document.body.removeAttribute('aria-hidden'); } catch (_) {}
+      try {
+        if (document.body.getAttribute('aria-hidden') === 'true') {
+          document.body.removeAttribute('aria-hidden');
+        }
+      } catch (_) {}
     };
     remove();
     window.__nbbAriaObs = new MutationObserver(remove);
-    try { window.__nbbAriaObs.observe(document.body, { attributes: true, attributeFilter: ['aria-hidden'] }); } catch (_) {}
+    try {
+      window.__nbbAriaObs.observe(document.body, {
+        attributes: true,
+        attributeFilter: ['aria-hidden'],
+      });
+    } catch (_) {}
   }
 
   // ── Console muting ─────────────────────────────────────────────────────────
@@ -849,21 +1053,24 @@
   function muteConsole() {
     if (window.__nbbEzMuted) return;
     window.__nbbEzMuted = true;
+
     const PREFIXES = [
       '[EzoicAds JS]: Placeholder Id',
+      'No valid placeholders for loadMore',
       'cannot call refresh on the same page',
       'no placeholders are currently defined in Refresh',
       'Debugger iframe already exists',
       '[CMP] Error in custom getTCData',
       'vignette: no interstitial API',
+      'Ezoic JS-Enable should only ever',
     ];
     const PATTERNS = [
       `with id ${PH_PREFIX}`,
       'adsbygoogle.push() error: All',
       'has already been defined',
-      'No valid placeholders for loadMore',
       'bad response. Status',
     ];
+
     for (const method of ['log', 'info', 'warn', 'error']) {
       const orig = console[method];
       if (typeof orig !== 'function') continue;
@@ -881,22 +1088,25 @@
   // ── Network warmup ─────────────────────────────────────────────────────────
 
   let _networkWarmed = false;
+
   function warmNetwork() {
     if (_networkWarmed) return;
     _networkWarmed = true;
     const head = document.head;
     if (!head) return;
-    for (const [rel, href, cors] of [
+    const hints = [
       ['preconnect',   'https://g.ezoic.net',                    true ],
       ['preconnect',   'https://go.ezoic.net',                   true ],
       ['preconnect',   'https://securepubads.g.doubleclick.net', true ],
       ['preconnect',   'https://pagead2.googlesyndication.com',  true ],
       ['dns-prefetch', 'https://g.ezoic.net',                    false],
       ['dns-prefetch', 'https://securepubads.g.doubleclick.net', false],
-    ]) {
+    ];
+    for (const [rel, href, cors] of hints) {
       if (head.querySelector(`link[rel="${rel}"][href="${href}"]`)) continue;
       const link = document.createElement('link');
-      link.rel = rel; link.href = href;
+      link.rel = rel;
+      link.href = href;
       if (cors) link.crossOrigin = 'anonymous';
       head.appendChild(link);
     }
@@ -907,35 +1117,55 @@
   function bindNodeBB() {
     const $ = window.jQuery;
     if (!$) return;
+
     $(window).off('.nbbEzoic');
+
+    // Only cleanup on actual page change, not same-page pagination
     $(window).on('action:ajaxify.start.nbbEzoic', (ev, data) => {
-      // Only cleanup if navigating to a different page
-      // NodeBB fires ajaxify.start for pagination/sorting on the same page
       const targetUrl = data?.url || data?.tpl_url || '';
       const currentPath = location.pathname.replace(/^\//, '');
-      // If the URL is basically the same (ignoring query/hash), skip cleanup
       if (targetUrl && targetUrl.replace(/[?#].*$/, '') === currentPath.replace(/[?#].*$/, '')) {
-        return;
+        return; // Same page — skip cleanup
       }
       cleanup();
     });
+
     $(window).on('action:ajaxify.end.nbbEzoic', () => {
-      state.pageKey = pageKey();
-      state.kind = null;
+      state.pageKey    = pageKey();
+      state.kind       = null;
       state.blockedUntil = 0;
-      muteConsole(); ensureTcfLocator(); protectAriaHidden(); warmNetwork();
-      getIO(); ensureDomObserver(); requestBurst();
+
+      muteConsole();
+      ensureTcfLocator();
+      protectAriaHidden();
+      warmNetwork();
+      patchShowAds();
+      getIO();
+      ensureDomObserver();
+      requestBurst();
     });
+
     const burstEvents = [
-      'action:ajaxify.contentLoaded', 'action:posts.loaded', 'action:topics.loaded',
-      'action:categories.loaded', 'action:category.loaded', 'action:topic.loaded',
+      'action:ajaxify.contentLoaded',
+      'action:posts.loaded',
+      'action:topics.loaded',
+      'action:categories.loaded',
+      'action:category.loaded',
+      'action:topic.loaded',
     ].map(e => `${e}.nbbEzoic`).join(' ');
+
     $(window).on(burstEvents, () => { if (!isBlocked()) requestBurst(); });
+
     try {
       require(['hooks'], hooks => {
         if (typeof hooks?.on !== 'function') return;
-        for (const ev of ['action:ajaxify.end', 'action:posts.loaded', 'action:topics.loaded',
-                          'action:categories.loaded', 'action:topic.loaded']) {
+        for (const ev of [
+          'action:ajaxify.end',
+          'action:posts.loaded',
+          'action:topics.loaded',
+          'action:categories.loaded',
+          'action:topic.loaded',
+        ]) {
           try { hooks.on(ev, () => { if (!isBlocked()) requestBurst(); }); } catch (_) {}
         }
       });
@@ -947,7 +1177,10 @@
     window.addEventListener('scroll', () => {
       if (ticking) return;
       ticking = true;
-      requestAnimationFrame(() => { ticking = false; requestBurst(); });
+      requestAnimationFrame(() => {
+        ticking = false;
+        requestBurst();
+      });
     }, { passive: true });
   }
 
@@ -958,6 +1191,7 @@
   ensureTcfLocator();
   protectAriaHidden();
   warmNetwork();
+  patchShowAds();
   getIO();
   ensureDomObserver();
   bindNodeBB();