nodebb-plugin-ezoic-infinite 1.6.89 → 1.6.91

package/library.js

@@ -7,59 +7,117 @@ const db = require.main.require('./src/database');
 const SETTINGS_KEY = 'ezoic-infinite';
 const plugin = {};
 
+/**
+ * Récupère les paramètres du plugin
+ */
 async function getSettings() {
-  return await meta.settings.get(SETTINGS_KEY);
+    return await meta.settings.get(SETTINGS_KEY);
 }
 
+/**
+ * Vérifie si l'utilisateur actuel fait partie d'un groupe exclu
+ */
 async function isUserExcluded(uid, excludedGroups) {
-  if (!uid || !excludedGroups || !excludedGroups.length) return false;
-  const userGroups = await groups.getUserGroupsNames([uid]);
-  return excludedGroups.some(g => userGroups[0].includes(g));
+    if (!uid || uid <= 0) return false;
+    if (!excludedGroups || !excludedGroups.length) return false;
+
+    // S'assurer que excludedGroups est un tableau
+    const excludedList = Array.isArray(excludedGroups) ? excludedGroups : [excludedGroups];
+    
+    // Récupérer les groupes de l'utilisateur
+    const userGroups = await groups.getUserGroupsNames([uid]);
+    
+    // Vérifier s'il y a une intersection entre les groupes de l'utilisateur et les exclus
+    return excludedList.some(g => userGroups[0].includes(g));
 }
 
+/**
+ * Récupère la liste de tous les groupes pour l'affichage dans l'admin
+ */
 async function getAllGroups() {
-  let names = await db.getSortedSetRange('groups:createtime', 0, -1);
-  const data = await groups.getGroupsData(names);
-  return data.filter(g => g && g.name).map(g => ({ name: g.name }));
+    let names = await db.getSortedSetRange('groups:createtime', 0, -1);
+    if (!names || !names.length) {
+        names = await db.getSortedSetRange('groups:visible:createtime', 0, -1);
+    }
+    const filtered = names.filter(name => !groups.isPrivilegeGroup(name));
+    const data = await groups.getGroupsData(filtered);
+    const valid = data.filter(g => g && g.name);
+    valid.sort((a, b) => String(a.name).localeCompare(String(b.name), undefined, { sensitivity: 'base' }));
+    return valid;
 }
 
+/**
+ * Initialisation du plugin (Routes et API)
+ */
 plugin.init = async ({ router, middleware }) => {
-  async function render(req, res) {
-    const settings = await getSettings();
-    const allGroups = await getAllGroups();
-    res.render('admin/plugins/ezoic-infinite', {
-      ...settings,
-      allGroups,
-    });
-  }
-
-  router.get('/admin/plugins/ezoic-infinite', middleware.admin.buildHeader, render);
-  router.get('/api/admin/plugins/ezoic-infinite', render);
-
-  router.get('/api/plugins/ezoic-infinite/config', async (req, res) => {
-    const settings = await getSettings();
-    const excluded = await isUserExcluded(req.uid, settings.excludedGroups || []);
-    res.json({
-      excluded,
-      enableBetweenAds: settings.enableBetweenAds === 'on',
-      showFirstTopicAd: settings.showFirstTopicAd === 'on',
-      placeholderIds: settings.placeholderIds,
-      intervalPosts: settings.intervalPosts || 10,
-      enableMessageAds: settings.enableMessageAds === 'on',
-      showFirstMessageAd: settings.showFirstMessageAd === 'on',
-      messagePlaceholderIds: settings.messagePlaceholderIds,
-      messageIntervalPosts: settings.messageIntervalPosts || 10,
+    async function render(req, res) {
+        const settings = await getSettings();
+        const allGroups = await getAllGroups();
+
+        res.render('admin/plugins/ezoic-infinite', {
+            title: 'Ezoic Infinite Ads',
+            ...settings,
+            // On force les booléens pour les cases à cocher dans le template
+            enableCategoryAds_checked: settings.enableCategoryAds === 'on' || settings.enableCategoryAds === true ? 'checked' : '',
+            enableBetweenAds_checked: settings.enableBetweenAds === 'on' || settings.enableBetweenAds === true ? 'checked' : '',
+            enableMessageAds_checked: settings.enableMessageAds === 'on' || settings.enableMessageAds === true ? 'checked' : '',
+            allGroups,
+        });
+    }
+
+    router.get('/admin/plugins/ezoic-infinite', middleware.admin.buildHeader, render);
+    router.get('/api/admin/plugins/ezoic-infinite', render);
+
+    // API de configuration appelée par client.js
+    router.get('/api/plugins/ezoic-infinite/config', async (req, res) => {
+        const settings = await getSettings();
+        
+        // Vérification de l'exclusion
+        const excludedGroups = settings.excludedGroups ? (Array.isArray(settings.excludedGroups) ? settings.excludedGroups : [settings.excludedGroups]) : [];
+        const excluded = await isUserExcluded(req.uid, excludedGroups);
+
+        res.json({
+            excluded,
+            // 1. Accueil (Catégories)
+            enableCategoryAds: settings.enableCategoryAds === 'on' || settings.enableCategoryAds === true,
+            showFirstCategoryAd: settings.showFirstCategoryAd === 'on' || settings.showFirstCategoryAd === true,
+            categoryPlaceholderIds: settings.categoryPlaceholderIds || "",
+            intervalCategories: parseInt(settings.intervalCategories, 10) || 5,
+
+            // 2. Liste des Topics (Page catégorie)
+            enableBetweenAds: settings.enableBetweenAds === 'on' || settings.enableBetweenAds === true,
+            showFirstTopicAd: settings.showFirstTopicAd === 'on' || settings.showFirstTopicAd === true,
+            placeholderIds: settings.placeholderIds || "",
+            intervalPosts: parseInt(settings.intervalPosts, 10) || 10,
+
+            // 3. Messages (Dans un post)
+            enableMessageAds: settings.enableMessageAds === 'on' || settings.enableMessageAds === true,
+            showFirstMessageAd: settings.showFirstMessageAd === 'on' || settings.showFirstMessageAd === true,
+            messagePlaceholderIds: settings.messagePlaceholderIds || "",
+            messageIntervalPosts: parseInt(settings.messageIntervalPosts, 10) || 10,
+        });
     });
-  });
 };
 
+/**
+ * Ajoute le lien dans le menu de navigation de l'administration
+ */
 plugin.addAdminNavigation = async (header) => {
-  header.plugins.push({
-    route: '/plugins/ezoic-infinite',
-    icon: 'fa-ad',
-    name: 'Ezoic Infinite'
-  });
-  return header;
+    header.plugins.push({
+        route: '/plugins/ezoic-infinite',
+        icon: 'fa-ad',
+        name: 'Ezoic Infinite'
+    });
+    return header;
+};
+
+/**
+ * Gère la sauvegarde des paramètres
+ */
+plugin.onSettingsSet = async (data) => {
+    if (data.plugin === 'ezoic-infinite') {
+        // Logique optionnelle à l'enregistrement
+    }
 };
 
 module.exports = plugin;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.89",
+  "version": "1.6.91",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -9,7 +9,6 @@
   
   let config = null;
   let isInternalChange = false;
-  let definedIds = new Set();
   let pendingIds = new Set();
   let refreshTimer = null;
 
@@ -24,7 +23,6 @@
     return p;
   }
 
-  // Cette fonction centralise les appels pour éviter de spammer Refresh()
   function triggerEzoic() {
     if (typeof window.ezstandalone === 'undefined' || pendingIds.size === 0) return;
 
@@ -32,21 +30,15 @@
       const idsToProcess = Array.from(pendingIds);
       pendingIds.clear();
 
-      // 1. Définir les nouveaux IDs
+      // On enregistre les IDs
       window.ezstandalone.define(idsToProcess);
 
-      // 2. Si c'est le tout premier appel de la page
-      if (!window.ezstandalone.enabled) {
-        window.ezstandalone.enable();
-        window.ezstandalone.display();
-      } else {
-        // 3. Sinon, on utilise Refresh MAIS seulement si on n'est pas 
-        // dans la même micro-seconde que l'initialisation
-        try {
-            window.ezstandalone.refresh();
-        } catch (e) {
-            console.warn('[Ezoic] Refresh skipped to prevent conflict');
-        }
+      // On appelle UNIQUEMENT refresh. 
+      // Si Ezoic n'est pas "enabled", il ignorera l'appel sans erreur bloquante.
+      try {
+          window.ezstandalone.refresh();
+      } catch (e) {
+          console.debug('[Ezoic] Refresh deferred');
       }
     });
   }
@@ -54,39 +46,38 @@
   function callEzoic(id) {
     const pid = parseInt(id, 10);
     if (isNaN(pid)) return;
-
-    // On ajoute l'ID à la liste des IDs à traiter
     pendingIds.add(pid);
-    definedIds.add(pid);
 
-    // On attend 200ms que les autres pubs du même scroll arrivent
-    // avant de lancer l'appel Ezoic unique. C'est le "Debounce".
     clearTimeout(refreshTimer);
-    refreshTimer = setTimeout(triggerEzoic, 200);
+    refreshTimer = setTimeout(triggerEzoic, 300);
   }
 
   function redistribute() {
     if (!config || config.excluded) return;
 
-    // Sélecteurs Harmony
+    // 1. Accueil (Catégories)
+    const categoryItems = document.querySelectorAll('.category-item, [component="categories/category"]');
+    // 2. Liste Topics
     const topicItems = document.querySelectorAll('li[component="category/topic"]');
+    // 3. Messages
     const postItems = document.querySelectorAll('[component="post"]');
 
+    if (categoryItems.length > 0 && config.enableCategoryAds) {
+      process(Array.from(categoryItems), 'home', config.intervalCategories, config.showFirstCategoryAd);
+    }
     if (topicItems.length > 0 && config.enableBetweenAds) {
-      processItems(Array.from(topicItems), 'between', config.intervalPosts, config.showFirstTopicAd);
+      process(Array.from(topicItems), 'topic-list', config.intervalPosts, config.showFirstTopicAd);
     }
-    
     if (postItems.length > 0 && config.enableMessageAds) {
-      processItems(Array.from(postItems), 'message', config.messageIntervalPosts, config.showFirstMessageAd);
+      process(Array.from(postItems), 'message', config.messageIntervalPosts, config.showFirstMessageAd);
     }
   }
 
-  function processItems(items, kind, interval, showFirst) {
+  function process(items, kind, interval, showFirst) {
     const int = parseInt(interval, 10) || 10;
     items.forEach((item, index) => {
       const pos = index + 1;
       const shouldHaveAd = (pos === 1 && showFirst) || (pos % int === 0);
-      
       const next = item.nextElementSibling;
       if (shouldHaveAd && !(next && next.classList.contains(WRAP_CLASS))) {
         const pool = getPool();
@@ -110,19 +101,17 @@
         const setup = (raw, kind) => {
           if (!raw) return;
           raw.split(/[\s,]+/).filter(Boolean).forEach(id => {
-            if (!document.querySelector(`[data-placeholder-id="${id}"]`)) {
-              const d = document.createElement('div');
-              d.className = WRAP_CLASS;
-              d.setAttribute('data-kind', kind);
-              d.setAttribute('data-placeholder-id', id);
-              d.innerHTML = `<div id="ezoic-pub-ad-placeholder-${id}"></div>`;
-              pool.appendChild(d);
-            }
+            const d = document.createElement('div');
+            d.className = WRAP_CLASS;
+            d.setAttribute('data-kind', kind);
+            d.setAttribute('data-placeholder-id', id);
+            d.innerHTML = `<div id="ezoic-pub-ad-placeholder-${id}"></div>`;
+            pool.appendChild(d);
           });
         };
-        setup(config.placeholderIds, 'between');
+        setup(config.categoryPlaceholderIds, 'home');
+        setup(config.placeholderIds, 'topic-list');
         setup(config.messagePlaceholderIds, 'message');
-        
         redistribute();
 
         const observer = new MutationObserver(() => {
@@ -132,19 +121,7 @@
       });
   }
 
-  // Crucial pour les SPA : Nettoyer l'état d'Ezoic lors d'un changement de page
-  window.addEventListener('action:ajaxify.start', function() {
-    if (typeof window.ezstandalone !== 'undefined' && window.ezstandalone.enabled) {
-        // Optionnel : window.ezstandalone.destroy(); 
-        // Mais souvent il vaut mieux juste laisser Ezoic gérer
-    }
-    definedIds.clear();
-    pendingIds.clear();
-  });
-
-  window.addEventListener('action:ajaxify.end', function() {
-    setTimeout(redistribute, 600);
-  });
+  window.addEventListener('action:ajaxify.end', () => setTimeout(redistribute, 500));
 
   if (document.readyState === 'loading') {
     document.addEventListener('DOMContentLoaded', init);

package/public/style.css

@@ -1,29 +1,34 @@
-/* Container global */
+/* Container global de pub */
 .nodebb-ezoic-wrap {
     display: block !important;
     width: 100% !important;
-    min-width: 100% !important;
     margin: 20px 0 !important;
     min-height: 250px; 
     clear: both;
     text-align: center;
 }
 
-/* Fix spécifique pour la liste des topics (Accueil Harmony) */
+/* Accueil (Catégories) */
+[component="categories/category"] + .nodebb-ezoic-wrap,
+.category-item + .nodebb-ezoic-wrap {
+    margin: 40px 0 !important;
+    border-top: 1px solid rgba(0,0,0,0.05);
+}
+
+/* Liste des Topics (Page catégorie) */
 li[component="category/topic"] + .nodebb-ezoic-wrap {
     list-style: none !important;
-    margin-left: 0 !important;
     padding: 15px 0;
     border-bottom: 1px solid rgba(0,0,0,0.05);
 }
 
-/* Si le bloc est vide ou n'a pas encore chargé */
-.nodebb-ezoic-wrap:empty {
-    min-height: 1px;
+/* Messages (Dans un post) */
+[component="post"] + .nodebb-ezoic-wrap {
+    margin: 40px 0 !important;
+    padding: 20px;
+    background: rgba(0,0,0,0.01);
 }
 
-/* Neutralisation des marges internes d'Ezoic */
-.ezoic-ad {
-    margin: 0 auto !important;
-    display: inline-block !important;
-}
+/* Masquage des blocs vides */
+.nodebb-ezoic-wrap:empty { min-height: 1px; }
+.ezoic-ad { margin: 0 auto !important; }