nodebb-plugin-ezoic-infinite 1.6.76 → 1.6.77

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.76",
+  "version": "1.6.77",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -133,29 +133,7 @@ function tightenEzoicMinHeight(wrap) {
     if (!wrap || !wrap.querySelector) return;
 
     const iframes = wrap.querySelectorAll('iframe');
-
-    // If the wrap is still empty, Ezoic often leaves inline `min-height:400px !important` on
-    // nested `.ezoic-ad` containers, which creates large blank gaps. We can't remove it with CSS.
-    // We collapse those gaps after a short grace period, while still allowing late fill.
-    if (!iframes || !iframes.length) {
-      try {
-        const created = parseInt(wrap.getAttribute('data-created') || '0', 10);
-        const age = created ? (now() - created) : 0;
-        // Give auctions/CMP a bit of time; then collapse the notorious 400px gap.
-        if (age >= 12000) {
-          const nodes = wrap.querySelectorAll('.ezoic-ad, .ezoic-ad-adaptive');
-          nodes.forEach((n) => {
-            const st = (n.getAttribute('style') || '').toLowerCase();
-            if (st.includes('min-height:400') || st.includes('min-height: 400') || st.includes('min-height:400px')) {
-              try { n.style.setProperty('min-height', '1px', 'important'); } catch (e) { n.style.minHeight = '1px'; }
-              try { n.style.setProperty('height', 'auto', 'important'); } catch (e) {}
-              try { n.style.setProperty('line-height', '0', 'important'); } catch (e) {}
-            }
-          });
-        }
-      } catch (e) {}
-      return;
-    }
+    if (!iframes || !iframes.length) return;
 
     // Find the closest "big" ezoic container that carries the 400px min-height.
     const firstIframe = iframes[0];
@@ -763,49 +741,38 @@ function globalGapFixInit() {
       // For message/topic pages we may prune filled or empty orphans if they are far away,
       // otherwise consecutive "stacks" can appear when posts are virtualized.
       const isMessage = (kindClass === 'ezoic-ad-message');
-      // IMPORTANT:
-      // On category/topic lists, NodeBB can virtualize/recycle list items while scrolling.
-      // If we keep *filled* wraps when their anchor items are gone, they can visually
-      // "stack" together on upward scroll. We therefore allow filled wraps to be hidden
-      // when orphaned, but we still avoid fully releasing them (so they can come back
-      // when anchors reappear).
-
-      // If the wrap is anchored to current items, ensure it is visible.
-      if (hasNearbyItem(wrap)) {
-        try { wrap.classList && wrap.classList.remove('ez-orphan-hidden'); wrap.style && (wrap.style.display = ''); } catch (e) {}
-        return;
-      }
+      if (!isMessage && isFilled(wrap)) return; // never prune filled ads for non-message lists
 
-      // If the anchor item is no longer in the DOM (virtualized), hide the wrap so ads never 'stack'
-      // back-to-back while scrolling. We'll restore it when its anchor comes back.
-      try { wrap.classList && wrap.classList.add('ez-orphan-hidden'); wrap.style && (wrap.style.display = 'none'); } catch (e) {}
-
-      // On topic/category lists, never release orphan wraps. Releasing moves placeholders around and makes
-      // ads appear to 'travel' from top to bottom as you scroll. Parking (hiding) keeps DOM order stable.
-      const isList = (kindClass === 'ezoic-ad-between' || kindClass === 'ezoic-ad-categories');
-      if (isList) return;
-
-      // Never release a fresh wrap: it may fill late (auction/CMP). Keep it hidden for a while.
+      // Never prune a fresh wrap: it may fill late.
       try {
         const created = parseInt(wrap.getAttribute('data-created') || '0', 10);
         if (created && (now() - created) < keepEmptyWrapMs()) return;
       } catch (e) {}
 
-      // For message ads: only release if far offscreen to avoid perceived 'vanishing' during fast scroll.
-      if (isMessage) {
-        try {
-          const r = wrap.getBoundingClientRect();
-          const vh = Math.max(1, window.innerHeight || 1);
-          const farAbove = r.bottom < -vh * 2;
-          const farBelow = r.top > vh * 4;
-          if (!farAbove && !farBelow) return;
-        } catch (e) {
-          return;
-        }
-      }
+if (hasNearbyItem(wrap)) {
+  try { wrap.classList && wrap.classList.remove('ez-orphan-hidden'); wrap.style && (wrap.style.display = ''); } catch (e) {}
+  return;
+}
+
+// If the anchor item is no longer in the DOM (virtualized), hide the wrap so ads never "stack"
+// back-to-back while scrolling. We'll recycle it when its anchor comes back.
+try { wrap.classList && wrap.classList.add('ez-orphan-hidden'); wrap.style && (wrap.style.display = 'none'); } catch (e) {}
+
+// For message ads: only release if far offscreen to avoid perceived "vanishing" during fast scroll.
+if (isMessage) {
+  try {
+    const r = wrap.getBoundingClientRect();
+    const vh = Math.max(1, window.innerHeight || 1);
+    const farAbove = r.bottom < -vh * 2;
+    const farBelow = r.top > vh * 4;
+    if (!farAbove && !farBelow) return;
+  } catch (e) {
+    return;
+  }
+}
 
-      withInternalDomChange(() => releaseWrapNode(wrap));
-      removed++;
+withInternalDomChange(() => releaseWrapNode(wrap));
+removed++;
     });
 
     return removed;
@@ -851,12 +818,6 @@ function globalGapFixInit() {
           const prevFilled = isFilled(prev);
           const curFilled = isFilled(w);
 
-          // On topic/category lists, prevent visible stacking by hiding the later wrap immediately.
-          if ((kindClass === 'ezoic-ad-between' || kindClass === 'ezoic-ad-categories') && prevFilled && curFilled) {
-            try { w.classList && w.classList.add('ez-stack-hidden'); w.style && (w.style.display = 'none'); } catch (e) {}
-            break;
-          }
-
           if (curFilled) {
             // If the previous one is empty (and not fresh), drop the previous instead.
             if (!prevFilled && !isFresh(prev)) {
@@ -1058,8 +1019,6 @@ function globalGapFixInit() {
               watchWrapForFill(ww);
               setTimeout(() => { try { tightenEzoicMinHeight(ww); } catch (e) {} }, 900);
               setTimeout(() => { try { tightenEzoicMinHeight(ww); } catch (e) {} }, 2200);
-              // Collapse the notorious 400px inline min-height if the slot stays empty.
-              setTimeout(() => { try { tightenEzoicMinHeight(ww); } catch (e) {} }, 12500);
             }
           } catch (e) {}
           setTimeout(() => { clearTimeout(hardTimer); release(); }, 650);
@@ -1145,7 +1104,7 @@ function buildOrdinalMap(items) {
       if (!id) {
         // Safe mode: disable recycling for topic message ads to prevent visual "jumping"
         // (ads seemingly moving back under the first post during virtualized scroll).
-        const allowRecycle = kindClass !== 'ezoic-ad-message' && kindClass !== 'ezoic-ad-between' && kindClass !== 'ezoic-ad-categories';
+        const allowRecycle = kindClass !== 'ezoic-ad-message';
         recycledWrap = (allowRecycle && scrollDir > 0) ? pickRecyclableWrap(kindClass) : null;
         if (recycledWrap) {
           id = recycledWrap.getAttribute('data-ezoic-wrapid') || '';